ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,001 Commits 1 Branch 0 Tags 5 MiB
75cde25b6f
Commit Graph

764 Commits

Author SHA1 Message Date
Timo Stollenwerk
ac4a64f55d Make sure comment UIDs in the catalog are always unique. This fixes 
http://dev.plone.org/plone/ticket/10652. We depend on plone.uuid and plone.app.uuid now. Refs #10652.

svn path=/plone.app.discussion/trunk/; revision=46005
 2010-11-28 11:39:19 +00:00
Timo Stollenwerk
b08d7ddbeb revert r46002. 
svn path=/plone.app.discussion/trunk/; revision=46003
 2010-11-28 10:00:31 +00:00
Timo Stollenwerk
7e39197114 hudson buildout added. 
svn path=/plone.app.discussion/trunk/; revision=46002
 2010-11-28 09:51:35 +00:00
David Glick
4c31afeac2 fix comparison of string to integer which broke 'check all' 
svn path=/plone.app.discussion/trunk/; revision=45926
 2010-11-23 18:53:38 +00:00
Timo Stollenwerk
7dbcc9e2be Use safe_unicode to decode the title of the content. encode("utf-9") caused Dexterity based content types to raise a unicode decode error. This fixes http://dev.plone.org/plone/ticket/11292. Refs #11292 
svn path=/plone.app.discussion/trunk/; revision=45915
 2010-11-23 14:03:47 +00:00
Israel Saeta Pérez
6f698551ce Update Spanish localization. 
svn path=/plone.app.discussion/trunk/; revision=45880
 2010-11-19 11:01:05 +00:00
Victor Fernandez de Alba
289f876244 Corrected typo in catalan translation 
svn path=/plone.app.discussion/trunk/; revision=45852
 2010-11-17 14:50:43 +00:00
Victor Fernandez de Alba
48d225e97e Catalan translations 
svn path=/plone.app.discussion/trunk/; revision=45851
 2010-11-17 14:26:15 +00:00
Luca Fabbri
7083607d63 update italian translation 
svn path=/plone.app.discussion/trunk/; revision=45811
 2010-11-15 16:02:11 +00:00
Yiorgis Gozadinos
ab00fa3d99 Make the creator indexer return utf-8 to the catalog. 
svn path=/plone.app.discussion/trunk/; revision=45735
 2010-11-10 10:06:20 +00:00
Timo Stollenwerk
d358a31c74 Comments viewlet test for posting anonymous comments added. 
svn path=/plone.app.discussion/trunk/; revision=45663
 2010-11-08 17:10:19 +00:00
Timo Stollenwerk
5b788d1156 Merge 'Convert anonymous-supplied name to unicode as done for authenticated members.' from jarn-unicode branch. 
svn path=/plone.app.discussion/trunk/; revision=45662
 2010-11-08 17:09:26 +00:00
Anton Stonor
91a488931d staring Danish translation 
svn path=/plone.app.discussion/trunk/; revision=45615
 2010-11-07 22:02:08 +00:00
Radim Novotny
469da01f11 typo in Czech translation 
svn path=/plone.app.discussion/trunk/; revision=45607
 2010-11-07 18:52:12 +00:00
Timo Stollenwerk
cbd2edf932 Catch SMTP exceptions when sending email notifications. 
svn path=/plone.app.discussion/trunk/; revision=45199
 2010-11-04 15:56:12 +00:00
Timo Stollenwerk
501cee78e2 ".comment" and ".replyTreeLevel0" are both CSS classes of the comment div. Fix for Plone 3 only. 
svn path=/plone.app.discussion/trunk/; revision=45189
 2010-11-04 14:50:30 +00:00
Timo Stollenwerk
823ada7491 Remove AJAX comment deletion binding. This function relies on the nextUntil() selector introduced by jQuery 1.4 and therefore breaks in Plone 3 (that currently uses jQuery 1.3.2). 
svn path=/plone.app.discussion/trunk/; revision=45188
 2010-11-04 14:42:32 +00:00
Timo Stollenwerk
b68da9925b Use parseInt with second param to make jslint happy. 
svn path=/plone.app.discussion/trunk/; revision=45187
 2010-11-04 14:37:18 +00:00
Radim Novotny
b3ec7d61f5 Updated Czech translation :) 
svn path=/plone.app.discussion/trunk/; revision=45126
 2010-11-03 13:52:16 +00:00
Timo Stollenwerk
3d2f01b440 Translations updated. 
svn path=/plone.app.discussion/trunk/; revision=45125
 2010-11-03 13:45:00 +00:00
Timo Stollenwerk
25a82538b4 Fix Czech language code and name. 
svn path=/plone.app.discussion/trunk/; revision=45124
 2010-11-03 13:42:20 +00:00
Timo Stollenwerk
7f98b94031 Fix Dutch language code and name. 
svn path=/plone.app.discussion/trunk/; revision=45123
 2010-11-03 13:40:48 +00:00
Timo Stollenwerk
b95707ac52 Re-add the CommentsViewlet can_manage method. This method has been removed in version 1.0b9 and added again in 1.0b11 because we don't want to change the API in beta releases. 
svn path=/plone.app.discussion/trunk/; revision=45110
 2010-11-03 11:26:18 +00:00
Timo Stollenwerk
8e8e78c2d9 Fix language code and name in the Basque .po file. 
svn path=/plone.app.discussion/trunk/; revision=45082
 2010-11-02 11:34:52 +00:00
Israel Saeta Pérez
1b02b799c6 Add and update es and eu l10ns. 
svn path=/plone.app.discussion/trunk/; revision=45063
 2010-11-02 09:05:22 +00:00
Timo Stollenwerk
a39ac82858 There is no need to set the comment title in the tests, since comments do not have title fields anymore. 
svn path=/plone.app.discussion/trunk/; revision=44738
 2010-10-31 11:09:32 +00:00
Timo Stollenwerk
feec103b56 Fix user email notification test for Plone 3. 
svn path=/plone.app.discussion/trunk/; revision=44737
 2010-10-31 10:48:45 +00:00
Timo Stollenwerk
fa6e380eaf Use secureSend for user email notification on Plone 3 
svn path=/plone.app.discussion/trunk/; revision=44736
 2010-10-31 10:34:58 +00:00
Timo Stollenwerk
c8cd370fc9 Use len(tuple()) instead of tuple() to make tests pass again. 
svn path=/plone.app.discussion/trunk/; revision=44706
 2010-10-30 19:26:51 +00:00
Timo Stollenwerk
093eaa393a Use tuple() to test for generators. Thanks to otacon! 
svn path=/plone.app.discussion/trunk/; revision=42096
 2010-10-30 18:58:20 +00:00
Timo Stollenwerk
cc96acb50a Ajaxify comment deletion and approval. thanks thomasdesvenain! 
svn path=/plone.app.discussion/trunk/; revision=40984
 2010-10-30 17:32:31 +00:00
Timo Stollenwerk
82afd3ef15 New feature: As a logged-in user, I can enable/disable email notification of additional comments on this content object. 
svn path=/plone.app.discussion/trunk/; revision=40949
 2010-10-30 15:02:05 +00:00
Timo Stollenwerk
5fe339215b Use the jstestdriver coverage plugin. 
svn path=/plone.app.discussion/trunk/; revision=40909
 2010-10-30 11:24:03 +00:00
Timo Stollenwerk
380b81bd3e Disable the moderation qunit tests for now because they are currently failing. 
svn path=/plone.app.discussion/trunk/; revision=40907
 2010-10-30 11:12:04 +00:00
Timo Stollenwerk
0820d3771f Basic js-test-driver configuration added. 
svn path=/plone.app.discussion/trunk/; revision=40892
 2010-10-30 10:22:21 +00:00
Timo Stollenwerk
81dcdeaea3 Disable the plone.app.registry check on schema elements, so no error is raised on upgrades. This fixes https://dev.plone.org/plone/ticket/11195. Refs #11195 
svn path=/plone.app.discussion/trunk/; revision=40868
 2010-10-29 10:43:46 +00:00
Timo Stollenwerk
f6b7ef1bcb Remove the too generic id attribute of the comment form. 
svn path=/plone.app.discussion/trunk/; revision=40858
 2010-10-28 10:30:10 +00:00
Timo Stollenwerk
777e687169 Rename the id of the comment form from "form" to "comment-form". 
svn path=/plone.app.discussion/trunk/; revision=40857
 2010-10-28 09:45:34 +00:00
Timo Stollenwerk
22e4189c37 Revert revisions r40851 to r40853, they should have gone into the ajax-ui branch. 
svn path=/plone.app.discussion/trunk/; revision=40856
 2010-10-28 09:39:00 +00:00
Timo Stollenwerk
14e2600a79 Make ajax call for delete comment button work for comment replies. 
svn path=/plone.app.discussion/trunk/; revision=40853
 2010-10-27 16:10:04 +00:00
Timo Stollenwerk
926e4f6b8e Integrate Denys ajax ui code. 
svn path=/plone.app.discussion/trunk/; revision=40852
 2010-10-27 14:44:52 +00:00
Timo Stollenwerk
79f4481722 Use "#comment-form" as id for the comment form instead of "#form" which is too generic. 
svn path=/plone.app.discussion/trunk/; revision=40851
 2010-10-27 14:44:06 +00:00
Hanno Schlichting
aa8a1ea934 Fixed handling of non-ascii member data, like fullname and email. 
svn path=/plone.app.discussion/trunk/; revision=40789
 2010-10-22 10:14:07 +00:00
Hanno Schlichting
54bbb08c62 Whitespace removal 
svn path=/plone.app.discussion/trunk/; revision=40788
 2010-10-22 09:57:55 +00:00
Andreas Jung
8fc3dda8e6 wrong language-code 
svn path=/plone.app.discussion/trunk/; revision=40586
 2010-10-11 09:37:28 +00:00
Radim Novotny
18e92f7a85 - Fixed "global name 'WrongCaptchaCode' is not defined" if norobots captcha, 
but no other validation package is installed.

svn path=/plone.app.discussion/trunk/; revision=40574
 2010-10-09 11:13:28 +00:00
Timo Stollenwerk
f7ed357a83 Use 'comment_review_workflow' instead of 'simple_publication_workflow' for testing. 
svn path=/plone.app.discussion/trunk/; revision=40571
 2010-10-08 11:03:14 +00:00
Timo Stollenwerk
324d2274bd Check for a 'pending' state in the current comment workflow instead of checking for the 'comment_review' workflow. Refs #11184. Merge last three submits in CHANGES.txt. 
svn path=/plone.app.discussion/trunk/; revision=40570
 2010-10-08 10:37:10 +00:00
Timo Stollenwerk
6e9bb4a9cd Check the review_state to decide if moderation is enabled. If the current comment workflow implements a 'pending' state, moderation is enabled. Refs #11184. 
svn path=/plone.app.discussion/trunk/; revision=40569
 2010-10-08 10:22:40 +00:00
Timo Stollenwerk
2790e6d4eb Check the review_state instead of the workflow after a comment has been posted to decide if a message is shown to the user. This allows integrators to use custom review workflows. Refs #11184 
svn path=/plone.app.discussion/trunk/; revision=40566
 2010-10-08 09:53:00 +00:00
Timo Stollenwerk
43d3222086 Run functional tests only with Plone 4 (and plone.testing). 
svn path=/plone.app.discussion/trunk/; revision=40537
 2010-10-06 15:12:11 +00:00
Timo Stollenwerk
94584429fd Do not use has_key. 
svn path=/plone.app.discussion/trunk/; revision=40536
 2010-10-06 14:12:30 +00:00
Timo Stollenwerk
4bbfe677e4 Replace the can_manage method with a can_review method that checks the 'Review comments' permission. This fixes http://dev.plone.org/plone/ticket/11145. 
svn path=/plone.app.discussion/trunk/; revision=40534
 2010-10-06 13:55:57 +00:00
Timo Stollenwerk
3e73903a8d Remove (old) functional test. 
svn path=/plone.app.discussion/trunk/; revision=40533
 2010-10-06 13:53:07 +00:00
Timo Stollenwerk
1230e67a01 Functional test for comment_review_workflow added; existing fonctional test renamed to functional_test_comments.txt; 
svn path=/plone.app.discussion/trunk/; revision=40532
 2010-10-06 13:52:11 +00:00
Timo Stollenwerk
1db321a044 Make pylint happy. 
svn path=/plone.app.discussion/trunk/; revision=40527
 2010-10-06 09:02:26 +00:00
Timo Stollenwerk
f9ca4497bd Obey the 80 chars limit. 
svn path=/plone.app.discussion/trunk/; revision=40526
 2010-10-06 08:47:24 +00:00
Timo Stollenwerk
94b0c58511 Fix pylint disable-msg statements. 
svn path=/plone.app.discussion/trunk/; revision=40521
 2010-10-05 15:54:49 +00:00
Timo Stollenwerk
fbb042c012 Remove unused import. 
svn path=/plone.app.discussion/trunk/; revision=40520
 2010-10-05 15:52:19 +00:00
Timo Stollenwerk
773345c40f Make pylint happy. 
svn path=/plone.app.discussion/trunk/; revision=40519
 2010-10-05 15:47:02 +00:00
Timo Stollenwerk
7de585542b Fix moderation actions (publish, delete) in the moderation view with virtual hosts. This is a replacement for http://dev.plone.org/plone/changeset/35608. 
svn path=/plone.app.discussion/trunk/; revision=40518
 2010-10-05 15:21:54 +00:00
Timo Stollenwerk
b984a445d5 Inline documentation for moderation view added. 
svn path=/plone.app.discussion/trunk/; revision=40517
 2010-10-05 15:14:12 +00:00
Timo Stollenwerk
7e42a39346 Remove .mo file from subversion. 
svn path=/plone.app.discussion/trunk/; revision=40516
 2010-10-05 14:07:39 +00:00
Timo Stollenwerk
837e6b2966 Do not show two "login to add comments" buttons when there are no comments yet. This fixes http://plone.org/products/plone.app.discussion/issues/12. 
svn path=/plone.app.discussion/trunk/; revision=40515
 2010-10-05 12:07:08 +00:00
Timo Stollenwerk
51642c2e0f German translations updated. 
svn path=/plone.app.discussion/trunk/; revision=40506
 2010-10-04 18:59:42 +00:00
Timo Stollenwerk
9841ba7229 Remove unnecessary decode statement from creator. 
svn path=/plone.app.discussion/trunk/; revision=40503
 2010-10-04 13:48:54 +00:00
Timo Stollenwerk
0ee649fb6c Functional test for special characters added. Remove unnecessary decode statement from creator. 
svn path=/plone.app.discussion/trunk/; revision=40502
 2010-10-04 13:48:27 +00:00
Timo Stollenwerk
b06ba43a75 Ignore currently unused code from code coverage. Overall code coverage is up to 95%. 
svn path=/plone.app.discussion/trunk/; revision=40497
 2010-10-03 19:54:59 +00:00
Timo Stollenwerk
6d92d1383c Remove comment title from comments viewlet tests. 
svn path=/plone.app.discussion/trunk/; revision=40496
 2010-10-03 19:41:02 +00:00
Timo Stollenwerk
ede295e649 Functional test for posting a comment with comment review workflow enabled. 
svn path=/plone.app.discussion/trunk/; revision=40495
 2010-10-03 19:07:30 +00:00
Timo Stollenwerk
603bcf3547 Ignore certain lines for code coverage. 
svn path=/plone.app.discussion/trunk/; revision=40494
 2010-10-03 16:52:26 +00:00
Timo Stollenwerk
f5cf756e31 Functional test for replying to an existing comment added. 
svn path=/plone.app.discussion/trunk/; revision=40493
 2010-10-03 16:50:47 +00:00
Timo Stollenwerk
497c2a075e There is no need to set the title in the handleComment method anymore. 
svn path=/plone.app.discussion/trunk/; revision=40492
 2010-10-03 07:29:44 +00:00
Timo Stollenwerk
e0055d0ba7 Make sure comment titles work with special characters as well. 
svn path=/plone.app.discussion/trunk/; revision=40486
 2010-10-02 18:16:49 +00:00
Timo Stollenwerk
51d6c60412 Use the right event subscriber to make sure all comments are removed from the catalog, if their content object is deleted. 
svn path=/plone.app.discussion/trunk/; revision=40485
 2010-10-02 14:50:17 +00:00
Luca Fabbri
1edbf3a262 italian translation updated 
svn path=/plone.app.discussion/trunk/; revision=40461
 2010-09-30 22:00:24 +00:00
Luca Fabbri
2d603c2c0e italian translation updated 
svn path=/plone.app.discussion/trunk/; revision=40460
 2010-09-30 21:52:40 +00:00
Timo Stollenwerk
0e27b8b7b6 Move regression test for #11157 into the main functional test. 
svn path=/plone.app.discussion/trunk/; revision=40458
 2010-09-30 17:45:26 +00:00
Timo Stollenwerk
22db0b1c78 Fix comment title for anonymous commentators that do not provide a name. 
svn path=/plone.app.discussion/trunk/; revision=40435
 2010-09-29 10:52:11 +00:00
Timo Stollenwerk
2cce7e0d0f "Post comment as logged-in users" test added. 
svn path=/plone.app.discussion/trunk/; revision=40434
 2010-09-29 10:17:25 +00:00
Timo Stollenwerk
689fd26c12 Apply the comment viewlet template and styles to the new title-less comments. This might require integrators to apply their custom templates and styles. 
svn path=/plone.app.discussion/trunk/; revision=40433
 2010-09-29 08:13:54 +00:00
Timo Stollenwerk
8d00463502 Remove subject line from comment batch moderation view, since this doesn't make sense anymore with auto-generated titles. 
svn path=/plone.app.discussion/trunk/; revision=40432
 2010-09-29 08:02:39 +00:00
Timo Stollenwerk
f67c7cde6d Remove title field from the comment form and replace it with an auto-generated title ("John Doe on Welcome to Plone"). 
This also fixes http://dev.plone.org/plone/ticket/11098

svn path=/plone.app.discussion/trunk/; revision=40431
 2010-09-29 07:56:36 +00:00
Timo Stollenwerk
7df932204c Functional plone.testing doctest added. 
svn path=/plone.app.discussion/trunk/; revision=40393
 2010-09-28 16:35:45 +00:00
Timo Stollenwerk
138942470c Make sure the __parent__ pointer (the conversation) of a comment is not acquisition wrapped in conversation.addComment. This fixes Refs #11157. 
svn path=/plone.app.discussion/trunk/; revision=40374
 2010-09-28 10:37:40 +00:00
Timo Stollenwerk
a55ff5b883 Fix pickle regression test. 
svn path=/plone.app.discussion/trunk/; revision=40373
 2010-09-28 10:18:16 +00:00
Timo Stollenwerk
77e44f96ad Added test (currently failing) to trigger "can't pickle objects in acquisition wrapper". Refs #11157 
svn path=/plone.app.discussion/trunk/; revision=40357
 2010-09-27 19:03:43 +00:00
Timo Stollenwerk
58868c55e7 whitespace. 
svn path=/plone.app.discussion/trunk/; revision=40232
 2010-09-24 19:45:57 +00:00
Timo Stollenwerk
e95ae26a11 Fix moderation test headline. 
svn path=/plone.app.discussion/trunk/; revision=40229
 2010-09-24 19:04:35 +00:00
Timo Stollenwerk
cf11a5134a Javascript tests for the bulk moderation view added (currently failing). 
svn path=/plone.app.discussion/trunk/; revision=40228
 2010-09-24 19:04:03 +00:00
Timo Stollenwerk
ad99e45203 Revert r35608 since this was breaking the comment moderation bulk actions. The BulkActionsView expects the absolute path of the comments without the portal url (e.g. '/plone/doc1/++conversation++default/1285346769126020'). This fixes https://dev.plone.org/plone/ticket/11156. 
svn path=/plone.app.discussion/trunk/; revision=40227
 2010-09-24 17:04:24 +00:00
Timo Stollenwerk
2ff95fe847 Make sure the moderation JS functions are executed after the page is fully loaded. 
svn path=/plone.app.discussion/trunk/; revision=40215
 2010-09-24 14:57:19 +00:00
Timo Stollenwerk
399bba5eca Use "(function($) { /* some code that uses $ */ })(jQuery)" instead of "$(document).ready(function(){ /* some code that uses $ */ });" to invoke jQuery code. 
svn path=/plone.app.discussion/trunk/; revision=40214
 2010-09-24 14:21:26 +00:00
Timo Stollenwerk
57758d2cf8 More workflow tests. 
svn path=/plone.app.discussion/trunk/; revision=40203
 2010-09-24 13:33:21 +00:00
Timo Stollenwerk
ea26c70eed Clean up whitespace, change workflow description. 
svn path=/plone.app.discussion/trunk/; revision=40192
 2010-09-24 03:12:12 +00:00
Timo Stollenwerk
41c9d030d8 Clean up whitespace, change workflow description. 
svn path=/plone.app.discussion/trunk/; revision=40191
 2010-09-24 03:11:39 +00:00
Timo Stollenwerk
d77ca9d583 Commenting form explanation added. 
svn path=/plone.app.discussion/trunk/; revision=40167
 2010-09-23 14:46:24 +00:00
Timo Stollenwerk
c364630a8c js test for comments updated. 
svn path=/plone.app.discussion/trunk/; revision=40166
 2010-09-23 14:42:18 +00:00
Timo Stollenwerk
9d0fa61c4d Remove unnecessary XXX since we already use layers. 
svn path=/plone.app.discussion/trunk/; revision=40165
 2010-09-23 12:56:17 +00:00
Timo Stollenwerk
f1cf4c9688 Translation files updated. 
svn path=/plone.app.discussion/trunk/; revision=40154
 2010-09-23 11:06:38 +00:00