ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,699 Commits 1 Branch 0 Tags 5 MiB
add7610466
Commit Graph

1164 Commits

Author SHA1 Message Date
Timo Stollenwerk
07cde3ca7b Pep8 2012-01-13 10:16:01 +01:00
Timo Stollenwerk
e17cfa68a1 Fix whitespace/Pep8/Pyflakes in tests. 2012-01-09 16:43:54 +01:00
Timo Stollenwerk
1f01a71aac Whitespace. 2012-01-09 16:31:52 +01:00
Timo Stollenwerk
3b1d1b8967 Changelog entry and test to fix #12437 added. 2011-12-21 19:37:40 +01:00
Timo Stollenwerk
5e81422cd1 Rename discussion var to ctool which is more appropriate. 2011-12-21 19:17:58 +01:00
Paul J Stevens
6eb38ace08 fix indexing of comments (#12437) 2011-12-21 15:07:33 +01:00
hvelarde
774efd39d6 updated Spanish translation 2011-12-14 15:35:46 -06:00
Timo Stollenwerk
6a7c89ec78 Do not raise an error if the comment text is None. 2011-11-30 13:05:59 +01:00
Vincent Fretin
02775ac744 fixed typo 2011-11-21 19:27:43 +01:00
Vincent Fretin
9040f25dc1 fixed po headers 2011-11-21 19:17:06 +01:00
Timo Stollenwerk
f68c2caf9f Remove unused PloneTestCase import. 2011-10-30 08:19:30 +01:00
Timo Stollenwerk
b0a177f4d2 Fix various text typos. 2011-10-30 08:11:06 +01:00
Karl Johan Kleist
3b0b8a96ce fixed speling error, closes #12288 2011-10-18 09:56:24 +03:00
Paul J Stevens
1e040a1fd9 update NL translations 2011-09-30 16:41:09 +02:00
Paul J Stevens
21d2115cca add Dutch translations 2011-09-30 16:03:05 +02:00
Jon Stahl
813631dde8 couple of typos in control panel helptext 
svn path=/plone.app.discussion/trunk/; revision=51868
 2011-08-31 21:11:47 +00:00
Timo Stollenwerk
5911bae362 whitespace. 
svn path=/plone.app.discussion/trunk/; revision=51798
 2011-08-26 11:13:19 +00:00
Takeshi Yamamoto
0a13f79460 corrected location of Japanese po file. 
svn path=/plone.app.discussion/trunk/; revision=51758
 2011-08-24 01:14:43 +00:00
Timo Stollenwerk
f2a5c52947 Remove one_state_workflow customizations. 
svn path=/plone.app.discussion/trunk/; revision=51722
 2011-08-22 19:27:42 +00:00
David Glick
2bf5b43df5 uncatalog comments from the old location of the item being moved, not its parent 
svn path=/plone.app.discussion/trunk/; revision=51692
 2011-08-20 02:37:24 +00:00
David Glick
2b10fd06e2 fix failing test in CMFPlone. some things are contentish but not adaptable to IConversation (such as collection criteria) 
svn path=/plone.app.discussion/trunk/; revision=51682
 2011-08-19 18:54:44 +00:00
Volodymyr Cherepanyak
6e157df3d3 Ukrainian translation added 
svn path=/plone.app.discussion/trunk/; revision=51663
 2011-08-19 09:33:15 +00:00
Jian Aijun
dea6b644b6 updated Simplified Chinese translations 
svn path=/plone.app.discussion/trunk/; revision=51655
 2011-08-19 04:46:50 +00:00
Timo Stollenwerk
3798338549 No need to manually put comments from conversation.getComments in an acquisition chain since getComments now returns acquisition wrapped comments. 
svn path=/plone.app.discussion/trunk/; revision=51642
 2011-08-18 07:31:00 +00:00
Timo Stollenwerk
5045960281 Make sure the conversation.getComments method returns acquisition wrapped comments. 
svn path=/plone.app.discussion/trunk/; revision=51639
 2011-08-18 06:39:25 +00:00
nobody
d870171b37 updated Simplified Chinese translations 
svn path=/plone.app.discussion/trunk/; revision=51590
 2011-08-11 06:09:14 +00:00
Timo Stollenwerk
87700f3810 Markdown syntax added to possible comment text transforms. 
svn path=/plone.app.discussion/trunk/; revision=51530
 2011-08-05 10:08:39 +00:00
Timo Stollenwerk
cdf2beda40 Make sure only comments to the content object are removed from the catalog when the content object is moved. 
svn path=/plone.app.discussion/trunk/; revision=51527
 2011-08-04 15:53:21 +00:00
Timo Stollenwerk
0e47299c75 Make sure the comment brains are updated properly when the content object is renamed. Thanks hannosch for the code review. 
svn path=/plone.app.discussion/trunk/; revision=51526
 2011-08-04 14:13:01 +00:00
Jian Aijun
ca163009cc updated Simplified Chinese translations 
svn path=/plone.app.discussion/trunk/; revision=51446
 2011-07-26 06:04:48 +00:00
Jian Aijun
3dd76e2bb4 added & updated Simplified Chinese translation 
svn path=/plone.app.discussion/trunk/; revision=51444
 2011-07-25 15:47:26 +00:00
Timo Stollenwerk
f98b82b2d8 Make sure the catalog index for creator always stores encoded stings and not unicode since all strings in the catalog have to be utf-8 encoded strings. 
svn path=/plone.app.discussion/trunk/; revision=51435
 2011-07-25 08:12:04 +00:00
Timo Stollenwerk
1a6b1fdb91 Use Plone's safe_encode method instead of encode() to make sure unicode encoded strings can be indexed too. 
svn path=/plone.app.discussion/trunk/; revision=51432
 2011-07-25 06:47:45 +00:00
Timo Stollenwerk
dbda349768 Automatically reload batch moderation page if no comments are left. This refs #11298. 
svn path=/plone.app.discussion/trunk/; revision=51274
 2011-07-15 17:29:29 +00:00
Timo Stollenwerk
637ac334ac Remove debug print. 
svn path=/plone.app.discussion/trunk/; revision=51259
 2011-07-15 08:25:34 +00:00
Timo Stollenwerk
160022b146 Another fix for http://dev.plone.org/plone/ticket/11486. r51246 fixed Chrome but broke Safari. This fix has been tested in Fx, Chrome, Safari and IE 9. 
svn path=/plone.app.discussion/trunk/; revision=51258
 2011-07-15 08:23:08 +00:00
Timo Stollenwerk
c2ff87a778 Fix discussion control panel submit. This fixes Refs #11486. 
svn path=/plone.app.discussion/trunk/; revision=51246
 2011-07-14 07:09:58 +00:00
Timo Stollenwerk
9cd4058bca Move move_comments test to the right position. 
svn path=/plone.app.discussion/trunk/; revision=50947
 2011-07-04 07:27:16 +00:00
Timo Stollenwerk
50641ac6cc Remove unnecessary lines from notify_content_object_moved event subscriber function. 
svn path=/plone.app.discussion/trunk/; revision=50944
 2011-07-04 07:07:42 +00:00
Timo Stollenwerk
b7dad192d5 Update comment brains in zcatalog when moving a content object with comments. This fixes http://dev.plone.org/plone/ticket/11331. Refs #11331 
svn path=/plone.app.discussion/trunk/; revision=50937
 2011-07-03 18:36:02 +00:00
Timo Stollenwerk
101e9e2616 Plone 3 specific exclusion of plone.app.uuid removed. 
svn path=/plone.app.discussion/trunk/; revision=50935
 2011-07-03 18:26:06 +00:00
Timo Stollenwerk
98bcc19d5c Do not render/update the comment form in CommentViewlets if commenting is disabled, since this slows down the page rendering. This fixes http://dev.plone.org/plone/ticket/11930 #11930 
svn path=/plone.app.discussion/trunk/; revision=50489
 2011-06-16 10:59:25 +00:00
Laurence Rowe
46404c709f Move comments.js registration so it is merged along with other anonymous resources 
svn path=/plone.app.discussion/trunk/; revision=50263
 2011-06-05 22:30:56 +00:00
Laurence Rowe
b653c7a130 Insert css after forms.css to allow merging 
svn path=/plone.app.discussion/trunk/; revision=50261
 2011-06-05 22:05:22 +00:00
Laurence Rowe
b18da3f1ae Simplify CSS and JS registrations. CSS will now be imported using the 
standard link and so can be merged.

svn path=/plone.app.discussion/trunk/; revision=50260
 2011-06-05 21:52:01 +00:00
WouterVH
f149f0f8dd - Enable the left-menu on the configlet, to be more consistent with all other configlets. 
Related to https://dev.plone.org/plone/ticket/11737
  [WouterVH]

svn path=/plone.app.discussion/trunk/; revision=50095
 2011-05-28 22:02:33 +00:00
Timo Stollenwerk
a7f61eb4d3 Refactor/clean up the handleComment method. 
svn path=/plone.app.discussion/trunk/; revision=50069
 2011-05-27 13:47:15 +00:00
Timo Stollenwerk
1ea5f0cdb4 Make handleComment method store comment attributes from form extenders. This allows us to extend the comment form with external add-ons. 
svn path=/plone.app.discussion/trunk/; revision=50059
 2011-05-26 21:37:37 +00:00
Jian Aijun
f9f394a1f1 Updated Simplified Chinese translation 
svn path=/plone.app.discussion/trunk/; revision=49791
 2011-05-19 01:39:35 +00:00
Jian Aijun
dbd872a517 Updated Simplified Chinese translation 
svn path=/plone.app.discussion/trunk/; revision=49630
 2011-05-15 23:46:21 +00:00
Jian Aijun
5f983ffb4b Updated Simplified Chinese translation 
svn path=/plone.app.discussion/trunk/; revision=49602
 2011-05-15 01:25:01 +00:00
Jian Aijun
582ad4af19 Add Simplified Chinese translation 
svn path=/plone.app.discussion/trunk/; revision=49577
 2011-05-14 01:37:59 +00:00
Giorgio Borelli
d9016974fc italian translation review 
svn path=/plone.app.discussion/trunk/; revision=49571
 2011-05-13 22:21:51 +00:00
Timo Stollenwerk
420af84651 Minor German translation fix. 
svn path=/plone.app.discussion/trunk/; revision=49340
 2011-05-06 09:18:19 +00:00
Karl Johan Kleist
731e95af7a sv: all strings now translated for Plone 4.1 
svn path=/plone.app.discussion/trunk/; revision=49336
 2011-05-05 18:08:01 +00:00
Karl Johan Kleist
51466e8192 sv: just a few looong ones remain to translate now 
svn path=/plone.app.discussion/trunk/; revision=49326
 2011-05-04 17:23:20 +00:00
Karl Johan Kleist
c02450f2ff sv: first version based on "no", several strings remain to translate 
svn path=/plone.app.discussion/trunk/; revision=49310
 2011-05-03 15:51:02 +00:00
Erico Andrei
9ac35de362 Tests expect a False to be returned from the funcion 
svn path=/plone.app.discussion/trunk/; revision=49137
 2011-04-27 19:33:00 +00:00
Erico Andrei
1a751b495f Unless Discussion Item has an workflow, moderation is not enabled 
svn path=/plone.app.discussion/trunk/; revision=49135
 2011-04-27 17:41:07 +00:00
Thomas Desvenain
3a224784b0 typo 
svn path=/plone.app.discussion/trunk/; revision=49134
 2011-04-27 16:19:39 +00:00
Timo Stollenwerk
46ad92c4a2 German translation updated. 
svn path=/plone.app.discussion/trunk/; revision=49048
 2011-04-22 17:30:35 +00:00
Timo Stollenwerk
5bbf73978e German translation updated. 
svn path=/plone.app.discussion/trunk/; revision=49047
 2011-04-22 17:28:41 +00:00
Timo Stollenwerk
d00282a437 Translations updated. German translations for notifications added. 
svn path=/plone.app.discussion/trunk/; revision=49046
 2011-04-22 17:28:00 +00:00
Timo Stollenwerk
e75685d5c0 Add links to delete/approve a comment in the moderator notification email. 
Remove the unnecessary workflow_action parameter from the PublishComments request.

svn path=/plone.app.discussion/trunk/; revision=49045
 2011-04-22 17:09:09 +00:00
Timo Stollenwerk
521ea78ce3 Whitespace. 
svn path=/plone.app.discussion/trunk/; revision=49043
 2011-04-22 17:04:35 +00:00
Timo Stollenwerk
f551e30849 Replace tabs with whitespace in moderation.js. 
svn path=/plone.app.discussion/trunk/; revision=49036
 2011-04-22 15:43:58 +00:00
Timo Stollenwerk
c66e243a86 Make sure the email settings in the control panel are disabled when commenting is disabled globally; 
Enable/disable moderator_email setting dynamically as mail settings or discussion settings change.

svn path=/plone.app.discussion/trunk/; revision=49035
 2011-04-22 15:41:45 +00:00
Timo Stollenwerk
b84211ddf0 Remove ImportError exceptions for Plone < 4.1 code and plone.z3cform < 0.6.0. 
svn path=/plone.app.discussion/trunk/; revision=49033
 2011-04-22 14:59:59 +00:00
Timo Stollenwerk
31ecf38129 Provide the comment body text in the email notification. 
svn path=/plone.app.discussion/trunk/; revision=49032
 2011-04-22 13:34:50 +00:00
Timo Stollenwerk
f8c39c1b87 Fix comment link in email notification. This fixes http://dev.plone.org/plone/ticket/11413 
svn path=/plone.app.discussion/trunk/; revision=49031
 2011-04-22 12:47:29 +00:00
Timo Stollenwerk
49504c1ddd Redirect to the comment itself when notifying a user about a new comment. 
svn path=/plone.app.discussion/trunk/; revision=49030
 2011-04-22 08:54:35 +00:00
Timo Stollenwerk
93df8aa50b Remove outdated DOCUMENTATION.txt. 
svn path=/plone.app.discussion/trunk/; revision=48997
 2011-04-21 13:18:00 +00:00
Timo Stollenwerk
84a80743fc Fix language code/name for japanese translation. 
svn path=/plone.app.discussion/trunk/; revision=48949
 2011-04-19 07:00:18 +00:00
Takeshi Yamamoto
7803cccf7d added Japanese translation 
svn path=/plone.app.discussion/trunk/; revision=48946
 2011-04-19 05:34:58 +00:00
Timo Stollenwerk
80a7b90a30 Move all tests from testing layer to plone.app.testing. 
svn path=/plone.app.discussion/trunk/; revision=48916
 2011-04-17 08:51:58 +00:00
Timo Stollenwerk
f3d97b2f20 Use plone.app.testing in test_moderation_view. 
svn path=/plone.app.discussion/trunk/; revision=48915
 2011-04-17 08:50:34 +00:00
Timo Stollenwerk
d66328a26a Use plone.app.testing in test_migration. 
svn path=/plone.app.discussion/trunk/; revision=48906
 2011-04-16 09:51:28 +00:00
Timo Stollenwerk
216e95aa27 Use plone.app.testing in test_indexers. 
svn path=/plone.app.discussion/trunk/; revision=48905
 2011-04-16 09:35:34 +00:00
Timo Stollenwerk
85126e9109 Use plone.app.testing in test_notifications. 
svn path=/plone.app.discussion/trunk/; revision=48904
 2011-04-16 09:31:03 +00:00
Timo Stollenwerk
1682c89745 Use plone.app.testing in test_tool. 
svn path=/plone.app.discussion/trunk/; revision=48903
 2011-04-16 09:30:11 +00:00
Timo Stollenwerk
fc59094cb2 Use plone.app.testing in test_workflow. 
svn path=/plone.app.discussion/trunk/; revision=48902
 2011-04-16 09:29:15 +00:00
Timo Stollenwerk
41f5afa8b9 Use plone.app.testing in test_conversation. 
svn path=/plone.app.discussion/trunk/; revision=48901
 2011-04-16 09:27:15 +00:00
Timo Stollenwerk
c4e69627b3 Use plone.app.testing in test_controlpanel. 
svn path=/plone.app.discussion/trunk/; revision=48900
 2011-04-16 09:26:20 +00:00
Timo Stollenwerk
f8019b0c10 Use plone.app.testing in test_comments_viewlet. 
svn path=/plone.app.discussion/trunk/; revision=48899
 2011-04-16 09:25:16 +00:00
Timo Stollenwerk
38b70a28e5 Use plone.app.testing in test_comment. 
svn path=/plone.app.discussion/trunk/; revision=48898
 2011-04-16 09:16:18 +00:00
Timo Stollenwerk
e5d45dbd78 Use plone.app.testing in test_catalog. 
svn path=/plone.app.discussion/trunk/; revision=48897
 2011-04-16 09:13:39 +00:00
Hanno Schlichting
4110b41ae6 Even simpler code :) 
svn path=/plone.app.discussion/trunk/; revision=48886
 2011-04-15 16:56:17 +00:00
Hanno Schlichting
b4c5d287dd Style ;) 
svn path=/plone.app.discussion/trunk/; revision=48885
 2011-04-15 16:47:57 +00:00
Hanno Schlichting
f2e47227f9 Fix old-style exception raising 
svn path=/plone.app.discussion/trunk/; revision=48884
 2011-04-15 16:44:16 +00:00
Hanno Schlichting
9db8909ea7 Avoid using deprecated test assertions, see http://docs.python.org/dev/library/unittest.html#deprecated-aliases for the full list 
svn path=/plone.app.discussion/trunk/; revision=48881
 2011-04-15 16:23:38 +00:00
Hanno Schlichting
811d4a0429 Avoid deprecation warnings and always specify a catalog query as a dict 
svn path=/plone.app.discussion/trunk/; revision=48880
 2011-04-15 16:17:02 +00:00
Ross Patterson
3708429a37 Move some policy out of the conversation storage adapter into a view, 
specifically "enabled()".  Prevents having to replace/migrate
persistent objects to change policy which really only concerns the
context and possibly the request, not the conversation storage. Fixes
#11372.

svn path=/plone.app.discussion/trunk/; revision=48849
 2011-04-15 04:29:46 +00:00
Ross Patterson
7354ca4298 Fix unindexing of comments when deleting content resulting from 
iterating over a BTree while modifying it. Fixes #11402.

svn path=/plone.app.discussion/trunk/; revision=48845
 2011-04-14 21:30:32 +00:00
Erico Andrei
82b4a7ca70 Adding Brazilian Portuguese translation 
svn path=/plone.app.discussion/trunk/; revision=48843
 2011-04-14 20:58:24 +00:00
Erico Andrei
ea94d5e842 Adding Brazilian Portuguese translation 
svn path=/plone.app.discussion/trunk/; revision=48842
 2011-04-14 20:57:09 +00:00
Ross Patterson
5786bfa6b6 pep8 
svn path=/plone.app.discussion/trunk/; revision=48840
 2011-04-14 20:17:10 +00:00
Ross Patterson
cad670d6af Fax Missing.Value for Creator in the catalog. Fixes #11634. 
svn path=/plone.app.discussion/trunk/; revision=48838
 2011-04-14 19:59:05 +00:00
Ross Patterson
187aa60452 These testbrowser tests certainly no longer raise 404s for me 
svn path=/plone.app.discussion/trunk/; revision=48837
 2011-04-14 19:06:55 +00:00
Ross Patterson
d3025fb3ec Fix some aq wrapper errors introduced by my previous fix but not 
exposed since the functional tests weren't running.

svn path=/plone.app.discussion/trunk/; revision=48836
 2011-04-14 19:06:24 +00:00
Ross Patterson
d8f864596e The functional tests haven't been running due to an unused import 
svn path=/plone.app.discussion/trunk/; revision=48835
 2011-04-14 19:05:31 +00:00
Ross Patterson
d5a999b429 Clarify a doctest 
svn path=/plone.app.discussion/trunk/; revision=48831
 2011-04-14 16:41:11 +00:00
WouterVH
4b95d10bb6 some more nl-translations 
svn path=/plone.app.discussion/trunk/; revision=48830
 2011-04-14 16:38:22 +00:00
Ross Patterson
586cd1fdb7 Don't add the annotation unless a comment is actually being added. 
Fixes #11370.

svn path=/plone.app.discussion/trunk/; revision=48829
 2011-04-14 16:17:29 +00:00
Thomas Desvenain
119c1cb060 French translations 
svn path=/plone.app.discussion/trunk/; revision=48820
 2011-04-14 12:52:04 +00:00
Vincent Fretin
7912d9a049 Resync translations 
svn path=/plone.app.discussion/trunk/; revision=48696
 2011-04-10 20:38:14 +00:00
Vincent Fretin
7b42c34493 Nobody seems to maintain the LANGUAGES variable, remove the update-translations.sh script, use a simpler locales/update.sh script. 
svn path=/plone.app.discussion/trunk/; revision=48695
 2011-04-10 20:37:37 +00:00
Vincent Fretin
ab5c728448 Fixed i18n of the "Commenting has been disabled." message. 
svn path=/plone.app.discussion/trunk/; revision=48694
 2011-04-10 20:28:21 +00:00
David Glick
7803674dd0 merge r48557 from 1.x branch 
svn path=/plone.app.discussion/trunk/; revision=48558
 2011-04-08 20:47:50 +00:00
David Glick
8d3a37ead9 merge r48555 from 1.x branch. bumping profile version to 100 so there's space for future upgrades in the 1.x line 
svn path=/plone.app.discussion/trunk/; revision=48556
 2011-04-08 20:23:07 +00:00
David Glick
d323d37285 add upgrade step for moderator_email setting 
svn path=/plone.app.discussion/branches/1.x/; revision=48555
 2011-04-08 20:20:34 +00:00
David Glick
6d11fa6d5e merge c48523 from 1.x branch 
svn path=/plone.app.discussion/trunk/; revision=48527
 2011-04-07 21:31:56 +00:00
David Glick
9aea1915c1 add moderator email setting 
svn path=/plone.app.discussion/branches/1.x/; revision=48523
 2011-04-07 20:02:27 +00:00
Pavel Bogdanovic
c669e03ae2 some german translations 
svn path=/plone.app.discussion/trunk/; revision=48395
 2011-04-04 13:01:48 +00:00
David Glick
203836dc5e make discussion.css cacheable 
svn path=/plone.app.discussion/trunk/; revision=48359
 2011-04-02 21:27:47 +00:00
David Glick
636bca745c merge r47140, r47290, r47579 from davisagli-features: fix timezone handling when migrating legacy comments and when indexing 
svn path=/plone.app.discussion/trunk/; revision=48358
 2011-04-02 21:26:36 +00:00
David Glick
9d83b4f0e6 merge -r46947 from davisagli-features: preserve legacy titles on migrated comments 
svn path=/plone.app.discussion/trunk/; revision=48357
 2011-04-02 21:16:24 +00:00
David Glick
eb004aab44 merge r46437 and r46946 from davisagli-features: respect the per-comment mime_type setting, and use the old cooked text/html from legacy comments when migrating 
svn path=/plone.app.discussion/trunk/; revision=48356
 2011-04-02 19:51:37 +00:00
David Glick
bf5946367a merge r46436 from davisagli-features: make it possible to specify a callback filter for the migration 
svn path=/plone.app.discussion/trunk/; revision=48354
 2011-04-02 19:33:10 +00:00
David Glick
feb1759958 fix incorrect parenthesization 
svn path=/plone.app.discussion/trunk/; revision=48240
 2011-03-26 05:04:22 +00:00
David Glick
ebbf2d9b7b fix deprecation warning 
svn path=/plone.app.discussion/trunk/; revision=48234
 2011-03-26 02:44:49 +00:00
Thomas Desvenain
9b87f2b246 French translations 
svn path=/plone.app.discussion/trunk/; revision=48112
 2011-03-17 16:51:08 +00:00
Thomas Desvenain
7c2a815fdb Fixed internationalization issues. 
svn path=/plone.app.discussion/trunk/; revision=48110
 2011-03-17 16:15:40 +00:00
Thomas Desvenain
cf5f101538 message extraction + french translations (previous commit was bad) 
svn path=/plone.app.discussion/trunk/; revision=48108
 2011-03-17 15:30:31 +00:00
Thomas Desvenain
7271293606 message extraction + french translations 
svn path=/plone.app.discussion/trunk/; revision=48107
 2011-03-17 15:23:47 +00:00
Patrick Gerken
882e9e028f Take care of properly converting titles to unicode 
svn path=/plone.app.discussion/branches/1.x/; revision=47999
 2011-03-09 03:07:59 +00:00
Patrick Gerken
de9ebea499 Ups, there is a nother unicode problem 
svn path=/plone.app.discussion/branches/1.x/; revision=47998
 2011-03-09 03:07:46 +00:00
Patrick Gerken
39d692f9b8 Trigger failure for objects with unicode titles in string 
svn path=/plone.app.discussion/branches/1.x/; revision=47997
 2011-03-09 03:07:29 +00:00
Patrick Gerken
65aab05d1b Fixed test failure for the default user portrait, which changed from 
defaultUser.gif to defaultUser.png in Products.PlonePAS 4.0.5.

Backport if maurits changes to the trunk

svn path=/plone.app.discussion/branches/1.x/; revision=47996
 2011-03-09 03:03:17 +00:00
Patrick Gerken
79701cce7e Take care of properly converting titles to unicode 
svn path=/plone.app.discussion/trunk/; revision=47991
 2011-03-08 20:15:52 +00:00
Patrick Gerken
774ed36746 Ups, there is a nother unicode problem 
svn path=/plone.app.discussion/trunk/; revision=47990
 2011-03-08 20:15:37 +00:00
Patrick Gerken
b6d406d298 Trigger failure for objects with unicode titles in string 
svn path=/plone.app.discussion/trunk/; revision=47989
 2011-03-08 20:15:21 +00:00
JC Brand
97b8b6a060 Add the af translations to the 1.x branch as well. 
svn path=/plone.app.discussion/branches/1.x/; revision=47959
 2011-03-07 15:48:51 +00:00
JC Brand
c26e1b9123 Add af translations 
svn path=/plone.app.discussion/trunk/; revision=47953
 2011-03-07 13:49:13 +00:00
Maurits van Rees
478273aa80 minor code cleanup 
svn path=/plone.app.discussion/trunk/; revision=47599
 2011-02-15 16:23:12 +00:00
Maurits van Rees
81d74cfe6b Fixed test failure for the default user portrait, which changed from 
defaultUser.gif to defaultUser.png in Products.PlonePAS 4.0.5.

svn path=/plone.app.discussion/trunk/; revision=47597
 2011-02-15 16:19:13 +00:00
Timo Stollenwerk
bf96d0082f Remove "Plone 3 only" code; Do not monkey patch the BAD_TYPES vocabulary or plone.app.vocabularies anymore. 
svn path=/plone.app.discussion/trunk/; revision=47311
 2011-02-08 09:28:51 +00:00
Timo Stollenwerk
0a0e69d47d Do not check for a comment review workflow when sending out a moderator email notification. This fixes http://dev.plone.org/plone/ticket/11444. Refs #11444 
svn path=/plone.app.discussion/trunk/; revision=47292
 2011-02-07 11:48:24 +00:00
Timo Stollenwerk
de4353641b Do not check for a comment review workflow when sending out a moderator email notification. This fixes http://dev.plone.org/plone/ticket/11444. Refs #11444 
svn path=/plone.app.discussion/branches/1.x/; revision=47189
 2011-02-02 19:55:24 +00:00
Timo Stollenwerk
0c435dc9ca Check if the current user has configured an e-mail address for the email notification option. Refs #11428 
svn path=/plone.app.discussion/trunk/; revision=47069
 2011-01-26 08:15:14 +00:00
Timo Stollenwerk
15c681d27f Check if the current user has configured an e-mail address for the email notification option. Refs #11428 
svn path=/plone.app.discussion/branches/1.x/; revision=47068
 2011-01-26 08:06:21 +00:00
Timo Stollenwerk
543b9d47c5 Remove moderation_enabled setting from registry to avoid migration problems to 1.0RC1. Refs #11419. 
svn path=/plone.app.discussion/branches/1.x/; revision=47031
 2011-01-24 08:37:43 +00:00
Timo Stollenwerk
ed4f2b1fa8 Comment out the discussion control panel event subscriber tests. We disabled this functionality anyway. 
svn path=/plone.app.discussion/branches/1.x/; revision=46991
 2011-01-22 12:39:15 +00:00
Timo Stollenwerk
2f30c27555 Disable the control panel event subscribers. We don't need them since we disabled the enable_moderation setting in the discussion control panel anyway. 
svn path=/plone.app.discussion/branches/1.x/; revision=46990
 2011-01-22 12:34:49 +00:00
Timo Stollenwerk
5cac8b7a1b Hide the moderation_enabled widget in the discussion control panel. We need plone.app.controlpanel > 2.1b1 for this, which is not shipped with Plone 3.x or 4.0.x. 
svn path=/plone.app.discussion/branches/1.x/; revision=46989
 2011-01-22 12:00:15 +00:00
Timo Stollenwerk
4ab29000a6 Import Owned from OFS.owner to avoid deprecation warnings. 
svn path=/plone.app.discussion/trunk/; revision=46977
 2011-01-20 20:38:50 +00:00
Timo Stollenwerk
f3ff8e9647 Fix failing test. Discussion is enabled by default again. 
svn path=/plone.app.discussion/branches/1.x/; revision=46975
 2011-01-20 20:08:51 +00:00
Timo Stollenwerk
fb0ca6c795 Replace tabs with whitespace. 
svn path=/plone.app.discussion/trunk/; revision=46974
 2011-01-20 20:04:38 +00:00
Timo Stollenwerk
9790dd5b65 Enable discussion by default if p.a.discussion is shipped as add-on product. 
svn path=/plone.app.discussion/branches/1.x/; revision=46973
 2011-01-20 19:49:58 +00:00
Timo Stollenwerk
9cc32a76a4 Enable ajaxify comment deletion again ([thomasdesvenain]). This has been disabled in 1.0b12 because of problems with Plone 3. 
svn path=/plone.app.discussion/trunk/; revision=46970
 2011-01-20 19:38:26 +00:00
Timo Stollenwerk
c15c898565 Remove collective.autopermission dependency. 
svn path=/plone.app.discussion/trunk/; revision=46969
 2011-01-20 19:37:54 +00:00
Timo Stollenwerk
75cde25b6f Always show existing comments, even if commenting is disabled. 
svn path=/plone.app.discussion/trunk/; revision=46785
 2011-01-07 15:27:17 +00:00
Timo Stollenwerk
61e231b336 Fix CSS for commenter images with a width of more than 2.5em. This fixes http://dev.plone.org/plone/ticket/11391. Refs #11391 
svn path=/plone.app.discussion/trunk/; revision=46783
 2011-01-07 10:27:13 +00:00
Timo Stollenwerk
c438743a3b Show a 'Comments are moderated.' message next to the comment form if comments are moderated. 
svn path=/plone.app.discussion/trunk/; revision=46782
 2011-01-07 10:20:24 +00:00
David Glick
b0ca33dcc6 make sure p.a.registry ZCML is loaded 
svn path=/plone.app.discussion/trunk/; revision=46432
 2010-12-21 19:20:36 +00:00
Maurits van Rees
d90c436f8a Removed the conditional loading of event subscribers: 
- zope.app.container is available in both Plone 3 and Plone 4, so the 'not-installed zope.app.container' condition was always false
- zope.lifecycleevent.interfaces does not have an IObjectAddedEvent or IObjectRemovedEvent so even if the condition would have been true, the loading would have failed.

svn path=/plone.app.discussion/trunk/; revision=46367
 2010-12-16 02:12:13 +00:00
Maurits van Rees
a2a17085a3 Nuke trailing white space 
svn path=/plone.app.discussion/trunk/; revision=46366
 2010-12-15 23:52:56 +00:00
Maurits van Rees
aff8a3709c Avoid sending multiple notification emails to the same person when 
he has commented multiple times.

svn path=/plone.app.discussion/trunk/; revision=46365
 2010-12-15 23:41:57 +00:00
Maurits van Rees
9eb172023a No tabs in zcml please 
svn path=/plone.app.discussion/trunk/; revision=46364
 2010-12-15 22:59:24 +00:00
Maurits van Rees
87d767651b Do not fail on startup with Plone 3 when plone.uuid is not there: 
make implementing the plone.uuid.interfaces.IAttributeUUID interface conditional for Plone 4 only.

svn path=/plone.app.discussion/trunk/; revision=46363
 2010-12-15 22:45:19 +00:00
David Glick
0cb75778ba make sure comments don't get indexed with their parents' UID in Plone 3. only declare dependency on plone.app.uuid in Python 2.6, since we only use it in Plone 4 currently. 
svn path=/plone.app.discussion/trunk/; revision=46353
 2010-12-15 20:39:55 +00:00
Timo Stollenwerk
b9d929bca3 Fix failing test. 
svn path=/plone.app.discussion/trunk/; revision=46344
 2010-12-14 21:30:40 +00:00
Timo Stollenwerk
a8bfd7fc6e Disable discussion by default. 
svn path=/plone.app.discussion/trunk/; revision=46337
 2010-12-14 17:58:46 +00:00
Timo Stollenwerk
d702c666f0 Tests for moderation_enabled setting added. 
svn path=/plone.app.discussion/trunk/; revision=46266
 2010-12-12 13:56:06 +00:00
Timo Stollenwerk
ea2038b122 Remove XXX line from conversation.py. Martin and I agree that this is probably not relevant anymore. Refs #9288 
svn path=/plone.app.discussion/trunk/; revision=46265
 2010-12-12 12:51:41 +00:00
Timo Stollenwerk
a9ef0503f2 Move discussion action item from actionicons.xml to actions.xml to avoid deprecation warning. 
svn path=/plone.app.discussion/trunk/; revision=46264
 2010-12-12 12:40:19 +00:00
Timo Stollenwerk
4c4cd9e44d Replace XXX with todo. 
svn path=/plone.app.discussion/trunk/; revision=46263
 2010-12-12 08:14:48 +00:00
Timo Stollenwerk
0485398de0 whitespace, make jslint happy. 
svn path=/plone.app.discussion/trunk/; revision=46262
 2010-12-12 08:13:03 +00:00
Timo Stollenwerk
be78fbe300 There is no need to enable the "enable moderation" checkbox dynamically, except when commenting is disabled/enabled globally. 
svn path=/plone.app.discussion/trunk/; revision=46261
 2010-12-12 07:35:43 +00:00
Timo Stollenwerk
08857df7a9 Fix cancel button on edit view when using Dexterity types. This fixes http://dev.plone.org/plone/ticket/11338. Refs #11338 
svn path=/plone.app.discussion/trunk/; revision=46254
 2010-12-11 21:33:43 +00:00
Timo Stollenwerk
f2f97c5b38 Change the comment workflow setting in the discussion control panel if the setting is changed in the types control panel; show warning message and disable the setting if a custom comment workflow is enabled. 
svn path=/plone.app.discussion/trunk/; revision=46253
 2010-12-11 21:30:18 +00:00
Timo Stollenwerk
0475376ed0 "Enable comment moderation" setting added to the discussion control panel. Just a proof of concept so far. Not fully implemented yet. No tests. 
svn path=/plone.app.discussion/trunk/; revision=46249
 2010-12-11 17:18:14 +00:00
Timo Stollenwerk
09a804aa88 Remove unnecessary and failing test. 
svn path=/plone.app.discussion/trunk/; revision=46235
 2010-12-10 09:16:36 +00:00
Timo Stollenwerk
54af7d3fa1 Assigning the 'Reply to item' permission to the 'Authenticated' role. The old commenting system allowed 'Authenticated' users to post comments. Also, OpenID users do not possess the 'Authenticated' role. Refs #9288 
svn path=/plone.app.discussion/trunk/; revision=46230
 2010-12-10 08:57:35 +00:00
Timo Stollenwerk
45140c66db Functional test for posting a comment as user without the 'Reply to item' permission added. 
svn path=/plone.app.discussion/trunk/; revision=46215
 2010-12-09 10:58:32 +00:00
Timo Stollenwerk
7e279d3ad3 Make sure the handleComment method checks for the 'Reply to item' permission when adding a comment. 
svn path=/plone.app.discussion/trunk/; revision=46212
 2010-12-09 08:11:41 +00:00
Timo Stollenwerk
c8e78449a2 Make the mail-setting warning message show up in the discussion control panel. 
svn path=/plone.app.discussion/trunk/; revision=46211
 2010-12-09 08:07:15 +00:00
Timo Stollenwerk
797ed40852 Link directly to the "Discussion Item" types control panel in the moderation view. 
svn path=/plone.app.discussion/trunk/; revision=46207
 2010-12-08 17:45:58 +00:00
Timo Stollenwerk
583b25530e Show "moderate comments" link in the admin panel only if a moderation workflow is enabled for comments. 
svn path=/plone.app.discussion/trunk/; revision=46206
 2010-12-08 17:45:11 +00:00
Timo Stollenwerk
6e354718f4 Revert r46143. 
svn path=/plone.app.discussion/trunk/; revision=46144
 2010-12-05 14:56:13 +00:00
Timo Stollenwerk
22425b06ac Disable commenting by default if pad is shipped with Plone. If shipped as add-on product, commenting should be enabled by default. 
svn path=/plone.app.discussion/trunk/; revision=46143
 2010-12-05 14:50:25 +00:00
Timo Stollenwerk
04a0669731 Remove the grey background from disabled settings. 
svn path=/plone.app.discussion/trunk/; revision=46142
 2010-12-05 14:10:21 +00:00
Timo Stollenwerk
bbd44b7b95 workflow setting added to control panel config string. 
svn path=/plone.app.discussion/trunk/; revision=46091
 2010-12-02 23:20:10 +00:00
Timo Stollenwerk
ffde4b423d Do not allow to change the mail settings in the discussion control panel, if there is no valid mail setup. Refactor js code to use class settings of #content. 
svn path=/plone.app.discussion/trunk/; revision=46090
 2010-12-02 23:02:00 +00:00
Timo Stollenwerk
fbd7eb2bbc Do not allow to change the mail settings in the discussion control panel, if there is no valid mail setup. 
svn path=/plone.app.discussion/trunk/; revision=46089
 2010-12-02 21:07:58 +00:00
Timo Stollenwerk
1b36f99a7a make jslint happy; disable settings onload; 
svn path=/plone.app.discussion/trunk/; revision=46088
 2010-12-02 19:49:49 +00:00
Timo Stollenwerk
2a7a65293e disable form fields when disabling the fields. 
svn path=/plone.app.discussion/trunk/; revision=46087
 2010-12-02 19:09:16 +00:00
Timo Stollenwerk
f97c17e62a Factor out enable/disable settings function. 
svn path=/plone.app.discussion/trunk/; revision=46086
 2010-12-02 18:50:21 +00:00
Timo Stollenwerk
ffcc29a401 Override the default plone.app.registry controlpanel template; JS file for the controlpanel added. Disable all commenting options in the discussion control panel when comments are disabled globally. 
svn path=/plone.app.discussion/trunk/; revision=46085
 2010-12-02 18:15:47 +00:00
Timo Stollenwerk
c311a4f88d Check for the 'review comments' permission instead of 'manage' to decide if the user should see a 'this comment is pending' message. 
svn path=/plone.app.discussion/trunk/; revision=46050
 2010-12-01 06:34:05 +00:00
Timo Stollenwerk
19f0666b39 Move "moderate comments" site action above the logout action. 
svn path=/plone.app.discussion/trunk/; revision=46047
 2010-11-30 18:17:02 +00:00
Timo Stollenwerk
d94767576b Do not use plone.app.uuid to generate unique UIDs for Plone 3. plone.app.uuid causes the IObjectAddedEvent to be fired twice on Plone 3. This causes the email notifications to be send twice. This means that https://dev.plone.org/plone/ticket/10652 is fixed only for Plone 4. 
svn path=/plone.app.discussion/trunk/; revision=46043
 2010-11-30 09:50:12 +00:00
Timo Stollenwerk
2b3a84e9d1 Moderator notification description updated. 
svn path=/plone.app.discussion/trunk/; revision=46042
 2010-11-30 09:13:30 +00:00
Timo Stollenwerk
13772c6e5b Redirect back to the discussion control panel when the discussion control panel form is submitted. 
svn path=/plone.app.discussion/trunk/; revision=46040
 2010-11-30 09:06:46 +00:00
Timo Stollenwerk
824ed1e94a Fix document_byline bottom margin if commenter images are disabled. 
svn path=/plone.app.discussion/trunk/; revision=46037
 2010-11-30 07:33:22 +00:00
Timo Stollenwerk
0c94707743 Dynamically show the comment formatting message dependent on the text transform setting. 
svn path=/plone.app.discussion/trunk/; revision=46035
 2010-11-29 22:42:20 +00:00
Timo Stollenwerk
ea2ff81b43 Description for text transform added to the discussion control panel. 
svn path=/plone.app.discussion/trunk/; revision=46027
 2010-11-29 18:54:29 +00:00
Timo Stollenwerk
9dd33c47d0 Move the discussion control panel to the core Plone configuration. 
svn path=/plone.app.discussion/trunk/; revision=46020
 2010-11-29 17:40:37 +00:00
Timo Stollenwerk
f0cecaf274 Always set the effective date of a comment to the same value as the creation date. 
svn path=/plone.app.discussion/trunk/; revision=46019
 2010-11-29 17:36:52 +00:00
Timo Stollenwerk
b26d5a5a62 Fix SMTP exception when an email is send to the moderator. 
svn path=/plone.app.discussion/trunk/; revision=46013
 2010-11-29 08:27:09 +00:00
Timo Stollenwerk
3b31ac1602 Always import ObjectCreatedEvent from zope.lifecycleevent. 
svn path=/plone.app.discussion/trunk/; revision=46006
 2010-11-28 12:01:27 +00:00
Timo Stollenwerk
ac4a64f55d Make sure comment UIDs in the catalog are always unique. This fixes 
http://dev.plone.org/plone/ticket/10652. We depend on plone.uuid and plone.app.uuid now. Refs #10652.

svn path=/plone.app.discussion/trunk/; revision=46005
 2010-11-28 11:39:19 +00:00
Timo Stollenwerk
b08d7ddbeb revert r46002. 
svn path=/plone.app.discussion/trunk/; revision=46003
 2010-11-28 10:00:31 +00:00
Timo Stollenwerk
7e39197114 hudson buildout added. 
svn path=/plone.app.discussion/trunk/; revision=46002
 2010-11-28 09:51:35 +00:00
David Glick
4c31afeac2 fix comparison of string to integer which broke 'check all' 
svn path=/plone.app.discussion/trunk/; revision=45926
 2010-11-23 18:53:38 +00:00
Timo Stollenwerk
7dbcc9e2be Use safe_unicode to decode the title of the content. encode("utf-9") caused Dexterity based content types to raise a unicode decode error. This fixes http://dev.plone.org/plone/ticket/11292. Refs #11292 
svn path=/plone.app.discussion/trunk/; revision=45915
 2010-11-23 14:03:47 +00:00
Israel Saeta Pérez
6f698551ce Update Spanish localization. 
svn path=/plone.app.discussion/trunk/; revision=45880
 2010-11-19 11:01:05 +00:00
Victor Fernandez de Alba
289f876244 Corrected typo in catalan translation 
svn path=/plone.app.discussion/trunk/; revision=45852
 2010-11-17 14:50:43 +00:00
Victor Fernandez de Alba
48d225e97e Catalan translations 
svn path=/plone.app.discussion/trunk/; revision=45851
 2010-11-17 14:26:15 +00:00
Luca Fabbri
7083607d63 update italian translation 
svn path=/plone.app.discussion/trunk/; revision=45811
 2010-11-15 16:02:11 +00:00
Yiorgis Gozadinos
ab00fa3d99 Make the creator indexer return utf-8 to the catalog. 
svn path=/plone.app.discussion/trunk/; revision=45735
 2010-11-10 10:06:20 +00:00
Timo Stollenwerk
d358a31c74 Comments viewlet test for posting anonymous comments added. 
svn path=/plone.app.discussion/trunk/; revision=45663
 2010-11-08 17:10:19 +00:00
Timo Stollenwerk
5b788d1156 Merge 'Convert anonymous-supplied name to unicode as done for authenticated members.' from jarn-unicode branch. 
svn path=/plone.app.discussion/trunk/; revision=45662
 2010-11-08 17:09:26 +00:00
Anton Stonor
91a488931d staring Danish translation 
svn path=/plone.app.discussion/trunk/; revision=45615
 2010-11-07 22:02:08 +00:00
Radim Novotny
469da01f11 typo in Czech translation 
svn path=/plone.app.discussion/trunk/; revision=45607
 2010-11-07 18:52:12 +00:00
Timo Stollenwerk
cbd2edf932 Catch SMTP exceptions when sending email notifications. 
svn path=/plone.app.discussion/trunk/; revision=45199
 2010-11-04 15:56:12 +00:00
Timo Stollenwerk
501cee78e2 ".comment" and ".replyTreeLevel0" are both CSS classes of the comment div. Fix for Plone 3 only. 
svn path=/plone.app.discussion/trunk/; revision=45189
 2010-11-04 14:50:30 +00:00
Timo Stollenwerk
823ada7491 Remove AJAX comment deletion binding. This function relies on the nextUntil() selector introduced by jQuery 1.4 and therefore breaks in Plone 3 (that currently uses jQuery 1.3.2). 
svn path=/plone.app.discussion/trunk/; revision=45188
 2010-11-04 14:42:32 +00:00
Timo Stollenwerk
b68da9925b Use parseInt with second param to make jslint happy. 
svn path=/plone.app.discussion/trunk/; revision=45187
 2010-11-04 14:37:18 +00:00
Radim Novotny
b3ec7d61f5 Updated Czech translation :) 
svn path=/plone.app.discussion/trunk/; revision=45126
 2010-11-03 13:52:16 +00:00
Timo Stollenwerk
3d2f01b440 Translations updated. 
svn path=/plone.app.discussion/trunk/; revision=45125
 2010-11-03 13:45:00 +00:00
Timo Stollenwerk
25a82538b4 Fix Czech language code and name. 
svn path=/plone.app.discussion/trunk/; revision=45124
 2010-11-03 13:42:20 +00:00
Timo Stollenwerk
7f98b94031 Fix Dutch language code and name. 
svn path=/plone.app.discussion/trunk/; revision=45123
 2010-11-03 13:40:48 +00:00
Timo Stollenwerk
b95707ac52 Re-add the CommentsViewlet can_manage method. This method has been removed in version 1.0b9 and added again in 1.0b11 because we don't want to change the API in beta releases. 
svn path=/plone.app.discussion/trunk/; revision=45110
 2010-11-03 11:26:18 +00:00
Timo Stollenwerk
8e8e78c2d9 Fix language code and name in the Basque .po file. 
svn path=/plone.app.discussion/trunk/; revision=45082
 2010-11-02 11:34:52 +00:00
Israel Saeta Pérez
1b02b799c6 Add and update es and eu l10ns. 
svn path=/plone.app.discussion/trunk/; revision=45063
 2010-11-02 09:05:22 +00:00
Timo Stollenwerk
a39ac82858 There is no need to set the comment title in the tests, since comments do not have title fields anymore. 
svn path=/plone.app.discussion/trunk/; revision=44738
 2010-10-31 11:09:32 +00:00
Timo Stollenwerk
feec103b56 Fix user email notification test for Plone 3. 
svn path=/plone.app.discussion/trunk/; revision=44737
 2010-10-31 10:48:45 +00:00
Timo Stollenwerk
fa6e380eaf Use secureSend for user email notification on Plone 3 
svn path=/plone.app.discussion/trunk/; revision=44736
 2010-10-31 10:34:58 +00:00
Timo Stollenwerk
c8cd370fc9 Use len(tuple()) instead of tuple() to make tests pass again. 
svn path=/plone.app.discussion/trunk/; revision=44706
 2010-10-30 19:26:51 +00:00
Timo Stollenwerk
093eaa393a Use tuple() to test for generators. Thanks to otacon! 
svn path=/plone.app.discussion/trunk/; revision=42096
 2010-10-30 18:58:20 +00:00
Timo Stollenwerk
cc96acb50a Ajaxify comment deletion and approval. thanks thomasdesvenain! 
svn path=/plone.app.discussion/trunk/; revision=40984
 2010-10-30 17:32:31 +00:00
Timo Stollenwerk
82afd3ef15 New feature: As a logged-in user, I can enable/disable email notification of additional comments on this content object. 
svn path=/plone.app.discussion/trunk/; revision=40949
 2010-10-30 15:02:05 +00:00
Timo Stollenwerk
5fe339215b Use the jstestdriver coverage plugin. 
svn path=/plone.app.discussion/trunk/; revision=40909
 2010-10-30 11:24:03 +00:00
Timo Stollenwerk
380b81bd3e Disable the moderation qunit tests for now because they are currently failing. 
svn path=/plone.app.discussion/trunk/; revision=40907
 2010-10-30 11:12:04 +00:00
Timo Stollenwerk
0820d3771f Basic js-test-driver configuration added. 
svn path=/plone.app.discussion/trunk/; revision=40892
 2010-10-30 10:22:21 +00:00
Timo Stollenwerk
81dcdeaea3 Disable the plone.app.registry check on schema elements, so no error is raised on upgrades. This fixes https://dev.plone.org/plone/ticket/11195. Refs #11195 
svn path=/plone.app.discussion/trunk/; revision=40868
 2010-10-29 10:43:46 +00:00
Timo Stollenwerk
f6b7ef1bcb Remove the too generic id attribute of the comment form. 
svn path=/plone.app.discussion/trunk/; revision=40858
 2010-10-28 10:30:10 +00:00
Timo Stollenwerk
777e687169 Rename the id of the comment form from "form" to "comment-form". 
svn path=/plone.app.discussion/trunk/; revision=40857
 2010-10-28 09:45:34 +00:00
Timo Stollenwerk
22e4189c37 Revert revisions r40851 to r40853, they should have gone into the ajax-ui branch. 
svn path=/plone.app.discussion/trunk/; revision=40856
 2010-10-28 09:39:00 +00:00
Timo Stollenwerk
14e2600a79 Make ajax call for delete comment button work for comment replies. 
svn path=/plone.app.discussion/trunk/; revision=40853
 2010-10-27 16:10:04 +00:00
Timo Stollenwerk
926e4f6b8e Integrate Denys ajax ui code. 
svn path=/plone.app.discussion/trunk/; revision=40852
 2010-10-27 14:44:52 +00:00
Timo Stollenwerk
79f4481722 Use "#comment-form" as id for the comment form instead of "#form" which is too generic. 
svn path=/plone.app.discussion/trunk/; revision=40851
 2010-10-27 14:44:06 +00:00
Hanno Schlichting
aa8a1ea934 Fixed handling of non-ascii member data, like fullname and email. 
svn path=/plone.app.discussion/trunk/; revision=40789
 2010-10-22 10:14:07 +00:00
Hanno Schlichting
54bbb08c62 Whitespace removal 
svn path=/plone.app.discussion/trunk/; revision=40788
 2010-10-22 09:57:55 +00:00
Andreas Jung
8fc3dda8e6 wrong language-code 
svn path=/plone.app.discussion/trunk/; revision=40586
 2010-10-11 09:37:28 +00:00
Radim Novotny
18e92f7a85 - Fixed "global name 'WrongCaptchaCode' is not defined" if norobots captcha, 
but no other validation package is installed.

svn path=/plone.app.discussion/trunk/; revision=40574
 2010-10-09 11:13:28 +00:00
Timo Stollenwerk
f7ed357a83 Use 'comment_review_workflow' instead of 'simple_publication_workflow' for testing. 
svn path=/plone.app.discussion/trunk/; revision=40571
 2010-10-08 11:03:14 +00:00
Timo Stollenwerk
324d2274bd Check for a 'pending' state in the current comment workflow instead of checking for the 'comment_review' workflow. Refs #11184. Merge last three submits in CHANGES.txt. 
svn path=/plone.app.discussion/trunk/; revision=40570
 2010-10-08 10:37:10 +00:00
Timo Stollenwerk
6e9bb4a9cd Check the review_state to decide if moderation is enabled. If the current comment workflow implements a 'pending' state, moderation is enabled. Refs #11184. 
svn path=/plone.app.discussion/trunk/; revision=40569
 2010-10-08 10:22:40 +00:00
Timo Stollenwerk
2790e6d4eb Check the review_state instead of the workflow after a comment has been posted to decide if a message is shown to the user. This allows integrators to use custom review workflows. Refs #11184 
svn path=/plone.app.discussion/trunk/; revision=40566
 2010-10-08 09:53:00 +00:00
Timo Stollenwerk
43d3222086 Run functional tests only with Plone 4 (and plone.testing). 
svn path=/plone.app.discussion/trunk/; revision=40537
 2010-10-06 15:12:11 +00:00
Timo Stollenwerk
94584429fd Do not use has_key. 
svn path=/plone.app.discussion/trunk/; revision=40536
 2010-10-06 14:12:30 +00:00
Timo Stollenwerk
4bbfe677e4 Replace the can_manage method with a can_review method that checks the 'Review comments' permission. This fixes http://dev.plone.org/plone/ticket/11145. 
svn path=/plone.app.discussion/trunk/; revision=40534
 2010-10-06 13:55:57 +00:00
Timo Stollenwerk
3e73903a8d Remove (old) functional test. 
svn path=/plone.app.discussion/trunk/; revision=40533
 2010-10-06 13:53:07 +00:00
Timo Stollenwerk
1230e67a01 Functional test for comment_review_workflow added; existing fonctional test renamed to functional_test_comments.txt; 
svn path=/plone.app.discussion/trunk/; revision=40532
 2010-10-06 13:52:11 +00:00
Timo Stollenwerk
1db321a044 Make pylint happy. 
svn path=/plone.app.discussion/trunk/; revision=40527
 2010-10-06 09:02:26 +00:00
Timo Stollenwerk
f9ca4497bd Obey the 80 chars limit. 
svn path=/plone.app.discussion/trunk/; revision=40526
 2010-10-06 08:47:24 +00:00
Timo Stollenwerk
94b0c58511 Fix pylint disable-msg statements. 
svn path=/plone.app.discussion/trunk/; revision=40521
 2010-10-05 15:54:49 +00:00
Timo Stollenwerk
fbb042c012 Remove unused import. 
svn path=/plone.app.discussion/trunk/; revision=40520
 2010-10-05 15:52:19 +00:00
Timo Stollenwerk
773345c40f Make pylint happy. 
svn path=/plone.app.discussion/trunk/; revision=40519
 2010-10-05 15:47:02 +00:00
Timo Stollenwerk
7de585542b Fix moderation actions (publish, delete) in the moderation view with virtual hosts. This is a replacement for http://dev.plone.org/plone/changeset/35608. 
svn path=/plone.app.discussion/trunk/; revision=40518
 2010-10-05 15:21:54 +00:00
Timo Stollenwerk
b984a445d5 Inline documentation for moderation view added. 
svn path=/plone.app.discussion/trunk/; revision=40517
 2010-10-05 15:14:12 +00:00
Timo Stollenwerk
7e42a39346 Remove .mo file from subversion. 
svn path=/plone.app.discussion/trunk/; revision=40516
 2010-10-05 14:07:39 +00:00
Timo Stollenwerk
837e6b2966 Do not show two "login to add comments" buttons when there are no comments yet. This fixes http://plone.org/products/plone.app.discussion/issues/12. 
svn path=/plone.app.discussion/trunk/; revision=40515
 2010-10-05 12:07:08 +00:00
Timo Stollenwerk
51642c2e0f German translations updated. 
svn path=/plone.app.discussion/trunk/; revision=40506
 2010-10-04 18:59:42 +00:00
Timo Stollenwerk
9841ba7229 Remove unnecessary decode statement from creator. 
svn path=/plone.app.discussion/trunk/; revision=40503
 2010-10-04 13:48:54 +00:00
Timo Stollenwerk
0ee649fb6c Functional test for special characters added. Remove unnecessary decode statement from creator. 
svn path=/plone.app.discussion/trunk/; revision=40502
 2010-10-04 13:48:27 +00:00
Timo Stollenwerk
b06ba43a75 Ignore currently unused code from code coverage. Overall code coverage is up to 95%. 
svn path=/plone.app.discussion/trunk/; revision=40497
 2010-10-03 19:54:59 +00:00
Timo Stollenwerk
6d92d1383c Remove comment title from comments viewlet tests. 
svn path=/plone.app.discussion/trunk/; revision=40496
 2010-10-03 19:41:02 +00:00
Timo Stollenwerk
ede295e649 Functional test for posting a comment with comment review workflow enabled. 
svn path=/plone.app.discussion/trunk/; revision=40495
 2010-10-03 19:07:30 +00:00
Timo Stollenwerk
603bcf3547 Ignore certain lines for code coverage. 
svn path=/plone.app.discussion/trunk/; revision=40494
 2010-10-03 16:52:26 +00:00
Timo Stollenwerk
f5cf756e31 Functional test for replying to an existing comment added. 
svn path=/plone.app.discussion/trunk/; revision=40493
 2010-10-03 16:50:47 +00:00
Timo Stollenwerk
497c2a075e There is no need to set the title in the handleComment method anymore. 
svn path=/plone.app.discussion/trunk/; revision=40492
 2010-10-03 07:29:44 +00:00
Timo Stollenwerk
e0055d0ba7 Make sure comment titles work with special characters as well. 
svn path=/plone.app.discussion/trunk/; revision=40486
 2010-10-02 18:16:49 +00:00
Timo Stollenwerk
51d6c60412 Use the right event subscriber to make sure all comments are removed from the catalog, if their content object is deleted. 
svn path=/plone.app.discussion/trunk/; revision=40485
 2010-10-02 14:50:17 +00:00
Luca Fabbri
1edbf3a262 italian translation updated 
svn path=/plone.app.discussion/trunk/; revision=40461
 2010-09-30 22:00:24 +00:00
Luca Fabbri
2d603c2c0e italian translation updated 
svn path=/plone.app.discussion/trunk/; revision=40460
 2010-09-30 21:52:40 +00:00
Timo Stollenwerk
0e27b8b7b6 Move regression test for #11157 into the main functional test. 
svn path=/plone.app.discussion/trunk/; revision=40458
 2010-09-30 17:45:26 +00:00
Timo Stollenwerk
22db0b1c78 Fix comment title for anonymous commentators that do not provide a name. 
svn path=/plone.app.discussion/trunk/; revision=40435
 2010-09-29 10:52:11 +00:00
Timo Stollenwerk
2cce7e0d0f "Post comment as logged-in users" test added. 
svn path=/plone.app.discussion/trunk/; revision=40434
 2010-09-29 10:17:25 +00:00
Timo Stollenwerk
689fd26c12 Apply the comment viewlet template and styles to the new title-less comments. This might require integrators to apply their custom templates and styles. 
svn path=/plone.app.discussion/trunk/; revision=40433
 2010-09-29 08:13:54 +00:00
Timo Stollenwerk
8d00463502 Remove subject line from comment batch moderation view, since this doesn't make sense anymore with auto-generated titles. 
svn path=/plone.app.discussion/trunk/; revision=40432
 2010-09-29 08:02:39 +00:00
Timo Stollenwerk
f67c7cde6d Remove title field from the comment form and replace it with an auto-generated title ("John Doe on Welcome to Plone"). 
This also fixes http://dev.plone.org/plone/ticket/11098

svn path=/plone.app.discussion/trunk/; revision=40431
 2010-09-29 07:56:36 +00:00
Timo Stollenwerk
7df932204c Functional plone.testing doctest added. 
svn path=/plone.app.discussion/trunk/; revision=40393
 2010-09-28 16:35:45 +00:00
Timo Stollenwerk
138942470c Make sure the __parent__ pointer (the conversation) of a comment is not acquisition wrapped in conversation.addComment. This fixes Refs #11157. 
svn path=/plone.app.discussion/trunk/; revision=40374
 2010-09-28 10:37:40 +00:00
Timo Stollenwerk
a55ff5b883 Fix pickle regression test. 
svn path=/plone.app.discussion/trunk/; revision=40373
 2010-09-28 10:18:16 +00:00
Timo Stollenwerk
77e44f96ad Added test (currently failing) to trigger "can't pickle objects in acquisition wrapper". Refs #11157 
svn path=/plone.app.discussion/trunk/; revision=40357
 2010-09-27 19:03:43 +00:00
Timo Stollenwerk
58868c55e7 whitespace. 
svn path=/plone.app.discussion/trunk/; revision=40232
 2010-09-24 19:45:57 +00:00
Timo Stollenwerk
e95ae26a11 Fix moderation test headline. 
svn path=/plone.app.discussion/trunk/; revision=40229
 2010-09-24 19:04:35 +00:00
Timo Stollenwerk
cf11a5134a Javascript tests for the bulk moderation view added (currently failing). 
svn path=/plone.app.discussion/trunk/; revision=40228
 2010-09-24 19:04:03 +00:00
Timo Stollenwerk
ad99e45203 Revert r35608 since this was breaking the comment moderation bulk actions. The BulkActionsView expects the absolute path of the comments without the portal url (e.g. '/plone/doc1/++conversation++default/1285346769126020'). This fixes https://dev.plone.org/plone/ticket/11156. 
svn path=/plone.app.discussion/trunk/; revision=40227
 2010-09-24 17:04:24 +00:00
Timo Stollenwerk
2ff95fe847 Make sure the moderation JS functions are executed after the page is fully loaded. 
svn path=/plone.app.discussion/trunk/; revision=40215
 2010-09-24 14:57:19 +00:00
Timo Stollenwerk
399bba5eca Use "(function($) { /* some code that uses $ */ })(jQuery)" instead of "$(document).ready(function(){ /* some code that uses $ */ });" to invoke jQuery code. 
svn path=/plone.app.discussion/trunk/; revision=40214
 2010-09-24 14:21:26 +00:00
Timo Stollenwerk
57758d2cf8 More workflow tests. 
svn path=/plone.app.discussion/trunk/; revision=40203
 2010-09-24 13:33:21 +00:00
Timo Stollenwerk
ea26c70eed Clean up whitespace, change workflow description. 
svn path=/plone.app.discussion/trunk/; revision=40192
 2010-09-24 03:12:12 +00:00
Timo Stollenwerk
41c9d030d8 Clean up whitespace, change workflow description. 
svn path=/plone.app.discussion/trunk/; revision=40191
 2010-09-24 03:11:39 +00:00
Timo Stollenwerk
d77ca9d583 Commenting form explanation added. 
svn path=/plone.app.discussion/trunk/; revision=40167
 2010-09-23 14:46:24 +00:00
Timo Stollenwerk
c364630a8c js test for comments updated. 
svn path=/plone.app.discussion/trunk/; revision=40166
 2010-09-23 14:42:18 +00:00
Timo Stollenwerk
9d0fa61c4d Remove unnecessary XXX since we already use layers. 
svn path=/plone.app.discussion/trunk/; revision=40165
 2010-09-23 12:56:17 +00:00
Timo Stollenwerk
f1cf4c9688 Translation files updated. 
svn path=/plone.app.discussion/trunk/; revision=40154
 2010-09-23 11:06:38 +00:00