Commit Graph

1189 Commits

Author SHA1 Message Date
Jens W. Klein 6609ab6af5 make flake8 happy 2014-03-25 18:38:12 +01:00
Jens W. Klein a145413ac2 make flake8 happy 2014-03-25 18:37:06 +01:00
Jens W. Klein 67213b70eb make flake8 happy 2014-03-25 18:36:14 +01:00
tisto 01641b4957 Merge branch 'fix_reindex_on_publish' of git://github.com/RedTurtle/plone.app.discussion into RedTurtle-fix_reindex_on_publish 2014-03-24 20:49:32 +01:00
tisto 9c9c2e2aaa Merge branch 'master' of git://github.com/huubbouma/plone.app.discussion into huubbouma-master
Conflicts:
	CHANGES.rst
2014-03-23 18:54:44 +01:00
maartenkling 0ea9a7131f merge upstream and fix numbering 2014-03-04 09:16:36 +01:00
Philip Bauer d788d07a87 fix test. the richtext-field in plone.app.contenttypes uses a behavior 2014-02-14 09:40:55 +01:00
Kees Hink 6ae623c39d Remove DL's from portal message in templates. 2014-02-11 09:42:42 +01:00
Kees Hink cc02ed01ad Remove DL's from portal message in templates. 2014-02-11 09:38:54 +01:00
Ovidiu Miron 6bc5db4276 Fixed typo error 2014-02-04 11:46:29 +02:00
Ovidiu Miron a9d0cb574b Execute the property workflow 2014-02-04 11:15:31 +02:00
maartenkling 8ccd648928 user member.getId as author_username, so membrane users and plone users have portraits and author urls 2014-02-02 14:55:37 +01:00
Timo Stollenwerk a8dc5dd3f0 Remove test_suite functions since they are only needed for zope.testing < 3.8.0. 2013-12-19 09:54:03 +01:00
tisto a2ae2a888f Remov qunit and jstestdriver test setup. 2013-12-15 12:56:51 +01:00
tisto f0a9d9ad6b Pep8 2013-12-15 12:02:32 +01:00
Timo Stollenwerk a2552acd2b Merge pull request #36 from aputtu/patch-1
Corrections and additions to the Danish translation
2013-11-26 10:27:52 -08:00
Alan Hoey 8161dc14da Fixing test failures. 2013-11-25 12:54:49 +00:00
Alan Hoey e6ec6ebe16 Add tests to confirm that some methods of a conversation incorrectly use an unwrapped comment to determine whether anonymous users can view. 2013-11-25 12:52:31 +00:00
Alan Hoey 4804868ab2 Refactor acquisition tests to define the expected behaviour when dealing with wrapped and unwrapped comments. 2013-11-25 12:06:05 +00:00
Alan Hoey 4be4c03c49 Fix total comments index 2013-11-21 18:13:31 +00:00
vmaksymiv 8e56b99638 added test acquisition chain for unwrapped object
Conflicts:
	plone/app/discussion/tests/test_acquisition.py
2013-11-21 17:23:36 +00:00
Kees Hink 5fb6968fca Add a test for Acquisition in comments. 2013-11-21 17:22:12 +00:00
Roman Kozlovskyi f1747c7a87 Updated ukrainian translations 2013-11-17 21:10:02 +02:00
David Glick 7cfbd20d72 don't fail test if portal_atct is missing 2013-11-15 00:11:13 -08:00
Timo Stollenwerk 654869a30d Remove old topic test. New collections are tested in p.a.contenttypes anyways. 2013-11-14 11:01:14 +01:00
Mikel Larreategi 4fdd1f7467 update basque translation 2013-11-14 09:13:20 +01:00
Mikel Larreategi ceae98cd19 update basque translation 2013-11-14 09:12:38 +01:00
Mikel Larreategi 2f781fe6e9 update basque translation 2013-11-14 09:12:31 +01:00
Benoît Suttor c3ce01edd0 Use defaultUser.png instead of defaultUser.gif
Indeed, defaultUser.gif is in a deprecated skins folder (Products/CMFPlone/
skins/plone_deprecated/defaultUser.gif) and not defaultUser.png
(Products/CMFPlone/skins/plone_images/defaultUser.png).
Test is also updated.
2013-11-13 15:53:12 +01:00
maartenkling c45650261e Rename @@discussion-settings to @@discussion-controlpanel 2013-11-12 10:45:59 +01:00
JeanMichel FRANCOIS 410b8c998a Fix ownership of comments. 2013-11-05 10:23:15 +01:00
aputtu 00861f5f9c Corrections and additions to the Danish translation 2013-10-22 20:22:05 +02:00
David Glick dcba2c2714 re-add ICommentingTool to support migration 2013-10-18 21:40:50 -07:00
tisto d225cbfc9a Remove bbb directory. 2013-10-16 19:20:15 +02:00
tisto e7cae8430a Replace deprecated test assert statements. 2013-10-10 16:29:15 +02:00
tisto fbc78e2951 Remove portal_discussion tool. 2013-10-10 15:36:18 +02:00
tisto 08c3db59e1 Portuguese translation added. 2013-09-24 14:21:45 +02:00
Huub Bouma fd85de9c30 Fix comments Title if utf-8 characters in author_name 2013-09-20 16:28:05 +02:00
Timo Stollenwerk 9049368cba Refactor tests to use the PLONE_APP_CONTENTTYPES_FIXTURE instead of the PLONE_FIXTURE. This fixes all test p.a.discussion test failures. 2013-08-29 22:20:47 +02:00
Jens W. Klein 645bbb0a95 typo: renamed 'annotions' to 'annotations' 2013-08-26 14:49:26 +02:00
JeanMichel FRANCOIS 34bbd39829 fix: add form serialized data to the delete comment ajax form submit
Even if in fresh Plone there is no data, I'm in a case where I'm adding
'ajax' marker in the form to not render all the page (which is the case
here) and the render is not used at all except if the action do not
happens in ajax.
2013-08-21 11:07:48 +02:00
Andrea Cecchi bde1a1a44a fix reindexObject for comment container object 2013-08-20 15:37:56 +02:00
Andreas Zeidler b027789391 prevent the viewlet from raising an error for objects that are not annotatable 2013-08-15 00:01:22 +02:00
Paul J Stevens 52c6372664 fix deprecation warning 2013-06-04 13:23:22 +00:00
Paul J Stevens 1946991928 fix regression
introduced by 702f7e1f1d
2013-06-04 13:19:41 +00:00
Thomas Desvenain f90c1531bc Update french translation 2013-05-23 09:35:41 +02:00
Jan Ulrich Hasecke a03409a2cb Update plone.app.discussion.po
Some translations
2013-05-22 19:03:00 +02:00
Kees Hink fd9d0a0eba Revert "Add a test for permission Acquisition on comments."
This reverts commit 66d355544f.
2013-05-10 13:39:02 +02:00
Kees Hink 6d5c193d8c Revert "Move application of custom workflow to test_acquisition.py..."
This reverts commit 6e9b32254e.
2013-05-10 13:38:46 +02:00
Kees Hink 6e9b32254e Move application of custom workflow to test_acquisition.py...
...so it doesn't interfere with other test in the layer.
2013-05-10 13:26:30 +02:00
Kees Hink 66d355544f Add a test for permission Acquisition on comments.
We use a different workflow for comments:
The View permission is acquired instead of given explicitly,
as outlined in https://dev.plone.org/ticket/12531.
2013-05-10 13:18:58 +02:00
Timo Stollenwerk e2a43aefb6 Remove testbrowser dump. 2013-04-22 14:55:04 +02:00
Timo Stollenwerk 73d84a22d7 Pep8. 2013-04-18 16:12:00 +02:00
Timo Stollenwerk 607719fd42 Pep8. 2013-04-18 15:57:01 +02:00
Timo Stollenwerk b151244138 Pep8. 2013-04-18 15:51:57 +02:00
Timo Stollenwerk 0a8cd01922 Pep8 2013-04-18 15:46:28 +02:00
Timo Stollenwerk 37faab444a Pep8. 2013-04-18 15:38:17 +02:00
Timo Stollenwerk 0b8112fda1 Pep8. 2013-04-18 15:31:40 +02:00
Timo Stollenwerk 849299f233 Pep8. 2013-04-18 15:21:00 +02:00
Timo Stollenwerk 20935da608 Pep8. 2013-04-17 19:37:10 +02:00
Timo Stollenwerk 29fe4bbec7 Pep8. 2013-04-17 19:34:17 +02:00
Timo Stollenwerk b4c22e90bf Pep8. 2013-04-17 19:27:30 +02:00
Timo Stollenwerk 943065c15f Pep8. 2013-04-17 19:07:40 +02:00
Timo Stollenwerk dcb2d3e7d4 Pep8 2013-04-17 19:04:45 +02:00
Timo Stollenwerk 65ade424d8 Pep8. 2013-04-17 14:55:50 +02:00
Timo Stollenwerk aa61364342 Merge pull request #25 from datakurre/master
Fix migration to not fail when member has been deleted
2013-04-17 05:52:17 -07:00
Timo Stollenwerk 628f72ea0b Pep8. 2013-04-17 14:24:39 +02:00
Timo Stollenwerk 1e95e33573 Pep8 2013-04-13 22:47:30 +02:00
Roman Kozlovskyi 803d6c7fbb Updated ukrainian translations 2013-04-12 15:11:29 +03:00
Asko Soukka 4165a74180 Fix migration to not fail when member has been deleted 2013-04-10 10:28:46 +03:00
Felipe Duardo 7f16b55493 return to last commit... 2013-04-09 13:55:21 -03:00
Felipe Duardo 79a96a8c1e Added a prefix to the id attr of the comment field
The W3C validator does not accept the attributes id or class started with numbers.
2013-04-09 12:21:14 -03:00
Érico Andrei d77ecc31f3 Update pt_BR translation 2013-04-06 09:57:13 -03:00
Érico Andrei e6deebf9b5 Sync translations 2013-04-06 09:56:53 -03:00
Érico Andrei 1bbaace2fd Sync translations 2013-04-06 09:48:44 -03:00
Patrick Gerken 05f0e7e4d8 Many updates to handle non public comments properly 2013-03-28 14:28:22 +01:00
Timo Stollenwerk 0c6b873bef Do not raise an error when no workflow is assigned to the comment type. 2013-03-27 17:06:14 +01:00
Timo Stollenwerk 317bbca6d8 Whitespace. 2013-03-27 16:58:35 +01:00
bdbaddog 6f675b6f80 Merge pull request #23 from bdbaddog/fix_comment_user_migration
fix migration of author_name and author_username
2013-02-11 10:20:41 -08:00
Roman Kozlovskyi 948d7d4956 Updated Ukrainian translation 2013-02-04 13:39:17 +02:00
ichim-david e2d8543020 Cherry-picked 7a48d5 and 10f031 from 2.1.x branch to master 2013-02-03 22:07:51 +02:00
ichim-david 321f725bda Added Romanian translation 2013-02-03 18:11:00 +02:00
Timo Stollenwerk a6afdf265c Pep8 2013-01-10 18:40:04 +01:00
Timo Stollenwerk 69b628c386 Pep8. 2013-01-10 18:33:46 +01:00
JeanMichel FRANCOIS 0e72ce12a6 remove upgrade step from here. all upgrade step of plone goes to plone.app.upgrades 2013-01-08 10:31:16 +01:00
JeanMichel FRANCOIS a16958c1c7 add anonymous_email_enabled settings to really let integrator activate it. add the migration script which add the option to the registry and do not change the behavior: the email will not be displayed by default 2013-01-04 19:00:24 +01:00
William Deegan 68d195375e use member.getProperty('fullname') if member.fullname is an empty string. Not sure in what case this would happen, but it did happen in my site migration 2012-12-15 16:47:01 -08:00
William Deegan 372b573cb1 move creation of test user to test setup, rather than just in the new test_migrate_comment_with_creator() method 2012-12-15 16:45:56 -08:00
William Deegan ff1f65a75e simplify some of the logic and get some tests in place to cover them. TDB: test against actual site to ensure the changes to the logic don't break a real environment, but still work with the tests.. 2012-12-13 21:14:40 -08:00
William Deegan 485571325f fix migration of author_name and author_username 2012-11-27 21:32:07 -08:00
maartenkling 412cfed5c5 first check if captcha is installed before we open browsers zcml files that depend on these packages, fixes #12118 and #12774 2012-11-26 14:50:07 +01:00
Kees Hink e57d3a2ad4 Convert test for invalid comment id in url to integration test. 2012-11-16 10:29:50 +01:00
Kees Hink 6bd31ad490 Make conversation view not break when comment-id cannot be converted to long, fixes #13327 2012-11-14 13:25:10 +01:00
maartenkling 3f82467828 add missing declaration 2012-11-13 09:45:17 +01:00
maartenkling 1c25c5c10a add permissions to type, fixes #11497 2012-11-13 09:40:32 +01:00
maartenkling c6af5ee670 Merge remote-tracking branch 'upstream/master' 2012-11-13 09:37:14 +01:00
Timo Stollenwerk e008bcf54d Whitespace. 2012-11-04 17:25:25 +01:00
Timo Stollenwerk 41a53fc8ff Fix failing test. 2012-11-04 17:18:46 +01:00
maartenkling f1aaa0d752 The border attribute is obsolete. Consider specifying img { border: 0; } in CSS instead. 2012-11-01 08:31:02 +01:00
Johannes Raggam 882236cb15 For migrations of comments without a valid old_status, apply the 'published'
state.
2012-10-31 22:46:10 +01:00
Johannes Raggam d2ccec6efe Re-apply eleddy's 'Revert modification date since this is fixed in
p.a.caching now.' as her commit was lost later on due to some git magic.
2012-10-31 22:26:51 +01:00
Johannes Raggam dae55074cd really set the modification date 2012-10-31 22:15:20 +01:00
maartenkling 62b0b47b56 remove the submitting completly, the form is submitted fine without and this fixes both #13037 and #12357 2012-10-26 11:12:44 +02:00
maartenkling cb14c4f89e change how to submit the form to stop ff to hang, this fixes #13037 2012-10-25 21:46:57 +02:00
maartenkling 96d72e7e29 fix #11324, add fallback border color for ie8 and browser that not support boxshadows 2012-10-22 10:04:35 +02:00
maartenkling 66898bb87a remove inline styles, this also fixes #12399 2012-10-22 09:58:40 +02:00
Timo Stollenwerk 07140cd136 Merge pull request #13 from l34marr/master
zh-tw PO updated
2012-10-19 06:02:26 -07:00
Thomas Clement Mogensen 481690ac09 update danish translation 2012-10-19 14:35:53 +02:00
Thijs Jonkman 1fb71d5f17 Unified the site setup html structure
Change to unify the site setup html structure
=============================================
- Check for structure:

  #portal-column-content
    #content
      .setup-link
      .documentFirstHeading
      .documentDescription
      #content-core

- Check for body template- class

Related changes
---------------
Templates have also changed in:
  plone.app.contentrules
  plone.app.controlpanel
  plone.app.discussion
  plone.app.registry
  plone.app.users
  Products.CMFPlone

Styles have been updated in plonetheme.sunburst
2012-10-14 17:00:13 +02:00
TsungWei Hu 37c6dfde0e zh-tw PO updated. 2012-10-09 21:03:24 +08:00
rnd0101 cdea1ce59d Update plone/app/discussion/browser/comments.pt
i18n for the Anonymous
2012-09-19 12:55:55 +03:00
Izak Burger cde250bf4c remove unused local variable. 2012-09-17 23:57:13 +02:00
Izak Burger 4d1e7b5806 don't ignore user_notification checkbox. 2012-09-17 23:51:15 +02:00
Gaudenz Steinlin 56b08b2247 Fix catalog updates for IObjectMovedEvent
If comments were moved because an object on a higher level than the
commented object was moved, these comments were wrongly reindexed.
The commented object also got a wrong __parent__ pointer.

This fixes https://dev.plone.org/ticket/13172.
2012-09-17 16:52:05 +02:00
Timo Stollenwerk 05c2c19c93 Replace discussionitem_icon.gif with png version. 2012-09-02 08:31:58 +02:00
Patrick Gerken 9146aa8025 Don't use reindexObject from catalog, but from the object
collective.indexing assumes that reindexObject from catalog is not
an official api method, therefor it does not patch it.
This results in missing updates if plone.app.discussion is used
together with solr, which uses collective.indexing
2012-08-22 18:00:27 +02:00
David Glick 58b4205f38 Revert "Attempt to fix test_format_time()."
This reverts commit c231794940.
2012-08-02 22:21:26 -07:00
David Glick 7fe9f062e8 Revert "Update master"
This reverts commit 53ec8e52ea.
2012-08-02 22:21:19 -07:00
Karl Johan Kleist 53ec8e52ea Update master 2012-07-18 06:58:17 +03:00
Karl Johan Kleist c231794940 Attempt to fix test_format_time(). 2012-07-18 06:56:14 +03:00
Timo Stollenwerk 528e1a1434 Run ConversationTest for dexterity types only if dexterity is installed. 2012-07-12 18:56:10 +02:00
Timo Stollenwerk 103c7323e7 Fix test that fails due to the creator/author_name changes. 2012-07-12 17:29:05 +02:00
Timo Stollenwerk a6a48a58dd Fix test that fails due to the css id changes due to comment text field. 2012-07-12 17:28:12 +02:00
Timo Stollenwerk c47689af42 Fix handling of comments with invalid transforms. Write an error msg to the log and just return the untransformed text. 2012-07-12 16:03:02 +02:00
Timo Stollenwerk 702f7e1f1d Make 'text/plain' the default mime type for comments and make sure the default type is set properly when creating a new comment. 2012-07-12 16:01:07 +02:00
Timo Stollenwerk f45373b311 Test for mime type transformation from html to html added. 2012-07-12 15:54:38 +02:00
Timo Stollenwerk eded7f1059 text/html added to possible mime types for comments. 2012-07-12 15:54:01 +02:00
Timo Stollenwerk ac9d4f9584 Rename the id of the text widgets because there can be css-id clashes with
the text field of documents when using TinyMCE in overlays or multiple
instances of TinyMCE on a single page.
2012-07-12 15:49:19 +02:00
Timo Stollenwerk 0535e659ff Refactor the comment creator/author_name to comply with the Plone core convention to store the username on the creator attribute and not the fullname. 2012-07-12 15:39:27 +02:00
Timo Stollenwerk 19a511f4e5 Merge pull request #7 from plone/hide-from-breadcrumb
Hide Conversation objects from breadcrumb navigation
2012-07-12 06:18:42 -07:00
Timo Stollenwerk f45a2e8bba Replace deprecated unit test methods. 2012-07-12 15:08:22 +02:00
tisto 65590732ea Move api documentation to a separate folder. 2012-07-12 15:03:26 +02:00
Timo Stollenwerk 7d34baf2d5 Prepare files for API documentation. 2012-07-12 14:56:03 +02:00
Timo Stollenwerk 4919b50edb Merge pull request #6 from stonor/master
Please pull this updated Danish translation
2012-07-12 03:44:10 -07:00
Timo Stollenwerk 19685db96b Merge pull request #9 from Goldmund-Wyldebeast-Wunderliebe/master
no more recursive came_from redirection after logged_in
2012-07-12 03:35:33 -07:00
Karl Johan Kleist 636e77e3b2 Reverting, as per Timo's comment in 49734cd39b (commitcomment-1559057).
So Jenkins is running the tests using the en-US locale?
2012-07-10 10:56:56 +03:00
Karl Johan Kleist 49734cd39b Fallback for localized time is now ISO style.
https://jenkins.plone.org/job/plone-4.3-tests/89/testReport/junit/plone.app.discussion.tests.test_comments_viewlet/TestCommentsViewlet/test_format_time/
2012-07-07 11:58:46 +03:00
Radim Novotny d86e19e717 Added empty translation files for Slovak language 2012-07-02 17:54:58 +02:00
Timo Stollenwerk 0e587a7d85 Support for Dexterity added. 2012-06-30 10:59:49 +02:00
Paul J Stevens 53428fe5f6 total_comments only counts published comments
Also migrate workflow state during migration.
2012-06-13 11:17:22 +00:00
Paul J Stevens e31f90c440 Prune duplicated test code 2012-06-12 14:44:42 +00:00
Gaudenz Steinlin ad5cca6454 Hide Conversation objects from breadcrumb navigation
The breadcrumbs navigation is also used in the search results view.
This lead to Conversation objects showing up if 'Discussion Items'
are searchable.
2012-05-29 13:40:31 +02:00
Gaudenz Steinlin a7b3c818f2 Delete own comments
Add permission to allow comment authors to delete their own comments if
there are no replies yet.
2012-05-29 13:33:46 +02:00
Gaudenz Steinlin 3eab51e1c4 Add Site Administrator role to Review comments permission 2012-05-29 13:26:05 +02:00
Gaudenz Steinlin 4e0bf9f25e Fix JS comment deletion
If the comment tree had just one top level comment the whole tree was
removed by the JS code if just one comment in the tree was deleted.
These comments were (correctly) not removed from the ZODB.
2012-05-29 13:26:05 +02:00
Anton Stonor cc2af905dc Updating Danish translation 2012-05-23 08:35:04 +02:00
Hanno Schlichting 1b0ba3c0b0 No longer depend on zope.app packages. 2012-05-18 18:19:12 -04:00
Takeshi Yamamoto 5f063d60ea fixed Kanji typo. 2012-05-15 20:54:56 +09:00
Huub Bouma c9848bebfe no more recursive came_from redirection after logged_in 2012-04-12 13:06:05 +02:00
Timo Stollenwerk f66d6e1c05 Make topic/collection tests pass when plone.app.collection is installed. 2012-04-02 22:00:27 +02:00