Commit Graph
100 Commits
Author SHA1 Message Date
Timo Stollenwerk abdab3c12e Use 1.0b6 KGS from good-py.
svn path=/plone.app.discussion/trunk/; revision=39677
2010-09-06 10:05:18 +00:00
Timo Stollenwerk 288732d276 Removed unused imports from test_comments_viewlet tests.
svn path=/plone.app.discussion/trunk/; revision=39632
2010-09-03 21:57:36 +00:00
Timo Stollenwerk 2fda1455d4 Remove zope.testing version pinning since it does not avoid the teardown failure in coverage-test.
svn path=/plone.app.discussion/trunk/; revision=39631
2010-09-03 21:50:12 +00:00
Timo Stollenwerk a4011ce414 Fix the comment view test.
svn path=/plone.app.discussion/trunk/; revision=39629
2010-09-03 21:23:44 +00:00
Timo Stollenwerk 34f1106748 Pylint: "E1121 Too many positional arguments for function call" added to ignore list; pinning zope.testing to 3.9.5 to avoid coverage-test failure.
svn path=/plone.app.discussion/trunk/; revision=39628
2010-09-03 21:01:22 +00:00
Timo Stollenwerk ea13020498 Raise an unauthorized error when authenticated users try to post a comment on a content object that has discussion disabled. Thanks to vincentfrentin for reporting this!
svn path=/plone.app.discussion/trunk/; revision=39627
2010-09-03 20:40:27 +00:00
Timo Stollenwerk a410c72333 Complete comments form integration test.
svn path=/plone.app.discussion/trunk/; revision=39610
2010-09-02 20:52:33 +00:00
Timo Stollenwerk 4f4f9f9cec Fix whitespace for coverage test.
svn path=/plone.app.discussion/trunk/; revision=39609
2010-09-02 20:21:53 +00:00
Timo Stollenwerk 81cba38a74 Comment form test added.
svn path=/plone.app.discussion/trunk/; revision=39608
2010-09-02 20:00:43 +00:00
Timo Stollenwerk d0914c072e Changelog updated (Czech translation added).
svn path=/plone.app.discussion/trunk/; revision=39590
2010-09-01 08:58:46 +00:00
Timo Stollenwerk 87ce946947 Removed unused imports. Raise ImportError when import fails.
svn path=/plone.app.discussion/trunk/; revision=39571
2010-08-31 17:36:28 +00:00
Timo Stollenwerk 77d3bc2eb1 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39570
2010-08-31 17:33:22 +00:00
Timo Stollenwerk d59369a408 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39569
2010-08-31 17:31:27 +00:00
Timo Stollenwerk 9c5f1dd1d8 Unused imports removed.
svn path=/plone.app.discussion/trunk/; revision=39568
2010-08-31 17:29:26 +00:00
Timo Stollenwerk 8d915b6327 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39567
2010-08-31 17:28:07 +00:00
Timo Stollenwerk 23122ded8b Test if registry has been registered.
svn path=/plone.app.discussion/trunk/; revision=39356
2010-08-28 22:58:23 +00:00
Timo Stollenwerk c530e2dbf3 use package-directory param for more flexibility.
svn path=/plone.app.discussion/trunk/; revision=39355
2010-08-28 22:57:47 +00:00
Timo Stollenwerk dc160f9d5e Obey the 80 chars limit in the comments view.
svn path=/plone.app.discussion/trunk/; revision=39332
2010-08-28 20:19:58 +00:00
Timo Stollenwerk 785b006394 Obey the 80 chars limit in the migration function.
svn path=/plone.app.discussion/trunk/; revision=39331
2010-08-28 20:18:36 +00:00
Timo Stollenwerk 632e167806 revert 39237 since this breaks some tests.
svn path=/plone.app.discussion/trunk/; revision=39330
2010-08-28 20:10:48 +00:00
Timo Stollenwerk a2a8956d09 Obey the 80 char limit.
svn path=/plone.app.discussion/trunk/; revision=39327
2010-08-28 20:02:08 +00:00
Timo Stollenwerk f0ff6119cf "Clean up code with PyLint" added to changes.
svn path=/plone.app.discussion/trunk/; revision=39326
2010-08-28 19:55:58 +00:00
Timo Stollenwerk cef90c576b remove author_username variable, because it is unused.
svn path=/plone.app.discussion/trunk/; revision=39325
2010-08-28 19:54:57 +00:00
Timo Stollenwerk 87b2c5dd02 Comment out author_notification because we don't use it right now.
svn path=/plone.app.discussion/trunk/; revision=39324
2010-08-28 19:51:53 +00:00
Timo Stollenwerk 946ff36190 "W0622 total_comments: Redefining built-in 'object'" added to pylint msg ignores.
svn path=/plone.app.discussion/trunk/; revision=39323
2010-08-28 19:48:40 +00:00
Timo Stollenwerk 318afe5aae Fix indentation.
svn path=/plone.app.discussion/trunk/; revision=39322
2010-08-28 19:45:53 +00:00
Timo Stollenwerk 4390b8929b Revert r39314. zptlint failed as expected. hudson integration works!
svn path=/plone.app.discussion/trunk/; revision=39319
2010-08-28 19:31:17 +00:00
Timo Stollenwerk 133da3d305 BREAK templates to check if zptlint in hudson works. Will be reverted immediately.
svn path=/plone.app.discussion/trunk/; revision=39314
2010-08-28 19:19:27 +00:00
Timo Stollenwerk e37e48498b Write errors to the stout as well.
svn path=/plone.app.discussion/trunk/; revision=39313
2010-08-28 19:18:33 +00:00
Timo Stollenwerk a1e81d4eaf exit with an error if zptlint fails.
svn path=/plone.app.discussion/trunk/; revision=39312
2010-08-28 19:12:31 +00:00
Timo Stollenwerk 0ea94c56ff fix typo in zptlint-test section.
svn path=/plone.app.discussion/trunk/; revision=39307
2010-08-28 18:23:38 +00:00
Timo Stollenwerk f110dd6c40 pylint excludes updated; zptlint added.
svn path=/plone.app.discussion/trunk/; revision=39306
2010-08-28 18:21:54 +00:00
Timo Stollenwerk 42cad90262 omelette added; disable more pylint messages.
svn path=/plone.app.discussion/trunk/; revision=39288
2010-08-28 17:07:10 +00:00
Timo Stollenwerk 435040e0b2 Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39287
2010-08-28 17:06:53 +00:00
Timo Stollenwerk 0f9c98ec97 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39272
2010-08-28 16:11:58 +00:00
Timo Stollenwerk 5f5b831904 Be more specific, use ImportError.
svn path=/plone.app.discussion/trunk/; revision=39270
2010-08-28 16:08:36 +00:00
Timo Stollenwerk e12d19a6e9 Fix bugs that have been introduced with the latest pylint "optimizations".
svn path=/plone.app.discussion/trunk/; revision=39269
2010-08-28 16:07:44 +00:00
Timo Stollenwerk 9264d2d42d Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39265
2010-08-28 15:35:21 +00:00
Timo Stollenwerk 487d5308a5 Fix jscoverage and pylint sections.
svn path=/plone.app.discussion/trunk/; revision=39248
2010-08-28 14:07:35 +00:00
Timo Stollenwerk 6b53b7bad2 buildout section to build jscoverage added.
svn path=/plone.app.discussion/trunk/; revision=39220
2010-08-28 12:27:39 +00:00
Timo Stollenwerk 7f8522672c jscoverage and pylint added to test buildout.
svn path=/plone.app.discussion/trunk/; revision=39218
2010-08-28 12:05:53 +00:00
Timo Stollenwerk 7aa09d45b2 jscoverage script added to dev buildout.
svn path=/plone.app.discussion/trunk/; revision=39156
2010-08-27 22:27:09 +00:00
Timo Stollenwerk ba8e7ac5cd Move the functions out of the ready function. this makes the JS tests pass.
svn path=/plone.app.discussion/trunk/; revision=39151
2010-08-27 21:26:37 +00:00
Timo Stollenwerk 67fb426f08 Javascript doc added.
svn path=/plone.app.discussion/trunk/; revision=39146
2010-08-27 20:52:38 +00:00
Timo Stollenwerk f4435a563b Remove unnecessary init test. remove namespaces from method calls.
svn path=/plone.app.discussion/trunk/; revision=39145
2010-08-27 20:51:19 +00:00
Timo Stollenwerk 9e405b47a1 qunit files added.
svn path=/plone.app.discussion/trunk/; revision=39143
2010-08-27 20:50:18 +00:00
Timo Stollenwerk a1605fb88b Revert r39104 since it breaks the comments js.
svn path=/plone.app.discussion/trunk/; revision=39141
2010-08-27 20:45:11 +00:00
Timo Stollenwerk d713409aa1 Use a discussion JS namespace for comments.js; JS tests for clearForm and createReplyForm functions added.
svn path=/plone.app.discussion/trunk/; revision=39104
2010-08-27 17:11:25 +00:00
Timo Stollenwerk 2c5d387cfc Rename js directory to javascripts.
svn path=/plone.app.discussion/trunk/; revision=39066
2010-08-27 12:07:04 +00:00
Timo Stollenwerk e310c1d021 Basic JS tests added.
svn path=/plone.app.discussion/trunk/; revision=39064
2010-08-27 11:41:39 +00:00
Timo Stollenwerk d3074fa4fd Make Javascripts pass JSLint validation
svn path=/plone.app.discussion/trunk/; revision=39059
2010-08-27 10:34:42 +00:00
Timo Stollenwerk d4b4c56fe2 Fix coverage report section.
svn path=/plone.app.discussion/trunk/; revision=39041
2010-08-26 16:04:16 +00:00
Timo Stollenwerk 867e641465 Fix coveragereport script.
svn path=/plone.app.discussion/trunk/; revision=38987
2010-08-26 10:28:22 +00:00
Timo Stollenwerk 61565de95a Put email notification subscribers into their own zcml file so it is easier for integrators to override them.
svn path=/plone.app.discussion/trunk/; revision=38981
2010-08-26 09:31:49 +00:00
Timo Stollenwerk a2c89ed5e8 Plain text and intelligent text options for comment text added to preserve basic text structure and to make links clickable.
svn path=/plone.app.discussion/trunk/; revision=38931
2010-08-25 14:03:29 +00:00
Timo Stollenwerk 35d7743b7a Plain text to HTML transformation added for comment text
svn path=/plone.app.discussion/trunk/; revision=38898
2010-08-25 09:19:28 +00:00
Timo Stollenwerk 1579064ee6 Back to development: 1.0b7
svn path=/plone.app.discussion/trunk/; revision=38887
2010-08-24 09:19:09 +00:00
Timo Stollenwerk 94ebb54421 Update README to 1.0b6 as well.
svn path=/plone.app.discussion/trunk/; revision=38886
2010-08-24 09:18:30 +00:00
Timo Stollenwerk aae3a522bd zest.releaser added to plone 4 dev buildout.
svn path=/plone.app.discussion/trunk/; revision=38885
2010-08-24 09:17:58 +00:00
Timo Stollenwerk 6d5d72f778 Prepare 1.0b6 release.
svn path=/plone.app.discussion/trunk/; revision=38883
2010-08-24 09:05:41 +00:00
Timo Stollenwerk c6252d5116 Remove "exit-with-status" option from test section in the test-plone-4 buildout.
svn path=/plone.app.discussion/trunk/; revision=38882
2010-08-24 09:04:13 +00:00
Timo Stollenwerk 49db74fe3e Remove xmltestreport options that break the coverage report.
svn path=/plone.app.discussion/trunk/; revision=38676
2010-08-09 17:58:22 +00:00
Timo Stollenwerk 510ea5c272 Missing test part added.
svn path=/plone.app.discussion/trunk/; revision=38675
2010-08-09 16:58:38 +00:00
Timo Stollenwerk f9766aeeb6 Test coverage added to test-plone4 buildout.
svn path=/plone.app.discussion/trunk/; revision=38666
2010-08-09 13:05:07 +00:00
Timo Stollenwerk 7a2f1ff12b Fix indentation.
svn path=/plone.app.discussion/trunk/; revision=38665
2010-08-09 12:42:21 +00:00
Timo Stollenwerk d37d5aa9f5 Redirect to the comment form action instead of the absolute url when a comment is posted. This fixes the accidentially triggered file upload when a comment is posted on a file content object.
svn path=/plone.app.discussion/trunk/; revision=38664
2010-08-09 12:25:14 +00:00
Timo Stollenwerk 7fef29cf64 We are still on 1.0b6.
svn path=/plone.app.discussion/trunk/; revision=38663
2010-08-09 12:21:04 +00:00
Timo Stollenwerk 539fa85bb4 Version pins for Plone 4 test buildout updated.
svn path=/plone.app.discussion/trunk/; revision=38662
2010-08-09 12:06:13 +00:00
Timo Stollenwerk 34a199a2cb Upgrade dev buildout to Plone 4.0rc1 (pin down TinyMCE to 1.1.1 because fetching 1.1.2 breaks buildout)
svn path=/plone.app.discussion/trunk/; revision=38661
2010-08-09 11:49:04 +00:00
Timo Stollenwerk 86c2bbe001 Spanish and German translation updated.
svn path=/plone.app.discussion/trunk/; revision=38552
2010-08-05 18:41:22 +00:00
Timo Stollenwerk 27a2d3fa36 Use only one MessageFactory.
svn path=/plone.app.discussion/trunk/; revision=38551
2010-08-05 18:40:22 +00:00
Timo Stollenwerk 25d1da3475 Spanish translation added. Thanks to Judith Sanleandro.
svn path=/plone.app.discussion/trunk/; revision=38550
2010-08-05 17:18:19 +00:00
Timo Stollenwerk ae5754455b Translation files updated. Spanish translation added.
svn path=/plone.app.discussion/trunk/; revision=38547
2010-08-05 16:47:24 +00:00
Timo Stollenwerk f72972844d Call the CaptchaValidator even when no captcha data was submitted. This is necessary to ensure that the collective.akismet validator is called when installed.
svn path=/plone.app.discussion/trunk/; revision=38541
2010-08-05 15:36:07 +00:00
Timo Stollenwerk 9d8c675e69 collective.akismet added to plugin section.
svn path=/plone.app.discussion/trunk/; revision=38141
2010-07-19 09:42:08 +00:00
Timo Stollenwerk 0925a63c15 Unnecessary imports removed.
svn path=/plone.app.discussion/trunk/; revision=38139
2010-07-19 08:25:37 +00:00
Timo Stollenwerk d0f93e6376 version => 1.0b6
svn path=/plone.app.discussion/trunk/; revision=38138
2010-07-19 08:01:53 +00:00
Timo Stollenwerk 4cea4bf384 whitespace
svn path=/plone.app.discussion/trunk/; revision=38137
2010-07-19 08:01:25 +00:00
Timo Stollenwerk d61b5e5964 Point to 1.0b5 to avoid confusion.
svn path=/plone.app.discussion/trunk/; revision=37919
2010-07-16 15:58:04 +00:00
Timo Stollenwerk 01332a2618 Prepare 1.0b5 release.
svn path=/plone.app.discussion/trunk/; revision=37917
2010-07-16 15:31:36 +00:00
Timo Stollenwerk 88ce860aa5 Use self.form instead of CommentForm for the CommentsViewlet update method so integrators don't have to override the viewlet's update method. [Matous]
svn path=/plone.app.discussion/trunk/; revision=37916
2010-07-16 15:26:01 +00:00
Timo Stollenwerk 85d5b823b0 Remove collective.akismet from the captcha documentation.
svn path=/plone.app.discussion/trunk/; revision=37915
2010-07-16 15:08:18 +00:00
Timo Stollenwerk c3320def88 Make sure the form fields in the reply form are always placed under the field labels; Fix CSS overflow bug that occurs with the new Plone 4.0b5 comment styles
svn path=/plone.app.discussion/trunk/; revision=37774
2010-07-13 13:39:35 +00:00
Timo Stollenwerk 6ca6f58acd Remove unnecessary variables and imports.
svn path=/plone.app.discussion/trunk/; revision=37773
2010-07-13 13:21:12 +00:00
Timo Stollenwerk 3e625f3677 Upgrade dev buildout to Plone 4.0b5; Use PloneTestCase trunk for now until 0.9.10 is out. Thanks MJ!
svn path=/plone.app.discussion/trunk/; revision=37772
2010-07-13 13:19:53 +00:00
Timo Stollenwerk 42dbf1fe85 Remove unnecessary Zope download line from dev buildout.
svn path=/plone.app.discussion/trunk/; revision=37770
2010-07-13 11:45:49 +00:00
Timo Stollenwerk 1807205710 CHANGES updated (Unnecessary imports and variables removed.).
svn path=/plone.app.discussion/trunk/; revision=37769
2010-07-13 10:46:41 +00:00
Timo Stollenwerk a54a15a90f Remove unnecessary imports and variables from test code.
svn path=/plone.app.discussion/trunk/; revision=37768
2010-07-13 10:45:53 +00:00
Timo Stollenwerk cfdd99b111 remove unnecessary imports / variables; whitespace
svn path=/plone.app.discussion/trunk/; revision=37767
2010-07-13 10:41:26 +00:00
Timo Stollenwerk 66c235aa5e fix whitespace
svn path=/plone.app.discussion/trunk/; revision=37766
2010-07-13 10:40:45 +00:00
Timo Stollenwerk a5683b0674 remove unnecessary imports.
svn path=/plone.app.discussion/trunk/; revision=37765
2010-07-13 10:40:24 +00:00
Timo Stollenwerk f3b1dab916 Move AkismetValidator from plone.app.discussion to collective.akismet.
svn path=/plone.app.discussion/trunk/; revision=37764
2010-07-13 09:24:23 +00:00
Timo Stollenwerk 5784ed82a3 Remove unnecessary imports from vocabularies.py.
svn path=/plone.app.discussion/trunk/; revision=37763
2010-07-13 09:23:10 +00:00
Timo Stollenwerk 31c0f7b459 Check for collective.akismet to detect akismet plugin, not for the Python akismet package.
svn path=/plone.app.discussion/trunk/; revision=37762
2010-07-13 09:22:05 +00:00
Timo Stollenwerk 2dbc337fc7 Remove unnecessary imports from captcha.py.
svn path=/plone.app.discussion/trunk/; revision=37760
2010-07-13 09:20:32 +00:00
Timo Stollenwerk 1a84b0b7b8 Remove unnecessary imports.
svn path=/plone.app.discussion/trunk/; revision=37759
2010-07-13 09:19:20 +00:00
Timo Stollenwerk 27d8ced62d revert r37751.
svn path=/plone.app.discussion/trunk/; revision=37753
2010-07-12 13:49:57 +00:00
Timo Stollenwerk cac0bae7a5 revert r37751.
svn path=/plone.app.discussion/trunk/; revision=37752
2010-07-12 13:47:53 +00:00
Timo Stollenwerk eabf3bc890 Always use zope.component getUtility instead of queryUtility.
svn path=/plone.app.discussion/trunk/; revision=37751
2010-07-12 13:34:02 +00:00
Timo Stollenwerk 5bdfe7c750 plone.z3cform trunk added to mr.developer.
svn path=/plone.app.discussion/trunk/; revision=37747
2010-07-12 06:43:57 +00:00