ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
912 Commits 1 Branch 0 Tags
823ada74915463c685adaf34725ab7b7e95b5663
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Timo Stollenwerk 823ada7491 Remove AJAX comment deletion binding. This function relies on the nextUntil() selector introduced by jQuery 1.4 and therefore breaks in Plone 3 (that currently uses jQuery 1.3.2). 
svn path=/plone.app.discussion/trunk/; revision=45188
 2010-11-04 14:42:32 +00:00
Timo Stollenwerk b68da9925b Use parseInt with second param to make jslint happy. 
svn path=/plone.app.discussion/trunk/; revision=45187
 2010-11-04 14:37:18 +00:00
Timo Stollenwerk 89ac3f6b86 Prepare plone.app.discussion 1.0b11. 
svn path=/plone.app.discussion/trunk/; revision=45133
 2010-11-03 16:21:13 +00:00
Timo Stollenwerk 004b5def22 Preparing release 1.0b11 
svn path=/plone.app.discussion/trunk/; revision=45131
 2010-11-03 15:26:06 +00:00
Timo Stollenwerk 3ebc83447f Point to the 1.0b11 KGS in README. 
svn path=/plone.app.discussion/trunk/; revision=45130
 2010-11-03 15:13:28 +00:00
Timo Stollenwerk 2bc0acd968 Update Sphinx release number to 1.0b11. 
svn path=/plone.app.discussion/trunk/; revision=45128
 2010-11-03 13:59:54 +00:00
Timo Stollenwerk dc37db70d9 zope.i18n pinned down in Plone 3 KGS. 
svn path=/plone.app.discussion/trunk/; revision=45127
 2010-11-03 13:54:57 +00:00
Timo Stollenwerk 3d2f01b440 Translations updated. 
svn path=/plone.app.discussion/trunk/; revision=45125
 2010-11-03 13:45:00 +00:00
Timo Stollenwerk 25a82538b4 Fix Czech language code and name. 
svn path=/plone.app.discussion/trunk/; revision=45124
 2010-11-03 13:42:20 +00:00
Timo Stollenwerk 7f98b94031 Fix Dutch language code and name. 
svn path=/plone.app.discussion/trunk/; revision=45123
 2010-11-03 13:40:48 +00:00
Timo Stollenwerk b95707ac52 Re-add the CommentsViewlet can_manage method. This method has been removed in version 1.0b9 and added again in 1.0b11 because we don't want to change the API in beta releases. 
svn path=/plone.app.discussion/trunk/; revision=45110
 2010-11-03 11:26:18 +00:00
Timo Stollenwerk a8616c1c87 Don't declare the zope.schema dependency in setup.py because it will fetch a version that breaks the Plone 3 buildout. 
svn path=/plone.app.discussion/trunk/; revision=45083
 2010-11-02 12:21:02 +00:00
Timo Stollenwerk 8e8e78c2d9 Fix language code and name in the Basque .po file. 
svn path=/plone.app.discussion/trunk/; revision=45082
 2010-11-02 11:34:52 +00:00
Timo Stollenwerk 885c988ec9 Declare z3c.form and zope.schema as minimum version dependencies in setup.py in case people use a different KGS. 
svn path=/plone.app.discussion/trunk/; revision=45081
 2010-11-02 10:38:38 +00:00
Timo Stollenwerk a39ac82858 There is no need to set the comment title in the tests, since comments do not have title fields anymore. 
svn path=/plone.app.discussion/trunk/; revision=44738
 2010-10-31 11:09:32 +00:00
Timo Stollenwerk feec103b56 Fix user email notification test for Plone 3. 
svn path=/plone.app.discussion/trunk/; revision=44737
 2010-10-31 10:48:45 +00:00
Timo Stollenwerk fa6e380eaf Use secureSend for user email notification on Plone 3 
svn path=/plone.app.discussion/trunk/; revision=44736
 2010-10-31 10:34:58 +00:00
Timo Stollenwerk c8cd370fc9 Use len(tuple()) instead of tuple() to make tests pass again. 
svn path=/plone.app.discussion/trunk/; revision=44706
 2010-10-30 19:26:51 +00:00
Timo Stollenwerk 093eaa393a Use tuple() to test for generators. Thanks to otacon! 
svn path=/plone.app.discussion/trunk/; revision=42096
 2010-10-30 18:58:20 +00:00
Timo Stollenwerk cc96acb50a Ajaxify comment deletion and approval. thanks thomasdesvenain! 
svn path=/plone.app.discussion/trunk/; revision=40984
 2010-10-30 17:32:31 +00:00
Timo Stollenwerk 18d7aadd0e Upgrade the plone 3.x buildout to work with z3c.form 2.3.3. We need this for the new user email notification feature. 
svn path=/plone.app.discussion/trunk/; revision=40963
 2010-10-30 16:03:31 +00:00
Timo Stollenwerk 82afd3ef15 New feature: As a logged-in user, I can enable/disable email notification of additional comments on this content object. 
svn path=/plone.app.discussion/trunk/; revision=40949
 2010-10-30 15:02:05 +00:00
Timo Stollenwerk 5fe339215b Use the jstestdriver coverage plugin. 
svn path=/plone.app.discussion/trunk/; revision=40909
 2010-10-30 11:24:03 +00:00
Timo Stollenwerk c6f03849df Remove jscoverage from buildout. 
svn path=/plone.app.discussion/trunk/; revision=40908
 2010-10-30 11:23:45 +00:00
Timo Stollenwerk 380b81bd3e Disable the moderation qunit tests for now because they are currently failing. 
svn path=/plone.app.discussion/trunk/; revision=40907
 2010-10-30 11:12:04 +00:00
Timo Stollenwerk 820fe7dd4e jstestdriver added to buildout. 
svn path=/plone.app.discussion/trunk/; revision=40903
 2010-10-30 10:55:45 +00:00
Timo Stollenwerk 0820d3771f Basic js-test-driver configuration added. 
svn path=/plone.app.discussion/trunk/; revision=40892
 2010-10-30 10:22:21 +00:00
Timo Stollenwerk 81dcdeaea3 Disable the plone.app.registry check on schema elements, so no error is raised on upgrades. This fixes https://dev.plone.org/plone/ticket/11195. Refs #11195 
svn path=/plone.app.discussion/trunk/; revision=40868
 2010-10-29 10:43:46 +00:00
Timo Stollenwerk 1316cfc83e Fix collective.recipe.sphinxbuilder version pin. 
svn path=/plone.app.discussion/trunk/; revision=40863
 2010-10-28 17:06:52 +00:00
Timo Stollenwerk f6b7ef1bcb Remove the too generic id attribute of the comment form. 
svn path=/plone.app.discussion/trunk/; revision=40858
 2010-10-28 10:30:10 +00:00
Timo Stollenwerk 777e687169 Rename the id of the comment form from "form" to "comment-form". 
svn path=/plone.app.discussion/trunk/; revision=40857
 2010-10-28 09:45:34 +00:00
Timo Stollenwerk 22e4189c37 Revert revisions r40851 to r40853, they should have gone into the ajax-ui branch. 
svn path=/plone.app.discussion/trunk/; revision=40856
 2010-10-28 09:39:00 +00:00
Timo Stollenwerk 14e2600a79 Make ajax call for delete comment button work for comment replies. 
svn path=/plone.app.discussion/trunk/; revision=40853
 2010-10-27 16:10:04 +00:00
Timo Stollenwerk 926e4f6b8e Integrate Denys ajax ui code. 
svn path=/plone.app.discussion/trunk/; revision=40852
 2010-10-27 14:44:52 +00:00
Timo Stollenwerk 79f4481722 Use "#comment-form" as id for the comment form instead of "#form" which is too generic. 
svn path=/plone.app.discussion/trunk/; revision=40851
 2010-10-27 14:44:06 +00:00
Timo Stollenwerk 11f786bcd6 Use 1.0b10 good-py link 
svn path=/plone.app.discussion/trunk/; revision=40659
 2010-10-15 15:54:37 +00:00
Timo Stollenwerk 5e6d638885 Back to 1.0b10 for a re-release. 
svn path=/plone.app.discussion/trunk/; revision=40658
 2010-10-15 15:53:33 +00:00
Timo Stollenwerk 239b38353a Back to development: 1.0b11 
svn path=/plone.app.discussion/trunk/; revision=40651
 2010-10-15 14:55:12 +00:00
Timo Stollenwerk 13dbd2d7c4 Preparing release 1.0b10 
svn path=/plone.app.discussion/trunk/; revision=40649
 2010-10-15 14:50:58 +00:00
Timo Stollenwerk 6c67b0dbda Update workflow documentation. we are not there yet. 
svn path=/plone.app.discussion/trunk/; revision=40648
 2010-10-15 14:49:54 +00:00
Timo Stollenwerk f7ed357a83 Use 'comment_review_workflow' instead of 'simple_publication_workflow' for testing. 
svn path=/plone.app.discussion/trunk/; revision=40571
 2010-10-08 11:03:14 +00:00
Timo Stollenwerk 324d2274bd Check for a 'pending' state in the current comment workflow instead of checking for the 'comment_review' workflow. Refs #11184. Merge last three submits in CHANGES.txt. 
svn path=/plone.app.discussion/trunk/; revision=40570
 2010-10-08 10:37:10 +00:00
Timo Stollenwerk 6e9bb4a9cd Check the review_state to decide if moderation is enabled. If the current comment workflow implements a 'pending' state, moderation is enabled. Refs #11184. 
svn path=/plone.app.discussion/trunk/; revision=40569
 2010-10-08 10:22:40 +00:00
Timo Stollenwerk 2790e6d4eb Check the review_state instead of the workflow after a comment has been posted to decide if a message is shown to the user. This allows integrators to use custom review workflows. Refs #11184 
svn path=/plone.app.discussion/trunk/; revision=40566
 2010-10-08 09:53:00 +00:00
Timo Stollenwerk aea10731cd Back to development: 1.0b10 
svn path=/plone.app.discussion/trunk/; revision=40544
 2010-10-07 07:14:29 +00:00
Timo Stollenwerk 23968e41b4 Preparing release 1.0b9 
svn path=/plone.app.discussion/trunk/; revision=40542
 2010-10-07 07:12:36 +00:00
Timo Stollenwerk 770b85f3df Prepare sphinx docs for 1.0b9 release. 
svn path=/plone.app.discussion/trunk/; revision=40541
 2010-10-07 07:11:37 +00:00
Timo Stollenwerk 43d3222086 Run functional tests only with Plone 4 (and plone.testing). 
svn path=/plone.app.discussion/trunk/; revision=40537
 2010-10-06 15:12:11 +00:00
Timo Stollenwerk 94584429fd Do not use has_key. 
svn path=/plone.app.discussion/trunk/; revision=40536
 2010-10-06 14:12:30 +00:00
Timo Stollenwerk 43bd68a6df Update changes. 
svn path=/plone.app.discussion/trunk/; revision=40535
 2010-10-06 13:56:49 +00:00
Timo Stollenwerk 4bbfe677e4 Replace the can_manage method with a can_review method that checks the 'Review comments' permission. This fixes http://dev.plone.org/plone/ticket/11145. 
svn path=/plone.app.discussion/trunk/; revision=40534
 2010-10-06 13:55:57 +00:00
Timo Stollenwerk 3e73903a8d Remove (old) functional test. 
svn path=/plone.app.discussion/trunk/; revision=40533
 2010-10-06 13:53:07 +00:00
Timo Stollenwerk 1230e67a01 Functional test for comment_review_workflow added; existing fonctional test renamed to functional_test_comments.txt; 
svn path=/plone.app.discussion/trunk/; revision=40532
 2010-10-06 13:52:11 +00:00
Timo Stollenwerk 1db321a044 Make pylint happy. 
svn path=/plone.app.discussion/trunk/; revision=40527
 2010-10-06 09:02:26 +00:00
Timo Stollenwerk f9ca4497bd Obey the 80 chars limit. 
svn path=/plone.app.discussion/trunk/; revision=40526
 2010-10-06 08:47:24 +00:00
Timo Stollenwerk 94b0c58511 Fix pylint disable-msg statements. 
svn path=/plone.app.discussion/trunk/; revision=40521
 2010-10-05 15:54:49 +00:00
Timo Stollenwerk fbb042c012 Remove unused import. 
svn path=/plone.app.discussion/trunk/; revision=40520
 2010-10-05 15:52:19 +00:00
Timo Stollenwerk 773345c40f Make pylint happy. 
svn path=/plone.app.discussion/trunk/; revision=40519
 2010-10-05 15:47:02 +00:00
Timo Stollenwerk 7de585542b Fix moderation actions (publish, delete) in the moderation view with virtual hosts. This is a replacement for http://dev.plone.org/plone/changeset/35608. 
svn path=/plone.app.discussion/trunk/; revision=40518
 2010-10-05 15:21:54 +00:00
Timo Stollenwerk b984a445d5 Inline documentation for moderation view added. 
svn path=/plone.app.discussion/trunk/; revision=40517
 2010-10-05 15:14:12 +00:00
Timo Stollenwerk 7e42a39346 Remove .mo file from subversion. 
svn path=/plone.app.discussion/trunk/; revision=40516
 2010-10-05 14:07:39 +00:00
Timo Stollenwerk 837e6b2966 Do not show two "login to add comments" buttons when there are no comments yet. This fixes http://plone.org/products/plone.app.discussion/issues/12. 
svn path=/plone.app.discussion/trunk/; revision=40515
 2010-10-05 12:07:08 +00:00
Timo Stollenwerk 7bdf340c88 Fix restructured text. 
svn path=/plone.app.discussion/trunk/; revision=40511
 2010-10-04 19:19:34 +00:00
Timo Stollenwerk 4b40575dd1 Back to development: 1.0b9 
svn path=/plone.app.discussion/trunk/; revision=40510
 2010-10-04 19:11:16 +00:00
Timo Stollenwerk 198225ae9a Preparing release 1.0b8 
svn path=/plone.app.discussion/trunk/; revision=40507
 2010-10-04 19:09:28 +00:00
Timo Stollenwerk 51642c2e0f German translations updated. 
svn path=/plone.app.discussion/trunk/; revision=40506
 2010-10-04 18:59:42 +00:00
Timo Stollenwerk 9841ba7229 Remove unnecessary decode statement from creator. 
svn path=/plone.app.discussion/trunk/; revision=40503
 2010-10-04 13:48:54 +00:00
Timo Stollenwerk 0ee649fb6c Functional test for special characters added. Remove unnecessary decode statement from creator. 
svn path=/plone.app.discussion/trunk/; revision=40502
 2010-10-04 13:48:27 +00:00
Timo Stollenwerk b06ba43a75 Ignore currently unused code from code coverage. Overall code coverage is up to 95%. 
svn path=/plone.app.discussion/trunk/; revision=40497
 2010-10-03 19:54:59 +00:00
Timo Stollenwerk 6d92d1383c Remove comment title from comments viewlet tests. 
svn path=/plone.app.discussion/trunk/; revision=40496
 2010-10-03 19:41:02 +00:00
Timo Stollenwerk ede295e649 Functional test for posting a comment with comment review workflow enabled. 
svn path=/plone.app.discussion/trunk/; revision=40495
 2010-10-03 19:07:30 +00:00
Timo Stollenwerk 603bcf3547 Ignore certain lines for code coverage. 
svn path=/plone.app.discussion/trunk/; revision=40494
 2010-10-03 16:52:26 +00:00
Timo Stollenwerk f5cf756e31 Functional test for replying to an existing comment added. 
svn path=/plone.app.discussion/trunk/; revision=40493
 2010-10-03 16:50:47 +00:00
Timo Stollenwerk 497c2a075e There is no need to set the title in the handleComment method anymore. 
svn path=/plone.app.discussion/trunk/; revision=40492
 2010-10-03 07:29:44 +00:00
Timo Stollenwerk e0055d0ba7 Make sure comment titles work with special characters as well. 
svn path=/plone.app.discussion/trunk/; revision=40486
 2010-10-02 18:16:49 +00:00
Timo Stollenwerk 51d6c60412 Use the right event subscriber to make sure all comments are removed from the catalog, if their content object is deleted. 
svn path=/plone.app.discussion/trunk/; revision=40485
 2010-10-02 14:50:17 +00:00
Timo Stollenwerk 0e27b8b7b6 Move regression test for #11157 into the main functional test. 
svn path=/plone.app.discussion/trunk/; revision=40458
 2010-09-30 17:45:26 +00:00
Timo Stollenwerk 22db0b1c78 Fix comment title for anonymous commentators that do not provide a name. 
svn path=/plone.app.discussion/trunk/; revision=40435
 2010-09-29 10:52:11 +00:00
Timo Stollenwerk 2cce7e0d0f "Post comment as logged-in users" test added. 
svn path=/plone.app.discussion/trunk/; revision=40434
 2010-09-29 10:17:25 +00:00
Timo Stollenwerk 689fd26c12 Apply the comment viewlet template and styles to the new title-less comments. This might require integrators to apply their custom templates and styles. 
svn path=/plone.app.discussion/trunk/; revision=40433
 2010-09-29 08:13:54 +00:00
Timo Stollenwerk 8d00463502 Remove subject line from comment batch moderation view, since this doesn't make sense anymore with auto-generated titles. 
svn path=/plone.app.discussion/trunk/; revision=40432
 2010-09-29 08:02:39 +00:00
Timo Stollenwerk f67c7cde6d Remove title field from the comment form and replace it with an auto-generated title ("John Doe on Welcome to Plone"). 
This also fixes http://dev.plone.org/plone/ticket/11098

svn path=/plone.app.discussion/trunk/; revision=40431
 2010-09-29 07:56:36 +00:00
Timo Stollenwerk f2f2dd524f Use the right trac link for the __parent__ pointer fix. 
svn path=/plone.app.discussion/trunk/; revision=40427
 2010-09-29 06:48:36 +00:00
Timo Stollenwerk e603494a83 Do not use https links in CHANGES.txt. 
svn path=/plone.app.discussion/trunk/; revision=40426
 2010-09-29 06:46:57 +00:00
Timo Stollenwerk f243929662 Fetch the testing dependencies. 
svn path=/plone.app.discussion/trunk/; revision=40394
 2010-09-28 16:36:50 +00:00
Timo Stollenwerk 7df932204c Functional plone.testing doctest added. 
svn path=/plone.app.discussion/trunk/; revision=40393
 2010-09-28 16:35:45 +00:00
Timo Stollenwerk 0259c1298f Add proper credits to the last CHANGES entry. 
svn path=/plone.app.discussion/trunk/; revision=40391
 2010-09-28 16:00:08 +00:00
Timo Stollenwerk 138942470c Make sure the __parent__ pointer (the conversation) of a comment is not acquisition wrapped in conversation.addComment. This fixes Refs #11157. 
svn path=/plone.app.discussion/trunk/; revision=40374
 2010-09-28 10:37:40 +00:00
Timo Stollenwerk a55ff5b883 Fix pickle regression test. 
svn path=/plone.app.discussion/trunk/; revision=40373
 2010-09-28 10:18:16 +00:00
Timo Stollenwerk 77e44f96ad Added test (currently failing) to trigger "can't pickle objects in acquisition wrapper". Refs #11157 
svn path=/plone.app.discussion/trunk/; revision=40357
 2010-09-27 19:03:43 +00:00
Timo Stollenwerk c444c74680 Explicit plain, html, and xml coverage report sections added. 
svn path=/plone.app.discussion/trunk/; revision=40237
 2010-09-24 23:12:38 +00:00
Timo Stollenwerk d70f236ed9 Fix tests directory exclusion, added htmlreport section. 
svn path=/plone.app.discussion/trunk/; revision=40235
 2010-09-24 22:45:10 +00:00
Timo Stollenwerk 32702896b5 Fix coverage report. 
svn path=/plone.app.discussion/trunk/; revision=40234
 2010-09-24 22:26:57 +00:00
Timo Stollenwerk 58868c55e7 whitespace. 
svn path=/plone.app.discussion/trunk/; revision=40232
 2010-09-24 19:45:57 +00:00
Timo Stollenwerk d736bfe0b1 Remove unused parts. 
svn path=/plone.app.discussion/trunk/; revision=40231
 2010-09-24 19:37:01 +00:00
Timo Stollenwerk a33ec8a049 Revert r40080 since this broke the coverage report. 
svn path=/plone.app.discussion/trunk/; revision=40230
 2010-09-24 19:27:59 +00:00
Timo Stollenwerk e95ae26a11 Fix moderation test headline. 
svn path=/plone.app.discussion/trunk/; revision=40229
 2010-09-24 19:04:35 +00:00
Timo Stollenwerk cf11a5134a Javascript tests for the bulk moderation view added (currently failing). 
svn path=/plone.app.discussion/trunk/; revision=40228
 2010-09-24 19:04:03 +00:00
Timo Stollenwerk ad99e45203 Revert r35608 since this was breaking the comment moderation bulk actions. The BulkActionsView expects the absolute path of the comments without the portal url (e.g. '/plone/doc1/++conversation++default/1285346769126020'). This fixes https://dev.plone.org/plone/ticket/11156. 
svn path=/plone.app.discussion/trunk/; revision=40227
 2010-09-24 17:04:24 +00:00
Timo Stollenwerk 2ff95fe847 Make sure the moderation JS functions are executed after the page is fully loaded. 
svn path=/plone.app.discussion/trunk/; revision=40215
 2010-09-24 14:57:19 +00:00