Commit Graph

698 Commits

Author SHA1 Message Date
Timo Stollenwerk
0ee649fb6c Functional test for special characters added. Remove unnecessary decode statement from creator.
svn path=/plone.app.discussion/trunk/; revision=40502
2010-10-04 13:48:27 +00:00
Timo Stollenwerk
b06ba43a75 Ignore currently unused code from code coverage. Overall code coverage is up to 95%.
svn path=/plone.app.discussion/trunk/; revision=40497
2010-10-03 19:54:59 +00:00
Timo Stollenwerk
6d92d1383c Remove comment title from comments viewlet tests.
svn path=/plone.app.discussion/trunk/; revision=40496
2010-10-03 19:41:02 +00:00
Timo Stollenwerk
ede295e649 Functional test for posting a comment with comment review workflow enabled.
svn path=/plone.app.discussion/trunk/; revision=40495
2010-10-03 19:07:30 +00:00
Timo Stollenwerk
603bcf3547 Ignore certain lines for code coverage.
svn path=/plone.app.discussion/trunk/; revision=40494
2010-10-03 16:52:26 +00:00
Timo Stollenwerk
f5cf756e31 Functional test for replying to an existing comment added.
svn path=/plone.app.discussion/trunk/; revision=40493
2010-10-03 16:50:47 +00:00
Timo Stollenwerk
497c2a075e There is no need to set the title in the handleComment method anymore.
svn path=/plone.app.discussion/trunk/; revision=40492
2010-10-03 07:29:44 +00:00
Timo Stollenwerk
e0055d0ba7 Make sure comment titles work with special characters as well.
svn path=/plone.app.discussion/trunk/; revision=40486
2010-10-02 18:16:49 +00:00
Timo Stollenwerk
51d6c60412 Use the right event subscriber to make sure all comments are removed from the catalog, if their content object is deleted.
svn path=/plone.app.discussion/trunk/; revision=40485
2010-10-02 14:50:17 +00:00
Luca Fabbri
1edbf3a262 italian translation updated
svn path=/plone.app.discussion/trunk/; revision=40461
2010-09-30 22:00:24 +00:00
Luca Fabbri
2d603c2c0e italian translation updated
svn path=/plone.app.discussion/trunk/; revision=40460
2010-09-30 21:52:40 +00:00
Timo Stollenwerk
0e27b8b7b6 Move regression test for #11157 into the main functional test.
svn path=/plone.app.discussion/trunk/; revision=40458
2010-09-30 17:45:26 +00:00
Timo Stollenwerk
22db0b1c78 Fix comment title for anonymous commentators that do not provide a name.
svn path=/plone.app.discussion/trunk/; revision=40435
2010-09-29 10:52:11 +00:00
Timo Stollenwerk
2cce7e0d0f "Post comment as logged-in users" test added.
svn path=/plone.app.discussion/trunk/; revision=40434
2010-09-29 10:17:25 +00:00
Timo Stollenwerk
689fd26c12 Apply the comment viewlet template and styles to the new title-less comments. This might require integrators to apply their custom templates and styles.
svn path=/plone.app.discussion/trunk/; revision=40433
2010-09-29 08:13:54 +00:00
Timo Stollenwerk
8d00463502 Remove subject line from comment batch moderation view, since this doesn't make sense anymore with auto-generated titles.
svn path=/plone.app.discussion/trunk/; revision=40432
2010-09-29 08:02:39 +00:00
Timo Stollenwerk
f67c7cde6d Remove title field from the comment form and replace it with an auto-generated title ("John Doe on Welcome to Plone").
This also fixes http://dev.plone.org/plone/ticket/11098

svn path=/plone.app.discussion/trunk/; revision=40431
2010-09-29 07:56:36 +00:00
Timo Stollenwerk
7df932204c Functional plone.testing doctest added.
svn path=/plone.app.discussion/trunk/; revision=40393
2010-09-28 16:35:45 +00:00
Timo Stollenwerk
138942470c Make sure the __parent__ pointer (the conversation) of a comment is not acquisition wrapped in conversation.addComment. This fixes Refs #11157.
svn path=/plone.app.discussion/trunk/; revision=40374
2010-09-28 10:37:40 +00:00
Timo Stollenwerk
a55ff5b883 Fix pickle regression test.
svn path=/plone.app.discussion/trunk/; revision=40373
2010-09-28 10:18:16 +00:00
Timo Stollenwerk
77e44f96ad Added test (currently failing) to trigger "can't pickle objects in acquisition wrapper". Refs #11157
svn path=/plone.app.discussion/trunk/; revision=40357
2010-09-27 19:03:43 +00:00
Timo Stollenwerk
58868c55e7 whitespace.
svn path=/plone.app.discussion/trunk/; revision=40232
2010-09-24 19:45:57 +00:00
Timo Stollenwerk
e95ae26a11 Fix moderation test headline.
svn path=/plone.app.discussion/trunk/; revision=40229
2010-09-24 19:04:35 +00:00
Timo Stollenwerk
cf11a5134a Javascript tests for the bulk moderation view added (currently failing).
svn path=/plone.app.discussion/trunk/; revision=40228
2010-09-24 19:04:03 +00:00
Timo Stollenwerk
ad99e45203 Revert r35608 since this was breaking the comment moderation bulk actions. The BulkActionsView expects the absolute path of the comments without the portal url (e.g. '/plone/doc1/++conversation++default/1285346769126020'). This fixes https://dev.plone.org/plone/ticket/11156.
svn path=/plone.app.discussion/trunk/; revision=40227
2010-09-24 17:04:24 +00:00
Timo Stollenwerk
2ff95fe847 Make sure the moderation JS functions are executed after the page is fully loaded.
svn path=/plone.app.discussion/trunk/; revision=40215
2010-09-24 14:57:19 +00:00
Timo Stollenwerk
399bba5eca Use "(function($) { /* some code that uses $ */ })(jQuery)" instead of "$(document).ready(function(){ /* some code that uses $ */ });" to invoke jQuery code.
svn path=/plone.app.discussion/trunk/; revision=40214
2010-09-24 14:21:26 +00:00
Timo Stollenwerk
57758d2cf8 More workflow tests.
svn path=/plone.app.discussion/trunk/; revision=40203
2010-09-24 13:33:21 +00:00
Timo Stollenwerk
ea26c70eed Clean up whitespace, change workflow description.
svn path=/plone.app.discussion/trunk/; revision=40192
2010-09-24 03:12:12 +00:00
Timo Stollenwerk
41c9d030d8 Clean up whitespace, change workflow description.
svn path=/plone.app.discussion/trunk/; revision=40191
2010-09-24 03:11:39 +00:00
Timo Stollenwerk
d77ca9d583 Commenting form explanation added.
svn path=/plone.app.discussion/trunk/; revision=40167
2010-09-23 14:46:24 +00:00
Timo Stollenwerk
c364630a8c js test for comments updated.
svn path=/plone.app.discussion/trunk/; revision=40166
2010-09-23 14:42:18 +00:00
Timo Stollenwerk
9d0fa61c4d Remove unnecessary XXX since we already use layers.
svn path=/plone.app.discussion/trunk/; revision=40165
2010-09-23 12:56:17 +00:00
Timo Stollenwerk
f1cf4c9688 Translation files updated.
svn path=/plone.app.discussion/trunk/; revision=40154
2010-09-23 11:06:38 +00:00
Timo Stollenwerk
0cee7c541d Finnish translation added.
svn path=/plone.app.discussion/trunk/; revision=40153
2010-09-23 11:04:47 +00:00
Radim Novotny
685fc2874d Updated Czech i18n
svn path=/plone.app.discussion/trunk/; revision=40140
2010-09-22 15:03:04 +00:00
Timo Stollenwerk
6b4fd0f0c1 Ignore certain lines for code coverage.
svn path=/plone.app.discussion/trunk/; revision=40083
2010-09-20 10:03:55 +00:00
Timo Stollenwerk
cbde125048 Ignore certain lines for code coverage.
svn path=/plone.app.discussion/trunk/; revision=40082
2010-09-20 10:03:38 +00:00
Timo Stollenwerk
aeabd6fc11 Ignore certain lines for code coverage.
svn path=/plone.app.discussion/trunk/; revision=40081
2010-09-20 10:02:07 +00:00
Timo Stollenwerk
4b3473f74b Always provide that path param for bulk action view tests.
svn path=/plone.app.discussion/trunk/; revision=40004
2010-09-18 17:02:37 +00:00
Timo Stollenwerk
14c0a3a4d1 Remove wrong_bulkaction test.
svn path=/plone.app.discussion/trunk/; revision=39946
2010-09-16 15:44:07 +00:00
Timo Stollenwerk
e8a4caa5db Some more tests for moderation bulk actions.
svn path=/plone.app.discussion/trunk/; revision=39945
2010-09-16 15:42:27 +00:00
Timo Stollenwerk
742412a7d8 Test publish bulk actions as well.
svn path=/plone.app.discussion/trunk/; revision=39943
2010-09-16 15:12:59 +00:00
Timo Stollenwerk
8d866a0ff6 Tests for moderate comments bulk actions added.
svn path=/plone.app.discussion/trunk/; revision=39942
2010-09-16 14:58:11 +00:00
Timo Stollenwerk
087efab54a Trying to fix the comments viewlet functional tests on Plone 3.x.
svn path=/plone.app.discussion/trunk/; revision=39932
2010-09-16 12:41:01 +00:00
Timo Stollenwerk
3d594a934d Captcha plugin support for collective.z3cform.norobots added.
svn path=/plone.app.discussion/trunk/; revision=39848
2010-09-10 13:02:56 +00:00
Karl Johan Kleist
59dc83cb88 speling error in field description, closes #11093
svn path=/plone.app.discussion/trunk/; revision=39845
2010-09-10 05:00:47 +00:00
Patrick Gerken
823da240d8 Change datetime conversion to handle TZ
The way it happens now, the timezone gets corrected

svn path=/plone.app.discussion/trunk/; revision=39728
2010-09-07 12:03:31 +00:00
Patrick Gerken
697d9af803 Test that correct local time gets displayed.
Since we now store the utc time in comments, we display
code must not only format the date correctly, but show the correct
local time.

svn path=/plone.app.discussion/trunk/; revision=39727
2010-09-07 12:03:18 +00:00
Patrick Gerken
a7b1eb7c10 Change all datetime creations from now to utcnow
svn path=/plone.app.discussion/trunk/; revision=39726
2010-09-07 12:03:07 +00:00
Patrick Gerken
4e43cfed2e Adding a test to assert that dates get stored utc
and not in local time

svn path=/plone.app.discussion/trunk/; revision=39725
2010-09-07 12:02:55 +00:00
Timo Stollenwerk
68a264c9d9 Use unicode strings for test requests in test_comments_viewlet to make the Plone 3 tests happy.
svn path=/plone.app.discussion/trunk/; revision=39680
2010-09-06 10:40:06 +00:00
Timo Stollenwerk
0358a03d5b Fetch context for the comment view with "context = aq_inner(self.context)". This fixes a failing Plone 3 test.
svn path=/plone.app.discussion/trunk/; revision=39678
2010-09-06 10:38:54 +00:00
Timo Stollenwerk
288732d276 Removed unused imports from test_comments_viewlet tests.
svn path=/plone.app.discussion/trunk/; revision=39632
2010-09-03 21:57:36 +00:00
Timo Stollenwerk
a4011ce414 Fix the comment view test.
svn path=/plone.app.discussion/trunk/; revision=39629
2010-09-03 21:23:44 +00:00
Timo Stollenwerk
ea13020498 Raise an unauthorized error when authenticated users try to post a comment on a content object that has discussion disabled. Thanks to vincentfrentin for reporting this!
svn path=/plone.app.discussion/trunk/; revision=39627
2010-09-03 20:40:27 +00:00
Timo Stollenwerk
a410c72333 Complete comments form integration test.
svn path=/plone.app.discussion/trunk/; revision=39610
2010-09-02 20:52:33 +00:00
Timo Stollenwerk
4f4f9f9cec Fix whitespace for coverage test.
svn path=/plone.app.discussion/trunk/; revision=39609
2010-09-02 20:21:53 +00:00
Timo Stollenwerk
81cba38a74 Comment form test added.
svn path=/plone.app.discussion/trunk/; revision=39608
2010-09-02 20:00:43 +00:00
Radim Novotny
237d9170c5 Added Czech translation
svn path=/plone.app.discussion/trunk/; revision=39589
2010-09-01 08:53:39 +00:00
Vincent Fretin
4b15b31e51 Translate the subject and be sure to set the charset to utf-8 for the mail.
svn path=/plone.app.discussion/trunk/; revision=39587
2010-09-01 07:32:28 +00:00
Vincent Fretin
da81b1073b Fixed translation
svn path=/plone.app.discussion/trunk/; revision=39586
2010-09-01 07:30:14 +00:00
Vincent Fretin
0d2e23842e Removed empty description for text transform
svn path=/plone.app.discussion/trunk/; revision=39585
2010-09-01 07:25:04 +00:00
Vincent Fretin
72f715dd4a Updated French translation
svn path=/plone.app.discussion/trunk/; revision=39584
2010-09-01 07:23:34 +00:00
Vincent Fretin
c3f49298fb plone.app.discussion: 3 messages added
svn path=/plone.app.discussion/trunk/; revision=39583
2010-09-01 07:21:48 +00:00
Vincent Fretin
d5baae3eec Fixed variables in the template for use with the i18n machinery
svn path=/plone.app.discussion/trunk/; revision=39582
2010-09-01 07:19:51 +00:00
Vincent Fretin
f5bed31131 internationalize notification mail
svn path=/plone.app.discussion/trunk/; revision=39572
2010-08-31 18:07:51 +00:00
Timo Stollenwerk
87ce946947 Removed unused imports. Raise ImportError when import fails.
svn path=/plone.app.discussion/trunk/; revision=39571
2010-08-31 17:36:28 +00:00
Timo Stollenwerk
77d3bc2eb1 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39570
2010-08-31 17:33:22 +00:00
Timo Stollenwerk
d59369a408 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39569
2010-08-31 17:31:27 +00:00
Timo Stollenwerk
9c5f1dd1d8 Unused imports removed.
svn path=/plone.app.discussion/trunk/; revision=39568
2010-08-31 17:29:26 +00:00
Timo Stollenwerk
8d915b6327 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39567
2010-08-31 17:28:07 +00:00
Timo Stollenwerk
23122ded8b Test if registry has been registered.
svn path=/plone.app.discussion/trunk/; revision=39356
2010-08-28 22:58:23 +00:00
Timo Stollenwerk
dc160f9d5e Obey the 80 chars limit in the comments view.
svn path=/plone.app.discussion/trunk/; revision=39332
2010-08-28 20:19:58 +00:00
Timo Stollenwerk
785b006394 Obey the 80 chars limit in the migration function.
svn path=/plone.app.discussion/trunk/; revision=39331
2010-08-28 20:18:36 +00:00
Timo Stollenwerk
632e167806 revert 39237 since this breaks some tests.
svn path=/plone.app.discussion/trunk/; revision=39330
2010-08-28 20:10:48 +00:00
Timo Stollenwerk
a2a8956d09 Obey the 80 char limit.
svn path=/plone.app.discussion/trunk/; revision=39327
2010-08-28 20:02:08 +00:00
Timo Stollenwerk
cef90c576b remove author_username variable, because it is unused.
svn path=/plone.app.discussion/trunk/; revision=39325
2010-08-28 19:54:57 +00:00
Timo Stollenwerk
87b2c5dd02 Comment out author_notification because we don't use it right now.
svn path=/plone.app.discussion/trunk/; revision=39324
2010-08-28 19:51:53 +00:00
Timo Stollenwerk
946ff36190 "W0622 total_comments: Redefining built-in 'object'" added to pylint msg ignores.
svn path=/plone.app.discussion/trunk/; revision=39323
2010-08-28 19:48:40 +00:00
Timo Stollenwerk
318afe5aae Fix indentation.
svn path=/plone.app.discussion/trunk/; revision=39322
2010-08-28 19:45:53 +00:00
Timo Stollenwerk
4390b8929b Revert r39314. zptlint failed as expected. hudson integration works!
svn path=/plone.app.discussion/trunk/; revision=39319
2010-08-28 19:31:17 +00:00
Timo Stollenwerk
133da3d305 BREAK templates to check if zptlint in hudson works. Will be reverted immediately.
svn path=/plone.app.discussion/trunk/; revision=39314
2010-08-28 19:19:27 +00:00
Timo Stollenwerk
435040e0b2 Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39287
2010-08-28 17:06:53 +00:00
Timo Stollenwerk
0f9c98ec97 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39272
2010-08-28 16:11:58 +00:00
Timo Stollenwerk
5f5b831904 Be more specific, use ImportError.
svn path=/plone.app.discussion/trunk/; revision=39270
2010-08-28 16:08:36 +00:00
Timo Stollenwerk
e12d19a6e9 Fix bugs that have been introduced with the latest pylint "optimizations".
svn path=/plone.app.discussion/trunk/; revision=39269
2010-08-28 16:07:44 +00:00
Timo Stollenwerk
9264d2d42d Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39265
2010-08-28 15:35:21 +00:00
Timo Stollenwerk
ba8e7ac5cd Move the functions out of the ready function. this makes the JS tests pass.
svn path=/plone.app.discussion/trunk/; revision=39151
2010-08-27 21:26:37 +00:00
Timo Stollenwerk
67fb426f08 Javascript doc added.
svn path=/plone.app.discussion/trunk/; revision=39146
2010-08-27 20:52:38 +00:00
Timo Stollenwerk
f4435a563b Remove unnecessary init test. remove namespaces from method calls.
svn path=/plone.app.discussion/trunk/; revision=39145
2010-08-27 20:51:19 +00:00
Timo Stollenwerk
9e405b47a1 qunit files added.
svn path=/plone.app.discussion/trunk/; revision=39143
2010-08-27 20:50:18 +00:00
Timo Stollenwerk
a1605fb88b Revert r39104 since it breaks the comments js.
svn path=/plone.app.discussion/trunk/; revision=39141
2010-08-27 20:45:11 +00:00
Timo Stollenwerk
d713409aa1 Use a discussion JS namespace for comments.js; JS tests for clearForm and createReplyForm functions added.
svn path=/plone.app.discussion/trunk/; revision=39104
2010-08-27 17:11:25 +00:00
Timo Stollenwerk
2c5d387cfc Rename js directory to javascripts.
svn path=/plone.app.discussion/trunk/; revision=39066
2010-08-27 12:07:04 +00:00
Timo Stollenwerk
e310c1d021 Basic JS tests added.
svn path=/plone.app.discussion/trunk/; revision=39064
2010-08-27 11:41:39 +00:00
Timo Stollenwerk
d3074fa4fd Make Javascripts pass JSLint validation
svn path=/plone.app.discussion/trunk/; revision=39059
2010-08-27 10:34:42 +00:00
Timo Stollenwerk
61565de95a Put email notification subscribers into their own zcml file so it is easier for integrators to override them.
svn path=/plone.app.discussion/trunk/; revision=38981
2010-08-26 09:31:49 +00:00
Timo Stollenwerk
a2c89ed5e8 Plain text and intelligent text options for comment text added to preserve basic text structure and to make links clickable.
svn path=/plone.app.discussion/trunk/; revision=38931
2010-08-25 14:03:29 +00:00
Timo Stollenwerk
35d7743b7a Plain text to HTML transformation added for comment text
svn path=/plone.app.discussion/trunk/; revision=38898
2010-08-25 09:19:28 +00:00