Commit Graph

727 Commits

Author SHA1 Message Date
Timo Stollenwerk
f0ff6119cf "Clean up code with PyLint" added to changes.
svn path=/plone.app.discussion/trunk/; revision=39326
2010-08-28 19:55:58 +00:00
Timo Stollenwerk
cef90c576b remove author_username variable, because it is unused.
svn path=/plone.app.discussion/trunk/; revision=39325
2010-08-28 19:54:57 +00:00
Timo Stollenwerk
87b2c5dd02 Comment out author_notification because we don't use it right now.
svn path=/plone.app.discussion/trunk/; revision=39324
2010-08-28 19:51:53 +00:00
Timo Stollenwerk
946ff36190 "W0622 total_comments: Redefining built-in 'object'" added to pylint msg ignores.
svn path=/plone.app.discussion/trunk/; revision=39323
2010-08-28 19:48:40 +00:00
Timo Stollenwerk
318afe5aae Fix indentation.
svn path=/plone.app.discussion/trunk/; revision=39322
2010-08-28 19:45:53 +00:00
Timo Stollenwerk
4390b8929b Revert r39314. zptlint failed as expected. hudson integration works!
svn path=/plone.app.discussion/trunk/; revision=39319
2010-08-28 19:31:17 +00:00
Timo Stollenwerk
133da3d305 BREAK templates to check if zptlint in hudson works. Will be reverted immediately.
svn path=/plone.app.discussion/trunk/; revision=39314
2010-08-28 19:19:27 +00:00
Timo Stollenwerk
e37e48498b Write errors to the stout as well.
svn path=/plone.app.discussion/trunk/; revision=39313
2010-08-28 19:18:33 +00:00
Timo Stollenwerk
a1e81d4eaf exit with an error if zptlint fails.
svn path=/plone.app.discussion/trunk/; revision=39312
2010-08-28 19:12:31 +00:00
Timo Stollenwerk
0ea94c56ff fix typo in zptlint-test section.
svn path=/plone.app.discussion/trunk/; revision=39307
2010-08-28 18:23:38 +00:00
Timo Stollenwerk
f110dd6c40 pylint excludes updated; zptlint added.
svn path=/plone.app.discussion/trunk/; revision=39306
2010-08-28 18:21:54 +00:00
Timo Stollenwerk
42cad90262 omelette added; disable more pylint messages.
svn path=/plone.app.discussion/trunk/; revision=39288
2010-08-28 17:07:10 +00:00
Timo Stollenwerk
435040e0b2 Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39287
2010-08-28 17:06:53 +00:00
Timo Stollenwerk
0f9c98ec97 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39272
2010-08-28 16:11:58 +00:00
Timo Stollenwerk
5f5b831904 Be more specific, use ImportError.
svn path=/plone.app.discussion/trunk/; revision=39270
2010-08-28 16:08:36 +00:00
Timo Stollenwerk
e12d19a6e9 Fix bugs that have been introduced with the latest pylint "optimizations".
svn path=/plone.app.discussion/trunk/; revision=39269
2010-08-28 16:07:44 +00:00
Timo Stollenwerk
9264d2d42d Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39265
2010-08-28 15:35:21 +00:00
Timo Stollenwerk
487d5308a5 Fix jscoverage and pylint sections.
svn path=/plone.app.discussion/trunk/; revision=39248
2010-08-28 14:07:35 +00:00
Timo Stollenwerk
6b53b7bad2 buildout section to build jscoverage added.
svn path=/plone.app.discussion/trunk/; revision=39220
2010-08-28 12:27:39 +00:00
Timo Stollenwerk
7f8522672c jscoverage and pylint added to test buildout.
svn path=/plone.app.discussion/trunk/; revision=39218
2010-08-28 12:05:53 +00:00
Timo Stollenwerk
7aa09d45b2 jscoverage script added to dev buildout.
svn path=/plone.app.discussion/trunk/; revision=39156
2010-08-27 22:27:09 +00:00
Timo Stollenwerk
ba8e7ac5cd Move the functions out of the ready function. this makes the JS tests pass.
svn path=/plone.app.discussion/trunk/; revision=39151
2010-08-27 21:26:37 +00:00
Timo Stollenwerk
67fb426f08 Javascript doc added.
svn path=/plone.app.discussion/trunk/; revision=39146
2010-08-27 20:52:38 +00:00
Timo Stollenwerk
f4435a563b Remove unnecessary init test. remove namespaces from method calls.
svn path=/plone.app.discussion/trunk/; revision=39145
2010-08-27 20:51:19 +00:00
Timo Stollenwerk
9e405b47a1 qunit files added.
svn path=/plone.app.discussion/trunk/; revision=39143
2010-08-27 20:50:18 +00:00
Timo Stollenwerk
a1605fb88b Revert r39104 since it breaks the comments js.
svn path=/plone.app.discussion/trunk/; revision=39141
2010-08-27 20:45:11 +00:00
Timo Stollenwerk
d713409aa1 Use a discussion JS namespace for comments.js; JS tests for clearForm and createReplyForm functions added.
svn path=/plone.app.discussion/trunk/; revision=39104
2010-08-27 17:11:25 +00:00
Timo Stollenwerk
2c5d387cfc Rename js directory to javascripts.
svn path=/plone.app.discussion/trunk/; revision=39066
2010-08-27 12:07:04 +00:00
Timo Stollenwerk
e310c1d021 Basic JS tests added.
svn path=/plone.app.discussion/trunk/; revision=39064
2010-08-27 11:41:39 +00:00
Timo Stollenwerk
d3074fa4fd Make Javascripts pass JSLint validation
svn path=/plone.app.discussion/trunk/; revision=39059
2010-08-27 10:34:42 +00:00
Timo Stollenwerk
d4b4c56fe2 Fix coverage report section.
svn path=/plone.app.discussion/trunk/; revision=39041
2010-08-26 16:04:16 +00:00
Timo Stollenwerk
867e641465 Fix coveragereport script.
svn path=/plone.app.discussion/trunk/; revision=38987
2010-08-26 10:28:22 +00:00
Timo Stollenwerk
61565de95a Put email notification subscribers into their own zcml file so it is easier for integrators to override them.
svn path=/plone.app.discussion/trunk/; revision=38981
2010-08-26 09:31:49 +00:00
Timo Stollenwerk
a2c89ed5e8 Plain text and intelligent text options for comment text added to preserve basic text structure and to make links clickable.
svn path=/plone.app.discussion/trunk/; revision=38931
2010-08-25 14:03:29 +00:00
Timo Stollenwerk
35d7743b7a Plain text to HTML transformation added for comment text
svn path=/plone.app.discussion/trunk/; revision=38898
2010-08-25 09:19:28 +00:00
Vincent Fretin
5a379b7c4f Hum, I half committed my changes apparently
svn path=/plone.app.discussion/trunk/; revision=38896
2010-08-25 06:46:24 +00:00
Vincent Fretin
17fce9d515 Rewrote all tal:condition in comments.pt. The authenticated user has
the reply button and the comment form if he has the "Reply to item"
permission and the conversation is currently enabled.

Warning:
There is a security hole at the moment. Any authenticated user having the
zope2.View permission or anonymous user without captcha can add a comment
by creating a post request.

svn path=/plone.app.discussion/trunk/; revision=38888
2010-08-24 11:25:17 +00:00
Timo Stollenwerk
1579064ee6 Back to development: 1.0b7
svn path=/plone.app.discussion/trunk/; revision=38887
2010-08-24 09:19:09 +00:00
Timo Stollenwerk
94ebb54421 Update README to 1.0b6 as well.
svn path=/plone.app.discussion/trunk/; revision=38886
2010-08-24 09:18:30 +00:00
Timo Stollenwerk
aae3a522bd zest.releaser added to plone 4 dev buildout.
svn path=/plone.app.discussion/trunk/; revision=38885
2010-08-24 09:17:58 +00:00
Timo Stollenwerk
6d5d72f778 Prepare 1.0b6 release.
svn path=/plone.app.discussion/trunk/; revision=38883
2010-08-24 09:05:41 +00:00
Timo Stollenwerk
c6252d5116 Remove "exit-with-status" option from test section in the test-plone-4 buildout.
svn path=/plone.app.discussion/trunk/; revision=38882
2010-08-24 09:04:13 +00:00
Vincent Fretin
352a517a0a Fixed the case where a folder has allow_discussion=False and
conversation.enabled() on a document in this folder returned False
instead of True because of allow_discussion acquisition.

svn path=/plone.app.discussion/trunk/; revision=38835
2010-08-20 11:52:05 +00:00
Patrick Gerken
01bc4a778a added .mo files to git ignore
svn path=/plone.app.discussion/trunk/; revision=38821
2010-08-19 14:38:22 +00:00
Timo Stollenwerk
49db74fe3e Remove xmltestreport options that break the coverage report.
svn path=/plone.app.discussion/trunk/; revision=38676
2010-08-09 17:58:22 +00:00
Timo Stollenwerk
510ea5c272 Missing test part added.
svn path=/plone.app.discussion/trunk/; revision=38675
2010-08-09 16:58:38 +00:00
Timo Stollenwerk
f9766aeeb6 Test coverage added to test-plone4 buildout.
svn path=/plone.app.discussion/trunk/; revision=38666
2010-08-09 13:05:07 +00:00
Timo Stollenwerk
7a2f1ff12b Fix indentation.
svn path=/plone.app.discussion/trunk/; revision=38665
2010-08-09 12:42:21 +00:00
Timo Stollenwerk
d37d5aa9f5 Redirect to the comment form action instead of the absolute url when a comment is posted. This fixes the accidentially triggered file upload when a comment is posted on a file content object.
svn path=/plone.app.discussion/trunk/; revision=38664
2010-08-09 12:25:14 +00:00
Timo Stollenwerk
7fef29cf64 We are still on 1.0b6.
svn path=/plone.app.discussion/trunk/; revision=38663
2010-08-09 12:21:04 +00:00