Commit Graph
100 Commits
Author SHA1 Message Date
Timo Stollenwerk 689fd26c12 Apply the comment viewlet template and styles to the new title-less comments. This might require integrators to apply their custom templates and styles.
svn path=/plone.app.discussion/trunk/; revision=40433
2010-09-29 08:13:54 +00:00
Timo Stollenwerk 8d00463502 Remove subject line from comment batch moderation view, since this doesn't make sense anymore with auto-generated titles.
svn path=/plone.app.discussion/trunk/; revision=40432
2010-09-29 08:02:39 +00:00
Timo Stollenwerk f67c7cde6d Remove title field from the comment form and replace it with an auto-generated title ("John Doe on Welcome to Plone").
This also fixes http://dev.plone.org/plone/ticket/11098

svn path=/plone.app.discussion/trunk/; revision=40431
2010-09-29 07:56:36 +00:00
Timo Stollenwerk f2f2dd524f Use the right trac link for the __parent__ pointer fix.
svn path=/plone.app.discussion/trunk/; revision=40427
2010-09-29 06:48:36 +00:00
Timo Stollenwerk e603494a83 Do not use https links in CHANGES.txt.
svn path=/plone.app.discussion/trunk/; revision=40426
2010-09-29 06:46:57 +00:00
Timo Stollenwerk f243929662 Fetch the testing dependencies.
svn path=/plone.app.discussion/trunk/; revision=40394
2010-09-28 16:36:50 +00:00
Timo Stollenwerk 7df932204c Functional plone.testing doctest added.
svn path=/plone.app.discussion/trunk/; revision=40393
2010-09-28 16:35:45 +00:00
Timo Stollenwerk 0259c1298f Add proper credits to the last CHANGES entry.
svn path=/plone.app.discussion/trunk/; revision=40391
2010-09-28 16:00:08 +00:00
Timo Stollenwerk 138942470c Make sure the __parent__ pointer (the conversation) of a comment is not acquisition wrapped in conversation.addComment. This fixes Refs #11157.
svn path=/plone.app.discussion/trunk/; revision=40374
2010-09-28 10:37:40 +00:00
Timo Stollenwerk a55ff5b883 Fix pickle regression test.
svn path=/plone.app.discussion/trunk/; revision=40373
2010-09-28 10:18:16 +00:00
Timo Stollenwerk 77e44f96ad Added test (currently failing) to trigger "can't pickle objects in acquisition wrapper". Refs #11157
svn path=/plone.app.discussion/trunk/; revision=40357
2010-09-27 19:03:43 +00:00
Timo Stollenwerk c444c74680 Explicit plain, html, and xml coverage report sections added.
svn path=/plone.app.discussion/trunk/; revision=40237
2010-09-24 23:12:38 +00:00
Timo Stollenwerk d70f236ed9 Fix tests directory exclusion, added htmlreport section.
svn path=/plone.app.discussion/trunk/; revision=40235
2010-09-24 22:45:10 +00:00
Timo Stollenwerk 32702896b5 Fix coverage report.
svn path=/plone.app.discussion/trunk/; revision=40234
2010-09-24 22:26:57 +00:00
Timo Stollenwerk 58868c55e7 whitespace.
svn path=/plone.app.discussion/trunk/; revision=40232
2010-09-24 19:45:57 +00:00
Timo Stollenwerk d736bfe0b1 Remove unused parts.
svn path=/plone.app.discussion/trunk/; revision=40231
2010-09-24 19:37:01 +00:00
Timo Stollenwerk a33ec8a049 Revert r40080 since this broke the coverage report.
svn path=/plone.app.discussion/trunk/; revision=40230
2010-09-24 19:27:59 +00:00
Timo Stollenwerk e95ae26a11 Fix moderation test headline.
svn path=/plone.app.discussion/trunk/; revision=40229
2010-09-24 19:04:35 +00:00
Timo Stollenwerk cf11a5134a Javascript tests for the bulk moderation view added (currently failing).
svn path=/plone.app.discussion/trunk/; revision=40228
2010-09-24 19:04:03 +00:00
Timo Stollenwerk ad99e45203 Revert r35608 since this was breaking the comment moderation bulk actions. The BulkActionsView expects the absolute path of the comments without the portal url (e.g. '/plone/doc1/++conversation++default/1285346769126020'). This fixes https://dev.plone.org/plone/ticket/11156.
svn path=/plone.app.discussion/trunk/; revision=40227
2010-09-24 17:04:24 +00:00
Timo Stollenwerk 2ff95fe847 Make sure the moderation JS functions are executed after the page is fully loaded.
svn path=/plone.app.discussion/trunk/; revision=40215
2010-09-24 14:57:19 +00:00
Timo Stollenwerk 399bba5eca Use "(function($) { /* some code that uses $ */ })(jQuery)" instead of "$(document).ready(function(){ /* some code that uses $ */ });" to invoke jQuery code.
svn path=/plone.app.discussion/trunk/; revision=40214
2010-09-24 14:21:26 +00:00
Timo Stollenwerk 4ec334b3d4 Workflow documentation added (first rough draft).
svn path=/plone.app.discussion/trunk/; revision=40206
2010-09-24 13:35:21 +00:00
Timo Stollenwerk 57758d2cf8 More workflow tests.
svn path=/plone.app.discussion/trunk/; revision=40203
2010-09-24 13:33:21 +00:00
Timo Stollenwerk ea26c70eed Clean up whitespace, change workflow description.
svn path=/plone.app.discussion/trunk/; revision=40192
2010-09-24 03:12:12 +00:00
Timo Stollenwerk 41c9d030d8 Clean up whitespace, change workflow description.
svn path=/plone.app.discussion/trunk/; revision=40191
2010-09-24 03:11:39 +00:00
Timo Stollenwerk d77ca9d583 Commenting form explanation added.
svn path=/plone.app.discussion/trunk/; revision=40167
2010-09-23 14:46:24 +00:00
Timo Stollenwerk c364630a8c js test for comments updated.
svn path=/plone.app.discussion/trunk/; revision=40166
2010-09-23 14:42:18 +00:00
Timo Stollenwerk 9d0fa61c4d Remove unnecessary XXX since we already use layers.
svn path=/plone.app.discussion/trunk/; revision=40165
2010-09-23 12:56:17 +00:00
Timo Stollenwerk f1cf4c9688 Translation files updated.
svn path=/plone.app.discussion/trunk/; revision=40154
2010-09-23 11:06:38 +00:00
Timo Stollenwerk 0cee7c541d Finnish translation added.
svn path=/plone.app.discussion/trunk/; revision=40153
2010-09-23 11:04:47 +00:00
Timo Stollenwerk 7b9a84dfbe Fix coverage report.
svn path=/plone.app.discussion/trunk/; revision=40110
2010-09-21 17:30:34 +00:00
Timo Stollenwerk 6b4fd0f0c1 Ignore certain lines for code coverage.
svn path=/plone.app.discussion/trunk/; revision=40083
2010-09-20 10:03:55 +00:00
Timo Stollenwerk cbde125048 Ignore certain lines for code coverage.
svn path=/plone.app.discussion/trunk/; revision=40082
2010-09-20 10:03:38 +00:00
Timo Stollenwerk aeabd6fc11 Ignore certain lines for code coverage.
svn path=/plone.app.discussion/trunk/; revision=40081
2010-09-20 10:02:07 +00:00
Timo Stollenwerk 9f605ab53b Fix coverage.
svn path=/plone.app.discussion/trunk/; revision=40080
2010-09-20 09:58:40 +00:00
Timo Stollenwerk 4b3473f74b Always provide that path param for bulk action view tests.
svn path=/plone.app.discussion/trunk/; revision=40004
2010-09-18 17:02:37 +00:00
Timo Stollenwerk bf7687364b Use coverage instead of z3c.coverage.
svn path=/plone.app.discussion/trunk/; revision=40003
2010-09-18 16:59:58 +00:00
Timo Stollenwerk 14c0a3a4d1 Remove wrong_bulkaction test.
svn path=/plone.app.discussion/trunk/; revision=39946
2010-09-16 15:44:07 +00:00
Timo Stollenwerk e8a4caa5db Some more tests for moderation bulk actions.
svn path=/plone.app.discussion/trunk/; revision=39945
2010-09-16 15:42:27 +00:00
Timo Stollenwerk 742412a7d8 Test publish bulk actions as well.
svn path=/plone.app.discussion/trunk/; revision=39943
2010-09-16 15:12:59 +00:00
Timo Stollenwerk 8d866a0ff6 Tests for moderate comments bulk actions added.
svn path=/plone.app.discussion/trunk/; revision=39942
2010-09-16 14:58:11 +00:00
Timo Stollenwerk 087efab54a Trying to fix the comments viewlet functional tests on Plone 3.x.
svn path=/plone.app.discussion/trunk/; revision=39932
2010-09-16 12:41:01 +00:00
Timo Stollenwerk 7502abe032 Fix coverage test.
svn path=/plone.app.discussion/trunk/; revision=39931
2010-09-16 11:46:25 +00:00
Timo Stollenwerk a42fb93c1c Restrict the coverage-test to plone.app.discussion.
svn path=/plone.app.discussion/trunk/; revision=39930
2010-09-16 11:36:17 +00:00
Timo Stollenwerk d3e2445b8a sphinx upload script added.
svn path=/plone.app.discussion/trunk/; revision=39929
2010-09-16 10:53:21 +00:00
Timo Stollenwerk 223e9167b4 Sphinx updated: notification subscribers are in notifications.zcml now.
svn path=/plone.app.discussion/trunk/; revision=39928
2010-09-16 10:50:27 +00:00
Timo Stollenwerk da9b61c120 collective.z3cform.norobots added to add-on section.
svn path=/plone.app.discussion/trunk/; revision=39927
2010-09-16 10:03:33 +00:00
Timo Stollenwerk 110d84cdcd Run code coverage on p.a.discussion package only.
svn path=/plone.app.discussion/trunk/; revision=39926
2010-09-16 08:23:51 +00:00
Timo Stollenwerk ff3391f23e Update version to 1.0b7 in README.
svn path=/plone.app.discussion/trunk/; revision=39902
2010-09-15 11:52:24 +00:00
Timo Stollenwerk 4137548d64 Back to development: 1.0b8
svn path=/plone.app.discussion/trunk/; revision=39901
2010-09-15 11:40:19 +00:00
Timo Stollenwerk d0dd7aabb6 Preparing release 1.0b7
svn path=/plone.app.discussion/trunk/; revision=39899
2010-09-15 11:38:20 +00:00
Timo Stollenwerk 300f696921 Prepare 1.0b7 release.
svn path=/plone.app.discussion/trunk/; revision=39898
2010-09-15 11:32:37 +00:00
Timo Stollenwerk 4dd2f87e4c Give saffe the appropriate credits.
svn path=/plone.app.discussion/trunk/; revision=39870
2010-09-13 14:35:40 +00:00
Timo Stollenwerk 3d594a934d Captcha plugin support for collective.z3cform.norobots added.
svn path=/plone.app.discussion/trunk/; revision=39848
2010-09-10 13:02:56 +00:00
Timo Stollenwerk 2aaf74ddd3 Use the pad trunk from c.z.norobots.
svn path=/plone.app.discussion/trunk/; revision=39847
2010-09-10 13:02:38 +00:00
Timo Stollenwerk f92d723b2b Use the Plone 4 test buildout as a basis for the dev buildout.
svn path=/plone.app.discussion/trunk/; revision=39846
2010-09-10 12:33:40 +00:00
Timo Stollenwerk 68a264c9d9 Use unicode strings for test requests in test_comments_viewlet to make the Plone 3 tests happy.
svn path=/plone.app.discussion/trunk/; revision=39680
2010-09-06 10:40:06 +00:00
Timo Stollenwerk f918b7698b Fetch context for the comment view with "context = aq_inner(self.context)". This fixes a failing Plone 3 test.
svn path=/plone.app.discussion/trunk/; revision=39679
2010-09-06 10:39:07 +00:00
Timo Stollenwerk 0358a03d5b Fetch context for the comment view with "context = aq_inner(self.context)". This fixes a failing Plone 3 test.
svn path=/plone.app.discussion/trunk/; revision=39678
2010-09-06 10:38:54 +00:00
Timo Stollenwerk abdab3c12e Use 1.0b6 KGS from good-py.
svn path=/plone.app.discussion/trunk/; revision=39677
2010-09-06 10:05:18 +00:00
Timo Stollenwerk 288732d276 Removed unused imports from test_comments_viewlet tests.
svn path=/plone.app.discussion/trunk/; revision=39632
2010-09-03 21:57:36 +00:00
Timo Stollenwerk 2fda1455d4 Remove zope.testing version pinning since it does not avoid the teardown failure in coverage-test.
svn path=/plone.app.discussion/trunk/; revision=39631
2010-09-03 21:50:12 +00:00
Timo Stollenwerk a4011ce414 Fix the comment view test.
svn path=/plone.app.discussion/trunk/; revision=39629
2010-09-03 21:23:44 +00:00
Timo Stollenwerk 34f1106748 Pylint: "E1121 Too many positional arguments for function call" added to ignore list; pinning zope.testing to 3.9.5 to avoid coverage-test failure.
svn path=/plone.app.discussion/trunk/; revision=39628
2010-09-03 21:01:22 +00:00
Timo Stollenwerk ea13020498 Raise an unauthorized error when authenticated users try to post a comment on a content object that has discussion disabled. Thanks to vincentfrentin for reporting this!
svn path=/plone.app.discussion/trunk/; revision=39627
2010-09-03 20:40:27 +00:00
Timo Stollenwerk a410c72333 Complete comments form integration test.
svn path=/plone.app.discussion/trunk/; revision=39610
2010-09-02 20:52:33 +00:00
Timo Stollenwerk 4f4f9f9cec Fix whitespace for coverage test.
svn path=/plone.app.discussion/trunk/; revision=39609
2010-09-02 20:21:53 +00:00
Timo Stollenwerk 81cba38a74 Comment form test added.
svn path=/plone.app.discussion/trunk/; revision=39608
2010-09-02 20:00:43 +00:00
Timo Stollenwerk d0914c072e Changelog updated (Czech translation added).
svn path=/plone.app.discussion/trunk/; revision=39590
2010-09-01 08:58:46 +00:00
Timo Stollenwerk 87ce946947 Removed unused imports. Raise ImportError when import fails.
svn path=/plone.app.discussion/trunk/; revision=39571
2010-08-31 17:36:28 +00:00
Timo Stollenwerk 77d3bc2eb1 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39570
2010-08-31 17:33:22 +00:00
Timo Stollenwerk d59369a408 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39569
2010-08-31 17:31:27 +00:00
Timo Stollenwerk 9c5f1dd1d8 Unused imports removed.
svn path=/plone.app.discussion/trunk/; revision=39568
2010-08-31 17:29:26 +00:00
Timo Stollenwerk 8d915b6327 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39567
2010-08-31 17:28:07 +00:00
Timo Stollenwerk 23122ded8b Test if registry has been registered.
svn path=/plone.app.discussion/trunk/; revision=39356
2010-08-28 22:58:23 +00:00
Timo Stollenwerk c530e2dbf3 use package-directory param for more flexibility.
svn path=/plone.app.discussion/trunk/; revision=39355
2010-08-28 22:57:47 +00:00
Timo Stollenwerk dc160f9d5e Obey the 80 chars limit in the comments view.
svn path=/plone.app.discussion/trunk/; revision=39332
2010-08-28 20:19:58 +00:00
Timo Stollenwerk 785b006394 Obey the 80 chars limit in the migration function.
svn path=/plone.app.discussion/trunk/; revision=39331
2010-08-28 20:18:36 +00:00
Timo Stollenwerk 632e167806 revert 39237 since this breaks some tests.
svn path=/plone.app.discussion/trunk/; revision=39330
2010-08-28 20:10:48 +00:00
Timo Stollenwerk a2a8956d09 Obey the 80 char limit.
svn path=/plone.app.discussion/trunk/; revision=39327
2010-08-28 20:02:08 +00:00
Timo Stollenwerk f0ff6119cf "Clean up code with PyLint" added to changes.
svn path=/plone.app.discussion/trunk/; revision=39326
2010-08-28 19:55:58 +00:00
Timo Stollenwerk cef90c576b remove author_username variable, because it is unused.
svn path=/plone.app.discussion/trunk/; revision=39325
2010-08-28 19:54:57 +00:00
Timo Stollenwerk 87b2c5dd02 Comment out author_notification because we don't use it right now.
svn path=/plone.app.discussion/trunk/; revision=39324
2010-08-28 19:51:53 +00:00
Timo Stollenwerk 946ff36190 "W0622 total_comments: Redefining built-in 'object'" added to pylint msg ignores.
svn path=/plone.app.discussion/trunk/; revision=39323
2010-08-28 19:48:40 +00:00
Timo Stollenwerk 318afe5aae Fix indentation.
svn path=/plone.app.discussion/trunk/; revision=39322
2010-08-28 19:45:53 +00:00
Timo Stollenwerk 4390b8929b Revert r39314. zptlint failed as expected. hudson integration works!
svn path=/plone.app.discussion/trunk/; revision=39319
2010-08-28 19:31:17 +00:00
Timo Stollenwerk 133da3d305 BREAK templates to check if zptlint in hudson works. Will be reverted immediately.
svn path=/plone.app.discussion/trunk/; revision=39314
2010-08-28 19:19:27 +00:00
Timo Stollenwerk e37e48498b Write errors to the stout as well.
svn path=/plone.app.discussion/trunk/; revision=39313
2010-08-28 19:18:33 +00:00
Timo Stollenwerk a1e81d4eaf exit with an error if zptlint fails.
svn path=/plone.app.discussion/trunk/; revision=39312
2010-08-28 19:12:31 +00:00
Timo Stollenwerk 0ea94c56ff fix typo in zptlint-test section.
svn path=/plone.app.discussion/trunk/; revision=39307
2010-08-28 18:23:38 +00:00
Timo Stollenwerk f110dd6c40 pylint excludes updated; zptlint added.
svn path=/plone.app.discussion/trunk/; revision=39306
2010-08-28 18:21:54 +00:00
Timo Stollenwerk 42cad90262 omelette added; disable more pylint messages.
svn path=/plone.app.discussion/trunk/; revision=39288
2010-08-28 17:07:10 +00:00
Timo Stollenwerk 435040e0b2 Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39287
2010-08-28 17:06:53 +00:00
Timo Stollenwerk 0f9c98ec97 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39272
2010-08-28 16:11:58 +00:00
Timo Stollenwerk 5f5b831904 Be more specific, use ImportError.
svn path=/plone.app.discussion/trunk/; revision=39270
2010-08-28 16:08:36 +00:00
Timo Stollenwerk e12d19a6e9 Fix bugs that have been introduced with the latest pylint "optimizations".
svn path=/plone.app.discussion/trunk/; revision=39269
2010-08-28 16:07:44 +00:00
Timo Stollenwerk 9264d2d42d Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39265
2010-08-28 15:35:21 +00:00
Timo Stollenwerk 487d5308a5 Fix jscoverage and pylint sections.
svn path=/plone.app.discussion/trunk/; revision=39248
2010-08-28 14:07:35 +00:00
Timo Stollenwerk 6b53b7bad2 buildout section to build jscoverage added.
svn path=/plone.app.discussion/trunk/; revision=39220
2010-08-28 12:27:39 +00:00