Commit Graph

979 Commits

Author SHA1 Message Date
Timo Stollenwerk
81dcdeaea3 Disable the plone.app.registry check on schema elements, so no error is raised on upgrades. This fixes https://dev.plone.org/plone/ticket/11195. Refs #11195
svn path=/plone.app.discussion/trunk/; revision=40868
2010-10-29 10:43:46 +00:00
Timo Stollenwerk
f6b7ef1bcb Remove the too generic id attribute of the comment form.
svn path=/plone.app.discussion/trunk/; revision=40858
2010-10-28 10:30:10 +00:00
Timo Stollenwerk
777e687169 Rename the id of the comment form from "form" to "comment-form".
svn path=/plone.app.discussion/trunk/; revision=40857
2010-10-28 09:45:34 +00:00
Timo Stollenwerk
22e4189c37 Revert revisions r40851 to r40853, they should have gone into the ajax-ui branch.
svn path=/plone.app.discussion/trunk/; revision=40856
2010-10-28 09:39:00 +00:00
Timo Stollenwerk
14e2600a79 Make ajax call for delete comment button work for comment replies.
svn path=/plone.app.discussion/trunk/; revision=40853
2010-10-27 16:10:04 +00:00
Timo Stollenwerk
926e4f6b8e Integrate Denys ajax ui code.
svn path=/plone.app.discussion/trunk/; revision=40852
2010-10-27 14:44:52 +00:00
Timo Stollenwerk
79f4481722 Use "#comment-form" as id for the comment form instead of "#form" which is too generic.
svn path=/plone.app.discussion/trunk/; revision=40851
2010-10-27 14:44:06 +00:00
Hanno Schlichting
aa8a1ea934 Fixed handling of non-ascii member data, like fullname and email.
svn path=/plone.app.discussion/trunk/; revision=40789
2010-10-22 10:14:07 +00:00
Hanno Schlichting
54bbb08c62 Whitespace removal
svn path=/plone.app.discussion/trunk/; revision=40788
2010-10-22 09:57:55 +00:00
Andreas Jung
8fc3dda8e6 wrong language-code
svn path=/plone.app.discussion/trunk/; revision=40586
2010-10-11 09:37:28 +00:00
Radim Novotny
18e92f7a85 - Fixed "global name 'WrongCaptchaCode' is not defined" if norobots captcha,
but no other validation package is installed.

svn path=/plone.app.discussion/trunk/; revision=40574
2010-10-09 11:13:28 +00:00
Timo Stollenwerk
f7ed357a83 Use 'comment_review_workflow' instead of 'simple_publication_workflow' for testing.
svn path=/plone.app.discussion/trunk/; revision=40571
2010-10-08 11:03:14 +00:00
Timo Stollenwerk
324d2274bd Check for a 'pending' state in the current comment workflow instead of checking for the 'comment_review' workflow. Refs #11184. Merge last three submits in CHANGES.txt.
svn path=/plone.app.discussion/trunk/; revision=40570
2010-10-08 10:37:10 +00:00
Timo Stollenwerk
6e9bb4a9cd Check the review_state to decide if moderation is enabled. If the current comment workflow implements a 'pending' state, moderation is enabled. Refs #11184.
svn path=/plone.app.discussion/trunk/; revision=40569
2010-10-08 10:22:40 +00:00
Timo Stollenwerk
2790e6d4eb Check the review_state instead of the workflow after a comment has been posted to decide if a message is shown to the user. This allows integrators to use custom review workflows. Refs #11184
svn path=/plone.app.discussion/trunk/; revision=40566
2010-10-08 09:53:00 +00:00
Timo Stollenwerk
43d3222086 Run functional tests only with Plone 4 (and plone.testing).
svn path=/plone.app.discussion/trunk/; revision=40537
2010-10-06 15:12:11 +00:00
Timo Stollenwerk
94584429fd Do not use has_key.
svn path=/plone.app.discussion/trunk/; revision=40536
2010-10-06 14:12:30 +00:00
Timo Stollenwerk
4bbfe677e4 Replace the can_manage method with a can_review method that checks the 'Review comments' permission. This fixes http://dev.plone.org/plone/ticket/11145.
svn path=/plone.app.discussion/trunk/; revision=40534
2010-10-06 13:55:57 +00:00
Timo Stollenwerk
3e73903a8d Remove (old) functional test.
svn path=/plone.app.discussion/trunk/; revision=40533
2010-10-06 13:53:07 +00:00
Timo Stollenwerk
1230e67a01 Functional test for comment_review_workflow added; existing fonctional test renamed to functional_test_comments.txt;
svn path=/plone.app.discussion/trunk/; revision=40532
2010-10-06 13:52:11 +00:00
Timo Stollenwerk
1db321a044 Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=40527
2010-10-06 09:02:26 +00:00
Timo Stollenwerk
f9ca4497bd Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=40526
2010-10-06 08:47:24 +00:00
Timo Stollenwerk
94b0c58511 Fix pylint disable-msg statements.
svn path=/plone.app.discussion/trunk/; revision=40521
2010-10-05 15:54:49 +00:00
Timo Stollenwerk
fbb042c012 Remove unused import.
svn path=/plone.app.discussion/trunk/; revision=40520
2010-10-05 15:52:19 +00:00
Timo Stollenwerk
773345c40f Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=40519
2010-10-05 15:47:02 +00:00
Timo Stollenwerk
7de585542b Fix moderation actions (publish, delete) in the moderation view with virtual hosts. This is a replacement for http://dev.plone.org/plone/changeset/35608.
svn path=/plone.app.discussion/trunk/; revision=40518
2010-10-05 15:21:54 +00:00
Timo Stollenwerk
b984a445d5 Inline documentation for moderation view added.
svn path=/plone.app.discussion/trunk/; revision=40517
2010-10-05 15:14:12 +00:00
Timo Stollenwerk
7e42a39346 Remove .mo file from subversion.
svn path=/plone.app.discussion/trunk/; revision=40516
2010-10-05 14:07:39 +00:00
Timo Stollenwerk
837e6b2966 Do not show two "login to add comments" buttons when there are no comments yet. This fixes http://plone.org/products/plone.app.discussion/issues/12.
svn path=/plone.app.discussion/trunk/; revision=40515
2010-10-05 12:07:08 +00:00
Timo Stollenwerk
51642c2e0f German translations updated.
svn path=/plone.app.discussion/trunk/; revision=40506
2010-10-04 18:59:42 +00:00
Timo Stollenwerk
9841ba7229 Remove unnecessary decode statement from creator.
svn path=/plone.app.discussion/trunk/; revision=40503
2010-10-04 13:48:54 +00:00
Timo Stollenwerk
0ee649fb6c Functional test for special characters added. Remove unnecessary decode statement from creator.
svn path=/plone.app.discussion/trunk/; revision=40502
2010-10-04 13:48:27 +00:00
Timo Stollenwerk
b06ba43a75 Ignore currently unused code from code coverage. Overall code coverage is up to 95%.
svn path=/plone.app.discussion/trunk/; revision=40497
2010-10-03 19:54:59 +00:00
Timo Stollenwerk
6d92d1383c Remove comment title from comments viewlet tests.
svn path=/plone.app.discussion/trunk/; revision=40496
2010-10-03 19:41:02 +00:00
Timo Stollenwerk
ede295e649 Functional test for posting a comment with comment review workflow enabled.
svn path=/plone.app.discussion/trunk/; revision=40495
2010-10-03 19:07:30 +00:00
Timo Stollenwerk
603bcf3547 Ignore certain lines for code coverage.
svn path=/plone.app.discussion/trunk/; revision=40494
2010-10-03 16:52:26 +00:00
Timo Stollenwerk
f5cf756e31 Functional test for replying to an existing comment added.
svn path=/plone.app.discussion/trunk/; revision=40493
2010-10-03 16:50:47 +00:00
Timo Stollenwerk
497c2a075e There is no need to set the title in the handleComment method anymore.
svn path=/plone.app.discussion/trunk/; revision=40492
2010-10-03 07:29:44 +00:00
Timo Stollenwerk
e0055d0ba7 Make sure comment titles work with special characters as well.
svn path=/plone.app.discussion/trunk/; revision=40486
2010-10-02 18:16:49 +00:00
Timo Stollenwerk
51d6c60412 Use the right event subscriber to make sure all comments are removed from the catalog, if their content object is deleted.
svn path=/plone.app.discussion/trunk/; revision=40485
2010-10-02 14:50:17 +00:00
Luca Fabbri
1edbf3a262 italian translation updated
svn path=/plone.app.discussion/trunk/; revision=40461
2010-09-30 22:00:24 +00:00
Luca Fabbri
2d603c2c0e italian translation updated
svn path=/plone.app.discussion/trunk/; revision=40460
2010-09-30 21:52:40 +00:00
Timo Stollenwerk
0e27b8b7b6 Move regression test for #11157 into the main functional test.
svn path=/plone.app.discussion/trunk/; revision=40458
2010-09-30 17:45:26 +00:00
Timo Stollenwerk
22db0b1c78 Fix comment title for anonymous commentators that do not provide a name.
svn path=/plone.app.discussion/trunk/; revision=40435
2010-09-29 10:52:11 +00:00
Timo Stollenwerk
2cce7e0d0f "Post comment as logged-in users" test added.
svn path=/plone.app.discussion/trunk/; revision=40434
2010-09-29 10:17:25 +00:00
Timo Stollenwerk
689fd26c12 Apply the comment viewlet template and styles to the new title-less comments. This might require integrators to apply their custom templates and styles.
svn path=/plone.app.discussion/trunk/; revision=40433
2010-09-29 08:13:54 +00:00
Timo Stollenwerk
8d00463502 Remove subject line from comment batch moderation view, since this doesn't make sense anymore with auto-generated titles.
svn path=/plone.app.discussion/trunk/; revision=40432
2010-09-29 08:02:39 +00:00
Timo Stollenwerk
f67c7cde6d Remove title field from the comment form and replace it with an auto-generated title ("John Doe on Welcome to Plone").
This also fixes http://dev.plone.org/plone/ticket/11098

svn path=/plone.app.discussion/trunk/; revision=40431
2010-09-29 07:56:36 +00:00
Timo Stollenwerk
7df932204c Functional plone.testing doctest added.
svn path=/plone.app.discussion/trunk/; revision=40393
2010-09-28 16:35:45 +00:00
Timo Stollenwerk
138942470c Make sure the __parent__ pointer (the conversation) of a comment is not acquisition wrapped in conversation.addComment. This fixes Refs #11157.
svn path=/plone.app.discussion/trunk/; revision=40374
2010-09-28 10:37:40 +00:00
Timo Stollenwerk
a55ff5b883 Fix pickle regression test.
svn path=/plone.app.discussion/trunk/; revision=40373
2010-09-28 10:18:16 +00:00
Timo Stollenwerk
77e44f96ad Added test (currently failing) to trigger "can't pickle objects in acquisition wrapper". Refs #11157
svn path=/plone.app.discussion/trunk/; revision=40357
2010-09-27 19:03:43 +00:00
Timo Stollenwerk
58868c55e7 whitespace.
svn path=/plone.app.discussion/trunk/; revision=40232
2010-09-24 19:45:57 +00:00
Timo Stollenwerk
e95ae26a11 Fix moderation test headline.
svn path=/plone.app.discussion/trunk/; revision=40229
2010-09-24 19:04:35 +00:00
Timo Stollenwerk
cf11a5134a Javascript tests for the bulk moderation view added (currently failing).
svn path=/plone.app.discussion/trunk/; revision=40228
2010-09-24 19:04:03 +00:00
Timo Stollenwerk
ad99e45203 Revert r35608 since this was breaking the comment moderation bulk actions. The BulkActionsView expects the absolute path of the comments without the portal url (e.g. '/plone/doc1/++conversation++default/1285346769126020'). This fixes https://dev.plone.org/plone/ticket/11156.
svn path=/plone.app.discussion/trunk/; revision=40227
2010-09-24 17:04:24 +00:00
Timo Stollenwerk
2ff95fe847 Make sure the moderation JS functions are executed after the page is fully loaded.
svn path=/plone.app.discussion/trunk/; revision=40215
2010-09-24 14:57:19 +00:00
Timo Stollenwerk
399bba5eca Use "(function($) { /* some code that uses $ */ })(jQuery)" instead of "$(document).ready(function(){ /* some code that uses $ */ });" to invoke jQuery code.
svn path=/plone.app.discussion/trunk/; revision=40214
2010-09-24 14:21:26 +00:00
Timo Stollenwerk
57758d2cf8 More workflow tests.
svn path=/plone.app.discussion/trunk/; revision=40203
2010-09-24 13:33:21 +00:00
Timo Stollenwerk
ea26c70eed Clean up whitespace, change workflow description.
svn path=/plone.app.discussion/trunk/; revision=40192
2010-09-24 03:12:12 +00:00
Timo Stollenwerk
41c9d030d8 Clean up whitespace, change workflow description.
svn path=/plone.app.discussion/trunk/; revision=40191
2010-09-24 03:11:39 +00:00
Timo Stollenwerk
d77ca9d583 Commenting form explanation added.
svn path=/plone.app.discussion/trunk/; revision=40167
2010-09-23 14:46:24 +00:00
Timo Stollenwerk
c364630a8c js test for comments updated.
svn path=/plone.app.discussion/trunk/; revision=40166
2010-09-23 14:42:18 +00:00
Timo Stollenwerk
9d0fa61c4d Remove unnecessary XXX since we already use layers.
svn path=/plone.app.discussion/trunk/; revision=40165
2010-09-23 12:56:17 +00:00
Timo Stollenwerk
f1cf4c9688 Translation files updated.
svn path=/plone.app.discussion/trunk/; revision=40154
2010-09-23 11:06:38 +00:00
Timo Stollenwerk
0cee7c541d Finnish translation added.
svn path=/plone.app.discussion/trunk/; revision=40153
2010-09-23 11:04:47 +00:00
Radim Novotny
685fc2874d Updated Czech i18n
svn path=/plone.app.discussion/trunk/; revision=40140
2010-09-22 15:03:04 +00:00
Timo Stollenwerk
6b4fd0f0c1 Ignore certain lines for code coverage.
svn path=/plone.app.discussion/trunk/; revision=40083
2010-09-20 10:03:55 +00:00
Timo Stollenwerk
cbde125048 Ignore certain lines for code coverage.
svn path=/plone.app.discussion/trunk/; revision=40082
2010-09-20 10:03:38 +00:00
Timo Stollenwerk
aeabd6fc11 Ignore certain lines for code coverage.
svn path=/plone.app.discussion/trunk/; revision=40081
2010-09-20 10:02:07 +00:00
Timo Stollenwerk
4b3473f74b Always provide that path param for bulk action view tests.
svn path=/plone.app.discussion/trunk/; revision=40004
2010-09-18 17:02:37 +00:00
Timo Stollenwerk
14c0a3a4d1 Remove wrong_bulkaction test.
svn path=/plone.app.discussion/trunk/; revision=39946
2010-09-16 15:44:07 +00:00
Timo Stollenwerk
e8a4caa5db Some more tests for moderation bulk actions.
svn path=/plone.app.discussion/trunk/; revision=39945
2010-09-16 15:42:27 +00:00
Timo Stollenwerk
742412a7d8 Test publish bulk actions as well.
svn path=/plone.app.discussion/trunk/; revision=39943
2010-09-16 15:12:59 +00:00
Timo Stollenwerk
8d866a0ff6 Tests for moderate comments bulk actions added.
svn path=/plone.app.discussion/trunk/; revision=39942
2010-09-16 14:58:11 +00:00
Timo Stollenwerk
087efab54a Trying to fix the comments viewlet functional tests on Plone 3.x.
svn path=/plone.app.discussion/trunk/; revision=39932
2010-09-16 12:41:01 +00:00
Timo Stollenwerk
3d594a934d Captcha plugin support for collective.z3cform.norobots added.
svn path=/plone.app.discussion/trunk/; revision=39848
2010-09-10 13:02:56 +00:00
Karl Johan Kleist
59dc83cb88 speling error in field description, closes #11093
svn path=/plone.app.discussion/trunk/; revision=39845
2010-09-10 05:00:47 +00:00
Patrick Gerken
823da240d8 Change datetime conversion to handle TZ
The way it happens now, the timezone gets corrected

svn path=/plone.app.discussion/trunk/; revision=39728
2010-09-07 12:03:31 +00:00
Patrick Gerken
697d9af803 Test that correct local time gets displayed.
Since we now store the utc time in comments, we display
code must not only format the date correctly, but show the correct
local time.

svn path=/plone.app.discussion/trunk/; revision=39727
2010-09-07 12:03:18 +00:00
Patrick Gerken
a7b1eb7c10 Change all datetime creations from now to utcnow
svn path=/plone.app.discussion/trunk/; revision=39726
2010-09-07 12:03:07 +00:00
Patrick Gerken
4e43cfed2e Adding a test to assert that dates get stored utc
and not in local time

svn path=/plone.app.discussion/trunk/; revision=39725
2010-09-07 12:02:55 +00:00
Timo Stollenwerk
68a264c9d9 Use unicode strings for test requests in test_comments_viewlet to make the Plone 3 tests happy.
svn path=/plone.app.discussion/trunk/; revision=39680
2010-09-06 10:40:06 +00:00
Timo Stollenwerk
0358a03d5b Fetch context for the comment view with "context = aq_inner(self.context)". This fixes a failing Plone 3 test.
svn path=/plone.app.discussion/trunk/; revision=39678
2010-09-06 10:38:54 +00:00
Timo Stollenwerk
288732d276 Removed unused imports from test_comments_viewlet tests.
svn path=/plone.app.discussion/trunk/; revision=39632
2010-09-03 21:57:36 +00:00
Timo Stollenwerk
a4011ce414 Fix the comment view test.
svn path=/plone.app.discussion/trunk/; revision=39629
2010-09-03 21:23:44 +00:00
Timo Stollenwerk
ea13020498 Raise an unauthorized error when authenticated users try to post a comment on a content object that has discussion disabled. Thanks to vincentfrentin for reporting this!
svn path=/plone.app.discussion/trunk/; revision=39627
2010-09-03 20:40:27 +00:00
Timo Stollenwerk
a410c72333 Complete comments form integration test.
svn path=/plone.app.discussion/trunk/; revision=39610
2010-09-02 20:52:33 +00:00
Timo Stollenwerk
4f4f9f9cec Fix whitespace for coverage test.
svn path=/plone.app.discussion/trunk/; revision=39609
2010-09-02 20:21:53 +00:00
Timo Stollenwerk
81cba38a74 Comment form test added.
svn path=/plone.app.discussion/trunk/; revision=39608
2010-09-02 20:00:43 +00:00
Radim Novotny
237d9170c5 Added Czech translation
svn path=/plone.app.discussion/trunk/; revision=39589
2010-09-01 08:53:39 +00:00
Vincent Fretin
4b15b31e51 Translate the subject and be sure to set the charset to utf-8 for the mail.
svn path=/plone.app.discussion/trunk/; revision=39587
2010-09-01 07:32:28 +00:00
Vincent Fretin
da81b1073b Fixed translation
svn path=/plone.app.discussion/trunk/; revision=39586
2010-09-01 07:30:14 +00:00
Vincent Fretin
0d2e23842e Removed empty description for text transform
svn path=/plone.app.discussion/trunk/; revision=39585
2010-09-01 07:25:04 +00:00
Vincent Fretin
72f715dd4a Updated French translation
svn path=/plone.app.discussion/trunk/; revision=39584
2010-09-01 07:23:34 +00:00
Vincent Fretin
c3f49298fb plone.app.discussion: 3 messages added
svn path=/plone.app.discussion/trunk/; revision=39583
2010-09-01 07:21:48 +00:00
Vincent Fretin
d5baae3eec Fixed variables in the template for use with the i18n machinery
svn path=/plone.app.discussion/trunk/; revision=39582
2010-09-01 07:19:51 +00:00
Vincent Fretin
f5bed31131 internationalize notification mail
svn path=/plone.app.discussion/trunk/; revision=39572
2010-08-31 18:07:51 +00:00
Timo Stollenwerk
87ce946947 Removed unused imports. Raise ImportError when import fails.
svn path=/plone.app.discussion/trunk/; revision=39571
2010-08-31 17:36:28 +00:00
Timo Stollenwerk
77d3bc2eb1 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39570
2010-08-31 17:33:22 +00:00
Timo Stollenwerk
d59369a408 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39569
2010-08-31 17:31:27 +00:00
Timo Stollenwerk
9c5f1dd1d8 Unused imports removed.
svn path=/plone.app.discussion/trunk/; revision=39568
2010-08-31 17:29:26 +00:00
Timo Stollenwerk
8d915b6327 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39567
2010-08-31 17:28:07 +00:00
Timo Stollenwerk
23122ded8b Test if registry has been registered.
svn path=/plone.app.discussion/trunk/; revision=39356
2010-08-28 22:58:23 +00:00
Timo Stollenwerk
dc160f9d5e Obey the 80 chars limit in the comments view.
svn path=/plone.app.discussion/trunk/; revision=39332
2010-08-28 20:19:58 +00:00
Timo Stollenwerk
785b006394 Obey the 80 chars limit in the migration function.
svn path=/plone.app.discussion/trunk/; revision=39331
2010-08-28 20:18:36 +00:00
Timo Stollenwerk
632e167806 revert 39237 since this breaks some tests.
svn path=/plone.app.discussion/trunk/; revision=39330
2010-08-28 20:10:48 +00:00
Timo Stollenwerk
a2a8956d09 Obey the 80 char limit.
svn path=/plone.app.discussion/trunk/; revision=39327
2010-08-28 20:02:08 +00:00
Timo Stollenwerk
cef90c576b remove author_username variable, because it is unused.
svn path=/plone.app.discussion/trunk/; revision=39325
2010-08-28 19:54:57 +00:00
Timo Stollenwerk
87b2c5dd02 Comment out author_notification because we don't use it right now.
svn path=/plone.app.discussion/trunk/; revision=39324
2010-08-28 19:51:53 +00:00
Timo Stollenwerk
946ff36190 "W0622 total_comments: Redefining built-in 'object'" added to pylint msg ignores.
svn path=/plone.app.discussion/trunk/; revision=39323
2010-08-28 19:48:40 +00:00
Timo Stollenwerk
318afe5aae Fix indentation.
svn path=/plone.app.discussion/trunk/; revision=39322
2010-08-28 19:45:53 +00:00
Timo Stollenwerk
4390b8929b Revert r39314. zptlint failed as expected. hudson integration works!
svn path=/plone.app.discussion/trunk/; revision=39319
2010-08-28 19:31:17 +00:00
Timo Stollenwerk
133da3d305 BREAK templates to check if zptlint in hudson works. Will be reverted immediately.
svn path=/plone.app.discussion/trunk/; revision=39314
2010-08-28 19:19:27 +00:00
Timo Stollenwerk
435040e0b2 Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39287
2010-08-28 17:06:53 +00:00
Timo Stollenwerk
0f9c98ec97 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39272
2010-08-28 16:11:58 +00:00
Timo Stollenwerk
5f5b831904 Be more specific, use ImportError.
svn path=/plone.app.discussion/trunk/; revision=39270
2010-08-28 16:08:36 +00:00
Timo Stollenwerk
e12d19a6e9 Fix bugs that have been introduced with the latest pylint "optimizations".
svn path=/plone.app.discussion/trunk/; revision=39269
2010-08-28 16:07:44 +00:00
Timo Stollenwerk
9264d2d42d Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39265
2010-08-28 15:35:21 +00:00
Timo Stollenwerk
ba8e7ac5cd Move the functions out of the ready function. this makes the JS tests pass.
svn path=/plone.app.discussion/trunk/; revision=39151
2010-08-27 21:26:37 +00:00
Timo Stollenwerk
67fb426f08 Javascript doc added.
svn path=/plone.app.discussion/trunk/; revision=39146
2010-08-27 20:52:38 +00:00
Timo Stollenwerk
f4435a563b Remove unnecessary init test. remove namespaces from method calls.
svn path=/plone.app.discussion/trunk/; revision=39145
2010-08-27 20:51:19 +00:00
Timo Stollenwerk
9e405b47a1 qunit files added.
svn path=/plone.app.discussion/trunk/; revision=39143
2010-08-27 20:50:18 +00:00
Timo Stollenwerk
a1605fb88b Revert r39104 since it breaks the comments js.
svn path=/plone.app.discussion/trunk/; revision=39141
2010-08-27 20:45:11 +00:00
Timo Stollenwerk
d713409aa1 Use a discussion JS namespace for comments.js; JS tests for clearForm and createReplyForm functions added.
svn path=/plone.app.discussion/trunk/; revision=39104
2010-08-27 17:11:25 +00:00
Timo Stollenwerk
2c5d387cfc Rename js directory to javascripts.
svn path=/plone.app.discussion/trunk/; revision=39066
2010-08-27 12:07:04 +00:00
Timo Stollenwerk
e310c1d021 Basic JS tests added.
svn path=/plone.app.discussion/trunk/; revision=39064
2010-08-27 11:41:39 +00:00
Timo Stollenwerk
d3074fa4fd Make Javascripts pass JSLint validation
svn path=/plone.app.discussion/trunk/; revision=39059
2010-08-27 10:34:42 +00:00
Timo Stollenwerk
61565de95a Put email notification subscribers into their own zcml file so it is easier for integrators to override them.
svn path=/plone.app.discussion/trunk/; revision=38981
2010-08-26 09:31:49 +00:00
Timo Stollenwerk
a2c89ed5e8 Plain text and intelligent text options for comment text added to preserve basic text structure and to make links clickable.
svn path=/plone.app.discussion/trunk/; revision=38931
2010-08-25 14:03:29 +00:00
Timo Stollenwerk
35d7743b7a Plain text to HTML transformation added for comment text
svn path=/plone.app.discussion/trunk/; revision=38898
2010-08-25 09:19:28 +00:00
Vincent Fretin
17fce9d515 Rewrote all tal:condition in comments.pt. The authenticated user has
the reply button and the comment form if he has the "Reply to item"
permission and the conversation is currently enabled.

Warning:
There is a security hole at the moment. Any authenticated user having the
zope2.View permission or anonymous user without captcha can add a comment
by creating a post request.

svn path=/plone.app.discussion/trunk/; revision=38888
2010-08-24 11:25:17 +00:00
Vincent Fretin
352a517a0a Fixed the case where a folder has allow_discussion=False and
conversation.enabled() on a document in this folder returned False
instead of True because of allow_discussion acquisition.

svn path=/plone.app.discussion/trunk/; revision=38835
2010-08-20 11:52:05 +00:00
Timo Stollenwerk
7a2f1ff12b Fix indentation.
svn path=/plone.app.discussion/trunk/; revision=38665
2010-08-09 12:42:21 +00:00
Timo Stollenwerk
d37d5aa9f5 Redirect to the comment form action instead of the absolute url when a comment is posted. This fixes the accidentially triggered file upload when a comment is posted on a file content object.
svn path=/plone.app.discussion/trunk/; revision=38664
2010-08-09 12:25:14 +00:00
Vincent Fretin
7705e7facf Updated zh_TW translation
svn path=/plone.app.discussion/trunk/; revision=38610
2010-08-08 08:55:31 +00:00
Vincent Fretin
d75fe71a3b Add point
svn path=/plone.app.discussion/trunk/; revision=38599
2010-08-06 20:22:07 +00:00
Vincent Fretin
7c007b1306 You can now translate the title and description of the product.
svn path=/plone.app.discussion/trunk/; revision=38597
2010-08-06 19:22:19 +00:00
Vincent Fretin
8d6e960804 changed translation
svn path=/plone.app.discussion/trunk/; revision=38596
2010-08-06 19:17:18 +00:00
Vincent Fretin
69c2ce9556 Added 3 new messages from the single state workflow
svn path=/plone.app.discussion/trunk/; revision=38583
2010-08-06 17:24:05 +00:00
Vincent Fretin
be0a6cb685 Added zh_TW translation, use Domain:zh_TW (case sensitive) in plone-zh_TW.po
svn path=/plone.app.discussion/trunk/; revision=38581
2010-08-06 17:15:59 +00:00
Vincent Fretin
fd6a8e0fd8 * Renamed legend_add_comment to label_add_comment to have the translation from
plone domain.
* label_comment_by and label_commented_at are not in Plone 4 translation anymore, so
  these two messages moved to plone.app.discussions i18n domain.

svn path=/plone.app.discussion/trunk/; revision=38574
2010-08-06 15:33:34 +00:00
Vincent Fretin
86aee7a2ea Added French translation.
svn path=/plone.app.discussion/trunk/; revision=38573
2010-08-06 15:21:29 +00:00
Vincent Fretin
733c3439ca Translate "Warning" shown in @@moderate-comments in the plone domain.
svn path=/plone.app.discussion/trunk/; revision=38568
2010-08-06 10:46:37 +00:00
Vincent Fretin
da7e28be74 Fixed some typo
svn path=/plone.app.discussion/trunk/; revision=38567
2010-08-06 10:43:44 +00:00
Giorgio Borelli
38b5f7dbae italian translation update
svn path=/plone.app.discussion/trunk/; revision=38566
2010-08-06 10:34:04 +00:00
Vincent Fretin
d2b19deeac use double quotes
svn path=/plone.app.discussion/trunk/; revision=38565
2010-08-06 10:01:52 +00:00
Vincent Fretin
c1e861e969 Fixed i18n markup of message_moderation_disabled.
svn path=/plone.app.discussion/trunk/; revision=38564
2010-08-06 09:51:23 +00:00
Vincent Fretin
27710ca541 It's 'Allow comments', not 'enable moderation'
svn path=/plone.app.discussion/trunk/; revision=38563
2010-08-06 09:34:05 +00:00
Timo Stollenwerk
86c2bbe001 Spanish and German translation updated.
svn path=/plone.app.discussion/trunk/; revision=38552
2010-08-05 18:41:22 +00:00
Timo Stollenwerk
27a2d3fa36 Use only one MessageFactory.
svn path=/plone.app.discussion/trunk/; revision=38551
2010-08-05 18:40:22 +00:00
Timo Stollenwerk
25d1da3475 Spanish translation added. Thanks to Judith Sanleandro.
svn path=/plone.app.discussion/trunk/; revision=38550
2010-08-05 17:18:19 +00:00
Vincent Fretin
6d07243885 Added fr to the script and added the empty i18n/plone-fr.po file
svn path=/plone.app.discussion/trunk/; revision=38549
2010-08-05 17:00:05 +00:00
Vincent Fretin
d0cb939828 Added fr directory with empty po file
svn path=/plone.app.discussion/trunk/; revision=38548
2010-08-05 16:57:25 +00:00
Timo Stollenwerk
ae5754455b Translation files updated. Spanish translation added.
svn path=/plone.app.discussion/trunk/; revision=38547
2010-08-05 16:47:24 +00:00
Timo Stollenwerk
f72972844d Call the CaptchaValidator even when no captcha data was submitted. This is necessary to ensure that the collective.akismet validator is called when installed.
svn path=/plone.app.discussion/trunk/; revision=38541
2010-08-05 15:36:07 +00:00
Patrick Gerken
94e73b43a7 Catch TypeError in indexers if content can not be adapted
Currently plone.app.discussion provides indexers
for IContentish. In these it tries to adapt
the content object to IDiscussion. But an IDiscussion Factory is only
provided for IAnnotatable.
The Criteria are IContentish but not IAnnotatable.
Indexing them fails

svn path=/plone.app.discussion/trunk/; revision=38182
2010-07-21 23:36:16 +00:00
Timo Stollenwerk
0925a63c15 Unnecessary imports removed.
svn path=/plone.app.discussion/trunk/; revision=38139
2010-07-19 08:25:37 +00:00
Timo Stollenwerk
88ce860aa5 Use self.form instead of CommentForm for the CommentsViewlet update method so integrators don't have to override the viewlet's update method. [Matous]
svn path=/plone.app.discussion/trunk/; revision=37916
2010-07-16 15:26:01 +00:00
Timo Stollenwerk
85d5b823b0 Remove collective.akismet from the captcha documentation.
svn path=/plone.app.discussion/trunk/; revision=37915
2010-07-16 15:08:18 +00:00
Timo Stollenwerk
c3320def88 Make sure the form fields in the reply form are always placed under the field labels; Fix CSS overflow bug that occurs with the new Plone 4.0b5 comment styles
svn path=/plone.app.discussion/trunk/; revision=37774
2010-07-13 13:39:35 +00:00
Timo Stollenwerk
6ca6f58acd Remove unnecessary variables and imports.
svn path=/plone.app.discussion/trunk/; revision=37773
2010-07-13 13:21:12 +00:00
Timo Stollenwerk
a54a15a90f Remove unnecessary imports and variables from test code.
svn path=/plone.app.discussion/trunk/; revision=37768
2010-07-13 10:45:53 +00:00
Timo Stollenwerk
cfdd99b111 remove unnecessary imports / variables; whitespace
svn path=/plone.app.discussion/trunk/; revision=37767
2010-07-13 10:41:26 +00:00
Timo Stollenwerk
66c235aa5e fix whitespace
svn path=/plone.app.discussion/trunk/; revision=37766
2010-07-13 10:40:45 +00:00
Timo Stollenwerk
a5683b0674 remove unnecessary imports.
svn path=/plone.app.discussion/trunk/; revision=37765
2010-07-13 10:40:24 +00:00
Timo Stollenwerk
f3b1dab916 Move AkismetValidator from plone.app.discussion to collective.akismet.
svn path=/plone.app.discussion/trunk/; revision=37764
2010-07-13 09:24:23 +00:00
Timo Stollenwerk
5784ed82a3 Remove unnecessary imports from vocabularies.py.
svn path=/plone.app.discussion/trunk/; revision=37763
2010-07-13 09:23:10 +00:00
Timo Stollenwerk
31c0f7b459 Check for collective.akismet to detect akismet plugin, not for the Python akismet package.
svn path=/plone.app.discussion/trunk/; revision=37762
2010-07-13 09:22:05 +00:00
Timo Stollenwerk
2dbc337fc7 Remove unnecessary imports from captcha.py.
svn path=/plone.app.discussion/trunk/; revision=37760
2010-07-13 09:20:32 +00:00
Timo Stollenwerk
1a84b0b7b8 Remove unnecessary imports.
svn path=/plone.app.discussion/trunk/; revision=37759
2010-07-13 09:19:20 +00:00
Timo Stollenwerk
27d8ced62d revert r37751.
svn path=/plone.app.discussion/trunk/; revision=37753
2010-07-12 13:49:57 +00:00
Timo Stollenwerk
cac0bae7a5 revert r37751.
svn path=/plone.app.discussion/trunk/; revision=37752
2010-07-12 13:47:53 +00:00
Timo Stollenwerk
eabf3bc890 Always use zope.component getUtility instead of queryUtility.
svn path=/plone.app.discussion/trunk/; revision=37751
2010-07-12 13:34:02 +00:00
Timo Stollenwerk
bddc4a96da Remove unnecessary import.
svn path=/plone.app.discussion/trunk/; revision=37692
2010-07-07 11:37:44 +00:00
Yiorgis Gozadinos
d0273e57bb Added norwegian translation.
svn path=/plone.app.discussion/trunk/; revision=37646
2010-07-05 12:14:16 +00:00
Hanno Schlichting
9d396e43f1 Protect against missing canonical in conversationCanonicalAdapterFactory.
svn path=/plone.app.discussion/trunk/; revision=37410
2010-06-25 17:16:15 +00:00
Timo Stollenwerk
5f2daced20 Captcha documentation updated (code examples included, etc).
svn path=/plone.app.discussion/trunk/; revision=37369
2010-06-21 09:11:45 +00:00
Hanno Schlichting
f7c18ea77e No tabs please
svn path=/plone.app.discussion/trunk/; revision=37350
2010-06-18 12:19:33 +00:00
Hanno Schlichting
7d3247ff0c Avoid deprecation warning for the Globals package.
svn path=/plone.app.discussion/trunk/; revision=37349
2010-06-18 12:01:44 +00:00
Timo Stollenwerk
12589d9fd2 Remove the hard coded check for title and text when the comment form is submitted. This allows integrators to write schema extenders that remove the title from the comment form.
svn path=/plone.app.discussion/trunk/; revision=37341
2010-06-17 18:56:26 +00:00
Timo Stollenwerk
6e98edf54f Fix ascii art blocks.
svn path=/plone.app.discussion/trunk/; revision=37336
2010-06-17 09:01:59 +00:00
Timo Stollenwerk
400956e264 Comments added to the notification subscriber functions.
svn path=/plone.app.discussion/trunk/; revision=37329
2010-06-17 06:57:51 +00:00
Timo Stollenwerk
e56bc65956 raise AkismetReject if Akismet rejects a comment as spam.
svn path=/plone.app.discussion/trunk/; revision=37276
2010-06-14 13:02:46 +00:00
Timo Stollenwerk
ac84b232b8 Import Captcha validator from validator directly.
svn path=/plone.app.discussion/trunk/; revision=37273
2010-06-14 12:42:28 +00:00
Timo Stollenwerk
29015324f2 Move the Akismet validator error message to the top.
svn path=/plone.app.discussion/trunk/; revision=37272
2010-06-14 12:25:56 +00:00
Timo Stollenwerk
ac6865311d Move captcha registration to its own captcha.zcml file. Fix captcha registration for Plone 3/Zope 2.10
svn path=/plone.app.discussion/trunk/; revision=37140
2010-06-10 14:57:03 +00:00
Timo Stollenwerk
926314ea49 Akismet spam protection plugin support added (collective.akismet).
svn path=/plone.app.discussion/trunk/; revision=37136
2010-06-10 13:11:33 +00:00
Timo Stollenwerk
92766752c4 Simplify the CaptchaValidator class by dynamically adapting a view with the name of the captcha plugin (e.g. recaptcha, captcha, akismet) for the validator.
svn path=/plone.app.discussion/trunk/; revision=37131
2010-06-10 10:51:41 +00:00
Kim Chee Leong
a10a2b6144 added Dutch translations for plone.app.discussion
svn path=/plone.app.discussion/trunk/; revision=37091
2010-06-07 14:35:03 +00:00
Pelle Kroegholt
84c111755c Enable caching and merging for comments.js to save some requests.
svn path=/plone.app.discussion/trunk/; revision=37002
2010-06-04 19:56:17 +00:00
Timo Stollenwerk
af1a8bfacd Replace the old NOTES.txt and PRINCIPLES.txt with the Sphinx versions. Fix Captcha title.
svn path=/plone.app.discussion/trunk/; revision=36998
2010-06-04 11:22:16 +00:00
Timo Stollenwerk
bca29657b5 minor.
svn path=/plone.app.discussion/trunk/; revision=36996
2010-06-04 11:13:22 +00:00
Timo Stollenwerk
429c334376 captcha.txt added to sphinx documentation.
svn path=/plone.app.discussion/trunk/; revision=36995
2010-06-04 11:11:01 +00:00
Timo Stollenwerk
7f28f2773a Design notes for the Captcha plugin architecture added.
svn path=/plone.app.discussion/trunk/; revision=36993
2010-06-04 10:57:57 +00:00
Timo Stollenwerk
3bda1a12f1 Make IDiscussionLayer inherit from Interface again. Remove IDefaultPloneLayer, since Plone 4.0b1 and plone.theme 2.0b1 are out now. This was fixed by #10109; https://dev.plone.org/plone/ticket/10109; thanks davisagli!
svn path=/plone.app.discussion/trunk/; revision=36992
2010-06-04 09:33:48 +00:00
Timo Stollenwerk
28d88dcfb4 Clean up Javascript code. Obey the 80 character limit.
svn path=/plone.app.discussion/trunk/; revision=36991
2010-06-04 09:25:47 +00:00
Timo Stollenwerk
2e0b52889d Clean up (Re)Captcha code. Register Captcha field/validator only if a package is installed that provides the "plone.app.discussion-captcha" feature (currently plone.formwidget.captcha and plone.formwidget.recaptcha trunk only).
svn path=/plone.app.discussion/trunk/; revision=36877
2010-06-01 16:38:29 +00:00
Timo Stollenwerk
682ceb2760 fix r36843 commit. set HAS_WRAPPED_FORM to false for plone.z3cform < 0.6.0.
svn path=/plone.app.discussion/trunk/; revision=36845
2010-05-31 10:05:57 +00:00
Timo Stollenwerk
3d22bc56c4 Fix encoding error in migration procedure, otherwise migration procedure breaks on joining output list in case we have there any non-ascii characters. [piv]
svn path=/plone.app.discussion/trunk/; revision=36844
2010-05-31 09:58:42 +00:00
Timo Stollenwerk
4f13054ae4 plone.z3cform 0.6.0 compatibility (fix maximum recursion depth error which appears with plone.z3cform higher than 0.5.10); [piv]
svn path=/plone.app.discussion/trunk/; revision=36843
2010-05-31 09:50:46 +00:00
Timo Stollenwerk
5c323a5cf4 Whitespace and comment added.
svn path=/plone.app.discussion/trunk/; revision=36787
2010-05-28 15:56:39 +00:00
Yiorgis Gozadinos
abe4cda5ba removed moderation.js from js registry and include it only in moderation.pt as that is the only place where it is used
svn path=/plone.app.discussion/trunk/; revision=36468
2010-05-03 11:53:20 +00:00
Timo Stollenwerk
a18fdb6128 interface description for enabled method added.
svn path=/plone.app.discussion/trunk/; revision=35687
2010-04-04 16:15:21 +00:00
Lennart Regebro
30c66b0b24 A bug in the moderator panel meant you couldn't delete items in a virtual host, if your portal was named "plone".
svn path=/plone.app.discussion/trunk/; revision=35608
2010-04-01 13:48:03 +00:00
Lennart Regebro
f7c676622b The the author_name in the control panel.
svn path=/plone.app.discussion/trunk/; revision=35533
2010-03-24 15:38:18 +00:00
Timo Stollenwerk
6bbf8dbc08 update translation files.
svn path=/plone.app.discussion/trunk/; revision=35353
2010-03-19 10:53:46 +00:00
Timo Stollenwerk
5040d48a33 Rename "Single State Workflow" to "Comment Single State Workflow".
svn path=/plone.app.discussion/trunk/; revision=35347
2010-03-19 10:17:00 +00:00
Timo Stollenwerk
5ce942d1d2 Rename 'publish comment' to 'approve comment'. This fixes #1608470.
svn path=/plone.app.discussion/trunk/; revision=35342
2010-03-19 09:58:35 +00:00
Timo Stollenwerk
437094d951 Show a warning in the moderation view if the moderation workflow is disabled.
svn path=/plone.app.discussion/trunk/; revision=35341
2010-03-19 09:44:07 +00:00
Timo Stollenwerk
24a34d6919 Move 'Moderate comments' link from site actions to user actions.
svn path=/plone.app.discussion/trunk/; revision=35303
2010-03-18 16:16:44 +00:00
Florian Friesdorf
5beebe42fa hardcoded fti_title, don't query typestool for Type()
all tests succeed

svn path=/plone.app.discussion/trunk/; revision=35290
2010-03-18 14:42:52 +00:00
Florian Friesdorf
8150617081 fixed #662654: As an administrator, I can configure a Collection to show
recent comments.

Type now correctly returns FTI type title. A catalog rebuild is
necessary.

svn path=/plone.app.discussion/trunk/; revision=35266
2010-03-18 13:22:16 +00:00
Florian Friesdorf
5e6c7f6fdb fixed catalog test to fail for current broken Type()
svn path=/plone.app.discussion/trunk/; revision=35265
2010-03-18 13:22:06 +00:00
Florian Friesdorf
2815febe46 Revert "Fix #662654: As an administrator, I can configure a Collection to show recent comments. Rename 'Discussion Item' title from 'Comment' to 'Discussion Item'."
This reverts commit 25c8faacc11353af815edb9dfdac567c2ddf284d.

Conflicts (solved):

	CHANGES.txt

test and full fix on the way

svn path=/plone.app.discussion/trunk/; revision=35264
2010-03-18 13:21:53 +00:00
Timo Stollenwerk
d0ee0a956f german po file updated. [juh]
svn path=/plone.app.discussion/trunk/; revision=35246
2010-03-18 10:16:00 +00:00
Florian Friesdorf
73944c09ce generated .gitignore from svnignore
svn path=/plone.app.discussion/trunk/; revision=35167
2010-03-17 16:54:24 +00:00
Timo Stollenwerk
c372cbb4fa fix language code, name, and domain for German translation.
svn path=/plone.app.discussion/trunk/; revision=35162
2010-03-17 16:40:57 +00:00
Timo Stollenwerk
cddeefa70a fix language code for german plone translation file.
svn path=/plone.app.discussion/trunk/; revision=35148
2010-03-17 16:13:39 +00:00
Timo Stollenwerk
c626bab2e5 German translation updated.
svn path=/plone.app.discussion/trunk/; revision=35141
2010-03-17 15:47:54 +00:00
Timo Stollenwerk
f5a171a6e0 add missing DiscussionLayer to TestCommentOperations test.
svn path=/plone.app.discussion/trunk/; revision=35129
2010-03-17 15:09:23 +00:00
Timo Stollenwerk
b70774343f collection test added.
svn path=/plone.app.discussion/trunk/; revision=35126
2010-03-17 15:00:19 +00:00
Timo Stollenwerk
e00453e9d6 Fix #662654: As an administrator, I can configure a Collection to show recent comments. Rename 'Discussion Item' title from 'Comment' to 'Discussion Item'.
svn path=/plone.app.discussion/trunk/; revision=35109
2010-03-17 14:04:34 +00:00
Timo Stollenwerk
37b8e0fe15 Fix #2419342: Fix untranslated published/deleted status messages. import _ from p.a.d message factory instead of from the standard Plone message factory.
svn path=/plone.app.discussion/trunk/; revision=35092
2010-03-17 12:34:38 +00:00
Timo Stollenwerk
5fedf90f18 Remove fixed width of the actions column of the moderation view. The translated button titles can differ in size from the English titles.
svn path=/plone.app.discussion/trunk/; revision=35087
2010-03-17 11:00:10 +00:00
Timo Stollenwerk
0776fecfd2 we can't set a widget for the author_notification field because we removed it.
svn path=/plone.app.discussion/trunk/; revision=35081
2010-03-17 10:49:26 +00:00
Timo Stollenwerk
e5ee53b644 comment out author_notification field because we postponed this setting.
svn path=/plone.app.discussion/trunk/; revision=35080
2010-03-17 10:44:17 +00:00
Timo Stollenwerk
7ef4f384e0 add additional hint to the "globally enabled" setting. respect 80 characters limit.
svn path=/plone.app.discussion/trunk/; revision=35079
2010-03-17 10:42:37 +00:00
Timo Stollenwerk
52ebbe2e71 Fix #2494228: Remove comments as well when a content object is deleted.
svn path=/plone.app.discussion/trunk/; revision=34965
2010-03-16 15:06:43 +00:00
Timo Stollenwerk
eec6bca238 hide the email field again since this does not make sense without user email notification.
svn path=/plone.app.discussion/trunk/; revision=34943
2010-03-16 13:24:13 +00:00
Timo Stollenwerk
819b66e149 merge r34694-r34695 from the jarn-1.0b3 branch.
Fix unicode error when non-ASCII characters are typed into the name field of a comment by anonymous users. 
We are indexing the member.id only now instead of the full member name or what anonymous users typed into the name field.

svn path=/plone.app.discussion/trunk/; revision=34932
2010-03-16 13:06:08 +00:00
Timo Stollenwerk
6e226be248 failing test for Pivotal Tracker issue #2494228 added (comment out test for now).
svn path=/plone.app.discussion/trunk/; revision=34915
2010-03-16 11:09:40 +00:00
Timo Stollenwerk
ebc4c408e3 fix tests for conversation.getThreads generator.
svn path=/plone.app.discussion/trunk/; revision=34911
2010-03-16 10:52:25 +00:00
Timo Stollenwerk
4ed9d08119 fix the moderator notification for Plone 3.x.
svn path=/plone.app.discussion/trunk/; revision=34698
2010-03-11 19:23:53 +00:00
Timo Stollenwerk
ce7e47f07b remove the user notification feature for now, since it requires the current z3c.form trunk and does not work with the latest release on PyPi.
svn path=/plone.app.discussion/trunk/; revision=34697
2010-03-11 19:23:26 +00:00
Timo Stollenwerk
2301565e27 remove the user notification feature for now, since it requires the current z3c.form trunk and does not work with the latest release on PyPi.
svn path=/plone.app.discussion/trunk/; revision=34696
2010-03-11 19:23:02 +00:00
Timo Stollenwerk
1d39b53c4b Merge notification branch into trunk:
New feature: As a moderator, I am notified when new comments require my attention;
New feature: As a commenter, I can enable/disable email notification of additional comments on this object;
Make p.a.d. work with the recent version of plone.z3cform (0.5.10);

svn path=/plone.app.discussion/trunk/; revision=34602
2010-03-06 10:04:34 +00:00
Timo Stollenwerk
d81b95f7c1 more catalog tests added.
svn path=/plone.app.discussion/branches/notification/; revision=34476
2010-03-03 19:20:02 +00:00
Timo Stollenwerk
ff0270dac7 hide author_notification field if author notification is disabled. save author notification setting properly when saving the form.
svn path=/plone.app.discussion/branches/notification/; revision=34475
2010-03-03 19:17:13 +00:00
Timo Stollenwerk
1920869f8b Make p.a.d. styles less generic. This fixes #10253.
svn path=/plone.app.discussion/trunk/; revision=34373
2010-02-26 16:56:31 +00:00
Luca Fabbri
05aa7785a9 Update and fixed italian translation
svn path=/plone.app.discussion/trunk/; revision=34354
2010-02-26 08:15:24 +00:00
Timo Stollenwerk
fabda285a0 merge Italian translation from the localization branch again. This fixes #2603933.
svn path=/plone.app.discussion/trunk/; revision=34344
2010-02-25 17:33:31 +00:00
Yiorgis Gozadinos
37910f3bdf Added greek i18n
svn path=/plone.app.discussion/trunk/; revision=34319
2010-02-23 08:44:41 +00:00
Timo Stollenwerk
57b41454bb update CommentsViewlet to follow best practice for showing a z3c.form inside a Viewlet. Override update method instead of init method.
svn path=/plone.app.discussion/branches/notification/; revision=34052
2010-02-16 20:25:56 +00:00
Timo Stollenwerk
90c44a7c67 test do not notify user when no sender is available.
svn path=/plone.app.discussion/branches/notification/; revision=33964
2010-02-13 21:44:26 +00:00
Timo Stollenwerk
be3d347471 user email notification added.
svn path=/plone.app.discussion/branches/notification/; revision=33963
2010-02-13 21:31:17 +00:00
Timo Stollenwerk
38fd65f46d remove whitespace to make coverage-test happy.
svn path=/plone.app.discussion/branches/notification/; revision=33929
2010-02-12 10:21:39 +00:00
Timo Stollenwerk
6e46ce7581 test moderator notification enabled setting.
svn path=/plone.app.discussion/branches/notification/; revision=33928
2010-02-12 10:11:01 +00:00
Timo Stollenwerk
f0fb6514c7 Moderator email notification added: As a moderator, I am notified when new comments require my attention.
svn path=/plone.app.discussion/branches/notification/; revision=33921
2010-02-11 21:05:28 +00:00
Timo Stollenwerk
67b5ff566e fix singlecheckboxwidget for comment form.
svn path=/plone.app.discussion/branches/notification/; revision=33873
2010-02-08 18:28:03 +00:00
Timo Stollenwerk
26031cd1f4 notification enabled field added to discussion control panel.
svn path=/plone.app.discussion/branches/notification/; revision=33869
2010-02-08 15:02:17 +00:00
Timo Stollenwerk
de3bb53c13 move author notification field to the bottom of the form.
svn path=/plone.app.discussion/branches/notification/; revision=33868
2010-02-08 14:47:53 +00:00
Timo Stollenwerk
c4dbf971fb author_notification field added.
svn path=/plone.app.discussion/branches/notification/; revision=33867
2010-02-08 12:02:54 +00:00
Timo Stollenwerk
23eeb041aa comment out CommentForm test.
svn path=/plone.app.discussion/trunk/; revision=33845
2010-02-07 11:37:34 +00:00
Timo Stollenwerk
b09c4197aa revert r33808 (revert r33488 (Register the event subscribers for the correct interfaces in Plone 3.), since this is breaking 13 tests.).
svn path=/plone.app.discussion/trunk/; revision=33813
2010-02-06 15:48:23 +00:00
Timo Stollenwerk
fde7f2f828 revert r33488 (Register the event subscribers for the correct interfaces in Plone 3.), since this is breaking 13 tests.
svn path=/plone.app.discussion/trunk/; revision=33808
2010-02-06 14:10:56 +00:00
Timo Stollenwerk
2ffbe75611 collection test added (failing).
svn path=/plone.app.discussion/trunk/; revision=33780
2010-02-05 22:40:38 +00:00
Hanno Schlichting
364a783408 Added an i18n directory for messages in the plone domain and updated scripts to rebuild and sync it.
svn path=/plone.app.discussion/trunk/; revision=33549
2010-01-28 15:00:39 +00:00
Hanno Schlichting
405ecc1268 Added an optional conversationCanonicalAdapterFactory showing how to share comments across all translations with LinguaPlone, by storing and retrieving the conversation from the canonical object.
svn path=/plone.app.discussion/trunk/; revision=33546
2010-01-28 13:44:56 +00:00
Hanno Schlichting
9c80b99ead Play by the Plone 3.3+ rules and use the INavigationRoot as a base for the moderation views.
svn path=/plone.app.discussion/trunk/; revision=33544
2010-01-28 13:23:58 +00:00
Hanno Schlichting
d937bcc42e Added a commentTitle CSS class to the comment titles.
svn path=/plone.app.discussion/trunk/; revision=33543
2010-01-28 11:48:44 +00:00
Hanno Schlichting
590b343a53 Update message ids to match their real text.
svn path=/plone.app.discussion/trunk/; revision=33542
2010-01-28 10:57:36 +00:00
Hanno Schlichting
d894c45343 Forgot one domain setting in the GS profile
svn path=/plone.app.discussion/trunk/; revision=33541
2010-01-28 10:49:29 +00:00
Timo Stollenwerk
2179e447ab Set CSS classes for the comment form in the updateActions method.
svn path=/plone.app.discussion/trunk/; revision=33520
2010-01-27 19:20:25 +00:00
Hanno Schlichting
faf339bec5 Optimized the conversation enabled method and avoid overlong lines
svn path=/plone.app.discussion/trunk/; revision=33514
2010-01-27 17:11:55 +00:00
Hanno Schlichting
9f4129a65f Respect the allow_comments field on an object and avoid calculations if no comments should be shown.
svn path=/plone.app.discussion/trunk/; revision=33511
2010-01-27 17:00:58 +00:00
Hanno Schlichting
034d0a93ad Automatically load the ZCML files of the captcha widgets if they are installed.
svn path=/plone.app.discussion/trunk/; revision=33498
2010-01-27 16:14:35 +00:00
Hanno Schlichting
29a81f0717 Fixed i18n domain in GenericSetup profiles to be `plone`. Other values aren't supported for GS profiles.
svn path=/plone.app.discussion/trunk/; revision=33492
2010-01-27 14:56:30 +00:00
Hanno Schlichting
c27d1b5cc1 De-tabbify
svn path=/plone.app.discussion/trunk/; revision=33491
2010-01-27 14:54:07 +00:00
Hanno Schlichting
ece5e3c302 Provide our own copy of the default one state workflow. Not all Plone sites have this workflow installed.
svn path=/plone.app.discussion/trunk/; revision=33490
2010-01-27 14:46:12 +00:00
Hanno Schlichting
efc60b2620 Register the event subscribers for the correct interfaces in Plone 3.
svn path=/plone.app.discussion/trunk/; revision=33488
2010-01-27 13:51:44 +00:00
Hanno Schlichting
1b78a1839b Factored out subscriber declarations into its own ZCML file.
svn path=/plone.app.discussion/trunk/; revision=33486
2010-01-27 12:28:47 +00:00
Timo Stollenwerk
f93f419f99 Custom cancel button class added again. Plone 3.x reply-to-comment form still uses this.
svn path=/plone.app.discussion/trunk/; revision=33453
2010-01-26 10:27:38 +00:00
Timo Stollenwerk
a7017cedb7 i18n tag added to 'show full comment text'.
svn path=/plone.app.discussion/trunk/; revision=33452
2010-01-26 10:18:46 +00:00
Timo Stollenwerk
b0c8b38199 fix comment actions column in Plone 3.x.
svn path=/plone.app.discussion/trunk/; revision=33451
2010-01-26 10:08:44 +00:00
Timo Stollenwerk
c0a480a695 complete german translation.
svn path=/plone.app.discussion/trunk/; revision=33450
2010-01-26 09:27:48 +00:00
Timo Stollenwerk
4fa3f476d4 allow to show the full text of a comment in the moderation view.
svn path=/plone.app.discussion/trunk/; revision=33400
2010-01-25 11:43:29 +00:00
Timo Stollenwerk
489afd8636 Bugfix #2281226: Moderation View: Comments disappear when hitting the 'Apply' button without choosing a bulk action.
svn path=/plone.app.discussion/trunk/; revision=33399
2010-01-25 10:51:27 +00:00
Timo Stollenwerk
9b29be8473 more German translations added.
svn path=/plone.app.discussion/trunk/; revision=33398
2010-01-25 09:10:25 +00:00
Timo Stollenwerk
c001b335b9 make i18ndude shut up about errors.
svn path=/plone.app.discussion/trunk/; revision=33388
2010-01-24 21:19:18 +00:00
Timo Stollenwerk
c96cafca18 merge r33351-r33355 from localization-enabled branch with current trunk.
svn path=/plone.app.discussion/trunk/; revision=33384
2010-01-24 19:46:14 +00:00
Timo Stollenwerk
440405c47b update translation script added.
svn path=/plone.app.discussion/trunk/; revision=33383
2010-01-24 19:39:47 +00:00
Timo Stollenwerk
1998c2d5a0 enable locales directory.
svn path=/plone.app.discussion/trunk/; revision=33382
2010-01-24 19:39:23 +00:00
Luca Fabbri
e7bec36665 Fixes to po and pot head infos
svn path=/plone.app.discussion/branches/localization-enabled/; revision=33355
2010-01-24 14:11:50 +00:00
Luca Fabbri
677490a445 Final fixes: now also the "Comment" button is translated
svn path=/plone.app.discussion/branches/localization-enabled/; revision=33354
2010-01-24 14:00:51 +00:00
Luca Fabbri
a6a1904d3e Commiting working translation.
Some light fixes was needed also to the code. 

svn path=/plone.app.discussion/branches/localization-enabled/; revision=33353
2010-01-24 13:47:39 +00:00
Luca Fabbri
569cd0f33b Added the locales support.
Also refactored interfaces string to cleanup the default i18n messages default.

svn path=/plone.app.discussion/branches/localization-enabled/; revision=33352
2010-01-24 11:25:22 +00:00
Timo Stollenwerk
3c22930ba2 test discussion control panel view.
svn path=/plone.app.discussion/trunk/; revision=33314
2010-01-23 09:02:09 +00:00
Timo Stollenwerk
6ca20c7514 Make test coverage happy. 1 second seems to be not enough to create a comment when running the test coverage.
svn path=/plone.app.discussion/trunk/; revision=33309
2010-01-23 07:26:19 +00:00
Timo Stollenwerk
0c1d32d7c6 comment out locales directory for now, since it is unused.
svn path=/plone.app.discussion/trunk/; revision=33288
2010-01-22 19:43:10 +00:00
Timo Stollenwerk
b31843f79a Fix globally enabled description.
svn path=/plone.app.discussion/trunk/; revision=33286
2010-01-22 19:21:30 +00:00
Timo Stollenwerk
ac3ade24f6 Redo the controlpanel UI.
svn path=/plone.app.discussion/trunk/; revision=33284
2010-01-22 19:17:46 +00:00
Timo Stollenwerk
1e58aa63b1 fix CommentViewlet has_replies method.
svn path=/plone.app.discussion/trunk/; revision=33282
2010-01-22 19:02:41 +00:00
Timo Stollenwerk
b1e4b2254c Fix 1513398: Show "anonymous" when name field is empty in comment form.
svn path=/plone.app.discussion/trunk/; revision=33281
2010-01-22 18:35:32 +00:00
Timo Stollenwerk
649e41fcd5 Undo r33270. Make IDiscussionLayer inherit from IDefaultPloneLayer for now, to fix the comment Viewlet in Plone 4.0a3. This can be removed again as soon as Plone 4.0b1 is out. Thanks davisagli!
svn path=/plone.app.discussion/trunk/; revision=33278
2010-01-22 17:54:30 +00:00
Timo Stollenwerk
0b530a0a75 Ugly hack that works around a "ContentProviderLookupError: plone.htmlhead" error caused by Zope 2 permissions. See https://bugs.launchpad.net/zope2/+bug/176566 for further details. This error occured on Plone 3.3.x only.
svn path=/plone.app.discussion/trunk/; revision=33275
2010-01-22 16:28:00 +00:00
Timo Stollenwerk
1a1c903086 Integration test for comments viewlet added.
Empty test class for comment form added.

svn path=/plone.app.discussion/trunk/; revision=33271
2010-01-22 12:29:26 +00:00
Timo Stollenwerk
5ff91da15d rename plone.comments Viewlet to plone.app.discussion.comments and hide the standard plone.comments Viewlet. This is necessary because overriding plone.comments is not working anymore in Plone 4.0a3. This should be fixed properly in the future.
svn path=/plone.app.discussion/trunk/; revision=33270
2010-01-22 12:08:30 +00:00
Timo Stollenwerk
7dda99a62a remove outstanding questions.
svn path=/plone.app.discussion/trunk/; revision=33235
2010-01-19 09:37:40 +00:00
Timo Stollenwerk
548c1debee remove unnecessary cancel button class.
svn path=/plone.app.discussion/trunk/; revision=33234
2010-01-19 08:26:41 +00:00
Timo Stollenwerk
3ceb9e1e4f use widget.addClass instead of overwriting an entire class for setting a CSS class.
svn path=/plone.app.discussion/trunk/; revision=33222
2010-01-18 19:47:46 +00:00
Timo Stollenwerk
365684f137 test stop iteration for get_replies method.
svn path=/plone.app.discussion/trunk/; revision=33218
2010-01-18 12:20:45 +00:00
Timo Stollenwerk
1bfff5255a more tests for comments viewlet.
svn path=/plone.app.discussion/trunk/; revision=33217
2010-01-18 11:38:57 +00:00
Timo Stollenwerk
ca0aecd170 user portal membership tool for is_anonyous method; tests for comments viewlet added.
svn path=/plone.app.discussion/trunk/; revision=33216
2010-01-18 11:04:08 +00:00
Timo Stollenwerk
77eaee146e tests for comments viewlet added (some are still empty).
svn path=/plone.app.discussion/trunk/; revision=33215
2010-01-18 09:55:44 +00:00
Timo Stollenwerk
d1bd1469c8 move comment view from browser/comments.py to browser/comment.py.
svn path=/plone.app.discussion/trunk/; revision=33214
2010-01-18 09:54:27 +00:00
Timo Stollenwerk
dc2e5232f7 fix migration tests. do not use transactions during unit testing.
svn path=/plone.app.discussion/trunk/; revision=32805
2010-01-03 17:36:01 +00:00
Timo Stollenwerk
e0cc673683 count old comments only during migration. show error log when comments could not be migrated.
svn path=/plone.app.discussion/trunk/; revision=32767
2010-01-02 19:45:05 +00:00
Timo Stollenwerk
275cb885ea dry_run and abort migration added to migration view.
svn path=/plone.app.discussion/trunk/; revision=32588
2009-12-21 23:36:35 +00:00
Timo Stollenwerk
adb0390227 use object_provides instead of portal_type to query the catalog for comments. this fixes bug #2010085;
svn path=/plone.app.discussion/trunk/; revision=32538
2009-12-19 15:03:12 +00:00
Timo Stollenwerk
2e004456f5 Bugfix for #2010078: Comments that await moderation are visually distinguished from published comments.
svn path=/plone.app.discussion/trunk/; revision=32537
2009-12-19 14:04:49 +00:00
Timo Stollenwerk
0fa11f9af9 remove unnecessary link in comment title.
svn path=/plone.app.discussion/trunk/; revision=32536
2009-12-19 13:39:28 +00:00
Timo Stollenwerk
5f9e443b9c fix bug #2010181: The name of a commenter who commented while not logged in should not appear as a link.
svn path=/plone.app.discussion/trunk/; revision=32535
2009-12-19 13:35:49 +00:00
Timo Stollenwerk
2bb8f514e8 fix unbound prefix error.
svn path=/plone.app.discussion/trunk/; revision=32436
2009-12-15 07:15:57 +00:00
Timo Stollenwerk
c873b76a9b locales directory added.
svn path=/plone.app.discussion/trunk/; revision=32431
2009-12-14 12:45:45 +00:00
Timo Stollenwerk
8c5342e8e3 Plone 4 compliant icon_expression added.
svn path=/plone.app.discussion/trunk/; revision=32359
2009-12-08 15:40:25 +00:00
Timo Stollenwerk
8e493363c4 rename remove button to delete.
svn path=/plone.app.discussion/trunk/; revision=32358
2009-12-08 15:37:52 +00:00
Timo Stollenwerk
42f8da327b fix styles for action column in moderation view.
svn path=/plone.app.discussion/trunk/; revision=32357
2009-12-08 15:29:37 +00:00
Timo Stollenwerk
6ddfbff8df fix even/odd styles for Plone 4.
svn path=/plone.app.discussion/trunk/; revision=32356
2009-12-08 11:53:10 +00:00
Timo Stollenwerk
47cba8797f filter tabs removed from moderation view;
svn path=/plone.app.discussion/trunk/; revision=32355
2009-12-08 11:19:26 +00:00
Timo Stollenwerk
a672c1ed11 Plone 4 styles added.
svn path=/plone.app.discussion/trunk/; revision=32349
2009-12-07 19:39:23 +00:00
Timo Stollenwerk
ff9e2205c9 fix ajax call for workflow_action publish in moderation view.
svn path=/plone.app.discussion/trunk/; revision=32342
2009-12-07 16:11:49 +00:00
Timo Stollenwerk
34b37cab2d fix toLocalizedTime for Plone 4 compatibility.
svn path=/plone.app.discussion/trunk/; revision=32340
2009-12-07 15:45:39 +00:00
Timo Stollenwerk
9713bda830 fix float issue for discussion div as well.
svn path=/plone.app.discussion/trunk/; revision=32339
2009-12-07 15:41:17 +00:00
Timo Stollenwerk
a741095b14 Clear "float: left" from "manage portlets" div above the comment viewlet. This will get fixed in the next Plone 4 release. A bug report has been added to the tracker: https://dev.plone.org/plone/ticket/9903
svn path=/plone.app.discussion/trunk/; revision=32338
2009-12-07 15:39:49 +00:00
Timo Stollenwerk
dd6fdd34fb fix typo.
svn path=/plone.app.discussion/trunk/; revision=31925
2009-11-19 21:42:02 +00:00
Timo Stollenwerk
6999e6f8d0 Replace yes/no widgets with single checkboxes.
svn path=/plone.app.discussion/trunk/; revision=31923
2009-11-19 21:40:08 +00:00
Timo Stollenwerk
ae2767daec fix redirect after a comment has been posted.
svn path=/plone.app.discussion/trunk/; revision=31000
2009-11-01 09:24:27 +00:00
Timo Stollenwerk
94adf62566 do not show moderation message when user has manage rights.
svn path=/plone.app.discussion/trunk/; revision=30997
2009-10-31 16:42:04 +00:00
Timo Stollenwerk
7550e95d5c fix redirection after a comment has been added.
svn path=/plone.app.discussion/trunk/; revision=30986
2009-10-31 12:33:59 +00:00
Timo Stollenwerk
58f8f4bf22 Do not show "publish" bulk action in moderation view when moderation is disabled. Fix story 1105355
.

svn path=/plone.app.discussion/trunk/; revision=30678
2009-10-18 13:12:52 +00:00
Timo Stollenwerk
3e75eedca8 KNOWN_ISSUES.txt removed.
svn path=/plone.app.discussion/trunk/; revision=30671
2009-10-17 16:34:58 +00:00
Timo Stollenwerk
c9a5070681 Adding Persistent to subclasses of comment - this fixes five.intid choking on Comments in the catalog on reinstall. evilbungle branch merge.
svn path=/plone.app.discussion/trunk/; revision=30670
2009-10-17 16:29:45 +00:00
Timo Stollenwerk
8db9c8c175 Removing hard coded publish action. evilbungle branch merge.
svn path=/plone.app.discussion/trunk/; revision=30669
2009-10-17 16:14:44 +00:00
Timo Stollenwerk
7ef2672e5c Making captcha validator only adapt for the appropriate browser layer. This fixes the captcha error issue when p.a.d is in a deployment but not installed yet. evilbungle branch merge.
svn path=/plone.app.discussion/trunk/; revision=30667
2009-10-17 14:13:27 +00:00
Timo Stollenwerk
7cd9ef2491 Changing browser:view registrations to browser:page since view doesn't actually do anything with the permissions. This fixes the anyone can delete comments problem. evilbungle branch merge.
svn path=/plone.app.discussion/trunk/; revision=30665
2009-10-17 13:50:55 +00:00
Timo Stollenwerk
78d547daa6 Replacing infinite-recursion happy traverse_parent_folders method with one based on aq_chain; evilbungle branch merge.
svn path=/plone.app.discussion/trunk/; revision=30660
2009-10-17 09:33:58 +00:00
Timo Stollenwerk
60b6196736 Show info message after adding a comment when moderation is enabled.
svn path=/plone.app.discussion/trunk/; revision=30659
2009-10-17 09:17:13 +00:00
Timo Stollenwerk
1ea36d7d82 Conversation indexers won't work on old discussion items. Fix tests.
svn path=/plone.app.discussion/trunk/; revision=30658
2009-10-17 08:28:50 +00:00
Timo Stollenwerk
e5f1a70de6 Make unit tests pass with Plone 3.3 again. Migration tests still failing.
svn path=/plone.app.discussion/trunk/; revision=30633
2009-10-16 12:11:58 +00:00
Hanno Schlichting
6e8f812eee Duh, I wanted the new CatalogAware without the OpaqueItemManager base, not the old CMFCatalogAware
svn path=/plone.app.discussion/trunk/; revision=30630
2009-10-16 00:51:58 +00:00
Hanno Schlichting
71ed707794 Get this running again for the most part under Plone 4.0 - the main trick was probably to use the new CMFCatalogAware class. Removed collective.testcaselayer dependency, as that broke totally. There's some test failures left, but indexing works in general. Maybe the custom indexing event handlers aren't all required anymore. The title_or_id test failure looks like there's an infinite loop in the __parent__ pointers never reaching the actual content object. This change breaks Plone 3.x compatibility for the moment.
svn path=/plone.app.discussion/trunk/; revision=30629
2009-10-16 00:42:08 +00:00
Timo Stollenwerk
c19feeab6e remove clear-and-rebuild catalog from known issues and todo.
svn path=/plone.app.discussion/trunk/; revision=30612
2009-10-15 10:45:35 +00:00
Timo Stollenwerk
f4a4b6e370 fix catalog clear-and-rebuild. this finally fixes story 847941.
svn path=/plone.app.discussion/trunk/; revision=30610
2009-10-15 10:11:12 +00:00
Timo Stollenwerk
9befc4c651 Monkey patch for clear-and-rebuild catalog added. This fixes story 847941. Nested comments are not reindexed yet.
svn path=/plone.app.discussion/trunk/; revision=30574
2009-10-14 14:58:08 +00:00
Timo Stollenwerk
83b631413a revert r30055, since p.a.d. will not become part of Plone 4.
svn path=/plone.app.discussion/trunk/; revision=30462
2009-10-12 18:46:03 +00:00
Timo Stollenwerk
b09d42e505 fix has_replies function when get_replies returns None.
svn path=/plone.app.discussion/trunk/; revision=30256
2009-10-07 20:50:01 +00:00
Timo Stollenwerk
f0cbc787ab has_replies function added to get only published comments for anon users. elro review fix. refs #9288
svn path=/plone.app.discussion/trunk/; revision=30252
2009-10-07 20:07:55 +00:00
Timo Stollenwerk
6daa8824fb Hide the editable-object border in moderation view. elro review fix. refs #9288
svn path=/plone.app.discussion/trunk/; revision=30244
2009-10-07 11:52:44 +00:00
Timo Stollenwerk
f9115d6f87 "comment objects are not indexed with Plone 4" added to known issues.
svn path=/plone.app.discussion/trunk/; revision=30087
2009-09-30 21:10:36 +00:00