Gil Forcada
26a21a12d5
Reindex comments when they are modified
2016-09-20 13:05:24 +02:00
Gil Forcada
d5e7afcd23
Use zope.interface decorator
...
This not only makes code more pleasent to read,
but also makes the code python 3 compatible
(while maintaining python 2 compatibility).
2016-07-08 23:17:03 +02:00
Gil Forcada
cb1bf28c16
Cleanup
...
Follow https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst
to clean up the code.
2016-02-05 09:43:42 +01:00
Gil Forcada
19fe254916
Remove i18n:registerTranslations directive
2015-11-09 22:47:46 +01:00
Gil Forcada
182342833b
Remove locales folder
...
Translations have already been moved to plone.app.locales.
See:
https://github.com/plone/plone.app.discussion/pull/74
https://github.com/collective/plone.app.locales/commit/b063d4811fae2372ebc88258d0c50afc2aaac5b6
2015-11-09 22:45:21 +01:00
Gil Forcada
dba633e127
Update CHANGES
2015-11-09 22:29:47 +01:00
Gil Forcada
0713bcd8bc
Use plone i18n domain
...
plone.app.discussion is an official Plone core package,
thus their translations belong to plone.app.locales.
This commit removes the plone.app.discussion domain and changes it for
plone.
This fixes:
https://github.com/plone/plone.app.discussion/issues/66
2015-11-05 00:30:42 +01:00
Gil Forcada Codinachs
4556486082
Merge pull request #67 from plonejp/master
...
Updated Japanese translation
2015-05-11 08:39:58 +02:00
Gil Forcada
add7610466
Add changelog entries
2015-05-03 23:10:45 +02:00
Gil Forcada
7c8a1371ee
'X not in Y'
2015-05-03 08:56:58 +02:00
Gil Forcada
dcb2a5f51b
2 spaces between top level classes
2015-05-03 08:43:22 +02:00
Gil Forcada
8410b7525f
Do not redefine comment
2015-05-03 08:42:52 +02:00
Gil Forcada
754e712372
Typo
2015-05-03 08:42:07 +02:00
Gil Forcada
ce48a9ed46
2 spaces before inline comment
2015-05-03 08:41:56 +02:00
Gil Forcada
8b883451ca
80 chars
2015-05-03 08:41:24 +02:00
Gil Forcada
fad5a96129
Unused variable
2015-05-03 08:27:21 +02:00
Gil Forcada
411f36e708
One argument per line
2015-05-03 08:27:03 +02:00
Gil Forcada
2baafcbfd8
Typo
2015-05-03 08:25:19 +02:00
Gil Forcada
0ade2c4329
'X not in Y' is recommended
2015-05-03 08:25:08 +02:00
Gil Forcada
9066183ea9
2 lines between top level functions/classes
2015-05-03 08:24:08 +02:00
Gil Forcada
4bc77a2831
Sort imports
...
Remove unused ones as well.
2015-05-03 08:16:41 +02:00
Gil Forcada
b4cc3b0f54
Revert "Trigger jenkins"
...
This reverts commit b550683868
2015-04-05 00:42:00 +02:00
Gil Forcada
b550683868
Trigger jenkins
2015-04-05 00:39:08 +02:00
Gil Forcada
83046caf73
Merge pull request #63 from plone/davisagli-test-fixture
...
create doc1 once in the text fixture rather than in setup for each test
2015-03-10 09:46:28 +01:00
Gil Forcada
2faf69bdbb
Merge pull request #62 from plone/acquisition-total-comments-4
...
Acquisition total comments
2015-02-25 21:47:42 +01:00
Gil Forcada
2a423095ab
Add note on CHANGES.rst
2015-02-25 21:47:08 +01:00
Gil Forcada
4ea41aba43
Fix tests
2015-02-16 16:35:43 +01:00
Gil Forcada
d5b5b1c2cd
Fix total_comments indexer
...
"@property removes Acquisition wrappers from 'self'.
I don't remember why exactly (some implementation detail of Acquisition),
but it's a fact of life."
Quote from @davisagli on
https://github.com/plone/plone.app.discussion/pull/58
In short: removing the @property from total_comments fix the problem.
2015-02-16 11:31:47 +01:00
Gil Forcada
535af3aace
Count acquisition wrapped comments
...
If the View permission is not set directly on the workflow,
but instead is left to be acquired,
total_comments will always return 0.
2015-02-16 11:28:49 +01:00
Gil Forcada
b4c1d9e42d
Sort imports
...
As per the styleguide
2015-02-16 10:22:09 +01:00
Gil Forcada
19026439dd
Use spaces please
2014-12-03 12:03:26 +01:00
Gil Forcada
fa127ad85c
Whitespaces cleanup
2014-08-23 00:31:28 +02:00
Gil Forcada