ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,101 Commits 1 Branch 0 Tags 5 MiB
1682c89745
Commit Graph

835 Commits

Author SHA1 Message Date
Timo Stollenwerk
093eaa393a Use tuple() to test for generators. Thanks to otacon! 
svn path=/plone.app.discussion/trunk/; revision=42096
 2010-10-30 18:58:20 +00:00
Timo Stollenwerk
cc96acb50a Ajaxify comment deletion and approval. thanks thomasdesvenain! 
svn path=/plone.app.discussion/trunk/; revision=40984
 2010-10-30 17:32:31 +00:00
Timo Stollenwerk
82afd3ef15 New feature: As a logged-in user, I can enable/disable email notification of additional comments on this content object. 
svn path=/plone.app.discussion/trunk/; revision=40949
 2010-10-30 15:02:05 +00:00
Timo Stollenwerk
5fe339215b Use the jstestdriver coverage plugin. 
svn path=/plone.app.discussion/trunk/; revision=40909
 2010-10-30 11:24:03 +00:00
Timo Stollenwerk
380b81bd3e Disable the moderation qunit tests for now because they are currently failing. 
svn path=/plone.app.discussion/trunk/; revision=40907
 2010-10-30 11:12:04 +00:00
Timo Stollenwerk
0820d3771f Basic js-test-driver configuration added. 
svn path=/plone.app.discussion/trunk/; revision=40892
 2010-10-30 10:22:21 +00:00
Timo Stollenwerk
81dcdeaea3 Disable the plone.app.registry check on schema elements, so no error is raised on upgrades. This fixes https://dev.plone.org/plone/ticket/11195. Refs #11195 
svn path=/plone.app.discussion/trunk/; revision=40868
 2010-10-29 10:43:46 +00:00
Timo Stollenwerk
f6b7ef1bcb Remove the too generic id attribute of the comment form. 
svn path=/plone.app.discussion/trunk/; revision=40858
 2010-10-28 10:30:10 +00:00
Timo Stollenwerk
777e687169 Rename the id of the comment form from "form" to "comment-form". 
svn path=/plone.app.discussion/trunk/; revision=40857
 2010-10-28 09:45:34 +00:00
Timo Stollenwerk
22e4189c37 Revert revisions r40851 to r40853, they should have gone into the ajax-ui branch. 
svn path=/plone.app.discussion/trunk/; revision=40856
 2010-10-28 09:39:00 +00:00
Timo Stollenwerk
14e2600a79 Make ajax call for delete comment button work for comment replies. 
svn path=/plone.app.discussion/trunk/; revision=40853
 2010-10-27 16:10:04 +00:00
Timo Stollenwerk
926e4f6b8e Integrate Denys ajax ui code. 
svn path=/plone.app.discussion/trunk/; revision=40852
 2010-10-27 14:44:52 +00:00
Timo Stollenwerk
79f4481722 Use "#comment-form" as id for the comment form instead of "#form" which is too generic. 
svn path=/plone.app.discussion/trunk/; revision=40851
 2010-10-27 14:44:06 +00:00
Hanno Schlichting
aa8a1ea934 Fixed handling of non-ascii member data, like fullname and email. 
svn path=/plone.app.discussion/trunk/; revision=40789
 2010-10-22 10:14:07 +00:00
Hanno Schlichting
54bbb08c62 Whitespace removal 
svn path=/plone.app.discussion/trunk/; revision=40788
 2010-10-22 09:57:55 +00:00
Andreas Jung
8fc3dda8e6 wrong language-code 
svn path=/plone.app.discussion/trunk/; revision=40586
 2010-10-11 09:37:28 +00:00
Radim Novotny
18e92f7a85 - Fixed "global name 'WrongCaptchaCode' is not defined" if norobots captcha, 
but no other validation package is installed.

svn path=/plone.app.discussion/trunk/; revision=40574
 2010-10-09 11:13:28 +00:00
Timo Stollenwerk
f7ed357a83 Use 'comment_review_workflow' instead of 'simple_publication_workflow' for testing. 
svn path=/plone.app.discussion/trunk/; revision=40571
 2010-10-08 11:03:14 +00:00
Timo Stollenwerk
324d2274bd Check for a 'pending' state in the current comment workflow instead of checking for the 'comment_review' workflow. Refs #11184. Merge last three submits in CHANGES.txt. 
svn path=/plone.app.discussion/trunk/; revision=40570
 2010-10-08 10:37:10 +00:00
Timo Stollenwerk
6e9bb4a9cd Check the review_state to decide if moderation is enabled. If the current comment workflow implements a 'pending' state, moderation is enabled. Refs #11184. 
svn path=/plone.app.discussion/trunk/; revision=40569
 2010-10-08 10:22:40 +00:00
Timo Stollenwerk
2790e6d4eb Check the review_state instead of the workflow after a comment has been posted to decide if a message is shown to the user. This allows integrators to use custom review workflows. Refs #11184 
svn path=/plone.app.discussion/trunk/; revision=40566
 2010-10-08 09:53:00 +00:00
Timo Stollenwerk
43d3222086 Run functional tests only with Plone 4 (and plone.testing). 
svn path=/plone.app.discussion/trunk/; revision=40537
 2010-10-06 15:12:11 +00:00
Timo Stollenwerk
94584429fd Do not use has_key. 
svn path=/plone.app.discussion/trunk/; revision=40536
 2010-10-06 14:12:30 +00:00
Timo Stollenwerk
4bbfe677e4 Replace the can_manage method with a can_review method that checks the 'Review comments' permission. This fixes http://dev.plone.org/plone/ticket/11145. 
svn path=/plone.app.discussion/trunk/; revision=40534
 2010-10-06 13:55:57 +00:00
Timo Stollenwerk
3e73903a8d Remove (old) functional test. 
svn path=/plone.app.discussion/trunk/; revision=40533
 2010-10-06 13:53:07 +00:00
Timo Stollenwerk
1230e67a01 Functional test for comment_review_workflow added; existing fonctional test renamed to functional_test_comments.txt; 
svn path=/plone.app.discussion/trunk/; revision=40532
 2010-10-06 13:52:11 +00:00
Timo Stollenwerk
1db321a044 Make pylint happy. 
svn path=/plone.app.discussion/trunk/; revision=40527
 2010-10-06 09:02:26 +00:00
Timo Stollenwerk
f9ca4497bd Obey the 80 chars limit. 
svn path=/plone.app.discussion/trunk/; revision=40526
 2010-10-06 08:47:24 +00:00
Timo Stollenwerk
94b0c58511 Fix pylint disable-msg statements. 
svn path=/plone.app.discussion/trunk/; revision=40521
 2010-10-05 15:54:49 +00:00
Timo Stollenwerk
fbb042c012 Remove unused import. 
svn path=/plone.app.discussion/trunk/; revision=40520
 2010-10-05 15:52:19 +00:00
Timo Stollenwerk
773345c40f Make pylint happy. 
svn path=/plone.app.discussion/trunk/; revision=40519
 2010-10-05 15:47:02 +00:00
Timo Stollenwerk
7de585542b Fix moderation actions (publish, delete) in the moderation view with virtual hosts. This is a replacement for http://dev.plone.org/plone/changeset/35608. 
svn path=/plone.app.discussion/trunk/; revision=40518
 2010-10-05 15:21:54 +00:00
Timo Stollenwerk
b984a445d5 Inline documentation for moderation view added. 
svn path=/plone.app.discussion/trunk/; revision=40517
 2010-10-05 15:14:12 +00:00
Timo Stollenwerk
7e42a39346 Remove .mo file from subversion. 
svn path=/plone.app.discussion/trunk/; revision=40516
 2010-10-05 14:07:39 +00:00
Timo Stollenwerk
837e6b2966 Do not show two "login to add comments" buttons when there are no comments yet. This fixes http://plone.org/products/plone.app.discussion/issues/12. 
svn path=/plone.app.discussion/trunk/; revision=40515
 2010-10-05 12:07:08 +00:00
Timo Stollenwerk
51642c2e0f German translations updated. 
svn path=/plone.app.discussion/trunk/; revision=40506
 2010-10-04 18:59:42 +00:00
Timo Stollenwerk
9841ba7229 Remove unnecessary decode statement from creator. 
svn path=/plone.app.discussion/trunk/; revision=40503
 2010-10-04 13:48:54 +00:00
Timo Stollenwerk
0ee649fb6c Functional test for special characters added. Remove unnecessary decode statement from creator. 
svn path=/plone.app.discussion/trunk/; revision=40502
 2010-10-04 13:48:27 +00:00
Timo Stollenwerk
b06ba43a75 Ignore currently unused code from code coverage. Overall code coverage is up to 95%. 
svn path=/plone.app.discussion/trunk/; revision=40497
 2010-10-03 19:54:59 +00:00
Timo Stollenwerk
6d92d1383c Remove comment title from comments viewlet tests. 
svn path=/plone.app.discussion/trunk/; revision=40496
 2010-10-03 19:41:02 +00:00
Timo Stollenwerk
ede295e649 Functional test for posting a comment with comment review workflow enabled. 
svn path=/plone.app.discussion/trunk/; revision=40495
 2010-10-03 19:07:30 +00:00
Timo Stollenwerk
603bcf3547 Ignore certain lines for code coverage. 
svn path=/plone.app.discussion/trunk/; revision=40494
 2010-10-03 16:52:26 +00:00
Timo Stollenwerk
f5cf756e31 Functional test for replying to an existing comment added. 
svn path=/plone.app.discussion/trunk/; revision=40493
 2010-10-03 16:50:47 +00:00
Timo Stollenwerk
497c2a075e There is no need to set the title in the handleComment method anymore. 
svn path=/plone.app.discussion/trunk/; revision=40492
 2010-10-03 07:29:44 +00:00
Timo Stollenwerk
e0055d0ba7 Make sure comment titles work with special characters as well. 
svn path=/plone.app.discussion/trunk/; revision=40486
 2010-10-02 18:16:49 +00:00
Timo Stollenwerk
51d6c60412 Use the right event subscriber to make sure all comments are removed from the catalog, if their content object is deleted. 
svn path=/plone.app.discussion/trunk/; revision=40485
 2010-10-02 14:50:17 +00:00
Luca Fabbri
1edbf3a262 italian translation updated 
svn path=/plone.app.discussion/trunk/; revision=40461
 2010-09-30 22:00:24 +00:00
Luca Fabbri
2d603c2c0e italian translation updated 
svn path=/plone.app.discussion/trunk/; revision=40460
 2010-09-30 21:52:40 +00:00
Timo Stollenwerk
0e27b8b7b6 Move regression test for #11157 into the main functional test. 
svn path=/plone.app.discussion/trunk/; revision=40458
 2010-09-30 17:45:26 +00:00
Timo Stollenwerk
22db0b1c78 Fix comment title for anonymous commentators that do not provide a name. 
svn path=/plone.app.discussion/trunk/; revision=40435
 2010-09-29 10:52:11 +00:00
Timo Stollenwerk
2cce7e0d0f "Post comment as logged-in users" test added. 
svn path=/plone.app.discussion/trunk/; revision=40434
 2010-09-29 10:17:25 +00:00
Timo Stollenwerk
689fd26c12 Apply the comment viewlet template and styles to the new title-less comments. This might require integrators to apply their custom templates and styles. 
svn path=/plone.app.discussion/trunk/; revision=40433
 2010-09-29 08:13:54 +00:00
Timo Stollenwerk
8d00463502 Remove subject line from comment batch moderation view, since this doesn't make sense anymore with auto-generated titles. 
svn path=/plone.app.discussion/trunk/; revision=40432
 2010-09-29 08:02:39 +00:00
Timo Stollenwerk
f67c7cde6d Remove title field from the comment form and replace it with an auto-generated title ("John Doe on Welcome to Plone"). 
This also fixes http://dev.plone.org/plone/ticket/11098

svn path=/plone.app.discussion/trunk/; revision=40431
 2010-09-29 07:56:36 +00:00
Timo Stollenwerk
7df932204c Functional plone.testing doctest added. 
svn path=/plone.app.discussion/trunk/; revision=40393
 2010-09-28 16:35:45 +00:00
Timo Stollenwerk
138942470c Make sure the __parent__ pointer (the conversation) of a comment is not acquisition wrapped in conversation.addComment. This fixes Refs #11157. 
svn path=/plone.app.discussion/trunk/; revision=40374
 2010-09-28 10:37:40 +00:00
Timo Stollenwerk
a55ff5b883 Fix pickle regression test. 
svn path=/plone.app.discussion/trunk/; revision=40373
 2010-09-28 10:18:16 +00:00
Timo Stollenwerk
77e44f96ad Added test (currently failing) to trigger "can't pickle objects in acquisition wrapper". Refs #11157 
svn path=/plone.app.discussion/trunk/; revision=40357
 2010-09-27 19:03:43 +00:00
Timo Stollenwerk
58868c55e7 whitespace. 
svn path=/plone.app.discussion/trunk/; revision=40232
 2010-09-24 19:45:57 +00:00
Timo Stollenwerk
e95ae26a11 Fix moderation test headline. 
svn path=/plone.app.discussion/trunk/; revision=40229
 2010-09-24 19:04:35 +00:00
Timo Stollenwerk
cf11a5134a Javascript tests for the bulk moderation view added (currently failing). 
svn path=/plone.app.discussion/trunk/; revision=40228
 2010-09-24 19:04:03 +00:00
Timo Stollenwerk
ad99e45203 Revert r35608 since this was breaking the comment moderation bulk actions. The BulkActionsView expects the absolute path of the comments without the portal url (e.g. '/plone/doc1/++conversation++default/1285346769126020'). This fixes https://dev.plone.org/plone/ticket/11156. 
svn path=/plone.app.discussion/trunk/; revision=40227
 2010-09-24 17:04:24 +00:00
Timo Stollenwerk
2ff95fe847 Make sure the moderation JS functions are executed after the page is fully loaded. 
svn path=/plone.app.discussion/trunk/; revision=40215
 2010-09-24 14:57:19 +00:00
Timo Stollenwerk
399bba5eca Use "(function($) { /* some code that uses $ */ })(jQuery)" instead of "$(document).ready(function(){ /* some code that uses $ */ });" to invoke jQuery code. 
svn path=/plone.app.discussion/trunk/; revision=40214
 2010-09-24 14:21:26 +00:00
Timo Stollenwerk
57758d2cf8 More workflow tests. 
svn path=/plone.app.discussion/trunk/; revision=40203
 2010-09-24 13:33:21 +00:00
Timo Stollenwerk
ea26c70eed Clean up whitespace, change workflow description. 
svn path=/plone.app.discussion/trunk/; revision=40192
 2010-09-24 03:12:12 +00:00
Timo Stollenwerk
41c9d030d8 Clean up whitespace, change workflow description. 
svn path=/plone.app.discussion/trunk/; revision=40191
 2010-09-24 03:11:39 +00:00
Timo Stollenwerk
d77ca9d583 Commenting form explanation added. 
svn path=/plone.app.discussion/trunk/; revision=40167
 2010-09-23 14:46:24 +00:00
Timo Stollenwerk
c364630a8c js test for comments updated. 
svn path=/plone.app.discussion/trunk/; revision=40166
 2010-09-23 14:42:18 +00:00
Timo Stollenwerk
9d0fa61c4d Remove unnecessary XXX since we already use layers. 
svn path=/plone.app.discussion/trunk/; revision=40165
 2010-09-23 12:56:17 +00:00
Timo Stollenwerk
f1cf4c9688 Translation files updated. 
svn path=/plone.app.discussion/trunk/; revision=40154
 2010-09-23 11:06:38 +00:00
Timo Stollenwerk
0cee7c541d Finnish translation added. 
svn path=/plone.app.discussion/trunk/; revision=40153
 2010-09-23 11:04:47 +00:00
Radim Novotny
685fc2874d Updated Czech i18n 
svn path=/plone.app.discussion/trunk/; revision=40140
 2010-09-22 15:03:04 +00:00
Timo Stollenwerk
6b4fd0f0c1 Ignore certain lines for code coverage. 
svn path=/plone.app.discussion/trunk/; revision=40083
 2010-09-20 10:03:55 +00:00
Timo Stollenwerk
cbde125048 Ignore certain lines for code coverage. 
svn path=/plone.app.discussion/trunk/; revision=40082
 2010-09-20 10:03:38 +00:00
Timo Stollenwerk
aeabd6fc11 Ignore certain lines for code coverage. 
svn path=/plone.app.discussion/trunk/; revision=40081
 2010-09-20 10:02:07 +00:00
Timo Stollenwerk
4b3473f74b Always provide that path param for bulk action view tests. 
svn path=/plone.app.discussion/trunk/; revision=40004
 2010-09-18 17:02:37 +00:00
Timo Stollenwerk
14c0a3a4d1 Remove wrong_bulkaction test. 
svn path=/plone.app.discussion/trunk/; revision=39946
 2010-09-16 15:44:07 +00:00
Timo Stollenwerk
e8a4caa5db Some more tests for moderation bulk actions. 
svn path=/plone.app.discussion/trunk/; revision=39945
 2010-09-16 15:42:27 +00:00
Timo Stollenwerk
742412a7d8 Test publish bulk actions as well. 
svn path=/plone.app.discussion/trunk/; revision=39943
 2010-09-16 15:12:59 +00:00
Timo Stollenwerk
8d866a0ff6 Tests for moderate comments bulk actions added. 
svn path=/plone.app.discussion/trunk/; revision=39942
 2010-09-16 14:58:11 +00:00
Timo Stollenwerk
087efab54a Trying to fix the comments viewlet functional tests on Plone 3.x. 
svn path=/plone.app.discussion/trunk/; revision=39932
 2010-09-16 12:41:01 +00:00
Timo Stollenwerk
3d594a934d Captcha plugin support for collective.z3cform.norobots added. 
svn path=/plone.app.discussion/trunk/; revision=39848
 2010-09-10 13:02:56 +00:00
Karl Johan Kleist
59dc83cb88 speling error in field description, closes #11093 
svn path=/plone.app.discussion/trunk/; revision=39845
 2010-09-10 05:00:47 +00:00
Patrick Gerken
823da240d8 Change datetime conversion to handle TZ 
The way it happens now, the timezone gets corrected

svn path=/plone.app.discussion/trunk/; revision=39728
 2010-09-07 12:03:31 +00:00
Patrick Gerken
697d9af803 Test that correct local time gets displayed. 
Since we now store the utc time in comments, we display
code must not only format the date correctly, but show the correct
local time.

svn path=/plone.app.discussion/trunk/; revision=39727
 2010-09-07 12:03:18 +00:00
Patrick Gerken
a7b1eb7c10 Change all datetime creations from now to utcnow 
svn path=/plone.app.discussion/trunk/; revision=39726
 2010-09-07 12:03:07 +00:00
Patrick Gerken
4e43cfed2e Adding a test to assert that dates get stored utc 
and not in local time

svn path=/plone.app.discussion/trunk/; revision=39725
 2010-09-07 12:02:55 +00:00
Timo Stollenwerk
68a264c9d9 Use unicode strings for test requests in test_comments_viewlet to make the Plone 3 tests happy. 
svn path=/plone.app.discussion/trunk/; revision=39680
 2010-09-06 10:40:06 +00:00
Timo Stollenwerk
0358a03d5b Fetch context for the comment view with "context = aq_inner(self.context)". This fixes a failing Plone 3 test. 
svn path=/plone.app.discussion/trunk/; revision=39678
 2010-09-06 10:38:54 +00:00
Timo Stollenwerk
288732d276 Removed unused imports from test_comments_viewlet tests. 
svn path=/plone.app.discussion/trunk/; revision=39632
 2010-09-03 21:57:36 +00:00
Timo Stollenwerk
a4011ce414 Fix the comment view test. 
svn path=/plone.app.discussion/trunk/; revision=39629
 2010-09-03 21:23:44 +00:00
Timo Stollenwerk
ea13020498 Raise an unauthorized error when authenticated users try to post a comment on a content object that has discussion disabled. Thanks to vincentfrentin for reporting this! 
svn path=/plone.app.discussion/trunk/; revision=39627
 2010-09-03 20:40:27 +00:00
Timo Stollenwerk
a410c72333 Complete comments form integration test. 
svn path=/plone.app.discussion/trunk/; revision=39610
 2010-09-02 20:52:33 +00:00
Timo Stollenwerk
4f4f9f9cec Fix whitespace for coverage test. 
svn path=/plone.app.discussion/trunk/; revision=39609
 2010-09-02 20:21:53 +00:00
Timo Stollenwerk
81cba38a74 Comment form test added. 
svn path=/plone.app.discussion/trunk/; revision=39608
 2010-09-02 20:00:43 +00:00
Radim Novotny
237d9170c5 Added Czech translation 
svn path=/plone.app.discussion/trunk/; revision=39589
 2010-09-01 08:53:39 +00:00
Vincent Fretin
4b15b31e51 Translate the subject and be sure to set the charset to utf-8 for the mail. 
svn path=/plone.app.discussion/trunk/; revision=39587
 2010-09-01 07:32:28 +00:00
Vincent Fretin
da81b1073b Fixed translation 
svn path=/plone.app.discussion/trunk/; revision=39586
 2010-09-01 07:30:14 +00:00
Vincent Fretin
0d2e23842e Removed empty description for text transform 
svn path=/plone.app.discussion/trunk/; revision=39585
 2010-09-01 07:25:04 +00:00
Vincent Fretin
72f715dd4a Updated French translation 
svn path=/plone.app.discussion/trunk/; revision=39584
 2010-09-01 07:23:34 +00:00
Vincent Fretin
c3f49298fb plone.app.discussion: 3 messages added 
svn path=/plone.app.discussion/trunk/; revision=39583
 2010-09-01 07:21:48 +00:00
Vincent Fretin
d5baae3eec Fixed variables in the template for use with the i18n machinery 
svn path=/plone.app.discussion/trunk/; revision=39582
 2010-09-01 07:19:51 +00:00
Vincent Fretin
f5bed31131 internationalize notification mail 
svn path=/plone.app.discussion/trunk/; revision=39572
 2010-08-31 18:07:51 +00:00
Timo Stollenwerk
87ce946947 Removed unused imports. Raise ImportError when import fails. 
svn path=/plone.app.discussion/trunk/; revision=39571
 2010-08-31 17:36:28 +00:00
Timo Stollenwerk
77d3bc2eb1 Obey the 80 chars limit. 
svn path=/plone.app.discussion/trunk/; revision=39570
 2010-08-31 17:33:22 +00:00
Timo Stollenwerk
d59369a408 Obey the 80 chars limit. 
svn path=/plone.app.discussion/trunk/; revision=39569
 2010-08-31 17:31:27 +00:00
Timo Stollenwerk
9c5f1dd1d8 Unused imports removed. 
svn path=/plone.app.discussion/trunk/; revision=39568
 2010-08-31 17:29:26 +00:00
Timo Stollenwerk
8d915b6327 Obey the 80 chars limit. 
svn path=/plone.app.discussion/trunk/; revision=39567
 2010-08-31 17:28:07 +00:00
Timo Stollenwerk
23122ded8b Test if registry has been registered. 
svn path=/plone.app.discussion/trunk/; revision=39356
 2010-08-28 22:58:23 +00:00
Timo Stollenwerk
dc160f9d5e Obey the 80 chars limit in the comments view. 
svn path=/plone.app.discussion/trunk/; revision=39332
 2010-08-28 20:19:58 +00:00
Timo Stollenwerk
785b006394 Obey the 80 chars limit in the migration function. 
svn path=/plone.app.discussion/trunk/; revision=39331
 2010-08-28 20:18:36 +00:00
Timo Stollenwerk
632e167806 revert 39237 since this breaks some tests. 
svn path=/plone.app.discussion/trunk/; revision=39330
 2010-08-28 20:10:48 +00:00
Timo Stollenwerk
a2a8956d09 Obey the 80 char limit. 
svn path=/plone.app.discussion/trunk/; revision=39327
 2010-08-28 20:02:08 +00:00
Timo Stollenwerk
cef90c576b remove author_username variable, because it is unused. 
svn path=/plone.app.discussion/trunk/; revision=39325
 2010-08-28 19:54:57 +00:00
Timo Stollenwerk
87b2c5dd02 Comment out author_notification because we don't use it right now. 
svn path=/plone.app.discussion/trunk/; revision=39324
 2010-08-28 19:51:53 +00:00
Timo Stollenwerk
946ff36190 "W0622 total_comments: Redefining built-in 'object'" added to pylint msg ignores. 
svn path=/plone.app.discussion/trunk/; revision=39323
 2010-08-28 19:48:40 +00:00
Timo Stollenwerk
318afe5aae Fix indentation. 
svn path=/plone.app.discussion/trunk/; revision=39322
 2010-08-28 19:45:53 +00:00
Timo Stollenwerk
4390b8929b Revert r39314. zptlint failed as expected. hudson integration works! 
svn path=/plone.app.discussion/trunk/; revision=39319
 2010-08-28 19:31:17 +00:00
Timo Stollenwerk
133da3d305 BREAK templates to check if zptlint in hudson works. Will be reverted immediately. 
svn path=/plone.app.discussion/trunk/; revision=39314
 2010-08-28 19:19:27 +00:00
Timo Stollenwerk
435040e0b2 Make pylint happy. 
svn path=/plone.app.discussion/trunk/; revision=39287
 2010-08-28 17:06:53 +00:00
Timo Stollenwerk
0f9c98ec97 Obey the 80 chars limit. 
svn path=/plone.app.discussion/trunk/; revision=39272
 2010-08-28 16:11:58 +00:00
Timo Stollenwerk
5f5b831904 Be more specific, use ImportError. 
svn path=/plone.app.discussion/trunk/; revision=39270
 2010-08-28 16:08:36 +00:00
Timo Stollenwerk
e12d19a6e9 Fix bugs that have been introduced with the latest pylint "optimizations". 
svn path=/plone.app.discussion/trunk/; revision=39269
 2010-08-28 16:07:44 +00:00
Timo Stollenwerk
9264d2d42d Make pylint happy. 
svn path=/plone.app.discussion/trunk/; revision=39265
 2010-08-28 15:35:21 +00:00
Timo Stollenwerk
ba8e7ac5cd Move the functions out of the ready function. this makes the JS tests pass. 
svn path=/plone.app.discussion/trunk/; revision=39151
 2010-08-27 21:26:37 +00:00
Timo Stollenwerk
67fb426f08 Javascript doc added. 
svn path=/plone.app.discussion/trunk/; revision=39146
 2010-08-27 20:52:38 +00:00
Timo Stollenwerk
f4435a563b Remove unnecessary init test. remove namespaces from method calls. 
svn path=/plone.app.discussion/trunk/; revision=39145
 2010-08-27 20:51:19 +00:00
Timo Stollenwerk
9e405b47a1 qunit files added. 
svn path=/plone.app.discussion/trunk/; revision=39143
 2010-08-27 20:50:18 +00:00
Timo Stollenwerk
a1605fb88b Revert r39104 since it breaks the comments js. 
svn path=/plone.app.discussion/trunk/; revision=39141
 2010-08-27 20:45:11 +00:00
Timo Stollenwerk
d713409aa1 Use a discussion JS namespace for comments.js; JS tests for clearForm and createReplyForm functions added. 
svn path=/plone.app.discussion/trunk/; revision=39104
 2010-08-27 17:11:25 +00:00
Timo Stollenwerk
2c5d387cfc Rename js directory to javascripts. 
svn path=/plone.app.discussion/trunk/; revision=39066
 2010-08-27 12:07:04 +00:00
Timo Stollenwerk
e310c1d021 Basic JS tests added. 
svn path=/plone.app.discussion/trunk/; revision=39064
 2010-08-27 11:41:39 +00:00
Timo Stollenwerk
d3074fa4fd Make Javascripts pass JSLint validation 
svn path=/plone.app.discussion/trunk/; revision=39059
 2010-08-27 10:34:42 +00:00
Timo Stollenwerk
61565de95a Put email notification subscribers into their own zcml file so it is easier for integrators to override them. 
svn path=/plone.app.discussion/trunk/; revision=38981
 2010-08-26 09:31:49 +00:00
Timo Stollenwerk
a2c89ed5e8 Plain text and intelligent text options for comment text added to preserve basic text structure and to make links clickable. 
svn path=/plone.app.discussion/trunk/; revision=38931
 2010-08-25 14:03:29 +00:00
Timo Stollenwerk
35d7743b7a Plain text to HTML transformation added for comment text 
svn path=/plone.app.discussion/trunk/; revision=38898
 2010-08-25 09:19:28 +00:00
Vincent Fretin
17fce9d515 Rewrote all tal:condition in comments.pt. The authenticated user has 
the reply button and the comment form if he has the "Reply to item"
permission and the conversation is currently enabled.

Warning:
There is a security hole at the moment. Any authenticated user having the
zope2.View permission or anonymous user without captcha can add a comment
by creating a post request.

svn path=/plone.app.discussion/trunk/; revision=38888
 2010-08-24 11:25:17 +00:00
Vincent Fretin
352a517a0a Fixed the case where a folder has allow_discussion=False and 
conversation.enabled() on a document in this folder returned False
instead of True because of allow_discussion acquisition.

svn path=/plone.app.discussion/trunk/; revision=38835
 2010-08-20 11:52:05 +00:00
Timo Stollenwerk
7a2f1ff12b Fix indentation. 
svn path=/plone.app.discussion/trunk/; revision=38665
 2010-08-09 12:42:21 +00:00
Timo Stollenwerk
d37d5aa9f5 Redirect to the comment form action instead of the absolute url when a comment is posted. This fixes the accidentially triggered file upload when a comment is posted on a file content object. 
svn path=/plone.app.discussion/trunk/; revision=38664
 2010-08-09 12:25:14 +00:00
Vincent Fretin
7705e7facf Updated zh_TW translation 
svn path=/plone.app.discussion/trunk/; revision=38610
 2010-08-08 08:55:31 +00:00
Vincent Fretin
d75fe71a3b Add point 
svn path=/plone.app.discussion/trunk/; revision=38599
 2010-08-06 20:22:07 +00:00
Vincent Fretin
7c007b1306 You can now translate the title and description of the product. 
svn path=/plone.app.discussion/trunk/; revision=38597
 2010-08-06 19:22:19 +00:00
Vincent Fretin
8d6e960804 changed translation 
svn path=/plone.app.discussion/trunk/; revision=38596
 2010-08-06 19:17:18 +00:00
Vincent Fretin
69c2ce9556 Added 3 new messages from the single state workflow 
svn path=/plone.app.discussion/trunk/; revision=38583
 2010-08-06 17:24:05 +00:00
Vincent Fretin
be0a6cb685 Added zh_TW translation, use Domain:zh_TW (case sensitive) in plone-zh_TW.po 
svn path=/plone.app.discussion/trunk/; revision=38581
 2010-08-06 17:15:59 +00:00
Vincent Fretin
fd6a8e0fd8 * Renamed legend_add_comment to label_add_comment to have the translation from 
plone domain.
* label_comment_by and label_commented_at are not in Plone 4 translation anymore, so
  these two messages moved to plone.app.discussions i18n domain.

svn path=/plone.app.discussion/trunk/; revision=38574
 2010-08-06 15:33:34 +00:00
Vincent Fretin
86aee7a2ea Added French translation. 
svn path=/plone.app.discussion/trunk/; revision=38573
 2010-08-06 15:21:29 +00:00
Vincent Fretin
733c3439ca Translate "Warning" shown in @@moderate-comments in the plone domain. 
svn path=/plone.app.discussion/trunk/; revision=38568
 2010-08-06 10:46:37 +00:00
Vincent Fretin
da7e28be74 Fixed some typo 
svn path=/plone.app.discussion/trunk/; revision=38567
 2010-08-06 10:43:44 +00:00
Giorgio Borelli
38b5f7dbae italian translation update 
svn path=/plone.app.discussion/trunk/; revision=38566
 2010-08-06 10:34:04 +00:00
Vincent Fretin
d2b19deeac use double quotes 
svn path=/plone.app.discussion/trunk/; revision=38565
 2010-08-06 10:01:52 +00:00
Vincent Fretin
c1e861e969 Fixed i18n markup of message_moderation_disabled. 
svn path=/plone.app.discussion/trunk/; revision=38564
 2010-08-06 09:51:23 +00:00
Vincent Fretin
27710ca541 It's 'Allow comments', not 'enable moderation' 
svn path=/plone.app.discussion/trunk/; revision=38563
 2010-08-06 09:34:05 +00:00
Timo Stollenwerk
86c2bbe001 Spanish and German translation updated. 
svn path=/plone.app.discussion/trunk/; revision=38552
 2010-08-05 18:41:22 +00:00
Timo Stollenwerk
27a2d3fa36 Use only one MessageFactory. 
svn path=/plone.app.discussion/trunk/; revision=38551
 2010-08-05 18:40:22 +00:00
Timo Stollenwerk
25d1da3475 Spanish translation added. Thanks to Judith Sanleandro. 
svn path=/plone.app.discussion/trunk/; revision=38550
 2010-08-05 17:18:19 +00:00
Vincent Fretin
6d07243885 Added fr to the script and added the empty i18n/plone-fr.po file 
svn path=/plone.app.discussion/trunk/; revision=38549
 2010-08-05 17:00:05 +00:00
Vincent Fretin
d0cb939828 Added fr directory with empty po file 
svn path=/plone.app.discussion/trunk/; revision=38548
 2010-08-05 16:57:25 +00:00
Timo Stollenwerk
ae5754455b Translation files updated. Spanish translation added. 
svn path=/plone.app.discussion/trunk/; revision=38547
 2010-08-05 16:47:24 +00:00
Timo Stollenwerk
f72972844d Call the CaptchaValidator even when no captcha data was submitted. This is necessary to ensure that the collective.akismet validator is called when installed. 
svn path=/plone.app.discussion/trunk/; revision=38541
 2010-08-05 15:36:07 +00:00
Patrick Gerken
94e73b43a7 Catch TypeError in indexers if content can not be adapted 
Currently plone.app.discussion provides indexers
for IContentish. In these it tries to adapt
the content object to IDiscussion. But an IDiscussion Factory is only
provided for IAnnotatable.
The Criteria are IContentish but not IAnnotatable.
Indexing them fails

svn path=/plone.app.discussion/trunk/; revision=38182
 2010-07-21 23:36:16 +00:00
Timo Stollenwerk
0925a63c15 Unnecessary imports removed. 
svn path=/plone.app.discussion/trunk/; revision=38139
 2010-07-19 08:25:37 +00:00
Timo Stollenwerk
88ce860aa5 Use self.form instead of CommentForm for the CommentsViewlet update method so integrators don't have to override the viewlet's update method. [Matous] 
svn path=/plone.app.discussion/trunk/; revision=37916
 2010-07-16 15:26:01 +00:00
Timo Stollenwerk
85d5b823b0 Remove collective.akismet from the captcha documentation. 
svn path=/plone.app.discussion/trunk/; revision=37915
 2010-07-16 15:08:18 +00:00
Timo Stollenwerk
c3320def88 Make sure the form fields in the reply form are always placed under the field labels; Fix CSS overflow bug that occurs with the new Plone 4.0b5 comment styles 
svn path=/plone.app.discussion/trunk/; revision=37774
 2010-07-13 13:39:35 +00:00
Timo Stollenwerk
6ca6f58acd Remove unnecessary variables and imports. 
svn path=/plone.app.discussion/trunk/; revision=37773
 2010-07-13 13:21:12 +00:00
Timo Stollenwerk
a54a15a90f Remove unnecessary imports and variables from test code. 
svn path=/plone.app.discussion/trunk/; revision=37768
 2010-07-13 10:45:53 +00:00
Timo Stollenwerk
cfdd99b111 remove unnecessary imports / variables; whitespace 
svn path=/plone.app.discussion/trunk/; revision=37767
 2010-07-13 10:41:26 +00:00
Timo Stollenwerk
66c235aa5e fix whitespace 
svn path=/plone.app.discussion/trunk/; revision=37766
 2010-07-13 10:40:45 +00:00
Timo Stollenwerk
a5683b0674 remove unnecessary imports. 
svn path=/plone.app.discussion/trunk/; revision=37765
 2010-07-13 10:40:24 +00:00
Timo Stollenwerk
f3b1dab916 Move AkismetValidator from plone.app.discussion to collective.akismet. 
svn path=/plone.app.discussion/trunk/; revision=37764
 2010-07-13 09:24:23 +00:00
Timo Stollenwerk
5784ed82a3 Remove unnecessary imports from vocabularies.py. 
svn path=/plone.app.discussion/trunk/; revision=37763
 2010-07-13 09:23:10 +00:00
Timo Stollenwerk
31c0f7b459 Check for collective.akismet to detect akismet plugin, not for the Python akismet package. 
svn path=/plone.app.discussion/trunk/; revision=37762
 2010-07-13 09:22:05 +00:00
Timo Stollenwerk
2dbc337fc7 Remove unnecessary imports from captcha.py. 
svn path=/plone.app.discussion/trunk/; revision=37760
 2010-07-13 09:20:32 +00:00
Timo Stollenwerk
1a84b0b7b8 Remove unnecessary imports. 
svn path=/plone.app.discussion/trunk/; revision=37759
 2010-07-13 09:19:20 +00:00
Timo Stollenwerk
27d8ced62d revert r37751. 
svn path=/plone.app.discussion/trunk/; revision=37753
 2010-07-12 13:49:57 +00:00
Timo Stollenwerk
cac0bae7a5 revert r37751. 
svn path=/plone.app.discussion/trunk/; revision=37752
 2010-07-12 13:47:53 +00:00
Timo Stollenwerk
eabf3bc890 Always use zope.component getUtility instead of queryUtility. 
svn path=/plone.app.discussion/trunk/; revision=37751
 2010-07-12 13:34:02 +00:00
Timo Stollenwerk
bddc4a96da Remove unnecessary import. 
svn path=/plone.app.discussion/trunk/; revision=37692
 2010-07-07 11:37:44 +00:00
Yiorgis Gozadinos
d0273e57bb Added norwegian translation. 
svn path=/plone.app.discussion/trunk/; revision=37646
 2010-07-05 12:14:16 +00:00
Hanno Schlichting
9d396e43f1 Protect against missing canonical in conversationCanonicalAdapterFactory. 
svn path=/plone.app.discussion/trunk/; revision=37410
 2010-06-25 17:16:15 +00:00
Timo Stollenwerk
5f2daced20 Captcha documentation updated (code examples included, etc). 
svn path=/plone.app.discussion/trunk/; revision=37369
 2010-06-21 09:11:45 +00:00
Hanno Schlichting
f7c18ea77e No tabs please 
svn path=/plone.app.discussion/trunk/; revision=37350
 2010-06-18 12:19:33 +00:00
Hanno Schlichting
7d3247ff0c Avoid deprecation warning for the Globals package. 
svn path=/plone.app.discussion/trunk/; revision=37349
 2010-06-18 12:01:44 +00:00
Timo Stollenwerk
12589d9fd2 Remove the hard coded check for title and text when the comment form is submitted. This allows integrators to write schema extenders that remove the title from the comment form. 
svn path=/plone.app.discussion/trunk/; revision=37341
 2010-06-17 18:56:26 +00:00
Timo Stollenwerk
6e98edf54f Fix ascii art blocks. 
svn path=/plone.app.discussion/trunk/; revision=37336
 2010-06-17 09:01:59 +00:00
Timo Stollenwerk
400956e264 Comments added to the notification subscriber functions. 
svn path=/plone.app.discussion/trunk/; revision=37329
 2010-06-17 06:57:51 +00:00
Timo Stollenwerk
e56bc65956 raise AkismetReject if Akismet rejects a comment as spam. 
svn path=/plone.app.discussion/trunk/; revision=37276
 2010-06-14 13:02:46 +00:00
Timo Stollenwerk
ac84b232b8 Import Captcha validator from validator directly. 
svn path=/plone.app.discussion/trunk/; revision=37273
 2010-06-14 12:42:28 +00:00
Timo Stollenwerk
29015324f2 Move the Akismet validator error message to the top. 
svn path=/plone.app.discussion/trunk/; revision=37272
 2010-06-14 12:25:56 +00:00
Timo Stollenwerk
ac6865311d Move captcha registration to its own captcha.zcml file. Fix captcha registration for Plone 3/Zope 2.10 
svn path=/plone.app.discussion/trunk/; revision=37140
 2010-06-10 14:57:03 +00:00
Timo Stollenwerk
926314ea49 Akismet spam protection plugin support added (collective.akismet). 
svn path=/plone.app.discussion/trunk/; revision=37136
 2010-06-10 13:11:33 +00:00
Timo Stollenwerk
92766752c4 Simplify the CaptchaValidator class by dynamically adapting a view with the name of the captcha plugin (e.g. recaptcha, captcha, akismet) for the validator. 
svn path=/plone.app.discussion/trunk/; revision=37131
 2010-06-10 10:51:41 +00:00
Kim Chee Leong
a10a2b6144 added Dutch translations for plone.app.discussion 
svn path=/plone.app.discussion/trunk/; revision=37091
 2010-06-07 14:35:03 +00:00
Pelle Kroegholt
84c111755c Enable caching and merging for comments.js to save some requests. 
svn path=/plone.app.discussion/trunk/; revision=37002
 2010-06-04 19:56:17 +00:00
Timo Stollenwerk
af1a8bfacd Replace the old NOTES.txt and PRINCIPLES.txt with the Sphinx versions. Fix Captcha title. 
svn path=/plone.app.discussion/trunk/; revision=36998
 2010-06-04 11:22:16 +00:00
Timo Stollenwerk
bca29657b5 minor. 
svn path=/plone.app.discussion/trunk/; revision=36996
 2010-06-04 11:13:22 +00:00
Timo Stollenwerk
429c334376 captcha.txt added to sphinx documentation. 
svn path=/plone.app.discussion/trunk/; revision=36995
 2010-06-04 11:11:01 +00:00