19a511f4e5
Merge pull request #7 from plone/hide-from-breadcrumb
...
Hide Conversation objects from breadcrumb navigation
2012-07-12 06:18:42 -07:00
53428fe5f6
total_comments only counts published comments
...
Also migrate workflow state during migration.
2012-06-13 11:17:22 +00:00
ad5cca6454
Hide Conversation objects from breadcrumb navigation
...
The breadcrumbs navigation is also used in the search results view.
This lead to Conversation objects showing up if 'Discussion Items'
are searchable.
2012-05-29 13:40:31 +02:00
a3883d7e7b
Pep8
2012-01-14 07:13:39 +01:00
5045960281
Make sure the conversation.getComments method returns acquisition wrapped comments.
...
svn path=/plone.app.discussion/trunk/; revision=51639
2011-08-18 06:39:25 +00:00
3708429a37
Move some policy out of the conversation storage adapter into a view,
...
specifically "enabled()". Prevents having to replace/migrate
persistent objects to change policy which really only concerns the
context and possibly the request, not the conversation storage. Fixes
#11372 .
svn path=/plone.app.discussion/trunk/; revision=48849
2011-04-15 04:29:46 +00:00
d3025fb3ec
Fix some aq wrapper errors introduced by my previous fix but not
...
exposed since the functional tests weren't running.
svn path=/plone.app.discussion/trunk/; revision=48836
2011-04-14 19:06:24 +00:00
586cd1fdb7
Don't add the annotation unless a comment is actually being added.
...
Fixes #11370 .
svn path=/plone.app.discussion/trunk/; revision=48829
2011-04-14 16:17:29 +00:00
bf96d0082f
Remove "Plone 3 only" code; Do not monkey patch the BAD_TYPES vocabulary or plone.app.vocabularies anymore.
...
svn path=/plone.app.discussion/trunk/; revision=47311
2011-02-08 09:28:51 +00:00
a2a17085a3
Nuke trailing white space
...
svn path=/plone.app.discussion/trunk/; revision=46366
2010-12-15 23:52:56 +00:00
ea2038b122
Remove XXX line from conversation.py. Martin and I agree that this is probably not relevant anymore. Refs #9288
...
svn path=/plone.app.discussion/trunk/; revision=46265
2010-12-12 12:51:41 +00:00
3b31ac1602
Always import ObjectCreatedEvent from zope.lifecycleevent.
...
svn path=/plone.app.discussion/trunk/; revision=46006
2010-11-28 12:01:27 +00:00
ac4a64f55d
Make sure comment UIDs in the catalog are always unique. This fixes
...
http://dev.plone.org/plone/ticket/10652 . We depend on plone.uuid and plone.app.uuid now. Refs #10652 .
svn path=/plone.app.discussion/trunk/; revision=46005
2010-11-28 11:39:19 +00:00
81dcdeaea3
Disable the plone.app.registry check on schema elements, so no error is raised on upgrades. This fixes https://dev.plone.org/plone/ticket/11195 . Refs #11195
...
svn path=/plone.app.discussion/trunk/; revision=40868
2010-10-29 10:43:46 +00:00
138942470c
Make sure the __parent__ pointer (the conversation) of a comment is not acquisition wrapped in conversation.addComment. This fixes Refs #11157 .
...
svn path=/plone.app.discussion/trunk/; revision=40374
2010-09-28 10:37:40 +00:00
aeabd6fc11
Ignore certain lines for code coverage.
...
svn path=/plone.app.discussion/trunk/; revision=40081
2010-09-20 10:02:07 +00:00
5f5b831904
Be more specific, use ImportError.
...
svn path=/plone.app.discussion/trunk/; revision=39270
2010-08-28 16:08:36 +00:00
352a517a0a
Fixed the case where a folder has allow_discussion=False and
...
conversation.enabled() on a document in this folder returned False
instead of True because of allow_discussion acquisition.
svn path=/plone.app.discussion/trunk/; revision=38835
2010-08-20 11:52:05 +00:00
cac0bae7a5
revert r37751.
...
svn path=/plone.app.discussion/trunk/; revision=37752
2010-07-12 13:47:53 +00:00
eabf3bc890
Always use zope.component getUtility instead of queryUtility.
...
svn path=/plone.app.discussion/trunk/; revision=37751
2010-07-12 13:34:02 +00:00
9d396e43f1
Protect against missing canonical in conversationCanonicalAdapterFactory.
...
svn path=/plone.app.discussion/trunk/; revision=37410
2010-06-25 17:16:15 +00:00
405ecc1268
Added an optional conversationCanonicalAdapterFactory showing how to share comments across all translations with LinguaPlone, by storing and retrieving the conversation from the canonical object.
...
svn path=/plone.app.discussion/trunk/; revision=33546
2010-01-28 13:44:56 +00:00
faf339bec5
Optimized the conversation enabled method and avoid overlong lines
...
svn path=/plone.app.discussion/trunk/; revision=33514
2010-01-27 17:11:55 +00:00
9f4129a65f
Respect the allow_comments field on an object and avoid calculations if no comments should be shown.
...
svn path=/plone.app.discussion/trunk/; revision=33511
2010-01-27 17:00:58 +00:00
78d547daa6
Replacing infinite-recursion happy traverse_parent_folders method with one based on aq_chain; evilbungle branch merge.
...
svn path=/plone.app.discussion/trunk/; revision=30660
2009-10-17 09:33:58 +00:00
e5f1a70de6
Make unit tests pass with Plone 3.3 again. Migration tests still failing.
...
svn path=/plone.app.discussion/trunk/; revision=30633
2009-10-16 12:11:58 +00:00
71ed707794
Get this running again for the most part under Plone 4.0 - the main trick was probably to use the new CMFCatalogAware class. Removed collective.testcaselayer dependency, as that broke totally. There's some test failures left, but indexing works in general. Maybe the custom indexing event handlers aren't all required anymore. The title_or_id test failure looks like there's an infinite loop in the __parent__ pointers never reaching the actual content object. This change breaks Plone 3.x compatibility for the moment.
...
svn path=/plone.app.discussion/trunk/; revision=30629
2009-10-16 00:42:08 +00:00
b106262e31
plone.registry 1.0a2 changed methods to mixedCase (for_interface to forInterface).
...
svn path=/plone.app.discussion/trunk/; revision=28024
2009-07-12 19:13:42 +00:00
360a758905
fix that enabled method check for FTI information of the current content object and not only for the "Document" portal_type.
...
svn path=/plone.app.discussion/trunk/; revision=27889
2009-07-07 14:48:39 +00:00
e2934a66b1
replace content_object.reindexObject() with event handlers.
...
svn path=/plone.app.discussion/trunk/; revision=27814
2009-07-04 16:18:48 +00:00
40eb6b17c1
reindex content object when deleting a comment.
...
svn path=/plone.app.discussion/trunk/; revision=27786
2009-07-03 06:33:22 +00:00
41010fb32a
fix for "TypeError: can't pickle OIBTreeItems objects".
...
svn path=/plone.app.discussion/trunk/; revision=27778
2009-07-02 17:50:20 +00:00
d7bbee3a99
revert changes from rev. 27776.
...
svn path=/plone.app.discussion/trunk/; revision=27777
2009-07-02 16:35:28 +00:00
045a926621
fix for "TypeError: can't pickle OIBTreeItems objects".
...
svn path=/plone.app.discussion/trunk/; revision=27776
2009-07-02 16:04:02 +00:00
e3e6d5548e
fix bug 834504. Replies have a wrong path index.
...
svn path=/plone.app.discussion/trunk/; revision=27656
2009-06-24 13:55:20 +00:00
23d4b25218
allow_discussion on folder level implemented.
...
svn path=/plone.app.discussion/trunk/; revision=27517
2009-06-19 15:51:50 +00:00
c8a24e5d74
make conversation.enabled return a boolean (remove the property decorator).
...
Always return false if the content object is a folder.
svn path=/plone.app.discussion/trunk/; revision=27502
2009-06-18 21:02:32 +00:00
476cc1c5e7
conversationAdapterFactory now always returns the acquisition wrapped conversation object.
...
svn path=/plone.app.discussion/trunk/; revision=27500
2009-06-18 20:53:25 +00:00
f8b317ac7a
add objectIds method to Conversation class to make publish comment work.
...
svn path=/plone.app.discussion/trunk/; revision=27468
2009-06-16 11:52:00 +00:00
8fb254f73d
add optional workflow actions to the get_replies method of the comments viewlet.
...
switch from Acquisition.explicit to Acquisition.implicit for the comment class.
adjust test_comment to work with Acquisition.implicit.
svn path=/plone.app.discussion/trunk/; revision=27406
2009-06-13 16:46:37 +00:00
e465d73c95
enabled property code added to conversation.
...
svn path=/plone.app.discussion/trunk/; revision=27380
2009-06-11 10:14:44 +00:00
9263a61a31
Delete children when deleting a parent comment.
...
svn path=/plone.app.discussion/trunk/; revision=27092
2009-05-24 16:19:21 +00:00
a1e11cb5ee
Turn getComments() and getThreads() into generators.
...
svn path=/plone.app.discussion/trunk/; revision=27090
2009-05-24 16:04:49 +00:00
ca0e299cdc
Fix dodgy IReplies adapter
...
svn path=/plone.app.discussion/trunk/; revision=27085
2009-05-24 14:19:06 +00:00
c28bfbe18f
d'oh!
...
svn path=/plone.app.discussion/trunk/; revision=27066
2009-05-23 16:10:24 +00:00
ac8fd41c10
Avoid test failures for now
...
svn path=/plone.app.discussion/trunk/; revision=27065
2009-05-23 15:59:15 +00:00
7284f2d9e2
Safer fallback - this method will have a different return signature when implemented
...
svn path=/plone.app.discussion/trunk/; revision=27064
2009-05-23 15:50:21 +00:00
8282307e0a
fix conversation.__delitem__ function and add test for deleting comments from a conversation.
...
svn path=/plone.app.discussion/trunk/; revision=27062
2009-05-23 14:18:35 +00:00
2ff696a252
Fix some security issues and make the traversal adapter work with OFS.Traversable. Requires a name, so we now call it ++conversation++default
...
svn path=/plone.app.discussion/trunk/; revision=27059
2009-05-23 11:52:57 +00:00
edf956f01c
Move viewlets to browser package, use a layer instead of an overrides.zcml. Also add ++comment++ namespace, though it may require refactoring
...
svn path=/plone.app.discussion/trunk/; revision=27055
2009-05-23 04:55:06 +00:00
Timo Stollenwerk
Paul J Stevens
Gaudenz Steinlin
Timo Stollenwerk
Ross Patterson
Maurits van Rees
Vincent Fretin
Hanno Schlichting
Martin Aspeli