Merge pull request #7 from plone/hide-from-breadcrumb

Hide Conversation objects from breadcrumb navigation

CHANGES.txt

@@ -48,6 +48,11 @@ Changelog
 - Fix excessive JS comment deletion.
   [gaudenz]
 
+- Hide Conversation objects from breadcrumb navigation. The breadcrumbs
+  navigation is also used in the search results view. This lead to Conversation
+  objects showing up if 'Discussion Items' are searchable.
+  [gaudenz]
+
 - No longer depend on zope.app packages.
   [hannosch]
 

plone/app/discussion/conversation.py

@@ -42,6 +42,8 @@ from BTrees.OIBTree import OIBTree
 from BTrees.LOBTree import LOBTree
 from BTrees.LLBTree import LLSet
 
+from Products.CMFPlone.interfaces import IHideFromBreadcrumbs
+
 from plone.app.discussion.interfaces import IConversation
 from plone.app.discussion.interfaces import IReplies
 from plone.app.discussion.comment import Comment
@@ -58,7 +60,7 @@ class Conversation(Traversable, Persistent, Explicit):
     comment lookup.
     """
 
-    implements(IConversation)
+    implements(IConversation, IHideFromBreadcrumbs)
 
     __allow_access_to_unprotected_subobjects__ = True
 

setup.py

@@ -12,6 +12,7 @@ install_requires = [
     'plone.indexer',
     'plone.registry',
     'plone.z3cform',
+    'Products.CMFPlone',
     'ZODB3',
     'zope.interface',
     'zope.component',