Commit Graph

1152 Commits

Author SHA1 Message Date
Huub Bouma
fd85de9c30 Fix comments Title if utf-8 characters in author_name 2013-09-20 16:28:05 +02:00
Timo Stollenwerk
9049368cba Refactor tests to use the PLONE_APP_CONTENTTYPES_FIXTURE instead of the PLONE_FIXTURE. This fixes all test p.a.discussion test failures. 2013-08-29 22:20:47 +02:00
Jens W. Klein
645bbb0a95 typo: renamed 'annotions' to 'annotations' 2013-08-26 14:49:26 +02:00
JeanMichel FRANCOIS
34bbd39829 fix: add form serialized data to the delete comment ajax form submit
Even if in fresh Plone there is no data, I'm in a case where I'm adding
'ajax' marker in the form to not render all the page (which is the case
here) and the render is not used at all except if the action do not
happens in ajax.
2013-08-21 11:07:48 +02:00
Andrea Cecchi
bde1a1a44a fix reindexObject for comment container object 2013-08-20 15:37:56 +02:00
Andreas Zeidler
b027789391 prevent the viewlet from raising an error for objects that are not annotatable 2013-08-15 00:01:22 +02:00
Paul J Stevens
52c6372664 fix deprecation warning 2013-06-04 13:23:22 +00:00
Paul J Stevens
1946991928 fix regression
introduced by 702f7e1f1d
2013-06-04 13:19:41 +00:00
Thomas Desvenain
f90c1531bc Update french translation 2013-05-23 09:35:41 +02:00
Jan Ulrich Hasecke
a03409a2cb Update plone.app.discussion.po
Some translations
2013-05-22 19:03:00 +02:00
Kees Hink
fd9d0a0eba Revert "Add a test for permission Acquisition on comments."
This reverts commit 66d355544f.
2013-05-10 13:39:02 +02:00
Kees Hink
6d5c193d8c Revert "Move application of custom workflow to test_acquisition.py..."
This reverts commit 6e9b32254e.
2013-05-10 13:38:46 +02:00
Kees Hink
6e9b32254e Move application of custom workflow to test_acquisition.py...
...so it doesn't interfere with other test in the layer.
2013-05-10 13:26:30 +02:00
Kees Hink
66d355544f Add a test for permission Acquisition on comments.
We use a different workflow for comments:
The View permission is acquired instead of given explicitly,
as outlined in https://dev.plone.org/ticket/12531.
2013-05-10 13:18:58 +02:00
Timo Stollenwerk
e2a43aefb6 Remove testbrowser dump. 2013-04-22 14:55:04 +02:00
Timo Stollenwerk
73d84a22d7 Pep8. 2013-04-18 16:12:00 +02:00
Timo Stollenwerk
607719fd42 Pep8. 2013-04-18 15:57:01 +02:00
Timo Stollenwerk
b151244138 Pep8. 2013-04-18 15:51:57 +02:00
Timo Stollenwerk
0a8cd01922 Pep8 2013-04-18 15:46:28 +02:00
Timo Stollenwerk
37faab444a Pep8. 2013-04-18 15:38:17 +02:00
Timo Stollenwerk
0b8112fda1 Pep8. 2013-04-18 15:31:40 +02:00
Timo Stollenwerk
849299f233 Pep8. 2013-04-18 15:21:00 +02:00
Timo Stollenwerk
20935da608 Pep8. 2013-04-17 19:37:10 +02:00
Timo Stollenwerk
29fe4bbec7 Pep8. 2013-04-17 19:34:17 +02:00
Timo Stollenwerk
b4c22e90bf Pep8. 2013-04-17 19:27:30 +02:00
Timo Stollenwerk
943065c15f Pep8. 2013-04-17 19:07:40 +02:00
Timo Stollenwerk
dcb2d3e7d4 Pep8 2013-04-17 19:04:45 +02:00
Timo Stollenwerk
65ade424d8 Pep8. 2013-04-17 14:55:50 +02:00
Timo Stollenwerk
aa61364342 Merge pull request #25 from datakurre/master
Fix migration to not fail when member has been deleted
2013-04-17 05:52:17 -07:00
Timo Stollenwerk
628f72ea0b Pep8. 2013-04-17 14:24:39 +02:00
Timo Stollenwerk
1e95e33573 Pep8 2013-04-13 22:47:30 +02:00
Roman Kozlovskyi
803d6c7fbb Updated ukrainian translations 2013-04-12 15:11:29 +03:00
Asko Soukka
4165a74180 Fix migration to not fail when member has been deleted 2013-04-10 10:28:46 +03:00
Felipe Duardo
7f16b55493 return to last commit... 2013-04-09 13:55:21 -03:00
Felipe Duardo
79a96a8c1e Added a prefix to the id attr of the comment field
The W3C validator does not accept the attributes id or class started with numbers.
2013-04-09 12:21:14 -03:00
Érico Andrei
d77ecc31f3 Update pt_BR translation 2013-04-06 09:57:13 -03:00
Érico Andrei
e6deebf9b5 Sync translations 2013-04-06 09:56:53 -03:00
Érico Andrei
1bbaace2fd Sync translations 2013-04-06 09:48:44 -03:00
Patrick Gerken
05f0e7e4d8 Many updates to handle non public comments properly 2013-03-28 14:28:22 +01:00
Timo Stollenwerk
0c6b873bef Do not raise an error when no workflow is assigned to the comment type. 2013-03-27 17:06:14 +01:00
Timo Stollenwerk
317bbca6d8 Whitespace. 2013-03-27 16:58:35 +01:00
bdbaddog
6f675b6f80 Merge pull request #23 from bdbaddog/fix_comment_user_migration
fix migration of author_name and author_username
2013-02-11 10:20:41 -08:00
Roman Kozlovskyi
948d7d4956 Updated Ukrainian translation 2013-02-04 13:39:17 +02:00
ichim-david
e2d8543020 Cherry-picked 7a48d5 and 10f031 from 2.1.x branch to master 2013-02-03 22:07:51 +02:00
ichim-david
321f725bda Added Romanian translation 2013-02-03 18:11:00 +02:00
Timo Stollenwerk
a6afdf265c Pep8 2013-01-10 18:40:04 +01:00
Timo Stollenwerk
69b628c386 Pep8. 2013-01-10 18:33:46 +01:00
JeanMichel FRANCOIS
0e72ce12a6 remove upgrade step from here. all upgrade step of plone goes to plone.app.upgrades 2013-01-08 10:31:16 +01:00
JeanMichel FRANCOIS
a16958c1c7 add anonymous_email_enabled settings to really let integrator activate it. add the migration script which add the option to the registry and do not change the behavior: the email will not be displayed by default 2013-01-04 19:00:24 +01:00
William Deegan
68d195375e use member.getProperty('fullname') if member.fullname is an empty string. Not sure in what case this would happen, but it did happen in my site migration 2012-12-15 16:47:01 -08:00
William Deegan
372b573cb1 move creation of test user to test setup, rather than just in the new test_migrate_comment_with_creator() method 2012-12-15 16:45:56 -08:00
William Deegan
ff1f65a75e simplify some of the logic and get some tests in place to cover them. TDB: test against actual site to ensure the changes to the logic don't break a real environment, but still work with the tests.. 2012-12-13 21:14:40 -08:00
William Deegan
485571325f fix migration of author_name and author_username 2012-11-27 21:32:07 -08:00
maartenkling
412cfed5c5 first check if captcha is installed before we open browsers zcml files that depend on these packages, fixes #12118 and #12774 2012-11-26 14:50:07 +01:00
Kees Hink
e57d3a2ad4 Convert test for invalid comment id in url to integration test. 2012-11-16 10:29:50 +01:00
Kees Hink
6bd31ad490 Make conversation view not break when comment-id cannot be converted to long, fixes #13327 2012-11-14 13:25:10 +01:00
maartenkling
3f82467828 add missing declaration 2012-11-13 09:45:17 +01:00
maartenkling
1c25c5c10a add permissions to type, fixes #11497 2012-11-13 09:40:32 +01:00
maartenkling
c6af5ee670 Merge remote-tracking branch 'upstream/master' 2012-11-13 09:37:14 +01:00
Timo Stollenwerk
e008bcf54d Whitespace. 2012-11-04 17:25:25 +01:00
Timo Stollenwerk
41a53fc8ff Fix failing test. 2012-11-04 17:18:46 +01:00
maartenkling
f1aaa0d752 The border attribute is obsolete. Consider specifying img { border: 0; } in CSS instead. 2012-11-01 08:31:02 +01:00
Johannes Raggam
882236cb15 For migrations of comments without a valid old_status, apply the 'published'
state.
2012-10-31 22:46:10 +01:00
Johannes Raggam
d2ccec6efe Re-apply eleddy's 'Revert modification date since this is fixed in
p.a.caching now.' as her commit was lost later on due to some git magic.
2012-10-31 22:26:51 +01:00
Johannes Raggam
dae55074cd really set the modification date 2012-10-31 22:15:20 +01:00
maartenkling
62b0b47b56 remove the submitting completly, the form is submitted fine without and this fixes both #13037 and #12357 2012-10-26 11:12:44 +02:00
maartenkling
cb14c4f89e change how to submit the form to stop ff to hang, this fixes #13037 2012-10-25 21:46:57 +02:00
maartenkling
96d72e7e29 fix #11324, add fallback border color for ie8 and browser that not support boxshadows 2012-10-22 10:04:35 +02:00
maartenkling
66898bb87a remove inline styles, this also fixes #12399 2012-10-22 09:58:40 +02:00
Timo Stollenwerk
07140cd136 Merge pull request #13 from l34marr/master
zh-tw PO updated
2012-10-19 06:02:26 -07:00
Thomas Clement Mogensen
481690ac09 update danish translation 2012-10-19 14:35:53 +02:00
Thijs Jonkman
1fb71d5f17 Unified the site setup html structure
Change to unify the site setup html structure
=============================================
- Check for structure:

  #portal-column-content
    #content
      .setup-link
      .documentFirstHeading
      .documentDescription
      #content-core

- Check for body template- class

Related changes
---------------
Templates have also changed in:
  plone.app.contentrules
  plone.app.controlpanel
  plone.app.discussion
  plone.app.registry
  plone.app.users
  Products.CMFPlone

Styles have been updated in plonetheme.sunburst
2012-10-14 17:00:13 +02:00
TsungWei Hu
37c6dfde0e zh-tw PO updated. 2012-10-09 21:03:24 +08:00
rnd0101
cdea1ce59d Update plone/app/discussion/browser/comments.pt
i18n for the Anonymous
2012-09-19 12:55:55 +03:00
Izak Burger
cde250bf4c remove unused local variable. 2012-09-17 23:57:13 +02:00
Izak Burger
4d1e7b5806 don't ignore user_notification checkbox. 2012-09-17 23:51:15 +02:00
Gaudenz Steinlin
56b08b2247 Fix catalog updates for IObjectMovedEvent
If comments were moved because an object on a higher level than the
commented object was moved, these comments were wrongly reindexed.
The commented object also got a wrong __parent__ pointer.

This fixes https://dev.plone.org/ticket/13172.
2012-09-17 16:52:05 +02:00
Timo Stollenwerk
05c2c19c93 Replace discussionitem_icon.gif with png version. 2012-09-02 08:31:58 +02:00
Patrick Gerken
9146aa8025 Don't use reindexObject from catalog, but from the object
collective.indexing assumes that reindexObject from catalog is not
an official api method, therefor it does not patch it.
This results in missing updates if plone.app.discussion is used
together with solr, which uses collective.indexing
2012-08-22 18:00:27 +02:00
David Glick
58b4205f38 Revert "Attempt to fix test_format_time()."
This reverts commit c231794940.
2012-08-02 22:21:26 -07:00
David Glick
7fe9f062e8 Revert "Update master"
This reverts commit 53ec8e52ea.
2012-08-02 22:21:19 -07:00
Karl Johan Kleist
53ec8e52ea Update master 2012-07-18 06:58:17 +03:00
Karl Johan Kleist
c231794940 Attempt to fix test_format_time(). 2012-07-18 06:56:14 +03:00
Timo Stollenwerk
528e1a1434 Run ConversationTest for dexterity types only if dexterity is installed. 2012-07-12 18:56:10 +02:00
Timo Stollenwerk
103c7323e7 Fix test that fails due to the creator/author_name changes. 2012-07-12 17:29:05 +02:00
Timo Stollenwerk
a6a48a58dd Fix test that fails due to the css id changes due to comment text field. 2012-07-12 17:28:12 +02:00
Timo Stollenwerk
c47689af42 Fix handling of comments with invalid transforms. Write an error msg to the log and just return the untransformed text. 2012-07-12 16:03:02 +02:00
Timo Stollenwerk
702f7e1f1d Make 'text/plain' the default mime type for comments and make sure the default type is set properly when creating a new comment. 2012-07-12 16:01:07 +02:00
Timo Stollenwerk
f45373b311 Test for mime type transformation from html to html added. 2012-07-12 15:54:38 +02:00
Timo Stollenwerk
eded7f1059 text/html added to possible mime types for comments. 2012-07-12 15:54:01 +02:00
Timo Stollenwerk
ac9d4f9584 Rename the id of the text widgets because there can be css-id clashes with
the text field of documents when using TinyMCE in overlays or multiple
instances of TinyMCE on a single page.
2012-07-12 15:49:19 +02:00
Timo Stollenwerk
0535e659ff Refactor the comment creator/author_name to comply with the Plone core convention to store the username on the creator attribute and not the fullname. 2012-07-12 15:39:27 +02:00
Timo Stollenwerk
19a511f4e5 Merge pull request #7 from plone/hide-from-breadcrumb
Hide Conversation objects from breadcrumb navigation
2012-07-12 06:18:42 -07:00
Timo Stollenwerk
f45a2e8bba Replace deprecated unit test methods. 2012-07-12 15:08:22 +02:00
tisto
65590732ea Move api documentation to a separate folder. 2012-07-12 15:03:26 +02:00
Timo Stollenwerk
7d34baf2d5 Prepare files for API documentation. 2012-07-12 14:56:03 +02:00
Timo Stollenwerk
4919b50edb Merge pull request #6 from stonor/master
Please pull this updated Danish translation
2012-07-12 03:44:10 -07:00
Timo Stollenwerk
19685db96b Merge pull request #9 from Goldmund-Wyldebeast-Wunderliebe/master
no more recursive came_from redirection after logged_in
2012-07-12 03:35:33 -07:00
Karl Johan Kleist
636e77e3b2 Reverting, as per Timo's comment in 49734cd39b (commitcomment-1559057).
So Jenkins is running the tests using the en-US locale?
2012-07-10 10:56:56 +03:00
Karl Johan Kleist
49734cd39b Fallback for localized time is now ISO style.
https://jenkins.plone.org/job/plone-4.3-tests/89/testReport/junit/plone.app.discussion.tests.test_comments_viewlet/TestCommentsViewlet/test_format_time/
2012-07-07 11:58:46 +03:00
Radim Novotny
d86e19e717 Added empty translation files for Slovak language 2012-07-02 17:54:58 +02:00
Timo Stollenwerk
0e587a7d85 Support for Dexterity added. 2012-06-30 10:59:49 +02:00
Paul J Stevens
53428fe5f6 total_comments only counts published comments
Also migrate workflow state during migration.
2012-06-13 11:17:22 +00:00
Paul J Stevens
e31f90c440 Prune duplicated test code 2012-06-12 14:44:42 +00:00
Gaudenz Steinlin
ad5cca6454 Hide Conversation objects from breadcrumb navigation
The breadcrumbs navigation is also used in the search results view.
This lead to Conversation objects showing up if 'Discussion Items'
are searchable.
2012-05-29 13:40:31 +02:00
Gaudenz Steinlin
a7b3c818f2 Delete own comments
Add permission to allow comment authors to delete their own comments if
there are no replies yet.
2012-05-29 13:33:46 +02:00
Gaudenz Steinlin
3eab51e1c4 Add Site Administrator role to Review comments permission 2012-05-29 13:26:05 +02:00
Gaudenz Steinlin
4e0bf9f25e Fix JS comment deletion
If the comment tree had just one top level comment the whole tree was
removed by the JS code if just one comment in the tree was deleted.
These comments were (correctly) not removed from the ZODB.
2012-05-29 13:26:05 +02:00
Anton Stonor
cc2af905dc Updating Danish translation 2012-05-23 08:35:04 +02:00
Hanno Schlichting
1b0ba3c0b0 No longer depend on zope.app packages. 2012-05-18 18:19:12 -04:00
Takeshi Yamamoto
5f063d60ea fixed Kanji typo. 2012-05-15 20:54:56 +09:00
Huub Bouma
c9848bebfe no more recursive came_from redirection after logged_in 2012-04-12 13:06:05 +02:00
Timo Stollenwerk
f66d6e1c05 Make topic/collection tests pass when plone.app.collection is installed. 2012-04-02 22:00:27 +02:00
Timo Stollenwerk
4d330f2daa Make comment collection tests work with plone.app.collection. 2012-03-31 18:40:58 +02:00
Timo Stollenwerk
ebb39b4994 No need to define portal_membership tool twice. 2012-03-19 16:32:33 +01:00
Timo Stollenwerk
58663fb492 Warning message added to discussion control panel that shows up if there are unmigrated comments. 2012-03-15 20:00:08 +01:00
Timo Stollenwerk
c76ef0523e Merge commit 877f2d3e84 which has been accidentially purged. 2012-03-15 19:06:23 +01:00
Timo Stollenwerk
910f75aa7e Make comments and controlpanel views more robust, so they don't break if no workflow is assigned to the 'Discussion Item' content type. 2012-03-15 13:06:00 +01:00
Elizabeth Leddy
877f2d3e84 fix url redirect for content types that must have /view in url to view contents 2012-03-14 15:01:17 -07:00
Timo Stollenwerk
5e5d9d0da4 Add missing meta_typ to 'Review comments' portal action. 2012-02-29 09:32:35 +01:00
Elizabeth Leddy
2971974f26 revert modification date since this is fixed in p.a.caching now 2012-02-25 11:59:30 +01:00
Mikel Larreategi
873300d347 fix typo in translation 2012-02-24 15:50:26 +01:00
Mikel Larreategi
1803410e07 add basque translation 2012-02-08 09:14:24 +01:00
Radim Novotny
f2462be14f Updated Czech i18n 2012-01-26 13:10:32 +01:00
Timo Stollenwerk
1920f1d4d5 Move IDiscussionSettings to the bottom of the interfaces file. 2012-01-25 16:02:00 +01:00
Timo Stollenwerk
80d70bbf08 Whitespace 2012-01-25 15:57:17 +01:00
Elizabeth Leddy
07b8ebc5df make sure commenting works when caching with modified headers 2012-01-24 18:28:02 -08:00
tisto
c14091c734 Pep8 2012-01-14 08:00:40 +01:00
tisto
81fd515455 Pep8 2012-01-14 07:53:03 +01:00
tisto
11e101f7d7 Pep8 2012-01-14 07:47:07 +01:00
tisto
aa36c0bc9b Pep8 2012-01-14 07:41:50 +01:00
tisto
2dc5393ff2 Pep8 2012-01-14 07:35:59 +01:00
tisto
2d4f7fd665 Pep8 2012-01-14 07:30:43 +01:00
tisto
0558a9b739 Pep8 2012-01-14 07:26:01 +01:00
tisto
a3883d7e7b Pep8 2012-01-14 07:13:39 +01:00
tisto
f520482eb3 Pep8 2012-01-14 07:03:29 +01:00
tisto
d5ccd2e2be Pep8 2012-01-14 06:57:25 +01:00
Timo Stollenwerk
cce409a729 Pep8 2012-01-13 14:40:26 +01:00
Timo Stollenwerk
07cde3ca7b Pep8 2012-01-13 10:16:01 +01:00
Timo Stollenwerk
e17cfa68a1 Fix whitespace/Pep8/Pyflakes in tests. 2012-01-09 16:43:54 +01:00
Timo Stollenwerk
1f01a71aac Whitespace. 2012-01-09 16:31:52 +01:00
Timo Stollenwerk
3b1d1b8967 Changelog entry and test to fix #12437 added. 2011-12-21 19:37:40 +01:00
Timo Stollenwerk
5e81422cd1 Rename discussion var to ctool which is more appropriate. 2011-12-21 19:17:58 +01:00
Paul J Stevens
6eb38ace08 fix indexing of comments (#12437) 2011-12-21 15:07:33 +01:00
hvelarde
774efd39d6 updated Spanish translation 2011-12-14 15:35:46 -06:00
Timo Stollenwerk
6a7c89ec78 Do not raise an error if the comment text is None. 2011-11-30 13:05:59 +01:00
Vincent Fretin
02775ac744 fixed typo 2011-11-21 19:27:43 +01:00
Vincent Fretin
9040f25dc1 fixed po headers 2011-11-21 19:17:06 +01:00
Timo Stollenwerk
f68c2caf9f Remove unused PloneTestCase import. 2011-10-30 08:19:30 +01:00
Timo Stollenwerk
b0a177f4d2 Fix various text typos. 2011-10-30 08:11:06 +01:00