ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,188 Commits 1 Branch 0 Tags 5 MiB
a78deecf78
Commit Graph

880 Commits

Author SHA1 Message Date
Timo Stollenwerk
38b70a28e5 Use plone.app.testing in test_comment. 
svn path=/plone.app.discussion/trunk/; revision=48898
 2011-04-16 09:16:18 +00:00
Timo Stollenwerk
e5d45dbd78 Use plone.app.testing in test_catalog. 
svn path=/plone.app.discussion/trunk/; revision=48897
 2011-04-16 09:13:39 +00:00
Hanno Schlichting
4110b41ae6 Even simpler code :) 
svn path=/plone.app.discussion/trunk/; revision=48886
 2011-04-15 16:56:17 +00:00
Hanno Schlichting
b4c5d287dd Style ;) 
svn path=/plone.app.discussion/trunk/; revision=48885
 2011-04-15 16:47:57 +00:00
Hanno Schlichting
f2e47227f9 Fix old-style exception raising 
svn path=/plone.app.discussion/trunk/; revision=48884
 2011-04-15 16:44:16 +00:00
Hanno Schlichting
9db8909ea7 Avoid using deprecated test assertions, see http://docs.python.org/dev/library/unittest.html#deprecated-aliases for the full list 
svn path=/plone.app.discussion/trunk/; revision=48881
 2011-04-15 16:23:38 +00:00
Hanno Schlichting
811d4a0429 Avoid deprecation warnings and always specify a catalog query as a dict 
svn path=/plone.app.discussion/trunk/; revision=48880
 2011-04-15 16:17:02 +00:00
Ross Patterson
3708429a37 Move some policy out of the conversation storage adapter into a view, 
specifically "enabled()".  Prevents having to replace/migrate
persistent objects to change policy which really only concerns the
context and possibly the request, not the conversation storage. Fixes
#11372.

svn path=/plone.app.discussion/trunk/; revision=48849
 2011-04-15 04:29:46 +00:00
Ross Patterson
7354ca4298 Fix unindexing of comments when deleting content resulting from 
iterating over a BTree while modifying it. Fixes #11402.

svn path=/plone.app.discussion/trunk/; revision=48845
 2011-04-14 21:30:32 +00:00
Erico Andrei
82b4a7ca70 Adding Brazilian Portuguese translation 
svn path=/plone.app.discussion/trunk/; revision=48843
 2011-04-14 20:58:24 +00:00
Erico Andrei
ea94d5e842 Adding Brazilian Portuguese translation 
svn path=/plone.app.discussion/trunk/; revision=48842
 2011-04-14 20:57:09 +00:00
Ross Patterson
5786bfa6b6 pep8 
svn path=/plone.app.discussion/trunk/; revision=48840
 2011-04-14 20:17:10 +00:00
Ross Patterson
cad670d6af Fax Missing.Value for Creator in the catalog. Fixes #11634. 
svn path=/plone.app.discussion/trunk/; revision=48838
 2011-04-14 19:59:05 +00:00
Ross Patterson
187aa60452 These testbrowser tests certainly no longer raise 404s for me 
svn path=/plone.app.discussion/trunk/; revision=48837
 2011-04-14 19:06:55 +00:00
Ross Patterson
d3025fb3ec Fix some aq wrapper errors introduced by my previous fix but not 
exposed since the functional tests weren't running.

svn path=/plone.app.discussion/trunk/; revision=48836
 2011-04-14 19:06:24 +00:00
Ross Patterson
d8f864596e The functional tests haven't been running due to an unused import 
svn path=/plone.app.discussion/trunk/; revision=48835
 2011-04-14 19:05:31 +00:00
Ross Patterson
d5a999b429 Clarify a doctest 
svn path=/plone.app.discussion/trunk/; revision=48831
 2011-04-14 16:41:11 +00:00
WouterVH
4b95d10bb6 some more nl-translations 
svn path=/plone.app.discussion/trunk/; revision=48830
 2011-04-14 16:38:22 +00:00
Ross Patterson
586cd1fdb7 Don't add the annotation unless a comment is actually being added. 
Fixes #11370.

svn path=/plone.app.discussion/trunk/; revision=48829
 2011-04-14 16:17:29 +00:00
Thomas Desvenain
119c1cb060 French translations 
svn path=/plone.app.discussion/trunk/; revision=48820
 2011-04-14 12:52:04 +00:00
Vincent Fretin
7912d9a049 Resync translations 
svn path=/plone.app.discussion/trunk/; revision=48696
 2011-04-10 20:38:14 +00:00
Vincent Fretin
7b42c34493 Nobody seems to maintain the LANGUAGES variable, remove the update-translations.sh script, use a simpler locales/update.sh script. 
svn path=/plone.app.discussion/trunk/; revision=48695
 2011-04-10 20:37:37 +00:00
Vincent Fretin
ab5c728448 Fixed i18n of the "Commenting has been disabled." message. 
svn path=/plone.app.discussion/trunk/; revision=48694
 2011-04-10 20:28:21 +00:00
David Glick
7803674dd0 merge r48557 from 1.x branch 
svn path=/plone.app.discussion/trunk/; revision=48558
 2011-04-08 20:47:50 +00:00
David Glick
8d3a37ead9 merge r48555 from 1.x branch. bumping profile version to 100 so there's space for future upgrades in the 1.x line 
svn path=/plone.app.discussion/trunk/; revision=48556
 2011-04-08 20:23:07 +00:00
David Glick
d323d37285 add upgrade step for moderator_email setting 
svn path=/plone.app.discussion/branches/1.x/; revision=48555
 2011-04-08 20:20:34 +00:00
David Glick
6d11fa6d5e merge c48523 from 1.x branch 
svn path=/plone.app.discussion/trunk/; revision=48527
 2011-04-07 21:31:56 +00:00
David Glick
9aea1915c1 add moderator email setting 
svn path=/plone.app.discussion/branches/1.x/; revision=48523
 2011-04-07 20:02:27 +00:00
Pavel Bogdanovic
c669e03ae2 some german translations 
svn path=/plone.app.discussion/trunk/; revision=48395
 2011-04-04 13:01:48 +00:00
David Glick
203836dc5e make discussion.css cacheable 
svn path=/plone.app.discussion/trunk/; revision=48359
 2011-04-02 21:27:47 +00:00
David Glick
636bca745c merge r47140, r47290, r47579 from davisagli-features: fix timezone handling when migrating legacy comments and when indexing 
svn path=/plone.app.discussion/trunk/; revision=48358
 2011-04-02 21:26:36 +00:00
David Glick
9d83b4f0e6 merge -r46947 from davisagli-features: preserve legacy titles on migrated comments 
svn path=/plone.app.discussion/trunk/; revision=48357
 2011-04-02 21:16:24 +00:00
David Glick
eb004aab44 merge r46437 and r46946 from davisagli-features: respect the per-comment mime_type setting, and use the old cooked text/html from legacy comments when migrating 
svn path=/plone.app.discussion/trunk/; revision=48356
 2011-04-02 19:51:37 +00:00
David Glick
bf5946367a merge r46436 from davisagli-features: make it possible to specify a callback filter for the migration 
svn path=/plone.app.discussion/trunk/; revision=48354
 2011-04-02 19:33:10 +00:00
David Glick
feb1759958 fix incorrect parenthesization 
svn path=/plone.app.discussion/trunk/; revision=48240
 2011-03-26 05:04:22 +00:00
David Glick
ebbf2d9b7b fix deprecation warning 
svn path=/plone.app.discussion/trunk/; revision=48234
 2011-03-26 02:44:49 +00:00
Thomas Desvenain
9b87f2b246 French translations 
svn path=/plone.app.discussion/trunk/; revision=48112
 2011-03-17 16:51:08 +00:00
Thomas Desvenain
7c2a815fdb Fixed internationalization issues. 
svn path=/plone.app.discussion/trunk/; revision=48110
 2011-03-17 16:15:40 +00:00
Thomas Desvenain
cf5f101538 message extraction + french translations (previous commit was bad) 
svn path=/plone.app.discussion/trunk/; revision=48108
 2011-03-17 15:30:31 +00:00
Thomas Desvenain
7271293606 message extraction + french translations 
svn path=/plone.app.discussion/trunk/; revision=48107
 2011-03-17 15:23:47 +00:00
Patrick Gerken
882e9e028f Take care of properly converting titles to unicode 
svn path=/plone.app.discussion/branches/1.x/; revision=47999
 2011-03-09 03:07:59 +00:00
Patrick Gerken
de9ebea499 Ups, there is a nother unicode problem 
svn path=/plone.app.discussion/branches/1.x/; revision=47998
 2011-03-09 03:07:46 +00:00
Patrick Gerken
39d692f9b8 Trigger failure for objects with unicode titles in string 
svn path=/plone.app.discussion/branches/1.x/; revision=47997
 2011-03-09 03:07:29 +00:00
Patrick Gerken
65aab05d1b Fixed test failure for the default user portrait, which changed from 
defaultUser.gif to defaultUser.png in Products.PlonePAS 4.0.5.

Backport if maurits changes to the trunk

svn path=/plone.app.discussion/branches/1.x/; revision=47996
 2011-03-09 03:03:17 +00:00
Patrick Gerken
79701cce7e Take care of properly converting titles to unicode 
svn path=/plone.app.discussion/trunk/; revision=47991
 2011-03-08 20:15:52 +00:00
Patrick Gerken
774ed36746 Ups, there is a nother unicode problem 
svn path=/plone.app.discussion/trunk/; revision=47990
 2011-03-08 20:15:37 +00:00
Patrick Gerken
b6d406d298 Trigger failure for objects with unicode titles in string 
svn path=/plone.app.discussion/trunk/; revision=47989
 2011-03-08 20:15:21 +00:00
JC Brand
97b8b6a060 Add the af translations to the 1.x branch as well. 
svn path=/plone.app.discussion/branches/1.x/; revision=47959
 2011-03-07 15:48:51 +00:00
JC Brand
c26e1b9123 Add af translations 
svn path=/plone.app.discussion/trunk/; revision=47953
 2011-03-07 13:49:13 +00:00
Maurits van Rees
478273aa80 minor code cleanup 
svn path=/plone.app.discussion/trunk/; revision=47599
 2011-02-15 16:23:12 +00:00
Maurits van Rees
81d74cfe6b Fixed test failure for the default user portrait, which changed from 
defaultUser.gif to defaultUser.png in Products.PlonePAS 4.0.5.

svn path=/plone.app.discussion/trunk/; revision=47597
 2011-02-15 16:19:13 +00:00
Timo Stollenwerk
bf96d0082f Remove "Plone 3 only" code; Do not monkey patch the BAD_TYPES vocabulary or plone.app.vocabularies anymore. 
svn path=/plone.app.discussion/trunk/; revision=47311
 2011-02-08 09:28:51 +00:00
Timo Stollenwerk
0a0e69d47d Do not check for a comment review workflow when sending out a moderator email notification. This fixes http://dev.plone.org/plone/ticket/11444. Refs #11444 
svn path=/plone.app.discussion/trunk/; revision=47292
 2011-02-07 11:48:24 +00:00
Timo Stollenwerk
de4353641b Do not check for a comment review workflow when sending out a moderator email notification. This fixes http://dev.plone.org/plone/ticket/11444. Refs #11444 
svn path=/plone.app.discussion/branches/1.x/; revision=47189
 2011-02-02 19:55:24 +00:00
Timo Stollenwerk
0c435dc9ca Check if the current user has configured an e-mail address for the email notification option. Refs #11428 
svn path=/plone.app.discussion/trunk/; revision=47069
 2011-01-26 08:15:14 +00:00
Timo Stollenwerk
15c681d27f Check if the current user has configured an e-mail address for the email notification option. Refs #11428 
svn path=/plone.app.discussion/branches/1.x/; revision=47068
 2011-01-26 08:06:21 +00:00
Timo Stollenwerk
543b9d47c5 Remove moderation_enabled setting from registry to avoid migration problems to 1.0RC1. Refs #11419. 
svn path=/plone.app.discussion/branches/1.x/; revision=47031
 2011-01-24 08:37:43 +00:00
Timo Stollenwerk
ed4f2b1fa8 Comment out the discussion control panel event subscriber tests. We disabled this functionality anyway. 
svn path=/plone.app.discussion/branches/1.x/; revision=46991
 2011-01-22 12:39:15 +00:00
Timo Stollenwerk
2f30c27555 Disable the control panel event subscribers. We don't need them since we disabled the enable_moderation setting in the discussion control panel anyway. 
svn path=/plone.app.discussion/branches/1.x/; revision=46990
 2011-01-22 12:34:49 +00:00
Timo Stollenwerk
5cac8b7a1b Hide the moderation_enabled widget in the discussion control panel. We need plone.app.controlpanel > 2.1b1 for this, which is not shipped with Plone 3.x or 4.0.x. 
svn path=/plone.app.discussion/branches/1.x/; revision=46989
 2011-01-22 12:00:15 +00:00
Timo Stollenwerk
4ab29000a6 Import Owned from OFS.owner to avoid deprecation warnings. 
svn path=/plone.app.discussion/trunk/; revision=46977
 2011-01-20 20:38:50 +00:00
Timo Stollenwerk
f3ff8e9647 Fix failing test. Discussion is enabled by default again. 
svn path=/plone.app.discussion/branches/1.x/; revision=46975
 2011-01-20 20:08:51 +00:00
Timo Stollenwerk
fb0ca6c795 Replace tabs with whitespace. 
svn path=/plone.app.discussion/trunk/; revision=46974
 2011-01-20 20:04:38 +00:00
Timo Stollenwerk
9790dd5b65 Enable discussion by default if p.a.discussion is shipped as add-on product. 
svn path=/plone.app.discussion/branches/1.x/; revision=46973
 2011-01-20 19:49:58 +00:00
Timo Stollenwerk
9cc32a76a4 Enable ajaxify comment deletion again ([thomasdesvenain]). This has been disabled in 1.0b12 because of problems with Plone 3. 
svn path=/plone.app.discussion/trunk/; revision=46970
 2011-01-20 19:38:26 +00:00
Timo Stollenwerk
c15c898565 Remove collective.autopermission dependency. 
svn path=/plone.app.discussion/trunk/; revision=46969
 2011-01-20 19:37:54 +00:00
Timo Stollenwerk
75cde25b6f Always show existing comments, even if commenting is disabled. 
svn path=/plone.app.discussion/trunk/; revision=46785
 2011-01-07 15:27:17 +00:00
Timo Stollenwerk
61e231b336 Fix CSS for commenter images with a width of more than 2.5em. This fixes http://dev.plone.org/plone/ticket/11391. Refs #11391 
svn path=/plone.app.discussion/trunk/; revision=46783
 2011-01-07 10:27:13 +00:00
Timo Stollenwerk
c438743a3b Show a 'Comments are moderated.' message next to the comment form if comments are moderated. 
svn path=/plone.app.discussion/trunk/; revision=46782
 2011-01-07 10:20:24 +00:00
David Glick
b0ca33dcc6 make sure p.a.registry ZCML is loaded 
svn path=/plone.app.discussion/trunk/; revision=46432
 2010-12-21 19:20:36 +00:00
Maurits van Rees
d90c436f8a Removed the conditional loading of event subscribers: 
- zope.app.container is available in both Plone 3 and Plone 4, so the 'not-installed zope.app.container' condition was always false
- zope.lifecycleevent.interfaces does not have an IObjectAddedEvent or IObjectRemovedEvent so even if the condition would have been true, the loading would have failed.

svn path=/plone.app.discussion/trunk/; revision=46367
 2010-12-16 02:12:13 +00:00
Maurits van Rees
a2a17085a3 Nuke trailing white space 
svn path=/plone.app.discussion/trunk/; revision=46366
 2010-12-15 23:52:56 +00:00
Maurits van Rees
aff8a3709c Avoid sending multiple notification emails to the same person when 
he has commented multiple times.

svn path=/plone.app.discussion/trunk/; revision=46365
 2010-12-15 23:41:57 +00:00
Maurits van Rees
9eb172023a No tabs in zcml please 
svn path=/plone.app.discussion/trunk/; revision=46364
 2010-12-15 22:59:24 +00:00
Maurits van Rees
87d767651b Do not fail on startup with Plone 3 when plone.uuid is not there: 
make implementing the plone.uuid.interfaces.IAttributeUUID interface conditional for Plone 4 only.

svn path=/plone.app.discussion/trunk/; revision=46363
 2010-12-15 22:45:19 +00:00
David Glick
0cb75778ba make sure comments don't get indexed with their parents' UID in Plone 3. only declare dependency on plone.app.uuid in Python 2.6, since we only use it in Plone 4 currently. 
svn path=/plone.app.discussion/trunk/; revision=46353
 2010-12-15 20:39:55 +00:00
Timo Stollenwerk
b9d929bca3 Fix failing test. 
svn path=/plone.app.discussion/trunk/; revision=46344
 2010-12-14 21:30:40 +00:00
Timo Stollenwerk
a8bfd7fc6e Disable discussion by default. 
svn path=/plone.app.discussion/trunk/; revision=46337
 2010-12-14 17:58:46 +00:00
Timo Stollenwerk
d702c666f0 Tests for moderation_enabled setting added. 
svn path=/plone.app.discussion/trunk/; revision=46266
 2010-12-12 13:56:06 +00:00
Timo Stollenwerk
ea2038b122 Remove XXX line from conversation.py. Martin and I agree that this is probably not relevant anymore. Refs #9288 
svn path=/plone.app.discussion/trunk/; revision=46265
 2010-12-12 12:51:41 +00:00
Timo Stollenwerk
a9ef0503f2 Move discussion action item from actionicons.xml to actions.xml to avoid deprecation warning. 
svn path=/plone.app.discussion/trunk/; revision=46264
 2010-12-12 12:40:19 +00:00
Timo Stollenwerk
4c4cd9e44d Replace XXX with todo. 
svn path=/plone.app.discussion/trunk/; revision=46263
 2010-12-12 08:14:48 +00:00
Timo Stollenwerk
0485398de0 whitespace, make jslint happy. 
svn path=/plone.app.discussion/trunk/; revision=46262
 2010-12-12 08:13:03 +00:00
Timo Stollenwerk
be78fbe300 There is no need to enable the "enable moderation" checkbox dynamically, except when commenting is disabled/enabled globally. 
svn path=/plone.app.discussion/trunk/; revision=46261
 2010-12-12 07:35:43 +00:00
Timo Stollenwerk
08857df7a9 Fix cancel button on edit view when using Dexterity types. This fixes http://dev.plone.org/plone/ticket/11338. Refs #11338 
svn path=/plone.app.discussion/trunk/; revision=46254
 2010-12-11 21:33:43 +00:00
Timo Stollenwerk
f2f97c5b38 Change the comment workflow setting in the discussion control panel if the setting is changed in the types control panel; show warning message and disable the setting if a custom comment workflow is enabled. 
svn path=/plone.app.discussion/trunk/; revision=46253
 2010-12-11 21:30:18 +00:00
Timo Stollenwerk
0475376ed0 "Enable comment moderation" setting added to the discussion control panel. Just a proof of concept so far. Not fully implemented yet. No tests. 
svn path=/plone.app.discussion/trunk/; revision=46249
 2010-12-11 17:18:14 +00:00
Timo Stollenwerk
09a804aa88 Remove unnecessary and failing test. 
svn path=/plone.app.discussion/trunk/; revision=46235
 2010-12-10 09:16:36 +00:00
Timo Stollenwerk
54af7d3fa1 Assigning the 'Reply to item' permission to the 'Authenticated' role. The old commenting system allowed 'Authenticated' users to post comments. Also, OpenID users do not possess the 'Authenticated' role. Refs #9288 
svn path=/plone.app.discussion/trunk/; revision=46230
 2010-12-10 08:57:35 +00:00
Timo Stollenwerk
45140c66db Functional test for posting a comment as user without the 'Reply to item' permission added. 
svn path=/plone.app.discussion/trunk/; revision=46215
 2010-12-09 10:58:32 +00:00
Timo Stollenwerk
7e279d3ad3 Make sure the handleComment method checks for the 'Reply to item' permission when adding a comment. 
svn path=/plone.app.discussion/trunk/; revision=46212
 2010-12-09 08:11:41 +00:00
Timo Stollenwerk
c8e78449a2 Make the mail-setting warning message show up in the discussion control panel. 
svn path=/plone.app.discussion/trunk/; revision=46211
 2010-12-09 08:07:15 +00:00
Timo Stollenwerk
797ed40852 Link directly to the "Discussion Item" types control panel in the moderation view. 
svn path=/plone.app.discussion/trunk/; revision=46207
 2010-12-08 17:45:58 +00:00
Timo Stollenwerk
583b25530e Show "moderate comments" link in the admin panel only if a moderation workflow is enabled for comments. 
svn path=/plone.app.discussion/trunk/; revision=46206
 2010-12-08 17:45:11 +00:00
Timo Stollenwerk
6e354718f4 Revert r46143. 
svn path=/plone.app.discussion/trunk/; revision=46144
 2010-12-05 14:56:13 +00:00
Timo Stollenwerk
22425b06ac Disable commenting by default if pad is shipped with Plone. If shipped as add-on product, commenting should be enabled by default. 
svn path=/plone.app.discussion/trunk/; revision=46143
 2010-12-05 14:50:25 +00:00
Timo Stollenwerk
04a0669731 Remove the grey background from disabled settings. 
svn path=/plone.app.discussion/trunk/; revision=46142
 2010-12-05 14:10:21 +00:00
Timo Stollenwerk
bbd44b7b95 workflow setting added to control panel config string. 
svn path=/plone.app.discussion/trunk/; revision=46091
 2010-12-02 23:20:10 +00:00
Timo Stollenwerk
ffde4b423d Do not allow to change the mail settings in the discussion control panel, if there is no valid mail setup. Refactor js code to use class settings of #content. 
svn path=/plone.app.discussion/trunk/; revision=46090
 2010-12-02 23:02:00 +00:00
Timo Stollenwerk
fbd7eb2bbc Do not allow to change the mail settings in the discussion control panel, if there is no valid mail setup. 
svn path=/plone.app.discussion/trunk/; revision=46089
 2010-12-02 21:07:58 +00:00