2b18d5a2e4
Revert "Merge pull request #38 from delib/evilbungle-comment-acquisition"
...
This reverts commit e18598e316fd6ac0788bhttp://jenkins.plone.org/job/plone-5.0-python-2.7/lastCompletedBuild/testReport/ for details.
2014-05-13 07:07:37 +02:00
e18598e316
Merge pull request #38 from delib/evilbungle-comment-acquisition
...
Fixing incorrect behaviour with acquired permissions
2014-05-12 22:53:34 +02:00
fe91d7801e
Add tests for custom events and contentrules events/string substitutions
2014-05-12 20:20:18 +03:00
22ed06b66d
Add second robot test to test adding comments.
2014-05-02 13:42:19 +02:00
f894d47d62
Add basic robot test setup and a first test.
2014-05-02 13:22:08 +02:00
6609ab6af5
make flake8 happy
2014-03-25 18:38:12 +01:00
a145413ac2
make flake8 happy
2014-03-25 18:37:06 +01:00
67213b70eb
make flake8 happy
2014-03-25 18:36:14 +01:00
9c9c2e2aaa
Merge branch 'master' of git://github.com/huubbouma/plone.app.discussion into huubbouma-master
...
Conflicts:
CHANGES.rst
2014-03-23 18:54:44 +01:00
0ea9a7131f
merge upstream and fix numbering
2014-03-04 09:16:36 +01:00
d788d07a87
fix test. the richtext-field in plone.app.contenttypes uses a behavior
2014-02-14 09:40:55 +01:00
8ccd648928
user member.getId as author_username, so membrane users and plone users have portraits and author urls
2014-02-02 14:55:37 +01:00
a8dc5dd3f0
Remove test_suite functions since they are only needed for zope.testing < 3.8.0.
2013-12-19 09:54:03 +01:00
a2ae2a888f
Remov qunit and jstestdriver test setup.
2013-12-15 12:56:51 +01:00
f0a9d9ad6b
Pep8
2013-12-15 12:02:32 +01:00
e6ec6ebe16
Add tests to confirm that some methods of a conversation incorrectly use an unwrapped comment to determine whether anonymous users can view.
2013-11-25 12:52:31 +00:00
4804868ab2
Refactor acquisition tests to define the expected behaviour when dealing with wrapped and unwrapped comments.
2013-11-25 12:06:05 +00:00
8e56b99638
added test acquisition chain for unwrapped object
...
Conflicts:
plone/app/discussion/tests/test_acquisition.py
2013-11-21 17:23:36 +00:00
5fb6968fca
Add a test for Acquisition in comments.
2013-11-21 17:22:12 +00:00
7cfbd20d72
don't fail test if portal_atct is missing
2013-11-15 00:11:13 -08:00
654869a30d
Remove old topic test. New collections are tested in p.a.contenttypes anyways.
2013-11-14 11:01:14 +01:00
c3ce01edd0
Use defaultUser.png instead of defaultUser.gif
...
Indeed, defaultUser.gif is in a deprecated skins folder (Products/CMFPlone/
skins/plone_deprecated/defaultUser.gif) and not defaultUser.png
(Products/CMFPlone/skins/plone_images/defaultUser.png).
Test is also updated.
2013-11-13 15:53:12 +01:00
c45650261e
Rename @@discussion-settings to @@discussion-controlpanel
2013-11-12 10:45:59 +01:00
410b8c998a
Fix ownership of comments.
2013-11-05 10:23:15 +01:00
e7cae8430a
Replace deprecated test assert statements.
2013-10-10 16:29:15 +02:00
fbc78e2951
Remove portal_discussion tool.
2013-10-10 15:36:18 +02:00
fd85de9c30
Fix comments Title if utf-8 characters in author_name
2013-09-20 16:28:05 +02:00
9049368cba
Refactor tests to use the PLONE_APP_CONTENTTYPES_FIXTURE instead of the PLONE_FIXTURE. This fixes all test p.a.discussion test failures.
2013-08-29 22:20:47 +02:00
b027789391
prevent the viewlet from raising an error for objects that are not annotatable
2013-08-15 00:01:22 +02:00
52c6372664
fix deprecation warning
2013-06-04 13:23:22 +00:00
fd9d0a0eba
Revert "Add a test for permission Acquisition on comments."
...
This reverts commit 66d355544f
2013-05-10 13:39:02 +02:00
6d5c193d8c
Revert "Move application of custom workflow to test_acquisition.py..."
...
This reverts commit 6e9b32254e
2013-05-10 13:38:46 +02:00
6e9b32254e
Move application of custom workflow to test_acquisition.py...
...
...so it doesn't interfere with other test in the layer.
2013-05-10 13:26:30 +02:00
66d355544f
Add a test for permission Acquisition on comments.
...
We use a different workflow for comments:
The View permission is acquired instead of given explicitly,
as outlined in https://dev.plone.org/ticket/12531 .
2013-05-10 13:18:58 +02:00
e2a43aefb6
Remove testbrowser dump.
2013-04-22 14:55:04 +02:00
849299f233
Pep8.
2013-04-18 15:21:00 +02:00
20935da608
Pep8.
2013-04-17 19:37:10 +02:00
29fe4bbec7
Pep8.
2013-04-17 19:34:17 +02:00
b4c22e90bf
Pep8.
2013-04-17 19:27:30 +02:00
943065c15f
Pep8.
2013-04-17 19:07:40 +02:00
dcb2d3e7d4
Pep8
2013-04-17 19:04:45 +02:00
628f72ea0b
Pep8.
2013-04-17 14:24:39 +02:00
05f0e7e4d8
Many updates to handle non public comments properly
2013-03-28 14:28:22 +01:00
6f675b6f80
Merge pull request #23 from bdbaddog/fix_comment_user_migration
...
fix migration of author_name and author_username
2013-02-11 10:20:41 -08:00
a6afdf265c
Pep8
2013-01-10 18:40:04 +01:00
69b628c386
Pep8.
2013-01-10 18:33:46 +01:00
372b573cb1
move creation of test user to test setup, rather than just in the new test_migrate_comment_with_creator() method
2012-12-15 16:45:56 -08:00
ff1f65a75e
simplify some of the logic and get some tests in place to cover them. TDB: test against actual site to ensure the changes to the logic don't break a real environment, but still work with the tests..
2012-12-13 21:14:40 -08:00
e57d3a2ad4
Convert test for invalid comment id in url to integration test.
2012-11-16 10:29:50 +01:00
6bd31ad490
Make conversation view not break when comment-id cannot be converted to long, fixes #13327
2012-11-14 13:25:10 +01:00
41a53fc8ff
Fix failing test.
2012-11-04 17:18:46 +01:00
56b08b2247
Fix catalog updates for IObjectMovedEvent
...
If comments were moved because an object on a higher level than the
commented object was moved, these comments were wrongly reindexed.
The commented object also got a wrong __parent__ pointer.
This fixes https://dev.plone.org/ticket/13172 .
2012-09-17 16:52:05 +02:00
58b4205f38
Revert "Attempt to fix test_format_time()."
...
This reverts commit c231794940
2012-08-02 22:21:26 -07:00
7fe9f062e8
Revert "Update master"
...
This reverts commit 53ec8e52ea
2012-08-02 22:21:19 -07:00
53ec8e52ea
Update master
2012-07-18 06:58:17 +03:00
c231794940
Attempt to fix test_format_time().
2012-07-18 06:56:14 +03:00
528e1a1434
Run ConversationTest for dexterity types only if dexterity is installed.
2012-07-12 18:56:10 +02:00
103c7323e7
Fix test that fails due to the creator/author_name changes.
2012-07-12 17:29:05 +02:00
a6a48a58dd
Fix test that fails due to the css id changes due to comment text field.
2012-07-12 17:28:12 +02:00
c47689af42
Fix handling of comments with invalid transforms. Write an error msg to the log and just return the untransformed text.
2012-07-12 16:03:02 +02:00
702f7e1f1d
Make 'text/plain' the default mime type for comments and make sure the default type is set properly when creating a new comment.
2012-07-12 16:01:07 +02:00
f45373b311
Test for mime type transformation from html to html added.
2012-07-12 15:54:38 +02:00
0535e659ff
Refactor the comment creator/author_name to comply with the Plone core convention to store the username on the creator attribute and not the fullname.
2012-07-12 15:39:27 +02:00
f45a2e8bba
Replace deprecated unit test methods.
2012-07-12 15:08:22 +02:00
636e77e3b2
Reverting, as per Timo's comment in 49734cd39b (commitcomment-1559057).
...
So Jenkins is running the tests using the en-US locale?
2012-07-10 10:56:56 +03:00
49734cd39b
Fallback for localized time is now ISO style.
...
https://jenkins.plone.org/job/plone-4.3-tests/89/testReport/junit/plone.app.discussion.tests.test_comments_viewlet/TestCommentsViewlet/test_format_time/
2012-07-07 11:58:46 +03:00
0e587a7d85
Support for Dexterity added.
2012-06-30 10:59:49 +02:00
53428fe5f6
total_comments only counts published comments
...
Also migrate workflow state during migration.
2012-06-13 11:17:22 +00:00
e31f90c440
Prune duplicated test code
2012-06-12 14:44:42 +00:00
f66d6e1c05
Make topic/collection tests pass when plone.app.collection is installed.
2012-04-02 22:00:27 +02:00
4d330f2daa
Make comment collection tests work with plone.app.collection.
2012-03-31 18:40:58 +02:00
877f2d3e84
fix url redirect for content types that must have /view in url to view contents
2012-03-14 15:01:17 -07:00
81fd515455
Pep8
2012-01-14 07:53:03 +01:00
11e101f7d7
Pep8
2012-01-14 07:47:07 +01:00
aa36c0bc9b
Pep8
2012-01-14 07:41:50 +01:00
2dc5393ff2
Pep8
2012-01-14 07:35:59 +01:00
0558a9b739
Pep8
2012-01-14 07:26:01 +01:00
a3883d7e7b
Pep8
2012-01-14 07:13:39 +01:00
f520482eb3
Pep8
2012-01-14 07:03:29 +01:00
e17cfa68a1
Fix whitespace/Pep8/Pyflakes in tests.
2012-01-09 16:43:54 +01:00
3b1d1b8967
Changelog entry and test to fix #12437 added.
2011-12-21 19:37:40 +01:00
f68c2caf9f
Remove unused PloneTestCase import.
2011-10-30 08:19:30 +01:00
b0a177f4d2
Fix various text typos.
2011-10-30 08:11:06 +01:00
cdf2beda40
Make sure only comments to the content object are removed from the catalog when the content object is moved.
...
svn path=/plone.app.discussion/trunk/; revision=51527
2011-08-04 15:53:21 +00:00
0e47299c75
Make sure the comment brains are updated properly when the content object is renamed. Thanks hannosch for the code review.
...
svn path=/plone.app.discussion/trunk/; revision=51526
2011-08-04 14:13:01 +00:00
9cd4058bca
Move move_comments test to the right position.
...
svn path=/plone.app.discussion/trunk/; revision=50947
2011-07-04 07:27:16 +00:00
b7dad192d5
Update comment brains in zcatalog when moving a content object with comments. This fixes http://dev.plone.org/plone/ticket/11331 . Refs #11331
...
svn path=/plone.app.discussion/trunk/; revision=50937
2011-07-03 18:36:02 +00:00
1a751b495f
Unless Discussion Item has an workflow, moderation is not enabled
...
svn path=/plone.app.discussion/trunk/; revision=49135
2011-04-27 17:41:07 +00:00
e75685d5c0
Add links to delete/approve a comment in the moderator notification email.
...
Remove the unnecessary workflow_action parameter from the PublishComments request.
svn path=/plone.app.discussion/trunk/; revision=49045
2011-04-22 17:09:09 +00:00
521ea78ce3
Whitespace.
...
svn path=/plone.app.discussion/trunk/; revision=49043
2011-04-22 17:04:35 +00:00
b84211ddf0
Remove ImportError exceptions for Plone < 4.1 code and plone.z3cform < 0.6.0.
...
svn path=/plone.app.discussion/trunk/; revision=49033
2011-04-22 14:59:59 +00:00
31ecf38129
Provide the comment body text in the email notification.
...
svn path=/plone.app.discussion/trunk/; revision=49032
2011-04-22 13:34:50 +00:00
f8c39c1b87
Fix comment link in email notification. This fixes http://dev.plone.org/plone/ticket/11413
...
svn path=/plone.app.discussion/trunk/; revision=49031
2011-04-22 12:47:29 +00:00
49504c1ddd
Redirect to the comment itself when notifying a user about a new comment.
...
svn path=/plone.app.discussion/trunk/; revision=49030
2011-04-22 08:54:35 +00:00
80a7b90a30
Move all tests from testing layer to plone.app.testing.
...
svn path=/plone.app.discussion/trunk/; revision=48916
2011-04-17 08:51:58 +00:00
f3d97b2f20
Use plone.app.testing in test_moderation_view.
...
svn path=/plone.app.discussion/trunk/; revision=48915
2011-04-17 08:50:34 +00:00
d66328a26a
Use plone.app.testing in test_migration.
...
svn path=/plone.app.discussion/trunk/; revision=48906
2011-04-16 09:51:28 +00:00
216e95aa27
Use plone.app.testing in test_indexers.
...
svn path=/plone.app.discussion/trunk/; revision=48905
2011-04-16 09:35:34 +00:00
85126e9109
Use plone.app.testing in test_notifications.
...
svn path=/plone.app.discussion/trunk/; revision=48904
2011-04-16 09:31:03 +00:00
1682c89745
Use plone.app.testing in test_tool.
...
svn path=/plone.app.discussion/trunk/; revision=48903
2011-04-16 09:30:11 +00:00
fc59094cb2
Use plone.app.testing in test_workflow.
...
svn path=/plone.app.discussion/trunk/; revision=48902
2011-04-16 09:29:15 +00:00
41f5afa8b9
Use plone.app.testing in test_conversation.
...
svn path=/plone.app.discussion/trunk/; revision=48901
2011-04-16 09:27:15 +00:00
c4e69627b3
Use plone.app.testing in test_controlpanel.
...
svn path=/plone.app.discussion/trunk/; revision=48900
2011-04-16 09:26:20 +00:00
f8019b0c10
Use plone.app.testing in test_comments_viewlet.
...
svn path=/plone.app.discussion/trunk/; revision=48899
2011-04-16 09:25:16 +00:00
38b70a28e5
Use plone.app.testing in test_comment.
...
svn path=/plone.app.discussion/trunk/; revision=48898
2011-04-16 09:16:18 +00:00
e5d45dbd78
Use plone.app.testing in test_catalog.
...
svn path=/plone.app.discussion/trunk/; revision=48897
2011-04-16 09:13:39 +00:00
9db8909ea7
Avoid using deprecated test assertions, see http://docs.python.org/dev/library/unittest.html#deprecated-aliases for the full list
...
svn path=/plone.app.discussion/trunk/; revision=48881
2011-04-15 16:23:38 +00:00
811d4a0429
Avoid deprecation warnings and always specify a catalog query as a dict
...
svn path=/plone.app.discussion/trunk/; revision=48880
2011-04-15 16:17:02 +00:00
3708429a37
Move some policy out of the conversation storage adapter into a view,
...
specifically "enabled()". Prevents having to replace/migrate
persistent objects to change policy which really only concerns the
context and possibly the request, not the conversation storage. Fixes
#11372 .
svn path=/plone.app.discussion/trunk/; revision=48849
2011-04-15 04:29:46 +00:00
7354ca4298
Fix unindexing of comments when deleting content resulting from
...
iterating over a BTree while modifying it. Fixes #11402 .
svn path=/plone.app.discussion/trunk/; revision=48845
2011-04-14 21:30:32 +00:00
5786bfa6b6
pep8
...
svn path=/plone.app.discussion/trunk/; revision=48840
2011-04-14 20:17:10 +00:00
cad670d6af
Fax Missing.Value for Creator in the catalog. Fixes #11634 .
...
svn path=/plone.app.discussion/trunk/; revision=48838
2011-04-14 19:59:05 +00:00
187aa60452
These testbrowser tests certainly no longer raise 404s for me
...
svn path=/plone.app.discussion/trunk/; revision=48837
2011-04-14 19:06:55 +00:00
d8f864596e
The functional tests haven't been running due to an unused import
...
svn path=/plone.app.discussion/trunk/; revision=48835
2011-04-14 19:05:31 +00:00
d5a999b429
Clarify a doctest
...
svn path=/plone.app.discussion/trunk/; revision=48831
2011-04-14 16:41:11 +00:00
586cd1fdb7
Don't add the annotation unless a comment is actually being added.
...
Fixes #11370 .
svn path=/plone.app.discussion/trunk/; revision=48829
2011-04-14 16:17:29 +00:00
6d11fa6d5e
merge c48523 from 1.x branch
...
svn path=/plone.app.discussion/trunk/; revision=48527
2011-04-07 21:31:56 +00:00
636bca745c
merge r47140, r47290, r47579 from davisagli-features: fix timezone handling when migrating legacy comments and when indexing
...
svn path=/plone.app.discussion/trunk/; revision=48358
2011-04-02 21:26:36 +00:00
9d83b4f0e6
merge -r46947 from davisagli-features: preserve legacy titles on migrated comments
...
svn path=/plone.app.discussion/trunk/; revision=48357
2011-04-02 21:16:24 +00:00
eb004aab44
merge r46437 and r46946 from davisagli-features: respect the per-comment mime_type setting, and use the old cooked text/html from legacy comments when migrating
...
svn path=/plone.app.discussion/trunk/; revision=48356
2011-04-02 19:51:37 +00:00
bf5946367a
merge r46436 from davisagli-features: make it possible to specify a callback filter for the migration
...
svn path=/plone.app.discussion/trunk/; revision=48354
2011-04-02 19:33:10 +00:00
774ed36746
Ups, there is a nother unicode problem
...
svn path=/plone.app.discussion/trunk/; revision=47990
2011-03-08 20:15:37 +00:00
b6d406d298
Trigger failure for objects with unicode titles in string
...
svn path=/plone.app.discussion/trunk/; revision=47989
2011-03-08 20:15:21 +00:00
478273aa80
minor code cleanup
...
svn path=/plone.app.discussion/trunk/; revision=47599
2011-02-15 16:23:12 +00:00
81d74cfe6b
Fixed test failure for the default user portrait, which changed from
...
defaultUser.gif to defaultUser.png in Products.PlonePAS 4.0.5.
svn path=/plone.app.discussion/trunk/; revision=47597
2011-02-15 16:19:13 +00:00
bf96d0082f
Remove "Plone 3 only" code; Do not monkey patch the BAD_TYPES vocabulary or plone.app.vocabularies anymore.
...
svn path=/plone.app.discussion/trunk/; revision=47311
2011-02-08 09:28:51 +00:00
0a0e69d47d
Do not check for a comment review workflow when sending out a moderator email notification. This fixes http://dev.plone.org/plone/ticket/11444 . Refs #11444
...
svn path=/plone.app.discussion/trunk/; revision=47292
2011-02-07 11:48:24 +00:00
c438743a3b
Show a 'Comments are moderated.' message next to the comment form if comments are moderated.
...
svn path=/plone.app.discussion/trunk/; revision=46782
2011-01-07 10:20:24 +00:00
a2a17085a3
Nuke trailing white space
...
svn path=/plone.app.discussion/trunk/; revision=46366
2010-12-15 23:52:56 +00:00
aff8a3709c
Avoid sending multiple notification emails to the same person when
...
he has commented multiple times.
svn path=/plone.app.discussion/trunk/; revision=46365
2010-12-15 23:41:57 +00:00
0cb75778ba
make sure comments don't get indexed with their parents' UID in Plone 3. only declare dependency on plone.app.uuid in Python 2.6, since we only use it in Plone 4 currently.
...
svn path=/plone.app.discussion/trunk/; revision=46353
2010-12-15 20:39:55 +00:00
b9d929bca3
Fix failing test.
...
svn path=/plone.app.discussion/trunk/; revision=46344
2010-12-14 21:30:40 +00:00
a8bfd7fc6e
Disable discussion by default.
...
svn path=/plone.app.discussion/trunk/; revision=46337
2010-12-14 17:58:46 +00:00
d702c666f0
Tests for moderation_enabled setting added.
...
svn path=/plone.app.discussion/trunk/; revision=46266
2010-12-12 13:56:06 +00:00
0475376ed0
"Enable comment moderation" setting added to the discussion control panel. Just a proof of concept so far. Not fully implemented yet. No tests.
...
svn path=/plone.app.discussion/trunk/; revision=46249
2010-12-11 17:18:14 +00:00
09a804aa88
Remove unnecessary and failing test.
...
svn path=/plone.app.discussion/trunk/; revision=46235
2010-12-10 09:16:36 +00:00
54af7d3fa1
Assigning the 'Reply to item' permission to the 'Authenticated' role. The old commenting system allowed 'Authenticated' users to post comments. Also, OpenID users do not possess the 'Authenticated' role. Refs #9288
...
svn path=/plone.app.discussion/trunk/; revision=46230
2010-12-10 08:57:35 +00:00
45140c66db
Functional test for posting a comment as user without the 'Reply to item' permission added.
...
svn path=/plone.app.discussion/trunk/; revision=46215
2010-12-09 10:58:32 +00:00
7e279d3ad3
Make sure the handleComment method checks for the 'Reply to item' permission when adding a comment.
...
svn path=/plone.app.discussion/trunk/; revision=46212
2010-12-09 08:11:41 +00:00
0c94707743
Dynamically show the comment formatting message dependent on the text transform setting.
...
svn path=/plone.app.discussion/trunk/; revision=46035
2010-11-29 22:42:20 +00:00
f0cecaf274
Always set the effective date of a comment to the same value as the creation date.
...
svn path=/plone.app.discussion/trunk/; revision=46019
2010-11-29 17:36:52 +00:00
ac4a64f55d
Make sure comment UIDs in the catalog are always unique. This fixes
...
http://dev.plone.org/plone/ticket/10652 . We depend on plone.uuid and plone.app.uuid now. Refs #10652 .
svn path=/plone.app.discussion/trunk/; revision=46005
2010-11-28 11:39:19 +00:00
b08d7ddbeb
revert r46002.
...
svn path=/plone.app.discussion/trunk/; revision=46003
2010-11-28 10:00:31 +00:00
7e39197114
hudson buildout added.
...
svn path=/plone.app.discussion/trunk/; revision=46002
2010-11-28 09:51:35 +00:00
d358a31c74
Comments viewlet test for posting anonymous comments added.
...
svn path=/plone.app.discussion/trunk/; revision=45663
2010-11-08 17:10:19 +00:00
b95707ac52
Re-add the CommentsViewlet can_manage method. This method has been removed in version 1.0b9 and added again in 1.0b11 because we don't want to change the API in beta releases.
...
svn path=/plone.app.discussion/trunk/; revision=45110
2010-11-03 11:26:18 +00:00
a39ac82858
There is no need to set the comment title in the tests, since comments do not have title fields anymore.
...
svn path=/plone.app.discussion/trunk/; revision=44738
2010-10-31 11:09:32 +00:00
feec103b56
Fix user email notification test for Plone 3.
...
svn path=/plone.app.discussion/trunk/; revision=44737
2010-10-31 10:48:45 +00:00
c8cd370fc9
Use len(tuple()) instead of tuple() to make tests pass again.
...
svn path=/plone.app.discussion/trunk/; revision=44706
2010-10-30 19:26:51 +00:00
093eaa393a
Use tuple() to test for generators. Thanks to otacon!
...
svn path=/plone.app.discussion/trunk/; revision=42096
2010-10-30 18:58:20 +00:00
Timo Stollenwerk
Timo Stollenwerk
Alin Voinea
Jens W. Klein
maartenkling
Philip Bauer
Alan Hoey
vmaksymiv
Kees Hink
David Glick
Benoît Suttor
JeanMichel FRANCOIS
Huub Bouma
Andreas Zeidler
Paul J Stevens
Patrick Gerken
bdbaddog
William Deegan
Kees Hink
Gaudenz Steinlin
David Glick
Karl Johan Kleist
Elizabeth Leddy
Timo Stollenwerk
Timo Stollenwerk
Erico Andrei
Hanno Schlichting
Ross Patterson
David Glick
Patrick Gerken
Maurits van Rees