Commit Graph

450 Commits

Author SHA1 Message Date
Markus Hilbert 3c36af8ebc Fixed tests when IRichText behavior is used. 2018-07-11 12:35:46 +02:00
Jens W. Klein 58711579c4 isort 2018-06-15 10:22:11 +02:00
Jens W. Klein bf0fa909b9 fix tests for plone.login merge 2018-06-15 10:14:51 +02:00
Philip Bauer 71dcbf8465 some py3 fixes 2018-03-18 17:01:27 +01:00
Philip Bauer e4f798d9d3 make doctest syntax py3 compatible 2018-01-26 11:11:50 +01:00
Philip Bauer 93a227c80d Add Python 2 / 3 compatibility 2018-01-25 13:04:11 +01:00
Katja Süss 78abff152d Test 2017-07-28 19:12:49 +00:00
Katja Süss 0fd9b02c80 Email validation 2017-06-20 15:16:19 +02:00
KUMAR AKSHAY 964dcea523 kakshay unittest (#121)
remove unittest2 dependency
2017-05-08 09:24:38 +02:00
Maurits van Rees b5eebe0cc8 Fixed tests with newer testbrowser. 2017-02-04 16:58:38 +01:00
MrTango bc2a9ac5d9 remove __of__ calls on views 2017-01-31 17:57:41 +01:00
Daniel Jowett d2bba1d5ea Fix some easy pep8 issues 2017-01-24 10:59:43 +00:00
Maurits van Rees 802e3ec04c Make comment on private content not publicly available in search results.
This is part of PloneHotfix20161129.

Updated metadata.xml version to 1000.  This leaves more room for
profile version increases in earlier releases.  We apply the rolemap
step again to avoid accidentally missing it.
2017-01-14 17:58:48 +01:00
Gil Forcada 26a21a12d5 Reindex comments when they are modified 2016-09-20 13:05:24 +02:00
Maurits van Rees 358ec89c03 Apply security hotfix 20160830 for redirects. 2016-09-19 17:10:10 +02:00
Maurits van Rees 6952923b1e Reset the required setting of the author_email widget each time.
Otherwise, the email field might get set to required when an anonymous
user visits, and then remain required when an authenticated user
visits, making it impossible for an authenticated user to fill in the
form without validation error.  Or when in the control panel the field
is set as not required anymore, that change would have no effect until
the instance was restarted.
2016-06-10 01:57:04 +02:00
Tom Gross 085567431f Make tests work with lxml safe html cleaner (#97)
* Make tests work with lxml safe html cleaner

* whitespace fix in test assertion
2016-05-31 11:41:34 +02:00
Gil Forcada cb1bf28c16 Cleanup
Follow https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst
to clean up the code.
2016-02-05 09:43:42 +01:00
Maurits van Rees e5d6916c2f In tests, use ``selection.any`` in querystrings.
Issue https://github.com/plone/Products.CMFPlone/issues/1040
2015-11-25 11:40:06 +01:00
Davi Lima 3f07781675 Update Site Setup link in all control panels (fixes plone/Products.CMFPlone#1255) 2015-11-23 09:13:00 -03:00
esteele 98f1f3d6a4 Move portal_properties settings to configuration registry
commit b13db31e3c55fd5ed9320e9d0c93aea48366c883
Author: esteele <eric@esteele.net>
Date:   Fri Sep 18 10:14:56 2015 +0200

    Remove pdb.

commit 6b3e591583146ca661556ef50cafd02f62c79d46
Author: esteele <eric@esteele.net>
Date:   Fri Sep 18 09:50:06 2015 +0200

    Fix registry id

commit 9dfce9a739496b6023f93376535dccc9a9310517
Author: esteele <eric@esteele.net>
Date:   Thu Sep 17 18:34:42 2015 +0200

    Use registry lookup for types_use_view_action_in_listings
2015-09-20 17:31:55 +02:00
vangheem 4bd649e021 fix test 2015-05-30 19:28:22 -05:00
Low Kian Seong da84d4d642 Fixing broken test on travis 2015-05-13 20:03:11 +08:00
vangheem 1a04b5b042 fix test failures with csrf protection and locking behavior 2015-05-08 12:06:29 -05:00
Gil Forcada dcb2a5f51b 2 spaces between top level classes 2015-05-03 08:43:22 +02:00
Gil Forcada 8410b7525f Do not redefine comment 2015-05-03 08:42:52 +02:00
Gil Forcada 754e712372 Typo 2015-05-03 08:42:07 +02:00
Gil Forcada ce48a9ed46 2 spaces before inline comment 2015-05-03 08:41:56 +02:00
Gil Forcada fad5a96129 Unused variable 2015-05-03 08:27:21 +02:00
Gil Forcada 411f36e708 One argument per line 2015-05-03 08:27:03 +02:00
Gil Forcada 2baafcbfd8 Typo 2015-05-03 08:25:19 +02:00
Gil Forcada 9066183ea9 2 lines between top level functions/classes 2015-05-03 08:24:08 +02:00
Gil Forcada 4bc77a2831 Sort imports
Remove unused ones as well.
2015-05-03 08:16:41 +02:00
David Glick 8690461ffb create doc1 in the text fixture rather than in setup for each test 2015-03-09 21:51:45 -07:00
Gil Forcada 4ea41aba43 Fix tests 2015-02-16 16:35:43 +01:00
Timo Stollenwerk 5f1a7fb5bc Merge branch 'master' into plip10359-z3cform
Conflicts:
	CHANGES.rst
2015-01-29 21:31:45 +01:00
Timo Stollenwerk c852609111 Merge branch 'master' into delete-own-comments
Conflicts:
	CHANGES.rst
2015-01-29 21:14:05 +01:00
Timo Stollenwerk 785bc7b890 Read mail settings from new (Plone 5) registry. 2014-12-13 16:20:08 +01:00
Vincent Fretin acacc8281a add a test for delete-own-comment view 2014-09-20 16:21:55 +02:00
Vincent Fretin 2a8082cfa7 add delete_own_comment_enabled option in control panel 2014-09-20 16:02:48 +02:00
Vincent Fretin 42d12200a7 Don't use session at all for content rules, set the event in the request to be able to access comment attributes. This fixes 'InvalidObjectReference: A new object is reachable from multiple databases.' if comment contains a RichTextValue which contains a RawValueHolder (persistent object). 2014-09-20 14:54:02 +02:00
Vincent Fretin ee28528f55 Don't use session at all for content rules, set the event in the request to be able to access comment attributes. This fixes 'InvalidObjectReference: A new object is reachable from multiple databases.' if comment contains a RichTextValue which contains a RawValueHolder (persistent object). 2014-09-20 14:14:19 +02:00
Gil Forcada fa127ad85c Whitespaces cleanup 2014-08-23 00:31:28 +02:00
Andrea Cecchi 4f255a355d rebased CHANGES and tests 2014-05-15 17:51:22 +02:00
Andrea Cecchi e453e0050b fixed HISTORY and add delete test to test_comments_viewlet 2014-05-15 17:51:22 +02:00
Andrea Cecchi 9a4e3718fc added Delete comments permission to manage comments deletion 2014-05-15 17:51:05 +02:00
Andrea Cecchi fd16144b9b fixed edit test 2014-05-15 17:51:05 +02:00
Andrea Cecchi 3711d2fb5f rebased branch from master 2014-05-15 17:51:05 +02:00
Guido A.J. Stevens 520b1e83f4 provide "delete own comments" as a configurable option 2014-05-15 17:50:32 +02:00
Guido A.J. Stevens a82352a36c Make comments editable 2014-05-15 17:50:32 +02:00
Timo Stollenwerk 2b18d5a2e4 Revert "Merge pull request #38 from delib/evilbungle-comment-acquisition"
This reverts commit e18598e316, reversing
changes made to fd6ac0788b.

This pull request introduces two test failures. See http://jenkins.plone.org/job/plone-5.0-python-2.7/lastCompletedBuild/testReport/ for details.
2014-05-13 07:07:37 +02:00
Timo Stollenwerk e18598e316 Merge pull request #38 from delib/evilbungle-comment-acquisition
Fixing incorrect behaviour with acquired permissions
2014-05-12 22:53:34 +02:00
Alin Voinea fe91d7801e Add tests for custom events and contentrules events/string substitutions 2014-05-12 20:20:18 +03:00
tisto 22ed06b66d Add second robot test to test adding comments. 2014-05-02 13:42:19 +02:00
tisto f894d47d62 Add basic robot test setup and a first test. 2014-05-02 13:22:08 +02:00
Jens W. Klein 6609ab6af5 make flake8 happy 2014-03-25 18:38:12 +01:00
Jens W. Klein a145413ac2 make flake8 happy 2014-03-25 18:37:06 +01:00
Jens W. Klein 67213b70eb make flake8 happy 2014-03-25 18:36:14 +01:00
tisto 9c9c2e2aaa Merge branch 'master' of git://github.com/huubbouma/plone.app.discussion into huubbouma-master
Conflicts:
	CHANGES.rst
2014-03-23 18:54:44 +01:00
maartenkling 0ea9a7131f merge upstream and fix numbering 2014-03-04 09:16:36 +01:00
Philip Bauer d788d07a87 fix test. the richtext-field in plone.app.contenttypes uses a behavior 2014-02-14 09:40:55 +01:00
maartenkling 8ccd648928 user member.getId as author_username, so membrane users and plone users have portraits and author urls 2014-02-02 14:55:37 +01:00
Timo Stollenwerk a8dc5dd3f0 Remove test_suite functions since they are only needed for zope.testing < 3.8.0. 2013-12-19 09:54:03 +01:00
tisto a2ae2a888f Remov qunit and jstestdriver test setup. 2013-12-15 12:56:51 +01:00
tisto f0a9d9ad6b Pep8 2013-12-15 12:02:32 +01:00
Alan Hoey e6ec6ebe16 Add tests to confirm that some methods of a conversation incorrectly use an unwrapped comment to determine whether anonymous users can view. 2013-11-25 12:52:31 +00:00
Alan Hoey 4804868ab2 Refactor acquisition tests to define the expected behaviour when dealing with wrapped and unwrapped comments. 2013-11-25 12:06:05 +00:00
vmaksymiv 8e56b99638 added test acquisition chain for unwrapped object
Conflicts:
	plone/app/discussion/tests/test_acquisition.py
2013-11-21 17:23:36 +00:00
Kees Hink 5fb6968fca Add a test for Acquisition in comments. 2013-11-21 17:22:12 +00:00
David Glick 7cfbd20d72 don't fail test if portal_atct is missing 2013-11-15 00:11:13 -08:00
Timo Stollenwerk 654869a30d Remove old topic test. New collections are tested in p.a.contenttypes anyways. 2013-11-14 11:01:14 +01:00
Benoît Suttor c3ce01edd0 Use defaultUser.png instead of defaultUser.gif
Indeed, defaultUser.gif is in a deprecated skins folder (Products/CMFPlone/
skins/plone_deprecated/defaultUser.gif) and not defaultUser.png
(Products/CMFPlone/skins/plone_images/defaultUser.png).
Test is also updated.
2013-11-13 15:53:12 +01:00
maartenkling c45650261e Rename @@discussion-settings to @@discussion-controlpanel 2013-11-12 10:45:59 +01:00
JeanMichel FRANCOIS 410b8c998a Fix ownership of comments. 2013-11-05 10:23:15 +01:00
tisto e7cae8430a Replace deprecated test assert statements. 2013-10-10 16:29:15 +02:00
tisto fbc78e2951 Remove portal_discussion tool. 2013-10-10 15:36:18 +02:00
Huub Bouma fd85de9c30 Fix comments Title if utf-8 characters in author_name 2013-09-20 16:28:05 +02:00
Timo Stollenwerk 9049368cba Refactor tests to use the PLONE_APP_CONTENTTYPES_FIXTURE instead of the PLONE_FIXTURE. This fixes all test p.a.discussion test failures. 2013-08-29 22:20:47 +02:00
Andreas Zeidler b027789391 prevent the viewlet from raising an error for objects that are not annotatable 2013-08-15 00:01:22 +02:00
Paul J Stevens 52c6372664 fix deprecation warning 2013-06-04 13:23:22 +00:00
Kees Hink fd9d0a0eba Revert "Add a test for permission Acquisition on comments."
This reverts commit 66d355544f.
2013-05-10 13:39:02 +02:00
Kees Hink 6d5c193d8c Revert "Move application of custom workflow to test_acquisition.py..."
This reverts commit 6e9b32254e.
2013-05-10 13:38:46 +02:00
Kees Hink 6e9b32254e Move application of custom workflow to test_acquisition.py...
...so it doesn't interfere with other test in the layer.
2013-05-10 13:26:30 +02:00
Kees Hink 66d355544f Add a test for permission Acquisition on comments.
We use a different workflow for comments:
The View permission is acquired instead of given explicitly,
as outlined in https://dev.plone.org/ticket/12531.
2013-05-10 13:18:58 +02:00
Timo Stollenwerk e2a43aefb6 Remove testbrowser dump. 2013-04-22 14:55:04 +02:00
Timo Stollenwerk 849299f233 Pep8. 2013-04-18 15:21:00 +02:00
Timo Stollenwerk 20935da608 Pep8. 2013-04-17 19:37:10 +02:00
Timo Stollenwerk 29fe4bbec7 Pep8. 2013-04-17 19:34:17 +02:00
Timo Stollenwerk b4c22e90bf Pep8. 2013-04-17 19:27:30 +02:00
Timo Stollenwerk 943065c15f Pep8. 2013-04-17 19:07:40 +02:00
Timo Stollenwerk dcb2d3e7d4 Pep8 2013-04-17 19:04:45 +02:00
Timo Stollenwerk 628f72ea0b Pep8. 2013-04-17 14:24:39 +02:00
Patrick Gerken 05f0e7e4d8 Many updates to handle non public comments properly 2013-03-28 14:28:22 +01:00
bdbaddog 6f675b6f80 Merge pull request #23 from bdbaddog/fix_comment_user_migration
fix migration of author_name and author_username
2013-02-11 10:20:41 -08:00
Timo Stollenwerk a6afdf265c Pep8 2013-01-10 18:40:04 +01:00
Timo Stollenwerk 69b628c386 Pep8. 2013-01-10 18:33:46 +01:00
William Deegan 372b573cb1 move creation of test user to test setup, rather than just in the new test_migrate_comment_with_creator() method 2012-12-15 16:45:56 -08:00
William Deegan ff1f65a75e simplify some of the logic and get some tests in place to cover them. TDB: test against actual site to ensure the changes to the logic don't break a real environment, but still work with the tests.. 2012-12-13 21:14:40 -08:00
Kees Hink e57d3a2ad4 Convert test for invalid comment id in url to integration test. 2012-11-16 10:29:50 +01:00
Kees Hink 6bd31ad490 Make conversation view not break when comment-id cannot be converted to long, fixes #13327 2012-11-14 13:25:10 +01:00