Commit Graph

1172 Commits

Author SHA1 Message Date
David Glick
7fe9f062e8 Revert "Update master"
This reverts commit 53ec8e52ea.
2012-08-02 22:21:19 -07:00
Karl Johan Kleist
53ec8e52ea Update master 2012-07-18 06:58:17 +03:00
Karl Johan Kleist
c231794940 Attempt to fix test_format_time(). 2012-07-18 06:56:14 +03:00
Timo Stollenwerk
528e1a1434 Run ConversationTest for dexterity types only if dexterity is installed. 2012-07-12 18:56:10 +02:00
Timo Stollenwerk
103c7323e7 Fix test that fails due to the creator/author_name changes. 2012-07-12 17:29:05 +02:00
Timo Stollenwerk
a6a48a58dd Fix test that fails due to the css id changes due to comment text field. 2012-07-12 17:28:12 +02:00
Timo Stollenwerk
c47689af42 Fix handling of comments with invalid transforms. Write an error msg to the log and just return the untransformed text. 2012-07-12 16:03:02 +02:00
Timo Stollenwerk
702f7e1f1d Make 'text/plain' the default mime type for comments and make sure the default type is set properly when creating a new comment. 2012-07-12 16:01:07 +02:00
Timo Stollenwerk
f45373b311 Test for mime type transformation from html to html added. 2012-07-12 15:54:38 +02:00
Timo Stollenwerk
eded7f1059 text/html added to possible mime types for comments. 2012-07-12 15:54:01 +02:00
Timo Stollenwerk
ac9d4f9584 Rename the id of the text widgets because there can be css-id clashes with
the text field of documents when using TinyMCE in overlays or multiple
instances of TinyMCE on a single page.
2012-07-12 15:49:19 +02:00
Timo Stollenwerk
0535e659ff Refactor the comment creator/author_name to comply with the Plone core convention to store the username on the creator attribute and not the fullname. 2012-07-12 15:39:27 +02:00
Timo Stollenwerk
19a511f4e5 Merge pull request #7 from plone/hide-from-breadcrumb
Hide Conversation objects from breadcrumb navigation
2012-07-12 06:18:42 -07:00
Timo Stollenwerk
f45a2e8bba Replace deprecated unit test methods. 2012-07-12 15:08:22 +02:00
tisto
65590732ea Move api documentation to a separate folder. 2012-07-12 15:03:26 +02:00
Timo Stollenwerk
7d34baf2d5 Prepare files for API documentation. 2012-07-12 14:56:03 +02:00
Timo Stollenwerk
4919b50edb Merge pull request #6 from stonor/master
Please pull this updated Danish translation
2012-07-12 03:44:10 -07:00
Timo Stollenwerk
19685db96b Merge pull request #9 from Goldmund-Wyldebeast-Wunderliebe/master
no more recursive came_from redirection after logged_in
2012-07-12 03:35:33 -07:00
Karl Johan Kleist
636e77e3b2 Reverting, as per Timo's comment in 49734cd39b (commitcomment-1559057).
So Jenkins is running the tests using the en-US locale?
2012-07-10 10:56:56 +03:00
Karl Johan Kleist
49734cd39b Fallback for localized time is now ISO style.
https://jenkins.plone.org/job/plone-4.3-tests/89/testReport/junit/plone.app.discussion.tests.test_comments_viewlet/TestCommentsViewlet/test_format_time/
2012-07-07 11:58:46 +03:00
Radim Novotny
d86e19e717 Added empty translation files for Slovak language 2012-07-02 17:54:58 +02:00
Timo Stollenwerk
0e587a7d85 Support for Dexterity added. 2012-06-30 10:59:49 +02:00
Paul J Stevens
53428fe5f6 total_comments only counts published comments
Also migrate workflow state during migration.
2012-06-13 11:17:22 +00:00
Paul J Stevens
e31f90c440 Prune duplicated test code 2012-06-12 14:44:42 +00:00
Gaudenz Steinlin
ad5cca6454 Hide Conversation objects from breadcrumb navigation
The breadcrumbs navigation is also used in the search results view.
This lead to Conversation objects showing up if 'Discussion Items'
are searchable.
2012-05-29 13:40:31 +02:00
Gaudenz Steinlin
a7b3c818f2 Delete own comments
Add permission to allow comment authors to delete their own comments if
there are no replies yet.
2012-05-29 13:33:46 +02:00
Gaudenz Steinlin
3eab51e1c4 Add Site Administrator role to Review comments permission 2012-05-29 13:26:05 +02:00
Gaudenz Steinlin
4e0bf9f25e Fix JS comment deletion
If the comment tree had just one top level comment the whole tree was
removed by the JS code if just one comment in the tree was deleted.
These comments were (correctly) not removed from the ZODB.
2012-05-29 13:26:05 +02:00
Anton Stonor
cc2af905dc Updating Danish translation 2012-05-23 08:35:04 +02:00
Hanno Schlichting
1b0ba3c0b0 No longer depend on zope.app packages. 2012-05-18 18:19:12 -04:00
Takeshi Yamamoto
5f063d60ea fixed Kanji typo. 2012-05-15 20:54:56 +09:00
Huub Bouma
c9848bebfe no more recursive came_from redirection after logged_in 2012-04-12 13:06:05 +02:00
Timo Stollenwerk
f66d6e1c05 Make topic/collection tests pass when plone.app.collection is installed. 2012-04-02 22:00:27 +02:00
Timo Stollenwerk
4d330f2daa Make comment collection tests work with plone.app.collection. 2012-03-31 18:40:58 +02:00
Timo Stollenwerk
ebb39b4994 No need to define portal_membership tool twice. 2012-03-19 16:32:33 +01:00
Timo Stollenwerk
58663fb492 Warning message added to discussion control panel that shows up if there are unmigrated comments. 2012-03-15 20:00:08 +01:00
Timo Stollenwerk
c76ef0523e Merge commit 877f2d3e84 which has been accidentially purged. 2012-03-15 19:06:23 +01:00
Timo Stollenwerk
910f75aa7e Make comments and controlpanel views more robust, so they don't break if no workflow is assigned to the 'Discussion Item' content type. 2012-03-15 13:06:00 +01:00
Elizabeth Leddy
877f2d3e84 fix url redirect for content types that must have /view in url to view contents 2012-03-14 15:01:17 -07:00
Timo Stollenwerk
5e5d9d0da4 Add missing meta_typ to 'Review comments' portal action. 2012-02-29 09:32:35 +01:00
Elizabeth Leddy
2971974f26 revert modification date since this is fixed in p.a.caching now 2012-02-25 11:59:30 +01:00
Mikel Larreategi
873300d347 fix typo in translation 2012-02-24 15:50:26 +01:00
Mikel Larreategi
1803410e07 add basque translation 2012-02-08 09:14:24 +01:00
Radim Novotny
f2462be14f Updated Czech i18n 2012-01-26 13:10:32 +01:00
Timo Stollenwerk
1920f1d4d5 Move IDiscussionSettings to the bottom of the interfaces file. 2012-01-25 16:02:00 +01:00
Timo Stollenwerk
80d70bbf08 Whitespace 2012-01-25 15:57:17 +01:00
Elizabeth Leddy
07b8ebc5df make sure commenting works when caching with modified headers 2012-01-24 18:28:02 -08:00
tisto
c14091c734 Pep8 2012-01-14 08:00:40 +01:00
tisto
81fd515455 Pep8 2012-01-14 07:53:03 +01:00
tisto
11e101f7d7 Pep8 2012-01-14 07:47:07 +01:00
tisto
aa36c0bc9b Pep8 2012-01-14 07:41:50 +01:00
tisto
2dc5393ff2 Pep8 2012-01-14 07:35:59 +01:00
tisto
2d4f7fd665 Pep8 2012-01-14 07:30:43 +01:00
tisto
0558a9b739 Pep8 2012-01-14 07:26:01 +01:00
tisto
a3883d7e7b Pep8 2012-01-14 07:13:39 +01:00
tisto
f520482eb3 Pep8 2012-01-14 07:03:29 +01:00
tisto
d5ccd2e2be Pep8 2012-01-14 06:57:25 +01:00
Timo Stollenwerk
cce409a729 Pep8 2012-01-13 14:40:26 +01:00
Timo Stollenwerk
07cde3ca7b Pep8 2012-01-13 10:16:01 +01:00
Timo Stollenwerk
e17cfa68a1 Fix whitespace/Pep8/Pyflakes in tests. 2012-01-09 16:43:54 +01:00
Timo Stollenwerk
1f01a71aac Whitespace. 2012-01-09 16:31:52 +01:00
Timo Stollenwerk
3b1d1b8967 Changelog entry and test to fix #12437 added. 2011-12-21 19:37:40 +01:00
Timo Stollenwerk
5e81422cd1 Rename discussion var to ctool which is more appropriate. 2011-12-21 19:17:58 +01:00
Paul J Stevens
6eb38ace08 fix indexing of comments (#12437) 2011-12-21 15:07:33 +01:00
hvelarde
774efd39d6 updated Spanish translation 2011-12-14 15:35:46 -06:00
Timo Stollenwerk
6a7c89ec78 Do not raise an error if the comment text is None. 2011-11-30 13:05:59 +01:00
Vincent Fretin
02775ac744 fixed typo 2011-11-21 19:27:43 +01:00
Vincent Fretin
9040f25dc1 fixed po headers 2011-11-21 19:17:06 +01:00
Timo Stollenwerk
f68c2caf9f Remove unused PloneTestCase import. 2011-10-30 08:19:30 +01:00
Timo Stollenwerk
b0a177f4d2 Fix various text typos. 2011-10-30 08:11:06 +01:00
Karl Johan Kleist
3b0b8a96ce fixed speling error, closes #12288 2011-10-18 09:56:24 +03:00
Paul J Stevens
1e040a1fd9 update NL translations 2011-09-30 16:41:09 +02:00
Paul J Stevens
21d2115cca add Dutch translations 2011-09-30 16:03:05 +02:00
Jon Stahl
813631dde8 couple of typos in control panel helptext
svn path=/plone.app.discussion/trunk/; revision=51868
2011-08-31 21:11:47 +00:00
Timo Stollenwerk
5911bae362 whitespace.
svn path=/plone.app.discussion/trunk/; revision=51798
2011-08-26 11:13:19 +00:00
Takeshi Yamamoto
0a13f79460 corrected location of Japanese po file.
svn path=/plone.app.discussion/trunk/; revision=51758
2011-08-24 01:14:43 +00:00
Timo Stollenwerk
f2a5c52947 Remove one_state_workflow customizations.
svn path=/plone.app.discussion/trunk/; revision=51722
2011-08-22 19:27:42 +00:00
David Glick
2bf5b43df5 uncatalog comments from the old location of the item being moved, not its parent
svn path=/plone.app.discussion/trunk/; revision=51692
2011-08-20 02:37:24 +00:00
David Glick
2b10fd06e2 fix failing test in CMFPlone. some things are contentish but not adaptable to IConversation (such as collection criteria)
svn path=/plone.app.discussion/trunk/; revision=51682
2011-08-19 18:54:44 +00:00
Volodymyr Cherepanyak
6e157df3d3 Ukrainian translation added
svn path=/plone.app.discussion/trunk/; revision=51663
2011-08-19 09:33:15 +00:00
Jian Aijun
dea6b644b6 updated Simplified Chinese translations
svn path=/plone.app.discussion/trunk/; revision=51655
2011-08-19 04:46:50 +00:00
Timo Stollenwerk
3798338549 No need to manually put comments from conversation.getComments in an acquisition chain since getComments now returns acquisition wrapped comments.
svn path=/plone.app.discussion/trunk/; revision=51642
2011-08-18 07:31:00 +00:00
Timo Stollenwerk
5045960281 Make sure the conversation.getComments method returns acquisition wrapped comments.
svn path=/plone.app.discussion/trunk/; revision=51639
2011-08-18 06:39:25 +00:00
nobody
d870171b37 updated Simplified Chinese translations
svn path=/plone.app.discussion/trunk/; revision=51590
2011-08-11 06:09:14 +00:00
Timo Stollenwerk
87700f3810 Markdown syntax added to possible comment text transforms.
svn path=/plone.app.discussion/trunk/; revision=51530
2011-08-05 10:08:39 +00:00
Timo Stollenwerk
cdf2beda40 Make sure only comments to the content object are removed from the catalog when the content object is moved.
svn path=/plone.app.discussion/trunk/; revision=51527
2011-08-04 15:53:21 +00:00
Timo Stollenwerk
0e47299c75 Make sure the comment brains are updated properly when the content object is renamed. Thanks hannosch for the code review.
svn path=/plone.app.discussion/trunk/; revision=51526
2011-08-04 14:13:01 +00:00
Jian Aijun
ca163009cc updated Simplified Chinese translations
svn path=/plone.app.discussion/trunk/; revision=51446
2011-07-26 06:04:48 +00:00
Jian Aijun
3dd76e2bb4 added & updated Simplified Chinese translation
svn path=/plone.app.discussion/trunk/; revision=51444
2011-07-25 15:47:26 +00:00
Timo Stollenwerk
f98b82b2d8 Make sure the catalog index for creator always stores encoded stings and not unicode since all strings in the catalog have to be utf-8 encoded strings.
svn path=/plone.app.discussion/trunk/; revision=51435
2011-07-25 08:12:04 +00:00
Timo Stollenwerk
1a6b1fdb91 Use Plone's safe_encode method instead of encode() to make sure unicode encoded strings can be indexed too.
svn path=/plone.app.discussion/trunk/; revision=51432
2011-07-25 06:47:45 +00:00
Timo Stollenwerk
dbda349768 Automatically reload batch moderation page if no comments are left. This refs #11298.
svn path=/plone.app.discussion/trunk/; revision=51274
2011-07-15 17:29:29 +00:00
Timo Stollenwerk
637ac334ac Remove debug print.
svn path=/plone.app.discussion/trunk/; revision=51259
2011-07-15 08:25:34 +00:00
Timo Stollenwerk
160022b146 Another fix for http://dev.plone.org/plone/ticket/11486. r51246 fixed Chrome but broke Safari. This fix has been tested in Fx, Chrome, Safari and IE 9.
svn path=/plone.app.discussion/trunk/; revision=51258
2011-07-15 08:23:08 +00:00
Timo Stollenwerk
c2ff87a778 Fix discussion control panel submit. This fixes Refs #11486.
svn path=/plone.app.discussion/trunk/; revision=51246
2011-07-14 07:09:58 +00:00
Timo Stollenwerk
9cd4058bca Move move_comments test to the right position.
svn path=/plone.app.discussion/trunk/; revision=50947
2011-07-04 07:27:16 +00:00
Timo Stollenwerk
50641ac6cc Remove unnecessary lines from notify_content_object_moved event subscriber function.
svn path=/plone.app.discussion/trunk/; revision=50944
2011-07-04 07:07:42 +00:00
Timo Stollenwerk
b7dad192d5 Update comment brains in zcatalog when moving a content object with comments. This fixes http://dev.plone.org/plone/ticket/11331. Refs #11331
svn path=/plone.app.discussion/trunk/; revision=50937
2011-07-03 18:36:02 +00:00
Timo Stollenwerk
101e9e2616 Plone 3 specific exclusion of plone.app.uuid removed.
svn path=/plone.app.discussion/trunk/; revision=50935
2011-07-03 18:26:06 +00:00
Timo Stollenwerk
98bcc19d5c Do not render/update the comment form in CommentViewlets if commenting is disabled, since this slows down the page rendering. This fixes http://dev.plone.org/plone/ticket/11930 #11930
svn path=/plone.app.discussion/trunk/; revision=50489
2011-06-16 10:59:25 +00:00
Laurence Rowe
46404c709f Move comments.js registration so it is merged along with other anonymous resources
svn path=/plone.app.discussion/trunk/; revision=50263
2011-06-05 22:30:56 +00:00
Laurence Rowe
b653c7a130 Insert css after forms.css to allow merging
svn path=/plone.app.discussion/trunk/; revision=50261
2011-06-05 22:05:22 +00:00
Laurence Rowe
b18da3f1ae Simplify CSS and JS registrations. CSS will now be imported using the
standard link and so can be merged.

svn path=/plone.app.discussion/trunk/; revision=50260
2011-06-05 21:52:01 +00:00
WouterVH
f149f0f8dd - Enable the left-menu on the configlet, to be more consistent with all other configlets.
Related to https://dev.plone.org/plone/ticket/11737
  [WouterVH]

svn path=/plone.app.discussion/trunk/; revision=50095
2011-05-28 22:02:33 +00:00
Timo Stollenwerk
a7f61eb4d3 Refactor/clean up the handleComment method.
svn path=/plone.app.discussion/trunk/; revision=50069
2011-05-27 13:47:15 +00:00
Timo Stollenwerk
1ea5f0cdb4 Make handleComment method store comment attributes from form extenders. This allows us to extend the comment form with external add-ons.
svn path=/plone.app.discussion/trunk/; revision=50059
2011-05-26 21:37:37 +00:00
Jian Aijun
f9f394a1f1 Updated Simplified Chinese translation
svn path=/plone.app.discussion/trunk/; revision=49791
2011-05-19 01:39:35 +00:00
Jian Aijun
dbd872a517 Updated Simplified Chinese translation
svn path=/plone.app.discussion/trunk/; revision=49630
2011-05-15 23:46:21 +00:00
Jian Aijun
5f983ffb4b Updated Simplified Chinese translation
svn path=/plone.app.discussion/trunk/; revision=49602
2011-05-15 01:25:01 +00:00
Jian Aijun
582ad4af19 Add Simplified Chinese translation
svn path=/plone.app.discussion/trunk/; revision=49577
2011-05-14 01:37:59 +00:00
Giorgio Borelli
d9016974fc italian translation review
svn path=/plone.app.discussion/trunk/; revision=49571
2011-05-13 22:21:51 +00:00
Timo Stollenwerk
420af84651 Minor German translation fix.
svn path=/plone.app.discussion/trunk/; revision=49340
2011-05-06 09:18:19 +00:00
Karl Johan Kleist
731e95af7a sv: all strings now translated for Plone 4.1
svn path=/plone.app.discussion/trunk/; revision=49336
2011-05-05 18:08:01 +00:00
Karl Johan Kleist
51466e8192 sv: just a few looong ones remain to translate now
svn path=/plone.app.discussion/trunk/; revision=49326
2011-05-04 17:23:20 +00:00
Karl Johan Kleist
c02450f2ff sv: first version based on "no", several strings remain to translate
svn path=/plone.app.discussion/trunk/; revision=49310
2011-05-03 15:51:02 +00:00
Erico Andrei
9ac35de362 Tests expect a False to be returned from the funcion
svn path=/plone.app.discussion/trunk/; revision=49137
2011-04-27 19:33:00 +00:00
Erico Andrei
1a751b495f Unless Discussion Item has an workflow, moderation is not enabled
svn path=/plone.app.discussion/trunk/; revision=49135
2011-04-27 17:41:07 +00:00
Thomas Desvenain
3a224784b0 typo
svn path=/plone.app.discussion/trunk/; revision=49134
2011-04-27 16:19:39 +00:00
Timo Stollenwerk
46ad92c4a2 German translation updated.
svn path=/plone.app.discussion/trunk/; revision=49048
2011-04-22 17:30:35 +00:00
Timo Stollenwerk
5bbf73978e German translation updated.
svn path=/plone.app.discussion/trunk/; revision=49047
2011-04-22 17:28:41 +00:00
Timo Stollenwerk
d00282a437 Translations updated. German translations for notifications added.
svn path=/plone.app.discussion/trunk/; revision=49046
2011-04-22 17:28:00 +00:00
Timo Stollenwerk
e75685d5c0 Add links to delete/approve a comment in the moderator notification email.
Remove the unnecessary workflow_action parameter from the PublishComments request.

svn path=/plone.app.discussion/trunk/; revision=49045
2011-04-22 17:09:09 +00:00
Timo Stollenwerk
521ea78ce3 Whitespace.
svn path=/plone.app.discussion/trunk/; revision=49043
2011-04-22 17:04:35 +00:00
Timo Stollenwerk
f551e30849 Replace tabs with whitespace in moderation.js.
svn path=/plone.app.discussion/trunk/; revision=49036
2011-04-22 15:43:58 +00:00
Timo Stollenwerk
c66e243a86 Make sure the email settings in the control panel are disabled when commenting is disabled globally;
Enable/disable moderator_email setting dynamically as mail settings or discussion settings change.

svn path=/plone.app.discussion/trunk/; revision=49035
2011-04-22 15:41:45 +00:00
Timo Stollenwerk
b84211ddf0 Remove ImportError exceptions for Plone < 4.1 code and plone.z3cform < 0.6.0.
svn path=/plone.app.discussion/trunk/; revision=49033
2011-04-22 14:59:59 +00:00
Timo Stollenwerk
31ecf38129 Provide the comment body text in the email notification.
svn path=/plone.app.discussion/trunk/; revision=49032
2011-04-22 13:34:50 +00:00
Timo Stollenwerk
f8c39c1b87 Fix comment link in email notification. This fixes http://dev.plone.org/plone/ticket/11413
svn path=/plone.app.discussion/trunk/; revision=49031
2011-04-22 12:47:29 +00:00
Timo Stollenwerk
49504c1ddd Redirect to the comment itself when notifying a user about a new comment.
svn path=/plone.app.discussion/trunk/; revision=49030
2011-04-22 08:54:35 +00:00
Timo Stollenwerk
93df8aa50b Remove outdated DOCUMENTATION.txt.
svn path=/plone.app.discussion/trunk/; revision=48997
2011-04-21 13:18:00 +00:00
Timo Stollenwerk
84a80743fc Fix language code/name for japanese translation.
svn path=/plone.app.discussion/trunk/; revision=48949
2011-04-19 07:00:18 +00:00
Takeshi Yamamoto
7803cccf7d added Japanese translation
svn path=/plone.app.discussion/trunk/; revision=48946
2011-04-19 05:34:58 +00:00
Timo Stollenwerk
80a7b90a30 Move all tests from testing layer to plone.app.testing.
svn path=/plone.app.discussion/trunk/; revision=48916
2011-04-17 08:51:58 +00:00
Timo Stollenwerk
f3d97b2f20 Use plone.app.testing in test_moderation_view.
svn path=/plone.app.discussion/trunk/; revision=48915
2011-04-17 08:50:34 +00:00
Timo Stollenwerk
d66328a26a Use plone.app.testing in test_migration.
svn path=/plone.app.discussion/trunk/; revision=48906
2011-04-16 09:51:28 +00:00
Timo Stollenwerk
216e95aa27 Use plone.app.testing in test_indexers.
svn path=/plone.app.discussion/trunk/; revision=48905
2011-04-16 09:35:34 +00:00
Timo Stollenwerk
85126e9109 Use plone.app.testing in test_notifications.
svn path=/plone.app.discussion/trunk/; revision=48904
2011-04-16 09:31:03 +00:00
Timo Stollenwerk
1682c89745 Use plone.app.testing in test_tool.
svn path=/plone.app.discussion/trunk/; revision=48903
2011-04-16 09:30:11 +00:00
Timo Stollenwerk
fc59094cb2 Use plone.app.testing in test_workflow.
svn path=/plone.app.discussion/trunk/; revision=48902
2011-04-16 09:29:15 +00:00
Timo Stollenwerk
41f5afa8b9 Use plone.app.testing in test_conversation.
svn path=/plone.app.discussion/trunk/; revision=48901
2011-04-16 09:27:15 +00:00
Timo Stollenwerk
c4e69627b3 Use plone.app.testing in test_controlpanel.
svn path=/plone.app.discussion/trunk/; revision=48900
2011-04-16 09:26:20 +00:00
Timo Stollenwerk
f8019b0c10 Use plone.app.testing in test_comments_viewlet.
svn path=/plone.app.discussion/trunk/; revision=48899
2011-04-16 09:25:16 +00:00
Timo Stollenwerk
38b70a28e5 Use plone.app.testing in test_comment.
svn path=/plone.app.discussion/trunk/; revision=48898
2011-04-16 09:16:18 +00:00
Timo Stollenwerk
e5d45dbd78 Use plone.app.testing in test_catalog.
svn path=/plone.app.discussion/trunk/; revision=48897
2011-04-16 09:13:39 +00:00
Hanno Schlichting
4110b41ae6 Even simpler code :)
svn path=/plone.app.discussion/trunk/; revision=48886
2011-04-15 16:56:17 +00:00
Hanno Schlichting
b4c5d287dd Style ;)
svn path=/plone.app.discussion/trunk/; revision=48885
2011-04-15 16:47:57 +00:00
Hanno Schlichting
f2e47227f9 Fix old-style exception raising
svn path=/plone.app.discussion/trunk/; revision=48884
2011-04-15 16:44:16 +00:00
Hanno Schlichting
9db8909ea7 Avoid using deprecated test assertions, see http://docs.python.org/dev/library/unittest.html#deprecated-aliases for the full list
svn path=/plone.app.discussion/trunk/; revision=48881
2011-04-15 16:23:38 +00:00
Hanno Schlichting
811d4a0429 Avoid deprecation warnings and always specify a catalog query as a dict
svn path=/plone.app.discussion/trunk/; revision=48880
2011-04-15 16:17:02 +00:00
Ross Patterson
3708429a37 Move some policy out of the conversation storage adapter into a view,
specifically "enabled()".  Prevents having to replace/migrate
persistent objects to change policy which really only concerns the
context and possibly the request, not the conversation storage. Fixes
#11372.

svn path=/plone.app.discussion/trunk/; revision=48849
2011-04-15 04:29:46 +00:00
Ross Patterson
7354ca4298 Fix unindexing of comments when deleting content resulting from
iterating over a BTree while modifying it. Fixes #11402.

svn path=/plone.app.discussion/trunk/; revision=48845
2011-04-14 21:30:32 +00:00
Erico Andrei
82b4a7ca70 Adding Brazilian Portuguese translation
svn path=/plone.app.discussion/trunk/; revision=48843
2011-04-14 20:58:24 +00:00
Erico Andrei
ea94d5e842 Adding Brazilian Portuguese translation
svn path=/plone.app.discussion/trunk/; revision=48842
2011-04-14 20:57:09 +00:00
Ross Patterson
5786bfa6b6 pep8
svn path=/plone.app.discussion/trunk/; revision=48840
2011-04-14 20:17:10 +00:00
Ross Patterson
cad670d6af Fax Missing.Value for Creator in the catalog. Fixes #11634.
svn path=/plone.app.discussion/trunk/; revision=48838
2011-04-14 19:59:05 +00:00
Ross Patterson
187aa60452 These testbrowser tests certainly no longer raise 404s for me
svn path=/plone.app.discussion/trunk/; revision=48837
2011-04-14 19:06:55 +00:00
Ross Patterson
d3025fb3ec Fix some aq wrapper errors introduced by my previous fix but not
exposed since the functional tests weren't running.

svn path=/plone.app.discussion/trunk/; revision=48836
2011-04-14 19:06:24 +00:00
Ross Patterson
d8f864596e The functional tests haven't been running due to an unused import
svn path=/plone.app.discussion/trunk/; revision=48835
2011-04-14 19:05:31 +00:00
Ross Patterson
d5a999b429 Clarify a doctest
svn path=/plone.app.discussion/trunk/; revision=48831
2011-04-14 16:41:11 +00:00
WouterVH
4b95d10bb6 some more nl-translations
svn path=/plone.app.discussion/trunk/; revision=48830
2011-04-14 16:38:22 +00:00
Ross Patterson
586cd1fdb7 Don't add the annotation unless a comment is actually being added.
Fixes #11370.

svn path=/plone.app.discussion/trunk/; revision=48829
2011-04-14 16:17:29 +00:00
Thomas Desvenain
119c1cb060 French translations
svn path=/plone.app.discussion/trunk/; revision=48820
2011-04-14 12:52:04 +00:00
Vincent Fretin
7912d9a049 Resync translations
svn path=/plone.app.discussion/trunk/; revision=48696
2011-04-10 20:38:14 +00:00
Vincent Fretin
7b42c34493 Nobody seems to maintain the LANGUAGES variable, remove the update-translations.sh script, use a simpler locales/update.sh script.
svn path=/plone.app.discussion/trunk/; revision=48695
2011-04-10 20:37:37 +00:00
Vincent Fretin
ab5c728448 Fixed i18n of the "Commenting has been disabled." message.
svn path=/plone.app.discussion/trunk/; revision=48694
2011-04-10 20:28:21 +00:00
David Glick
7803674dd0 merge r48557 from 1.x branch
svn path=/plone.app.discussion/trunk/; revision=48558
2011-04-08 20:47:50 +00:00
David Glick
8d3a37ead9 merge r48555 from 1.x branch. bumping profile version to 100 so there's space for future upgrades in the 1.x line
svn path=/plone.app.discussion/trunk/; revision=48556
2011-04-08 20:23:07 +00:00
David Glick
d323d37285 add upgrade step for moderator_email setting
svn path=/plone.app.discussion/branches/1.x/; revision=48555
2011-04-08 20:20:34 +00:00
David Glick
6d11fa6d5e merge c48523 from 1.x branch
svn path=/plone.app.discussion/trunk/; revision=48527
2011-04-07 21:31:56 +00:00
David Glick
9aea1915c1 add moderator email setting
svn path=/plone.app.discussion/branches/1.x/; revision=48523
2011-04-07 20:02:27 +00:00
Pavel Bogdanovic
c669e03ae2 some german translations
svn path=/plone.app.discussion/trunk/; revision=48395
2011-04-04 13:01:48 +00:00
David Glick
203836dc5e make discussion.css cacheable
svn path=/plone.app.discussion/trunk/; revision=48359
2011-04-02 21:27:47 +00:00
David Glick
636bca745c merge r47140, r47290, r47579 from davisagli-features: fix timezone handling when migrating legacy comments and when indexing
svn path=/plone.app.discussion/trunk/; revision=48358
2011-04-02 21:26:36 +00:00
David Glick
9d83b4f0e6 merge -r46947 from davisagli-features: preserve legacy titles on migrated comments
svn path=/plone.app.discussion/trunk/; revision=48357
2011-04-02 21:16:24 +00:00
David Glick
eb004aab44 merge r46437 and r46946 from davisagli-features: respect the per-comment mime_type setting, and use the old cooked text/html from legacy comments when migrating
svn path=/plone.app.discussion/trunk/; revision=48356
2011-04-02 19:51:37 +00:00
David Glick
bf5946367a merge r46436 from davisagli-features: make it possible to specify a callback filter for the migration
svn path=/plone.app.discussion/trunk/; revision=48354
2011-04-02 19:33:10 +00:00
David Glick
feb1759958 fix incorrect parenthesization
svn path=/plone.app.discussion/trunk/; revision=48240
2011-03-26 05:04:22 +00:00
David Glick
ebbf2d9b7b fix deprecation warning
svn path=/plone.app.discussion/trunk/; revision=48234
2011-03-26 02:44:49 +00:00
Thomas Desvenain
9b87f2b246 French translations
svn path=/plone.app.discussion/trunk/; revision=48112
2011-03-17 16:51:08 +00:00
Thomas Desvenain
7c2a815fdb Fixed internationalization issues.
svn path=/plone.app.discussion/trunk/; revision=48110
2011-03-17 16:15:40 +00:00
Thomas Desvenain
cf5f101538 message extraction + french translations (previous commit was bad)
svn path=/plone.app.discussion/trunk/; revision=48108
2011-03-17 15:30:31 +00:00
Thomas Desvenain
7271293606 message extraction + french translations
svn path=/plone.app.discussion/trunk/; revision=48107
2011-03-17 15:23:47 +00:00
Patrick Gerken
882e9e028f Take care of properly converting titles to unicode
svn path=/plone.app.discussion/branches/1.x/; revision=47999
2011-03-09 03:07:59 +00:00
Patrick Gerken
de9ebea499 Ups, there is a nother unicode problem
svn path=/plone.app.discussion/branches/1.x/; revision=47998
2011-03-09 03:07:46 +00:00
Patrick Gerken
39d692f9b8 Trigger failure for objects with unicode titles in string
svn path=/plone.app.discussion/branches/1.x/; revision=47997
2011-03-09 03:07:29 +00:00
Patrick Gerken
65aab05d1b Fixed test failure for the default user portrait, which changed from
defaultUser.gif to defaultUser.png in Products.PlonePAS 4.0.5.

Backport if maurits changes to the trunk

svn path=/plone.app.discussion/branches/1.x/; revision=47996
2011-03-09 03:03:17 +00:00
Patrick Gerken
79701cce7e Take care of properly converting titles to unicode
svn path=/plone.app.discussion/trunk/; revision=47991
2011-03-08 20:15:52 +00:00
Patrick Gerken
774ed36746 Ups, there is a nother unicode problem
svn path=/plone.app.discussion/trunk/; revision=47990
2011-03-08 20:15:37 +00:00
Patrick Gerken
b6d406d298 Trigger failure for objects with unicode titles in string
svn path=/plone.app.discussion/trunk/; revision=47989
2011-03-08 20:15:21 +00:00
JC Brand
97b8b6a060 Add the af translations to the 1.x branch as well.
svn path=/plone.app.discussion/branches/1.x/; revision=47959
2011-03-07 15:48:51 +00:00
JC Brand
c26e1b9123 Add af translations
svn path=/plone.app.discussion/trunk/; revision=47953
2011-03-07 13:49:13 +00:00
Maurits van Rees
478273aa80 minor code cleanup
svn path=/plone.app.discussion/trunk/; revision=47599
2011-02-15 16:23:12 +00:00
Maurits van Rees
81d74cfe6b Fixed test failure for the default user portrait, which changed from
defaultUser.gif to defaultUser.png in Products.PlonePAS 4.0.5.

svn path=/plone.app.discussion/trunk/; revision=47597
2011-02-15 16:19:13 +00:00
Timo Stollenwerk
bf96d0082f Remove "Plone 3 only" code; Do not monkey patch the BAD_TYPES vocabulary or plone.app.vocabularies anymore.
svn path=/plone.app.discussion/trunk/; revision=47311
2011-02-08 09:28:51 +00:00
Timo Stollenwerk
0a0e69d47d Do not check for a comment review workflow when sending out a moderator email notification. This fixes http://dev.plone.org/plone/ticket/11444. Refs #11444
svn path=/plone.app.discussion/trunk/; revision=47292
2011-02-07 11:48:24 +00:00
Timo Stollenwerk
de4353641b Do not check for a comment review workflow when sending out a moderator email notification. This fixes http://dev.plone.org/plone/ticket/11444. Refs #11444
svn path=/plone.app.discussion/branches/1.x/; revision=47189
2011-02-02 19:55:24 +00:00
Timo Stollenwerk
0c435dc9ca Check if the current user has configured an e-mail address for the email notification option. Refs #11428
svn path=/plone.app.discussion/trunk/; revision=47069
2011-01-26 08:15:14 +00:00
Timo Stollenwerk
15c681d27f Check if the current user has configured an e-mail address for the email notification option. Refs #11428
svn path=/plone.app.discussion/branches/1.x/; revision=47068
2011-01-26 08:06:21 +00:00
Timo Stollenwerk
543b9d47c5 Remove moderation_enabled setting from registry to avoid migration problems to 1.0RC1. Refs #11419.
svn path=/plone.app.discussion/branches/1.x/; revision=47031
2011-01-24 08:37:43 +00:00
Timo Stollenwerk
ed4f2b1fa8 Comment out the discussion control panel event subscriber tests. We disabled this functionality anyway.
svn path=/plone.app.discussion/branches/1.x/; revision=46991
2011-01-22 12:39:15 +00:00
Timo Stollenwerk
2f30c27555 Disable the control panel event subscribers. We don't need them since we disabled the enable_moderation setting in the discussion control panel anyway.
svn path=/plone.app.discussion/branches/1.x/; revision=46990
2011-01-22 12:34:49 +00:00
Timo Stollenwerk
5cac8b7a1b Hide the moderation_enabled widget in the discussion control panel. We need plone.app.controlpanel > 2.1b1 for this, which is not shipped with Plone 3.x or 4.0.x.
svn path=/plone.app.discussion/branches/1.x/; revision=46989
2011-01-22 12:00:15 +00:00
Timo Stollenwerk
4ab29000a6 Import Owned from OFS.owner to avoid deprecation warnings.
svn path=/plone.app.discussion/trunk/; revision=46977
2011-01-20 20:38:50 +00:00
Timo Stollenwerk
f3ff8e9647 Fix failing test. Discussion is enabled by default again.
svn path=/plone.app.discussion/branches/1.x/; revision=46975
2011-01-20 20:08:51 +00:00
Timo Stollenwerk
fb0ca6c795 Replace tabs with whitespace.
svn path=/plone.app.discussion/trunk/; revision=46974
2011-01-20 20:04:38 +00:00
Timo Stollenwerk
9790dd5b65 Enable discussion by default if p.a.discussion is shipped as add-on product.
svn path=/plone.app.discussion/branches/1.x/; revision=46973
2011-01-20 19:49:58 +00:00
Timo Stollenwerk
9cc32a76a4 Enable ajaxify comment deletion again ([thomasdesvenain]). This has been disabled in 1.0b12 because of problems with Plone 3.
svn path=/plone.app.discussion/trunk/; revision=46970
2011-01-20 19:38:26 +00:00
Timo Stollenwerk
c15c898565 Remove collective.autopermission dependency.
svn path=/plone.app.discussion/trunk/; revision=46969
2011-01-20 19:37:54 +00:00
Timo Stollenwerk
75cde25b6f Always show existing comments, even if commenting is disabled.
svn path=/plone.app.discussion/trunk/; revision=46785
2011-01-07 15:27:17 +00:00
Timo Stollenwerk
61e231b336 Fix CSS for commenter images with a width of more than 2.5em. This fixes http://dev.plone.org/plone/ticket/11391. Refs #11391
svn path=/plone.app.discussion/trunk/; revision=46783
2011-01-07 10:27:13 +00:00
Timo Stollenwerk
c438743a3b Show a 'Comments are moderated.' message next to the comment form if comments are moderated.
svn path=/plone.app.discussion/trunk/; revision=46782
2011-01-07 10:20:24 +00:00
David Glick
b0ca33dcc6 make sure p.a.registry ZCML is loaded
svn path=/plone.app.discussion/trunk/; revision=46432
2010-12-21 19:20:36 +00:00
Maurits van Rees
d90c436f8a Removed the conditional loading of event subscribers:
- zope.app.container is available in both Plone 3 and Plone 4, so the 'not-installed zope.app.container' condition was always false
- zope.lifecycleevent.interfaces does not have an IObjectAddedEvent or IObjectRemovedEvent so even if the condition would have been true, the loading would have failed.

svn path=/plone.app.discussion/trunk/; revision=46367
2010-12-16 02:12:13 +00:00
Maurits van Rees
a2a17085a3 Nuke trailing white space
svn path=/plone.app.discussion/trunk/; revision=46366
2010-12-15 23:52:56 +00:00
Maurits van Rees
aff8a3709c Avoid sending multiple notification emails to the same person when
he has commented multiple times.

svn path=/plone.app.discussion/trunk/; revision=46365
2010-12-15 23:41:57 +00:00
Maurits van Rees
9eb172023a No tabs in zcml please
svn path=/plone.app.discussion/trunk/; revision=46364
2010-12-15 22:59:24 +00:00
Maurits van Rees
87d767651b Do not fail on startup with Plone 3 when plone.uuid is not there:
make implementing the plone.uuid.interfaces.IAttributeUUID interface conditional for Plone 4 only.

svn path=/plone.app.discussion/trunk/; revision=46363
2010-12-15 22:45:19 +00:00
David Glick
0cb75778ba make sure comments don't get indexed with their parents' UID in Plone 3. only declare dependency on plone.app.uuid in Python 2.6, since we only use it in Plone 4 currently.
svn path=/plone.app.discussion/trunk/; revision=46353
2010-12-15 20:39:55 +00:00
Timo Stollenwerk
b9d929bca3 Fix failing test.
svn path=/plone.app.discussion/trunk/; revision=46344
2010-12-14 21:30:40 +00:00
Timo Stollenwerk
a8bfd7fc6e Disable discussion by default.
svn path=/plone.app.discussion/trunk/; revision=46337
2010-12-14 17:58:46 +00:00
Timo Stollenwerk
d702c666f0 Tests for moderation_enabled setting added.
svn path=/plone.app.discussion/trunk/; revision=46266
2010-12-12 13:56:06 +00:00
Timo Stollenwerk
ea2038b122 Remove XXX line from conversation.py. Martin and I agree that this is probably not relevant anymore. Refs #9288
svn path=/plone.app.discussion/trunk/; revision=46265
2010-12-12 12:51:41 +00:00
Timo Stollenwerk
a9ef0503f2 Move discussion action item from actionicons.xml to actions.xml to avoid deprecation warning.
svn path=/plone.app.discussion/trunk/; revision=46264
2010-12-12 12:40:19 +00:00
Timo Stollenwerk
4c4cd9e44d Replace XXX with todo.
svn path=/plone.app.discussion/trunk/; revision=46263
2010-12-12 08:14:48 +00:00
Timo Stollenwerk
0485398de0 whitespace, make jslint happy.
svn path=/plone.app.discussion/trunk/; revision=46262
2010-12-12 08:13:03 +00:00
Timo Stollenwerk
be78fbe300 There is no need to enable the "enable moderation" checkbox dynamically, except when commenting is disabled/enabled globally.
svn path=/plone.app.discussion/trunk/; revision=46261
2010-12-12 07:35:43 +00:00
Timo Stollenwerk
08857df7a9 Fix cancel button on edit view when using Dexterity types. This fixes http://dev.plone.org/plone/ticket/11338. Refs #11338
svn path=/plone.app.discussion/trunk/; revision=46254
2010-12-11 21:33:43 +00:00
Timo Stollenwerk
f2f97c5b38 Change the comment workflow setting in the discussion control panel if the setting is changed in the types control panel; show warning message and disable the setting if a custom comment workflow is enabled.
svn path=/plone.app.discussion/trunk/; revision=46253
2010-12-11 21:30:18 +00:00
Timo Stollenwerk
0475376ed0 "Enable comment moderation" setting added to the discussion control panel. Just a proof of concept so far. Not fully implemented yet. No tests.
svn path=/plone.app.discussion/trunk/; revision=46249
2010-12-11 17:18:14 +00:00
Timo Stollenwerk
09a804aa88 Remove unnecessary and failing test.
svn path=/plone.app.discussion/trunk/; revision=46235
2010-12-10 09:16:36 +00:00
Timo Stollenwerk
54af7d3fa1 Assigning the 'Reply to item' permission to the 'Authenticated' role. The old commenting system allowed 'Authenticated' users to post comments. Also, OpenID users do not possess the 'Authenticated' role. Refs #9288
svn path=/plone.app.discussion/trunk/; revision=46230
2010-12-10 08:57:35 +00:00
Timo Stollenwerk
45140c66db Functional test for posting a comment as user without the 'Reply to item' permission added.
svn path=/plone.app.discussion/trunk/; revision=46215
2010-12-09 10:58:32 +00:00
Timo Stollenwerk
7e279d3ad3 Make sure the handleComment method checks for the 'Reply to item' permission when adding a comment.
svn path=/plone.app.discussion/trunk/; revision=46212
2010-12-09 08:11:41 +00:00
Timo Stollenwerk
c8e78449a2 Make the mail-setting warning message show up in the discussion control panel.
svn path=/plone.app.discussion/trunk/; revision=46211
2010-12-09 08:07:15 +00:00
Timo Stollenwerk
797ed40852 Link directly to the "Discussion Item" types control panel in the moderation view.
svn path=/plone.app.discussion/trunk/; revision=46207
2010-12-08 17:45:58 +00:00
Timo Stollenwerk
583b25530e Show "moderate comments" link in the admin panel only if a moderation workflow is enabled for comments.
svn path=/plone.app.discussion/trunk/; revision=46206
2010-12-08 17:45:11 +00:00
Timo Stollenwerk
6e354718f4 Revert r46143.
svn path=/plone.app.discussion/trunk/; revision=46144
2010-12-05 14:56:13 +00:00
Timo Stollenwerk
22425b06ac Disable commenting by default if pad is shipped with Plone. If shipped as add-on product, commenting should be enabled by default.
svn path=/plone.app.discussion/trunk/; revision=46143
2010-12-05 14:50:25 +00:00
Timo Stollenwerk
04a0669731 Remove the grey background from disabled settings.
svn path=/plone.app.discussion/trunk/; revision=46142
2010-12-05 14:10:21 +00:00
Timo Stollenwerk
bbd44b7b95 workflow setting added to control panel config string.
svn path=/plone.app.discussion/trunk/; revision=46091
2010-12-02 23:20:10 +00:00
Timo Stollenwerk
ffde4b423d Do not allow to change the mail settings in the discussion control panel, if there is no valid mail setup. Refactor js code to use class settings of #content.
svn path=/plone.app.discussion/trunk/; revision=46090
2010-12-02 23:02:00 +00:00
Timo Stollenwerk
fbd7eb2bbc Do not allow to change the mail settings in the discussion control panel, if there is no valid mail setup.
svn path=/plone.app.discussion/trunk/; revision=46089
2010-12-02 21:07:58 +00:00
Timo Stollenwerk
1b36f99a7a make jslint happy; disable settings onload;
svn path=/plone.app.discussion/trunk/; revision=46088
2010-12-02 19:49:49 +00:00
Timo Stollenwerk
2a7a65293e disable form fields when disabling the fields.
svn path=/plone.app.discussion/trunk/; revision=46087
2010-12-02 19:09:16 +00:00
Timo Stollenwerk
f97c17e62a Factor out enable/disable settings function.
svn path=/plone.app.discussion/trunk/; revision=46086
2010-12-02 18:50:21 +00:00
Timo Stollenwerk
ffcc29a401 Override the default plone.app.registry controlpanel template; JS file for the controlpanel added. Disable all commenting options in the discussion control panel when comments are disabled globally.
svn path=/plone.app.discussion/trunk/; revision=46085
2010-12-02 18:15:47 +00:00
Timo Stollenwerk
c311a4f88d Check for the 'review comments' permission instead of 'manage' to decide if the user should see a 'this comment is pending' message.
svn path=/plone.app.discussion/trunk/; revision=46050
2010-12-01 06:34:05 +00:00
Timo Stollenwerk
19f0666b39 Move "moderate comments" site action above the logout action.
svn path=/plone.app.discussion/trunk/; revision=46047
2010-11-30 18:17:02 +00:00
Timo Stollenwerk
d94767576b Do not use plone.app.uuid to generate unique UIDs for Plone 3. plone.app.uuid causes the IObjectAddedEvent to be fired twice on Plone 3. This causes the email notifications to be send twice. This means that https://dev.plone.org/plone/ticket/10652 is fixed only for Plone 4.
svn path=/plone.app.discussion/trunk/; revision=46043
2010-11-30 09:50:12 +00:00
Timo Stollenwerk
2b3a84e9d1 Moderator notification description updated.
svn path=/plone.app.discussion/trunk/; revision=46042
2010-11-30 09:13:30 +00:00