Merge branch 'master' of https://github.com/plone-ve/plone.app.discussion

CHANGES.rst

@@ -4,7 +4,8 @@ Changelog
 2.4.3 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Only use edit overlay if available for editing comments
+  [vangheem]
 
 
 2.4.2 (2015-05-04)

plone/app/discussion/browser/comments.pt

@@ -9,7 +9,8 @@
                        has_replies python:view.has_replies(canReview);
                        showCommenterImage view/show_commenter_image;
                        errors options/state/getErrors|nothing;
-                       wtool context/@@plone_tools/workflow;"
+                       wtool context/@@plone_tools/workflow;
+                       auth_token context/@@authenticator/token|nothing"
            tal:condition="python:isDiscussionAllowed or has_replies"
            i18n:domain="plone">
 
@@ -115,19 +116,26 @@
                                    />
                         </form>
 
-                        <form name="edit"
+                        <tal:edit tal:condition="python:isEditCommentAllowed and canEdit">
-                              action=""
+                          <!-- plone 5 will have auth_token available
-                              method="get"
+                               so we'll use modal pattern -->
-                              class="commentactionsform"
+                          <a class="commentactionsform pat-plone-modal"
-                              tal:condition="python:isEditCommentAllowed and canEdit"
+                             tal:condition="auth_token"
-                              tal:attributes="action string:${reply/absolute_url}/@@edit-comment">
+                             tal:attributes="href string:${reply/absolute_url}/@@edit-comment?_authenticator=${auth_token}">Edit</a>
-                            <input name="form.button.EditComment"
+                          <form name="edit"
-                                   class="context"
+                                action=""
-                                   type="submit"
+                                method="get"
-                                   value="Edit"
+                                class="commentactionsform"
-                                   i18n:attributes="value label_edit;"
+                                tal:condition="not: auth_token"
-                                   />
+                                tal:attributes="action string:${reply/absolute_url}/@@edit-comment">
-                        </form>
+                              <input name="form.button.EditComment"
+                                     class="context"
+                                     type="submit"
+                                     value="Edit"
+                                     i18n:attributes="value label_edit;"
+                                     />
+                          </form>
+                        </tal:edit>
 
 
                         <!-- Workflow actions (e.g. 'publish') -->

plone/app/discussion/browser/javascripts/comments.js

@@ -189,12 +189,14 @@ require([  // jshint ignore:line
         /**********************************************************************
          * Edit a comment
          **********************************************************************/
-	$('form[name="edit"]').prepOverlay({
+    if($.fn.prepOverlay){
-        cssclass: 'overlay-edit-comment',
+    	$('form[name="edit"]').prepOverlay({
-        width: '60%',
+            cssclass: 'overlay-edit-comment',
-		subtype: 'ajax',
+            width: '60%',
-		filter: '#content>*'
+    		subtype: 'ajax',
-	});
+    		filter: '#content>*'
+    	});
+    }
 
         /**********************************************************************
          * Delete a comment and its answers.

plone/app/discussion/tests/functional_test_comments.txt

@@ -269,14 +269,15 @@ Use the Plone control panel to enable comment editing.
 
 Extract the edit comment url from the first "edit comment" button
 
+    >>> from Products.CMFPlone import __version__
     >>> browser.open(urldoc1)
-    >>> form = browser.getForm(name='edit', index=0)
+    >>> url = __version__[0] == '5' and browser.getLink(url='@@edit-comment').url or browser.getForm(name='edit', index=0).action
-    >>> '@@edit-comment' in form.action
+    >>> '@@edit-comment' in url
     True
 
 Open the edit comment view
 
-    >>> browser.open(form.action)
+    >>> browser.open(url)
     >>> ctrl = browser.getControl('Comment')
     >>> ctrl.value
     'Comment from admin'
@@ -298,10 +299,10 @@ Check it ain't so.
 
 Opening the edit comment view, then cancel, does nothing.
 
-    >>> form = browser.getForm(name='edit', index=0)
+    >>> url = __version__[0] == '5' and browser.getLink(url='@@edit-comment').url or browser.getForm(name='edit', index=0).action
-    >>> '@@edit-comment' in form.action
+    >>> '@@edit-comment' in url
     True
-    >>> browser.open(form.action)
+    >>> browser.open(url)
     >>> browser.getControl('Cancel').click()
     >>> browser.url.startswith('http://nohost/plone/doc1')
     True