ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,081 Commits 1 Branch 0 Tags 5 MiB
fe10c7448f
Commit Graph

1328 Commits

Author SHA1 Message Date
Katja Süss
b08852baa0 some code-analysis reclamations fixed. 
code-analysis OK up to: T100, S100, S101, C815, C812
 2017-07-29 11:35:15 +02:00
Katja Süss
100690ccdf html nearer to conventions 2017-07-29 11:33:53 +02:00
Katja Süss
78abff152d Test 2017-07-28 19:12:49 +00:00
Katja Süss
fb7c68d5e5 Make moderation view changes less invasive. 2017-07-28 19:12:47 +00:00
Katja Süss
71205b552f Replaced tabs with soft tabs 2017-07-28 19:12:40 +00:00
Katja Süss
01473db9b9 added missing new line at the end of the file 2017-07-28 19:12:15 +00:00
Katja Süss
8e344cbf2b Show email in moderation view 2017-07-28 19:12:01 +00:00
Katja Süss
15cf0e6336 Removed dependency on plone.api. Following style guidelines: one import per line 2017-06-21 12:15:32 +02:00
Katja Süss
0fd9b02c80 Email validation 2017-06-20 15:16:19 +02:00
KUMAR AKSHAY
964dcea523 kakshay unittest (#121) 
remove unittest2 dependency
 2017-05-08 09:24:38 +02:00
KUMAR AKSHAY
fba905e465 removed "change portal events" permission 
https://github.com/plone/Products.CMFPlone/issues/1975
 2017-04-11 14:45:36 +05:30
Maurits van Rees
b5eebe0cc8 Fixed tests with newer testbrowser. 2017-02-04 16:58:38 +01:00
MrTango
bc2a9ac5d9 remove __of__ calls on views 2017-01-31 17:57:41 +01:00
Daniel Jowett
d2bba1d5ea Fix some easy pep8 issues 2017-01-24 10:59:43 +00:00
Daniel Jowett
6547486fd8 Improve English on a couple of field descriptions 2017-01-24 10:41:15 +00:00
Maurits van Rees
802e3ec04c Make comment on private content not publicly available in search results. 
This is part of PloneHotfix20161129.

Updated metadata.xml version to 1000.  This leaves more room for
profile version increases in earlier releases.  We apply the rolemap
step again to avoid accidentally missing it.
 2017-01-14 17:58:48 +01:00
Maurits van Rees
97477163be Moved all upgrade steps to upgrades.zcml. 
Until now some were in configure.zcml and some in upgrades.zcml.
 2017-01-10 18:18:52 +01:00
Gil Forcada
26a21a12d5 Reindex comments when they are modified 2016-09-20 13:05:24 +02:00
Maurits van Rees
358ec89c03 Apply security hotfix 20160830 for redirects. 2016-09-19 17:10:10 +02:00
TsungWei Hu
466ca149d3 Update Traditional Chinese Translation. 2016-09-10 07:30:47 +00:00
Gil Forcada
d5e7afcd23 Use zope.interface decorator 
This not only makes code more pleasent to read,
but also makes the code python 3 compatible
(while maintaining python 2 compatibility).
 2016-07-08 23:17:03 +02:00
Jens W. Klein
69ded592c3 Merge pull request #104 from plone/maurits-remove-migration 
Removed `comment-migration` view.
 2016-06-13 09:48:39 +02:00
Maurits van Rees
1e9909ab6f Split too complex _enabled_for_archetypes. 2016-06-12 06:51:41 +02:00
Maurits van Rees
d496dfdddc Split too complex handleComment. 2016-06-12 06:51:41 +02:00
Maurits van Rees
814af8d837 Various flake8 fixes. 
- Removed tabs.
- Fixed E731 do not assign a lambda expression, use a def.
- avoid hasattr
 2016-06-12 06:51:35 +02:00
Maurits van Rees
bfeb66ee60 Removed comment-migration view. 
This did not work anymore on Plone 5.  If you still need to migrate
from old-style comments, so from Plone 4.0 or earlier, please upgrade
to Plone 4.3 first.
 2016-06-11 15:56:31 +02:00
Maurits van Rees
6952923b1e Reset the required setting of the author_email widget each time. 
Otherwise, the email field might get set to required when an anonymous
user visits, and then remain required when an authenticated user
visits, making it impossible for an authenticated user to fill in the
form without validation error.  Or when in the control panel the field
is set as not required anymore, that change would have no effect until
the instance was restarted.
 2016-06-10 01:57:04 +02:00
Maurits van Rees
e1dbaef82a Fixed possible cross site scripting (XSS) attack on moderate comments page. 2016-06-03 00:43:21 +02:00
Tom Gross
085567431f Make tests work with lxml safe html cleaner (#97) 
* Make tests work with lxml safe html cleaner

* whitespace fix in test assertion
 2016-05-31 11:41:34 +02:00
Maurits van Rees
89d542e8d2 Apply hotfix 20160419 (#94) 
Removed docstrings from some methods to avoid publishing them.
 2016-05-04 10:40:36 +02:00
Gil Forcada Codinachs
eee8e3c1b6 Mark edit link for translation (#91) 
Mark edit link for translation.
 2016-04-07 18:36:19 +02:00
Johannes Raggam
ec7fe25b6c Use `getSite()` instead of portal url 
For the discussion controlpanel, change base URLs from portal URL to what getSite returns, but don't change the controlpanels context binding.
This allows for more flexibility when configuring it to be allowed on a sub site with a local registry.
 2016-03-11 14:16:22 +01:00
serge73
0a94f185e7 Update plone-ru.po 2016-02-12 02:05:57 +05:00
Johannes Raggam
4df90c2ade remove duplicate 2016-02-10 17:16:35 +01:00
Gil Forcada
cb1bf28c16 Cleanup 
Follow https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst
to clean up the code.
 2016-02-05 09:43:42 +01:00
Fred van Dijk
fcb4bbf94b Get rid of the monkey patch on Products.CMFPlone's CatalogTool. 2016-01-25 14:45:59 +01:00
serge73
a08714575f Create plone-ru.po 2016-01-22 15:33:33 +05:00
Maurits van Rees
e5d6916c2f In tests, use `selection.any` in querystrings. 
Issue https://github.com/plone/Products.CMFPlone/issues/1040
 2015-11-25 11:40:06 +01:00
Davi Lima
3f07781675 Update Site Setup link in all control panels (fixes plone/Products.CMFPlone#1255) 2015-11-23 09:13:00 -03:00
Gil Forcada
19fe254916 Remove i18n:registerTranslations directive 2015-11-09 22:47:46 +01:00
Gil Forcada
182342833b Remove locales folder 
Translations have already been moved to plone.app.locales.

See:
https://github.com/plone/plone.app.discussion/pull/74
b063d4811f
 2015-11-09 22:45:21 +01:00
Gil Forcada
0713bcd8bc Use plone i18n domain 
plone.app.discussion is an official Plone core package,
thus their translations belong to plone.app.locales.

This commit removes the plone.app.discussion domain and changes it for
plone.

This fixes:
https://github.com/plone/plone.app.discussion/issues/66
 2015-11-05 00:30:42 +01:00
esteele
98f1f3d6a4 Move portal_properties settings to configuration registry 
commit b13db31e3c55fd5ed9320e9d0c93aea48366c883
Author: esteele <eric@esteele.net>
Date:   Fri Sep 18 10:14:56 2015 +0200

    Remove pdb.

commit 6b3e591583146ca661556ef50cafd02f62c79d46
Author: esteele <eric@esteele.net>
Date:   Fri Sep 18 09:50:06 2015 +0200

    Fix registry id

commit 9dfce9a739496b6023f93376535dccc9a9310517
Author: esteele <eric@esteele.net>
Date:   Thu Sep 17 18:34:42 2015 +0200

    Use registry lookup for types_use_view_action_in_listings
 2015-09-20 17:31:55 +02:00
Philip Bauer
e2bd22e74b fix comment-moderation 2015-09-19 14:58:53 +02:00
Philip Bauer
35e6ab2677 remove discussion.css 2015-09-16 14:58:42 +02:00
Encolpe DEGOUTE
c2c5c0abb6 update French translations 2015-09-16 01:33:06 +02:00
ichim-david
99ef943328 Refs #764; added context class to edit link: 
- This styles the link as a button which aligns with the other
  actions that have button styles from bootstrap and
  plonetheme.barcelonata
 2015-09-15 23:38:23 +03:00
ichim-david
6e85735b5b Fix reply button visibility toggle by javascript 2015-09-15 22:43:34 +03:00
ichim-david
cb83fc2042 Refs #764 style tweaks needed for plonetheme.barcelonata coexistance 2015-09-15 00:14:05 +03:00
Philip Bauer
0b0258867d Fix editing comments in Plone 5 2015-09-13 18:31:38 +02:00
Philip Bauer
b7f81fc3fe Move anonymous_email_enabled after anonymous_comments in controlpanel 2015-09-13 15:38:46 +02:00
Mikel Larreategi
b4bb681837 update basque translation 2015-09-09 12:52:14 +02:00
Victor Fernandez de Alba
35862dd6dc Updated links for the renamed 'Types' control panel 2015-07-16 12:17:59 +02:00
Victor Fernandez de Alba
89a18c889d Change the category of the configlet to 'plone-general' 2015-07-15 18:05:24 +02:00
Leonardo J. Caballero G
71bb802118 Merge branch 'master' of https://github.com/plone-ve/plone.app.discussion 2015-05-31 13:43:53 -04:30
Leonardo J. Caballero G
d227307832 Updated Spanish translation with check spell 2015-05-31 13:41:42 -04:30
vangheem
4bd649e021 fix test 2015-05-30 19:28:22 -05:00
vangheem
e2192e5973 use modal pattern for comment edit 2015-05-30 15:20:32 -05:00
vangheem
68665b6f2b Only use edit overlay if available for editing comments. We will need a plone 5 alternative 2015-05-30 11:45:02 -05:00
Low Kian Seong
da84d4d642 Fixing broken test on travis 2015-05-13 20:03:11 +08:00
Gil Forcada Codinachs
4556486082 Merge pull request #67 from plonejp/master 
Updated Japanese translation
 2015-05-11 08:39:58 +02:00
Takanori Suzuki
44e7f16636 fix fuzzy translation for japanese 2015-05-09 15:12:29 +09:00
Takanori Suzuki
f745e7c976 update japanese translation 2015-05-09 15:05:35 +09:00
vangheem
1a04b5b042 fix test failures with csrf protection and locking behavior 2015-05-08 12:06:29 -05:00
Gil Forcada
7c8a1371ee 'X not in Y' 2015-05-03 08:56:58 +02:00
Gil Forcada
dcb2a5f51b 2 spaces between top level classes 2015-05-03 08:43:22 +02:00
Gil Forcada
8410b7525f Do not redefine comment 2015-05-03 08:42:52 +02:00
Gil Forcada
754e712372 Typo 2015-05-03 08:42:07 +02:00
Gil Forcada
ce48a9ed46 2 spaces before inline comment 2015-05-03 08:41:56 +02:00
Gil Forcada
8b883451ca 80 chars 2015-05-03 08:41:24 +02:00
Gil Forcada
fad5a96129 Unused variable 2015-05-03 08:27:21 +02:00
Gil Forcada
411f36e708 One argument per line 2015-05-03 08:27:03 +02:00
Gil Forcada
2baafcbfd8 Typo 2015-05-03 08:25:19 +02:00
Gil Forcada
0ade2c4329 'X not in Y' is recommended 2015-05-03 08:25:08 +02:00
Gil Forcada
9066183ea9 2 lines between top level functions/classes 2015-05-03 08:24:08 +02:00
Gil Forcada
4bc77a2831 Sort imports 
Remove unused ones as well.
 2015-05-03 08:16:41 +02:00
Takanori Suzuki
acae47c17a update japanese translation 2015-04-29 17:57:23 +09:00
Manabu TERADA
b235f74f46 Merge branch 'master' of github.com:plone/plone.app.discussion 
Conflicts:
	plone/app/discussion/locales/ja/LC_MESSAGES/plone.app.discussion.po
 2015-04-29 17:39:14 +09:00
Takanori Suzuki
b868b44ba0 update japanese translation 2015-04-29 17:27:40 +09:00
David\ Beitey
285dbcd918 i18n for ICaptcha interface field 2015-03-23 18:06:29 +10:00
David Glick
8690461ffb create doc1 in the text fixture rather than in setup for each test 2015-03-09 21:51:45 -07:00
Gil Forcada
4ea41aba43 Fix tests 2015-02-16 16:35:43 +01:00
Gil Forcada
d5b5b1c2cd Fix total_comments indexer 
"@property removes Acquisition wrappers from 'self'.
I don't remember why exactly (some implementation detail of Acquisition),
but it's a fact of life."

Quote from @davisagli on
https://github.com/plone/plone.app.discussion/pull/58

In short: removing the @property from total_comments fix the problem.
 2015-02-16 11:31:47 +01:00
Gil Forcada
535af3aace Count acquisition wrapped comments 
If the View permission is not set directly on the workflow,
but instead is left to be acquired,
total_comments will always return 0.
 2015-02-16 11:28:49 +01:00
Gil Forcada
b4c1d9e42d Sort imports 
As per the styleguide
 2015-02-16 10:22:09 +01:00
vangheem
bd0637e0b2 fix window load event to use 2015-02-11 16:30:03 -06:00
vangheem
c49c9707ec more js improvements 2015-02-10 16:41:00 -06:00
vangheem
ad3953f794 use requirejs if available 2015-02-10 16:21:17 -06:00
Timo Stollenwerk
5f1a7fb5bc Merge branch 'master' into plip10359-z3cform 
Conflicts:
	CHANGES.rst
 2015-01-29 21:31:45 +01:00
Timo Stollenwerk
c852609111 Merge branch 'master' into delete-own-comments 
Conflicts:
	CHANGES.rst
 2015-01-29 21:14:05 +01:00
Timo Stollenwerk
785bc7b890 Read mail settings from new (Plone 5) registry. 2014-12-13 16:20:08 +01:00
Roberto Diaz
609e9f61aa Updated SPANISH .po file 2014-12-11 16:26:45 +01:00
Roberto Diaz
2a130ffeb1 Updated CATALAN .po file 2014-12-11 16:26:28 +01:00
João Toss Molon
744b5b6380 Updated pt-br translation 2014-12-05 17:38:04 -02:00
Gil Forcada
19026439dd Use spaces please 2014-12-03 12:03:26 +01:00
Victor Fernandez de Alba
30c88842c0 Reapplied on correct branch. 
Revert "Revert "Update tag for id=content element to article instead of a simple div.""

This reverts commit 45f58edd06.
 2014-10-09 13:30:53 +02:00
Vincent Fretin
06b20b8f81 merge fix from master (Don't execute createReplyForm js if there is no in_reply_to button) 2014-10-09 11:44:31 +02:00
Vincent Fretin
838f229726 Don't execute createReplyForm js if there is no in_reply_to button. 2014-10-09 11:41:00 +02:00
Vincent Fretin
acacc8281a add a test for delete-own-comment view 2014-09-20 16:21:55 +02:00
Vincent Fretin
2a8082cfa7 add delete_own_comment_enabled option in control panel 2014-09-20 16:02:48 +02:00
Vincent Fretin
42d12200a7 Don't use session at all for content rules, set the event in the request to be able to access comment attributes. This fixes 'InvalidObjectReference: A new object is reachable from multiple databases.' if comment contains a RichTextValue which contains a RawValueHolder (persistent object). 2014-09-20 14:54:02 +02:00
Vincent Fretin
ee28528f55 Don't use session at all for content rules, set the event in the request to be able to access comment attributes. This fixes 'InvalidObjectReference: A new object is reachable from multiple databases.' if comment contains a RichTextValue which contains a RawValueHolder (persistent object). 2014-09-20 14:14:19 +02:00
Thomas Desvenain
a94b3249a9 fixed can_delete called from parent 2014-09-05 11:11:54 +02:00
Gil Forcada
fa127ad85c Whitespaces cleanup 2014-08-23 00:31:28 +02:00
Jens W. Klein
2ba35bb0d4 merge fixed 2014-08-17 04:54:12 +02:00
Jens W. Klein
62b2990b7c merged master 2014-08-17 04:48:44 +02:00
Victor Fernandez de Alba
45f58edd06 Revert "Update tag for id=content element to article instead of a simple div." 
This reverts commit 0165f1b73c.
 2014-08-11 14:11:18 +02:00
Victor Fernandez de Alba
0165f1b73c Update tag for id=content element to article instead of a simple div. 2014-08-11 14:09:48 +02:00
Ammy2
002c81427e Id for textarea of reply form made unique 2014-06-25 02:32:48 +05:30
Andrea Cecchi
e9a4dcfc52 relaunched i18ndude and fix italian translations 2014-05-16 17:39:57 +02:00
Andrea Cecchi
4f255a355d rebased CHANGES and tests 2014-05-15 17:51:22 +02:00
Andrea Cecchi
e453e0050b fixed HISTORY and add delete test to test_comments_viewlet 2014-05-15 17:51:22 +02:00
Andrea Cecchi
f67f12bd05 fixed upgrade step 2014-05-15 17:51:05 +02:00
Andrea Cecchi
9a4e3718fc added Delete comments permission to manage comments deletion 2014-05-15 17:51:05 +02:00
Andrea Cecchi
fd16144b9b fixed edit test 2014-05-15 17:51:05 +02:00
Andrea Cecchi
3711d2fb5f rebased branch from master 2014-05-15 17:51:05 +02:00
Guido A.J. Stevens
520b1e83f4 provide "delete own comments" as a configurable option 2014-05-15 17:50:32 +02:00
Guido A.J. Stevens
a82352a36c Make comments editable 2014-05-15 17:50:32 +02:00
Timo Stollenwerk
2b18d5a2e4 Revert "Merge pull request #38 from delib/evilbungle-comment-acquisition" 
This reverts commit e18598e316, reversing
changes made to fd6ac0788b.

This pull request introduces two test failures. See http://jenkins.plone.org/job/plone-5.0-python-2.7/lastCompletedBuild/testReport/ for details.
 2014-05-13 07:07:37 +02:00
Timo Stollenwerk
e18598e316 Merge pull request #38 from delib/evilbungle-comment-acquisition 
Fixing incorrect behaviour with acquired permissions
 2014-05-12 22:53:34 +02:00
Timo Stollenwerk
fd6ac0788b Merge pull request #43 from plone/remove-dt-dl-dd 
Remove DL's from portal message in templates.
 2014-05-12 20:52:49 +02:00
Alin Voinea
fe91d7801e Add tests for custom events and contentrules events/string substitutions 2014-05-12 20:20:18 +03:00
Jens W. Klein
311eef63eb Merge pull request #48 from l34marr/translation 
Update Traditional Chinese Translation.
 2014-05-12 10:39:33 +02:00
tisto
22ed06b66d Add second robot test to test adding comments. 2014-05-02 13:42:19 +02:00
tisto
f894d47d62 Add basic robot test setup and a first test. 2014-05-02 13:22:08 +02:00
TsungWei Hu
6ced9ed0a5 Update Traditional Chinese Translation. 2014-05-02 18:30:08 +08:00
Gaudenz Steinlin
fa17c51a7b Replace $.live with $.on 
This is needed for jQuery >= 1.9 compatibility and is compatible with
JQuery >= 1.7 (Plone 4.3 onwards).
 2014-04-28 18:06:41 +02:00
Alin Voinea
6565dfe19e i18n update 2014-04-18 17:26:27 +03:00
Alin Voinea
28d7556c92 Remove hard dependency on plone.stringinterp 2014-04-18 16:42:06 +03:00
Alin Voinea
13830715a7 Add custom content rules string substitutions 
- Add content rules string substitutions for comment:
  - id
  - text
  - author email
  - author user name
  - author full name
 2014-04-18 16:36:06 +03:00
Alin Voinea
ab926d6a10 Update change log 
Conflicts:
	CHANGES.rst
 2014-04-18 16:35:45 +03:00
Alin Voinea
14d4382ca6 Use commented object as context instead of comment within event trigger 
- In order this to work with plone.contentrules use commented object as
  the main context within custom discussion events and add comment as the
  second parameter.
 2014-04-18 16:33:12 +03:00
Alin Voinea
4343197209 Trigger custom comment events on comment add/remove/reply 
Conflicts:
	plone/app/discussion/interfaces.py
 2014-04-18 16:32:43 +03:00
Jens W. Klein
2729f5a7e9 required showed up, but validation needs it on field too. huh. this is not what i expected, but, well, its z3cforms 2014-03-26 11:27:12 +01:00
Jens W. Klein
6bfa19411d bugfix 1: according to IDiscussionSettings.anonymous_email_enabled (cite): 
If selected, anonymous user will have to give their email. - But field
was not required. Now it is.

bugfix 2: anonymous email field was never saved.
 2014-03-25 21:30:50 +01:00
Jens W. Klein
9575a0436a synced with recent i18ndude and updated missing german translations 2014-03-25 19:14:26 +01:00
Jens W. Klein
14263973f0 synced with recent i18ndude and updated missing german translations (mostly in settings form) 2014-03-25 19:13:43 +01:00
Jens W. Klein
0a6d429237 corrected outdated help text 2014-03-25 18:53:51 +01:00
Jens W. Klein
334b01f9ff run of update translations. nothing really changed. anyway, no we're sure. next: missing translations (de) 2014-03-25 18:39:08 +01:00
Jens W. Klein
6609ab6af5 make flake8 happy 2014-03-25 18:38:12 +01:00
Jens W. Klein
a145413ac2 make flake8 happy 2014-03-25 18:37:06 +01:00
Jens W. Klein
67213b70eb make flake8 happy 2014-03-25 18:36:14 +01:00
tisto
01641b4957 Merge branch 'fix_reindex_on_publish' of git://github.com/RedTurtle/plone.app.discussion into RedTurtle-fix_reindex_on_publish 2014-03-24 20:49:32 +01:00
tisto
9c9c2e2aaa Merge branch 'master' of git://github.com/huubbouma/plone.app.discussion into huubbouma-master 
Conflicts:
	CHANGES.rst
 2014-03-23 18:54:44 +01:00
maartenkling
0ea9a7131f merge upstream and fix numbering 2014-03-04 09:16:36 +01:00
Philip Bauer
d788d07a87 fix test. the richtext-field in plone.app.contenttypes uses a behavior 2014-02-14 09:40:55 +01:00
Kees Hink
6ae623c39d Remove DL's from portal message in templates. 2014-02-11 09:42:42 +01:00
Kees Hink
cc02ed01ad Remove DL's from portal message in templates. 2014-02-11 09:38:54 +01:00
Ovidiu Miron
6bc5db4276 Fixed typo error 2014-02-04 11:46:29 +02:00
Ovidiu Miron
a9d0cb574b Execute the property workflow 2014-02-04 11:15:31 +02:00