ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
497 Commits 1 Branch 0 Tags 5 MiB
d81b95f7c1
Commit Graph

438 Commits

Author SHA1 Message Date
Timo Stollenwerk
ac3ade24f6 Redo the controlpanel UI. 
svn path=/plone.app.discussion/trunk/; revision=33284
 2010-01-22 19:17:46 +00:00
Timo Stollenwerk
1e58aa63b1 fix CommentViewlet has_replies method. 
svn path=/plone.app.discussion/trunk/; revision=33282
 2010-01-22 19:02:41 +00:00
Timo Stollenwerk
b1e4b2254c Fix 1513398: Show "anonymous" when name field is empty in comment form. 
svn path=/plone.app.discussion/trunk/; revision=33281
 2010-01-22 18:35:32 +00:00
Timo Stollenwerk
649e41fcd5 Undo r33270. Make IDiscussionLayer inherit from IDefaultPloneLayer for now, to fix the comment Viewlet in Plone 4.0a3. This can be removed again as soon as Plone 4.0b1 is out. Thanks davisagli! 
svn path=/plone.app.discussion/trunk/; revision=33278
 2010-01-22 17:54:30 +00:00
Timo Stollenwerk
0b530a0a75 Ugly hack that works around a "ContentProviderLookupError: plone.htmlhead" error caused by Zope 2 permissions. See https://bugs.launchpad.net/zope2/+bug/176566 for further details. This error occured on Plone 3.3.x only. 
svn path=/plone.app.discussion/trunk/; revision=33275
 2010-01-22 16:28:00 +00:00
Timo Stollenwerk
1a1c903086 Integration test for comments viewlet added. 
Empty test class for comment form added.

svn path=/plone.app.discussion/trunk/; revision=33271
 2010-01-22 12:29:26 +00:00
Timo Stollenwerk
5ff91da15d rename plone.comments Viewlet to plone.app.discussion.comments and hide the standard plone.comments Viewlet. This is necessary because overriding plone.comments is not working anymore in Plone 4.0a3. This should be fixed properly in the future. 
svn path=/plone.app.discussion/trunk/; revision=33270
 2010-01-22 12:08:30 +00:00
Timo Stollenwerk
7dda99a62a remove outstanding questions. 
svn path=/plone.app.discussion/trunk/; revision=33235
 2010-01-19 09:37:40 +00:00
Timo Stollenwerk
548c1debee remove unnecessary cancel button class. 
svn path=/plone.app.discussion/trunk/; revision=33234
 2010-01-19 08:26:41 +00:00
Timo Stollenwerk
3ceb9e1e4f use widget.addClass instead of overwriting an entire class for setting a CSS class. 
svn path=/plone.app.discussion/trunk/; revision=33222
 2010-01-18 19:47:46 +00:00
Timo Stollenwerk
365684f137 test stop iteration for get_replies method. 
svn path=/plone.app.discussion/trunk/; revision=33218
 2010-01-18 12:20:45 +00:00
Timo Stollenwerk
1bfff5255a more tests for comments viewlet. 
svn path=/plone.app.discussion/trunk/; revision=33217
 2010-01-18 11:38:57 +00:00
Timo Stollenwerk
ca0aecd170 user portal membership tool for is_anonyous method; tests for comments viewlet added. 
svn path=/plone.app.discussion/trunk/; revision=33216
 2010-01-18 11:04:08 +00:00
Timo Stollenwerk
77eaee146e tests for comments viewlet added (some are still empty). 
svn path=/plone.app.discussion/trunk/; revision=33215
 2010-01-18 09:55:44 +00:00
Timo Stollenwerk
d1bd1469c8 move comment view from browser/comments.py to browser/comment.py. 
svn path=/plone.app.discussion/trunk/; revision=33214
 2010-01-18 09:54:27 +00:00
Timo Stollenwerk
dc2e5232f7 fix migration tests. do not use transactions during unit testing. 
svn path=/plone.app.discussion/trunk/; revision=32805
 2010-01-03 17:36:01 +00:00
Timo Stollenwerk
e0cc673683 count old comments only during migration. show error log when comments could not be migrated. 
svn path=/plone.app.discussion/trunk/; revision=32767
 2010-01-02 19:45:05 +00:00
Timo Stollenwerk
275cb885ea dry_run and abort migration added to migration view. 
svn path=/plone.app.discussion/trunk/; revision=32588
 2009-12-21 23:36:35 +00:00
Timo Stollenwerk
adb0390227 use object_provides instead of portal_type to query the catalog for comments. this fixes bug #2010085; 
svn path=/plone.app.discussion/trunk/; revision=32538
 2009-12-19 15:03:12 +00:00
Timo Stollenwerk
2e004456f5 Bugfix for #2010078: Comments that await moderation are visually distinguished from published comments. 
svn path=/plone.app.discussion/trunk/; revision=32537
 2009-12-19 14:04:49 +00:00
Timo Stollenwerk
0fa11f9af9 remove unnecessary link in comment title. 
svn path=/plone.app.discussion/trunk/; revision=32536
 2009-12-19 13:39:28 +00:00
Timo Stollenwerk
5f9e443b9c fix bug #2010181: The name of a commenter who commented while not logged in should not appear as a link. 
svn path=/plone.app.discussion/trunk/; revision=32535
 2009-12-19 13:35:49 +00:00
Timo Stollenwerk
2bb8f514e8 fix unbound prefix error. 
svn path=/plone.app.discussion/trunk/; revision=32436
 2009-12-15 07:15:57 +00:00
Timo Stollenwerk
c873b76a9b locales directory added. 
svn path=/plone.app.discussion/trunk/; revision=32431
 2009-12-14 12:45:45 +00:00
Timo Stollenwerk
8c5342e8e3 Plone 4 compliant icon_expression added. 
svn path=/plone.app.discussion/trunk/; revision=32359
 2009-12-08 15:40:25 +00:00
Timo Stollenwerk
8e493363c4 rename remove button to delete. 
svn path=/plone.app.discussion/trunk/; revision=32358
 2009-12-08 15:37:52 +00:00
Timo Stollenwerk
42f8da327b fix styles for action column in moderation view. 
svn path=/plone.app.discussion/trunk/; revision=32357
 2009-12-08 15:29:37 +00:00
Timo Stollenwerk
6ddfbff8df fix even/odd styles for Plone 4. 
svn path=/plone.app.discussion/trunk/; revision=32356
 2009-12-08 11:53:10 +00:00
Timo Stollenwerk
47cba8797f filter tabs removed from moderation view; 
svn path=/plone.app.discussion/trunk/; revision=32355
 2009-12-08 11:19:26 +00:00
Timo Stollenwerk
a672c1ed11 Plone 4 styles added. 
svn path=/plone.app.discussion/trunk/; revision=32349
 2009-12-07 19:39:23 +00:00
Timo Stollenwerk
ff9e2205c9 fix ajax call for workflow_action publish in moderation view. 
svn path=/plone.app.discussion/trunk/; revision=32342
 2009-12-07 16:11:49 +00:00
Timo Stollenwerk
34b37cab2d fix toLocalizedTime for Plone 4 compatibility. 
svn path=/plone.app.discussion/trunk/; revision=32340
 2009-12-07 15:45:39 +00:00
Timo Stollenwerk
9713bda830 fix float issue for discussion div as well. 
svn path=/plone.app.discussion/trunk/; revision=32339
 2009-12-07 15:41:17 +00:00
Timo Stollenwerk
a741095b14 Clear "float: left" from "manage portlets" div above the comment viewlet. This will get fixed in the next Plone 4 release. A bug report has been added to the tracker: https://dev.plone.org/plone/ticket/9903 
svn path=/plone.app.discussion/trunk/; revision=32338
 2009-12-07 15:39:49 +00:00
Timo Stollenwerk
dd6fdd34fb fix typo. 
svn path=/plone.app.discussion/trunk/; revision=31925
 2009-11-19 21:42:02 +00:00
Timo Stollenwerk
6999e6f8d0 Replace yes/no widgets with single checkboxes. 
svn path=/plone.app.discussion/trunk/; revision=31923
 2009-11-19 21:40:08 +00:00
Timo Stollenwerk
ae2767daec fix redirect after a comment has been posted. 
svn path=/plone.app.discussion/trunk/; revision=31000
 2009-11-01 09:24:27 +00:00
Timo Stollenwerk
94adf62566 do not show moderation message when user has manage rights. 
svn path=/plone.app.discussion/trunk/; revision=30997
 2009-10-31 16:42:04 +00:00
Timo Stollenwerk
7550e95d5c fix redirection after a comment has been added. 
svn path=/plone.app.discussion/trunk/; revision=30986
 2009-10-31 12:33:59 +00:00
Timo Stollenwerk
58f8f4bf22 Do not show "publish" bulk action in moderation view when moderation is disabled. Fix story 1105355 
.

svn path=/plone.app.discussion/trunk/; revision=30678
 2009-10-18 13:12:52 +00:00
Timo Stollenwerk
3e75eedca8 KNOWN_ISSUES.txt removed. 
svn path=/plone.app.discussion/trunk/; revision=30671
 2009-10-17 16:34:58 +00:00
Timo Stollenwerk
c9a5070681 Adding Persistent to subclasses of comment - this fixes five.intid choking on Comments in the catalog on reinstall. evilbungle branch merge. 
svn path=/plone.app.discussion/trunk/; revision=30670
 2009-10-17 16:29:45 +00:00
Timo Stollenwerk
8db9c8c175 Removing hard coded publish action. evilbungle branch merge. 
svn path=/plone.app.discussion/trunk/; revision=30669
 2009-10-17 16:14:44 +00:00
Timo Stollenwerk
7ef2672e5c Making captcha validator only adapt for the appropriate browser layer. This fixes the captcha error issue when p.a.d is in a deployment but not installed yet. evilbungle branch merge. 
svn path=/plone.app.discussion/trunk/; revision=30667
 2009-10-17 14:13:27 +00:00
Timo Stollenwerk
7cd9ef2491 Changing browser:view registrations to browser:page since view doesn't actually do anything with the permissions. This fixes the anyone can delete comments problem. evilbungle branch merge. 
svn path=/plone.app.discussion/trunk/; revision=30665
 2009-10-17 13:50:55 +00:00
Timo Stollenwerk
78d547daa6 Replacing infinite-recursion happy traverse_parent_folders method with one based on aq_chain; evilbungle branch merge. 
svn path=/plone.app.discussion/trunk/; revision=30660
 2009-10-17 09:33:58 +00:00
Timo Stollenwerk
60b6196736 Show info message after adding a comment when moderation is enabled. 
svn path=/plone.app.discussion/trunk/; revision=30659
 2009-10-17 09:17:13 +00:00
Timo Stollenwerk
1ea36d7d82 Conversation indexers won't work on old discussion items. Fix tests. 
svn path=/plone.app.discussion/trunk/; revision=30658
 2009-10-17 08:28:50 +00:00
Timo Stollenwerk
e5f1a70de6 Make unit tests pass with Plone 3.3 again. Migration tests still failing. 
svn path=/plone.app.discussion/trunk/; revision=30633
 2009-10-16 12:11:58 +00:00
Hanno Schlichting
6e8f812eee Duh, I wanted the new CatalogAware without the OpaqueItemManager base, not the old CMFCatalogAware 
svn path=/plone.app.discussion/trunk/; revision=30630
 2009-10-16 00:51:58 +00:00
Hanno Schlichting
71ed707794 Get this running again for the most part under Plone 4.0 - the main trick was probably to use the new CMFCatalogAware class. Removed collective.testcaselayer dependency, as that broke totally. There's some test failures left, but indexing works in general. Maybe the custom indexing event handlers aren't all required anymore. The title_or_id test failure looks like there's an infinite loop in the __parent__ pointers never reaching the actual content object. This change breaks Plone 3.x compatibility for the moment. 
svn path=/plone.app.discussion/trunk/; revision=30629
 2009-10-16 00:42:08 +00:00
Timo Stollenwerk
c19feeab6e remove clear-and-rebuild catalog from known issues and todo. 
svn path=/plone.app.discussion/trunk/; revision=30612
 2009-10-15 10:45:35 +00:00
Timo Stollenwerk
f4a4b6e370 fix catalog clear-and-rebuild. this finally fixes story 847941. 
svn path=/plone.app.discussion/trunk/; revision=30610
 2009-10-15 10:11:12 +00:00
Timo Stollenwerk
9befc4c651 Monkey patch for clear-and-rebuild catalog added. This fixes story 847941. Nested comments are not reindexed yet. 
svn path=/plone.app.discussion/trunk/; revision=30574
 2009-10-14 14:58:08 +00:00
Timo Stollenwerk
83b631413a revert r30055, since p.a.d. will not become part of Plone 4. 
svn path=/plone.app.discussion/trunk/; revision=30462
 2009-10-12 18:46:03 +00:00
Timo Stollenwerk
b09d42e505 fix has_replies function when get_replies returns None. 
svn path=/plone.app.discussion/trunk/; revision=30256
 2009-10-07 20:50:01 +00:00
Timo Stollenwerk
f0cbc787ab has_replies function added to get only published comments for anon users. elro review fix. refs #9288 
svn path=/plone.app.discussion/trunk/; revision=30252
 2009-10-07 20:07:55 +00:00
Timo Stollenwerk
6daa8824fb Hide the editable-object border in moderation view. elro review fix. refs #9288 
svn path=/plone.app.discussion/trunk/; revision=30244
 2009-10-07 11:52:44 +00:00
Timo Stollenwerk
f9115d6f87 "comment objects are not indexed with Plone 4" added to known issues. 
svn path=/plone.app.discussion/trunk/; revision=30087
 2009-09-30 21:10:36 +00:00
Timo Stollenwerk
9adff9e869 comment out monkey patch of plone.app.vocabularies for now. 
svn path=/plone.app.discussion/trunk/; revision=30055
 2009-09-30 11:21:15 +00:00
Timo Stollenwerk
aae633cb26 update TODO.txt. 
svn path=/plone.app.discussion/trunk/; revision=29626
 2009-09-09 15:17:47 +00:00
Timo Stollenwerk
5a8e1eed93 Fix "insufficient privileges" bug reported by elro. 
svn path=/plone.app.discussion/trunk/; revision=29624
 2009-09-09 14:48:19 +00:00
Timo Stollenwerk
a6cc6c6fcb fix story 1109910. Tabs in moderation view have a margin. 
svn path=/plone.app.discussion/trunk/; revision=29461
 2009-08-29 16:23:54 +00:00
Timo Stollenwerk
9aaf24e247 Fix story 1140047. Comment text wraps around commenter image. 
svn path=/plone.app.discussion/trunk/; revision=29457
 2009-08-28 21:21:54 +00:00
Timo Stollenwerk
a69f2baf01 remove unnecessary discussion-check utility code. 
svn path=/plone.app.discussion/trunk/; revision=29436
 2009-08-28 13:34:45 +00:00
Timo Stollenwerk
96e2899955 hide the email field for now. we keep the field for integrators or later use. 
svn path=/plone.app.discussion/trunk/; revision=29435
 2009-08-28 13:12:14 +00:00
Timo Stollenwerk
48ab88a8b4 code cleanup; 
reply to comment button and handler removed; 
reply-to-comment is now handled by the comment handler as well;
this also solves story 1173673;

svn path=/plone.app.discussion/trunk/; revision=29434
 2009-08-28 13:03:16 +00:00
Timo Stollenwerk
1747a3655b fix recaptcha reply-to-comment form bug. 
svn path=/plone.app.discussion/trunk/; revision=29433
 2009-08-28 12:03:34 +00:00
Timo Stollenwerk
f7f10a5572 fix that conversation.enabled wasn't called. evilbungle fix. 
svn path=/plone.app.discussion/trunk/; revision=29432
 2009-08-28 11:39:02 +00:00
Timo Stollenwerk
1c3aa5e9b5 call WrongReCaptchaCode validator for recaptcha. 
svn path=/plone.app.discussion/trunk/; revision=29428
 2009-08-28 08:32:20 +00:00
Timo Stollenwerk
5cf3510dd9 import (re)captcha message factory for (re)captcha validation error. this fixes the strange type error. 
svn path=/plone.app.discussion/trunk/; revision=29427
 2009-08-28 08:28:58 +00:00
Timo Stollenwerk
72ac358c4c fix reply-to-comment form buttons. 
svn path=/plone.app.discussion/trunk/; revision=29405
 2009-08-26 22:31:23 +00:00
Timo Stollenwerk
8e406ccf2d remove "display: inline" CSS from reply-button; show reply-button only when JS is enabled. 
svn path=/plone.app.discussion/trunk/; revision=29404
 2009-08-26 21:55:27 +00:00
Timo Stollenwerk
defb4b91c4 hide reply and cancel button with css when JS is disabled. 
svn path=/plone.app.discussion/trunk/; revision=29403
 2009-08-26 21:53:34 +00:00
Timo Stollenwerk
d2ceb44a0c fixed IE errors. merge r29394 from evilbungle-safe-html branch. 
svn path=/plone.app.discussion/trunk/; revision=29398
 2009-08-26 15:05:58 +00:00
Timo Stollenwerk
9d5453b1da Modifying permissions so reviewers can moderate/remove comments. evilbungle branch r29364. 
svn path=/plone.app.discussion/trunk/; revision=29384
 2009-08-26 08:59:50 +00:00
Timo Stollenwerk
8b9a3e63c9 replace data.has_key() with "key in data". 
svn path=/plone.app.discussion/trunk/; revision=29342
 2009-08-24 18:09:32 +00:00
Timo Stollenwerk
c83d826c46 Making captcha validator only adapt for the appropriate browser layer. This fixes the captcha error issue when p.a.d is in a deployment but not installed yet. 
Merge from r29239 from evilbungle-safe-html branch.

svn path=/plone.app.discussion/trunk/; revision=29248
 2009-08-21 21:15:13 +00:00
Timo Stollenwerk
9c3bdb3a72 Stopping comments being rendered as structure; 
Merge r29173 from evilbungle-safe-html branch.

svn path=/plone.app.discussion/trunk/; revision=29246
 2009-08-21 20:52:12 +00:00
Timo Stollenwerk
8c9a8b9f93 remove limit on zcatalog query for comments. 
svn path=/plone.app.discussion/trunk/; revision=29244
 2009-08-21 19:53:04 +00:00
Carsten Senger
241c17df72 move the access of reply/Creator into a nested tag. tal:defines are 
evaluated before tal:condition so we may have no permission to access
Creator.

svn path=/plone.app.discussion/trunk/; revision=29207
 2009-08-20 02:21:23 +00:00
Carsten Senger
c145378f34 Allways use an accessor method on the comment, never access the 
attribute directly as the attribute is not acquisition wrapped 
and a permission check for the required permission will fail

svn path=/plone.app.discussion/trunk/; revision=29205
 2009-08-20 02:17:02 +00:00
Carsten Senger
984a1fed7d Zope 2.12 compatibility: ViewPageTemplate's id property is read only 
svn path=/plone.app.discussion/trunk/; revision=29203
 2009-08-20 02:11:57 +00:00
Carsten Senger
06b332a801 Compatibility with Zope 2.12: don't wrap the ViewPageTemplate into an acquisition wrapper. 
svn path=/plone.app.discussion/trunk/; revision=29201
 2009-08-20 02:09:53 +00:00
Carsten Senger
e946ef7979 Add an accessor method for title. As title is part of the interface 
IComment for which we <require> zope2.View a permission check will raise
Unauthorized cause we can not assure that the user's userfolder is in 
the acqusition chain of the object (the attribute is a bare unicode object).
It works for methods. im_self is used to get the acquisition wrapped
object.

svn path=/plone.app.discussion/trunk/; revision=29199
 2009-08-20 02:06:15 +00:00
Carsten Senger
4da4ab3599 import Event interfaces from where they are defined (also works in Zope 2.12) 
svn path=/plone.app.discussion/trunk/; revision=29187
 2009-08-19 22:16:06 +00:00
Timo Stollenwerk
775fc1572a Plone CSS classes added to buttons. 
svn path=/plone.app.discussion/trunk/; revision=29108
 2009-08-17 21:46:44 +00:00
Timo Stollenwerk
962e4dd0d3 autoresize css class added to comment-textarea. 
svn path=/plone.app.discussion/trunk/; revision=29104
 2009-08-17 20:31:37 +00:00
Timo Stollenwerk
ed4c6c411c Simplify comment form labels as suggested by jon. 
svn path=/plone.app.discussion/trunk/; revision=28979
 2009-08-16 08:38:42 +00:00
Timo Stollenwerk
09a88ff9fb todo update. 
svn path=/plone.app.discussion/trunk/; revision=28947
 2009-08-15 20:10:17 +00:00
Timo Stollenwerk
d889f2ed9a documentation update. 
svn path=/plone.app.discussion/trunk/; revision=28946
 2009-08-15 20:09:27 +00:00
Timo Stollenwerk
4a78ce44e0 fix captcha import; unit tests pass without p.f.captcha installed. 
svn path=/plone.app.discussion/trunk/; revision=28942
 2009-08-15 19:44:39 +00:00
Timo Stollenwerk
50de2b4031 fix discussion control panel description. 
svn path=/plone.app.discussion/trunk/; revision=28939
 2009-08-15 17:49:50 +00:00
Timo Stollenwerk
987805c927 fix inline validation for reply-to-comment form. 
svn path=/plone.app.discussion/trunk/; revision=28923
 2009-08-15 16:36:49 +00:00
Timo Stollenwerk
dbff6b4f67 add captcha check for reply-to-comment form. 
svn path=/plone.app.discussion/trunk/; revision=28922
 2009-08-15 16:36:35 +00:00
Timo Stollenwerk
bbf7cb5685 show captcha validation only for anonymous users. 
svn path=/plone.app.discussion/trunk/; revision=28902
 2009-08-15 11:35:54 +00:00
Timo Stollenwerk
2567483281 CaptchaValidator for captcha/recaptcha/no captcha added. This is necessary because the zcml registration of the CaptchaValidator has to work with all three options. 
svn path=/plone.app.discussion/trunk/; revision=28894
 2009-08-15 10:21:26 +00:00
Timo Stollenwerk
ead8813188 simplify (re)captcha test. 
svn path=/plone.app.discussion/trunk/; revision=28893
 2009-08-15 10:18:10 +00:00
Timo Stollenwerk
4ef604f43f make captcha field not required. otherwise recaptcha is not working. 
svn path=/plone.app.discussion/trunk/; revision=28892
 2009-08-15 10:17:34 +00:00
Timo Stollenwerk
cdfbdb3d7d remove debug line. 
svn path=/plone.app.discussion/trunk/; revision=28819
 2009-08-14 09:02:42 +00:00