Commit Graph

237 Commits

Author SHA1 Message Date
Ross Patterson d8f864596e The functional tests haven't been running due to an unused import
svn path=/plone.app.discussion/trunk/; revision=48835
2011-04-14 19:05:31 +00:00
Ross Patterson d5a999b429 Clarify a doctest
svn path=/plone.app.discussion/trunk/; revision=48831
2011-04-14 16:41:11 +00:00
Ross Patterson 586cd1fdb7 Don't add the annotation unless a comment is actually being added.
Fixes #11370.

svn path=/plone.app.discussion/trunk/; revision=48829
2011-04-14 16:17:29 +00:00
David Glick 6d11fa6d5e merge c48523 from 1.x branch
svn path=/plone.app.discussion/trunk/; revision=48527
2011-04-07 21:31:56 +00:00
David Glick 636bca745c merge r47140, r47290, r47579 from davisagli-features: fix timezone handling when migrating legacy comments and when indexing
svn path=/plone.app.discussion/trunk/; revision=48358
2011-04-02 21:26:36 +00:00
David Glick 9d83b4f0e6 merge -r46947 from davisagli-features: preserve legacy titles on migrated comments
svn path=/plone.app.discussion/trunk/; revision=48357
2011-04-02 21:16:24 +00:00
David Glick eb004aab44 merge r46437 and r46946 from davisagli-features: respect the per-comment mime_type setting, and use the old cooked text/html from legacy comments when migrating
svn path=/plone.app.discussion/trunk/; revision=48356
2011-04-02 19:51:37 +00:00
David Glick bf5946367a merge r46436 from davisagli-features: make it possible to specify a callback filter for the migration
svn path=/plone.app.discussion/trunk/; revision=48354
2011-04-02 19:33:10 +00:00
Patrick Gerken 774ed36746 Ups, there is a nother unicode problem
svn path=/plone.app.discussion/trunk/; revision=47990
2011-03-08 20:15:37 +00:00
Patrick Gerken b6d406d298 Trigger failure for objects with unicode titles in string
svn path=/plone.app.discussion/trunk/; revision=47989
2011-03-08 20:15:21 +00:00
Maurits van Rees 478273aa80 minor code cleanup
svn path=/plone.app.discussion/trunk/; revision=47599
2011-02-15 16:23:12 +00:00
Maurits van Rees 81d74cfe6b Fixed test failure for the default user portrait, which changed from
defaultUser.gif to defaultUser.png in Products.PlonePAS 4.0.5.

svn path=/plone.app.discussion/trunk/; revision=47597
2011-02-15 16:19:13 +00:00
Timo Stollenwerk bf96d0082f Remove "Plone 3 only" code; Do not monkey patch the BAD_TYPES vocabulary or plone.app.vocabularies anymore.
svn path=/plone.app.discussion/trunk/; revision=47311
2011-02-08 09:28:51 +00:00
Timo Stollenwerk 0a0e69d47d Do not check for a comment review workflow when sending out a moderator email notification. This fixes http://dev.plone.org/plone/ticket/11444. Refs #11444
svn path=/plone.app.discussion/trunk/; revision=47292
2011-02-07 11:48:24 +00:00
Timo Stollenwerk c438743a3b Show a 'Comments are moderated.' message next to the comment form if comments are moderated.
svn path=/plone.app.discussion/trunk/; revision=46782
2011-01-07 10:20:24 +00:00
Maurits van Rees a2a17085a3 Nuke trailing white space
svn path=/plone.app.discussion/trunk/; revision=46366
2010-12-15 23:52:56 +00:00
Maurits van Rees aff8a3709c Avoid sending multiple notification emails to the same person when
he has commented multiple times.

svn path=/plone.app.discussion/trunk/; revision=46365
2010-12-15 23:41:57 +00:00
David Glick 0cb75778ba make sure comments don't get indexed with their parents' UID in Plone 3. only declare dependency on plone.app.uuid in Python 2.6, since we only use it in Plone 4 currently.
svn path=/plone.app.discussion/trunk/; revision=46353
2010-12-15 20:39:55 +00:00
Timo Stollenwerk b9d929bca3 Fix failing test.
svn path=/plone.app.discussion/trunk/; revision=46344
2010-12-14 21:30:40 +00:00
Timo Stollenwerk a8bfd7fc6e Disable discussion by default.
svn path=/plone.app.discussion/trunk/; revision=46337
2010-12-14 17:58:46 +00:00
Timo Stollenwerk d702c666f0 Tests for moderation_enabled setting added.
svn path=/plone.app.discussion/trunk/; revision=46266
2010-12-12 13:56:06 +00:00
Timo Stollenwerk 0475376ed0 "Enable comment moderation" setting added to the discussion control panel. Just a proof of concept so far. Not fully implemented yet. No tests.
svn path=/plone.app.discussion/trunk/; revision=46249
2010-12-11 17:18:14 +00:00
Timo Stollenwerk 09a804aa88 Remove unnecessary and failing test.
svn path=/plone.app.discussion/trunk/; revision=46235
2010-12-10 09:16:36 +00:00
Timo Stollenwerk 54af7d3fa1 Assigning the 'Reply to item' permission to the 'Authenticated' role. The old commenting system allowed 'Authenticated' users to post comments. Also, OpenID users do not possess the 'Authenticated' role. Refs #9288
svn path=/plone.app.discussion/trunk/; revision=46230
2010-12-10 08:57:35 +00:00
Timo Stollenwerk 45140c66db Functional test for posting a comment as user without the 'Reply to item' permission added.
svn path=/plone.app.discussion/trunk/; revision=46215
2010-12-09 10:58:32 +00:00
Timo Stollenwerk 7e279d3ad3 Make sure the handleComment method checks for the 'Reply to item' permission when adding a comment.
svn path=/plone.app.discussion/trunk/; revision=46212
2010-12-09 08:11:41 +00:00
Timo Stollenwerk 0c94707743 Dynamically show the comment formatting message dependent on the text transform setting.
svn path=/plone.app.discussion/trunk/; revision=46035
2010-11-29 22:42:20 +00:00
Timo Stollenwerk f0cecaf274 Always set the effective date of a comment to the same value as the creation date.
svn path=/plone.app.discussion/trunk/; revision=46019
2010-11-29 17:36:52 +00:00
Timo Stollenwerk ac4a64f55d Make sure comment UIDs in the catalog are always unique. This fixes
http://dev.plone.org/plone/ticket/10652. We depend on plone.uuid and plone.app.uuid now. Refs #10652.

svn path=/plone.app.discussion/trunk/; revision=46005
2010-11-28 11:39:19 +00:00
Timo Stollenwerk b08d7ddbeb revert r46002.
svn path=/plone.app.discussion/trunk/; revision=46003
2010-11-28 10:00:31 +00:00
Timo Stollenwerk 7e39197114 hudson buildout added.
svn path=/plone.app.discussion/trunk/; revision=46002
2010-11-28 09:51:35 +00:00
Timo Stollenwerk d358a31c74 Comments viewlet test for posting anonymous comments added.
svn path=/plone.app.discussion/trunk/; revision=45663
2010-11-08 17:10:19 +00:00
Timo Stollenwerk b95707ac52 Re-add the CommentsViewlet can_manage method. This method has been removed in version 1.0b9 and added again in 1.0b11 because we don't want to change the API in beta releases.
svn path=/plone.app.discussion/trunk/; revision=45110
2010-11-03 11:26:18 +00:00
Timo Stollenwerk a39ac82858 There is no need to set the comment title in the tests, since comments do not have title fields anymore.
svn path=/plone.app.discussion/trunk/; revision=44738
2010-10-31 11:09:32 +00:00
Timo Stollenwerk feec103b56 Fix user email notification test for Plone 3.
svn path=/plone.app.discussion/trunk/; revision=44737
2010-10-31 10:48:45 +00:00
Timo Stollenwerk c8cd370fc9 Use len(tuple()) instead of tuple() to make tests pass again.
svn path=/plone.app.discussion/trunk/; revision=44706
2010-10-30 19:26:51 +00:00
Timo Stollenwerk 093eaa393a Use tuple() to test for generators. Thanks to otacon!
svn path=/plone.app.discussion/trunk/; revision=42096
2010-10-30 18:58:20 +00:00
Timo Stollenwerk 82afd3ef15 New feature: As a logged-in user, I can enable/disable email notification of additional comments on this content object.
svn path=/plone.app.discussion/trunk/; revision=40949
2010-10-30 15:02:05 +00:00
Timo Stollenwerk 5fe339215b Use the jstestdriver coverage plugin.
svn path=/plone.app.discussion/trunk/; revision=40909
2010-10-30 11:24:03 +00:00
Timo Stollenwerk 380b81bd3e Disable the moderation qunit tests for now because they are currently failing.
svn path=/plone.app.discussion/trunk/; revision=40907
2010-10-30 11:12:04 +00:00
Timo Stollenwerk 0820d3771f Basic js-test-driver configuration added.
svn path=/plone.app.discussion/trunk/; revision=40892
2010-10-30 10:22:21 +00:00
Hanno Schlichting aa8a1ea934 Fixed handling of non-ascii member data, like fullname and email.
svn path=/plone.app.discussion/trunk/; revision=40789
2010-10-22 10:14:07 +00:00
Hanno Schlichting 54bbb08c62 Whitespace removal
svn path=/plone.app.discussion/trunk/; revision=40788
2010-10-22 09:57:55 +00:00
Timo Stollenwerk f7ed357a83 Use 'comment_review_workflow' instead of 'simple_publication_workflow' for testing.
svn path=/plone.app.discussion/trunk/; revision=40571
2010-10-08 11:03:14 +00:00
Timo Stollenwerk 324d2274bd Check for a 'pending' state in the current comment workflow instead of checking for the 'comment_review' workflow. Refs #11184. Merge last three submits in CHANGES.txt.
svn path=/plone.app.discussion/trunk/; revision=40570
2010-10-08 10:37:10 +00:00
Timo Stollenwerk 6e9bb4a9cd Check the review_state to decide if moderation is enabled. If the current comment workflow implements a 'pending' state, moderation is enabled. Refs #11184.
svn path=/plone.app.discussion/trunk/; revision=40569
2010-10-08 10:22:40 +00:00
Timo Stollenwerk 43d3222086 Run functional tests only with Plone 4 (and plone.testing).
svn path=/plone.app.discussion/trunk/; revision=40537
2010-10-06 15:12:11 +00:00
Timo Stollenwerk 4bbfe677e4 Replace the can_manage method with a can_review method that checks the 'Review comments' permission. This fixes http://dev.plone.org/plone/ticket/11145.
svn path=/plone.app.discussion/trunk/; revision=40534
2010-10-06 13:55:57 +00:00
Timo Stollenwerk 3e73903a8d Remove (old) functional test.
svn path=/plone.app.discussion/trunk/; revision=40533
2010-10-06 13:53:07 +00:00
Timo Stollenwerk 1230e67a01 Functional test for comment_review_workflow added; existing fonctional test renamed to functional_test_comments.txt;
svn path=/plone.app.discussion/trunk/; revision=40532
2010-10-06 13:52:11 +00:00