Commit Graph

433 Commits

Author SHA1 Message Date
Maurits van Rees
266d87b3b9
Test-only fix: normalize white space when comparing output of comment.getText().
Needed to not fail with newer `plone.outputfilters` from this PR: https://github.com/plone/plone.outputfilters/pull/49
Comments go through the outputfilters, and the new branch calls `soup.prettify()` from `Beautifulsoup`, leading to more white space.
Sample test failures on Jenkins, see https://jenkins.plone.org/job/plip-plip-image-srcsets-3.8/5/#showFailuresLink

```
'<p>\n Go to http://www.plone.org\n</p>' != '<p>Go to http://www.plone.org</p>'
- <p>
-  Go to http://www.plone.org
? ^                          ^
+ <p>Go to http://www.plone.org</p>? ^^^                          ^^^^
- </p>

  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
    yield
  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 676, in run
    self._callTestMethod(testMethod)
  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
    method()
  File "/home/jenkins/.buildout/eggs/cp38/plone.app.discussion-4.0.0a7-py3.8.egg/plone/app/discussion/tests/test_comment.py", line 180, in test_getText_doesnt_link
    self.assertEqual(
  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 912, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 1292, in assertMultiLineEqual
    self.fail(self._formatMessage(msg, standardMsg))
  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 753, in fail
    raise self.failureException(msg)
```
2022-06-10 13:50:16 +02:00
Jens W. Klein
fe10c7448f
Merge pull request #195 from plone/plone-base-overhaul
Plone base overhaul
2022-05-03 15:10:38 +02:00
Maurits van Rees
ef6b558c28
Make compatible with robotframework 3-5. 2022-05-02 23:03:24 +02:00
Maurits van Rees
e81e26c02b
Removed a few more unicode literals. 2022-05-02 17:12:04 +02:00
Jens W. Klein
bcb9315772 add newsfile 2022-05-02 00:43:21 +02:00
Jens W. Klein
f443deacbd use plone.base and remove dependencies to CMFPlone 2022-05-02 00:39:34 +02:00
Jens W. Klein
19571f45ed remove six plus some bbb cleanup 2022-05-01 23:28:00 +02:00
Jens W. Klein
75c6a5dcc1 find -name "*.py" -exec pyupgrade --py3-only --py37-plus {} + 2022-05-01 23:14:41 +02:00
Jens W. Klein
34b758f2bd black 2022-05-01 23:14:09 +02:00
Jens W. Klein
e72d86b985 isort 2022-05-01 23:14:00 +02:00
Godefroid Chapelle
8bc3d824e6 Fix test
after PortalTransforms uses lxml html method to serialize
(instead of xml method)
2022-03-15 12:12:39 +01:00
Érico Andrei
6f3fa11f10 Implement events for Comment (ICommentModifiedEvent) and Reply(IReplyModifiedEvent) modification 2021-09-08 16:18:39 +02:00
Stefan Antonelli
c4c2bb8095 fix tests 2021-02-17 19:36:26 +01:00
Maurits van Rees
4d36d0b342
Fix tests with Products.MailHost 4.11.
Fixes https://github.com/plone/plone.app.discussion/issues/174
2021-01-22 16:37:12 +01:00
Maurits van Rees
c9d9cfca04
Message test: we never get a Message object, but always bytes/string/unicode.
Which type we get back, depends on the Python version and the Products.MailHost version.
2020-09-23 15:35:32 +02:00
Maurits van Rees
e4bcf2f53c
Fix tests with Products.MailHost 4.10. 2020-09-23 15:26:30 +02:00
Maurits van Rees
d39b2fcbbe
Merge pull request #166 from plone/moderation-extended
Extended Moderation of comments
2020-03-16 23:18:14 +01:00
tschorr
bf41101c86 fix test for Plone > 5; deprecate Plone < 5 2020-02-11 18:49:57 +01:00
Katja Suess
f7ae6e49a5 unique css ids
and bug fix test: editing comment: button label "save" instead of "edit comment"
2020-01-16 15:32:46 +01:00
Katja Suess
dde8640fc5 Update test_comments_viewlet.py 2020-01-11 11:43:35 +01:00
Katja Suess
c1ec431769 extended existing review workflow by stati 'rejected' and 'spam'
removed addional third workflow
2020-01-08 12:42:03 +01:00
Katja Suess
f777315da3 moderation view: get last transition entry faster
get it from @@contenthistorypopup instead from @@historyview
2020-01-08 12:41:06 +01:00
Katja Suess
54de9b32e1 Update test_moderation.robot 2020-01-08 12:41:06 +01:00
Katja Suess
bf20752b69 bulk moderation of comments
extended for comment_multiple_state_review_workflow, refactoring and tests
2020-01-08 12:39:57 +01:00
Katja Suess
084d2893e7 Additional (optional) workflow: "Comment Multiple State Review Workflow"
Moderator is not forced to delete a comment or to let it pending:
Workflow has two more states "rejected" and "spam" to existing review workflow.
Moderation view extended showing all states. Filter by state.
2020-01-08 12:36:28 +01:00
Katja Suess
7b43d80486 test_notifications moderator 2019-12-02 09:09:49 +01:00
Joni Orponen
c1518d87d1 Re-enable two disabled Robot tests. 2019-05-14 10:40:09 +02:00
Joni Orponen
45fd2c51ce Use the shared test setup and test teardown keywords in Robot tests. 2019-05-14 10:37:15 +02:00
Jens W. Klein
afa48be877 Do not depend on the meta_type metadata in the catalog 2019-02-04 16:04:54 +01:00
Jens W. Klein
6cf6bf25f2 fix test in py3 2018-09-28 14:22:51 +02:00
Philip Bauer
9e7448a049 fix test 2018-09-21 13:38:09 +02:00
hvelarde
c6d1f832da Fix old-division 2018-09-18 15:13:38 +02:00
Philip Bauer
95861b28d5 fix tests with py3 2018-09-18 15:13:38 +02:00
Markus Hilbert
3c36af8ebc Fixed tests when IRichText behavior is used. 2018-07-11 12:35:46 +02:00
Jens W. Klein
58711579c4 isort 2018-06-15 10:22:11 +02:00
Jens W. Klein
bf0fa909b9 fix tests for plone.login merge 2018-06-15 10:14:51 +02:00
Philip Bauer
71dcbf8465 some py3 fixes 2018-03-18 17:01:27 +01:00
Philip Bauer
e4f798d9d3 make doctest syntax py3 compatible 2018-01-26 11:11:50 +01:00
Philip Bauer
93a227c80d Add Python 2 / 3 compatibility 2018-01-25 13:04:11 +01:00
Katja Süss
78abff152d Test 2017-07-28 19:12:49 +00:00
Katja Süss
0fd9b02c80 Email validation 2017-06-20 15:16:19 +02:00
KUMAR AKSHAY
964dcea523 kakshay unittest (#121)
remove unittest2 dependency
2017-05-08 09:24:38 +02:00
Maurits van Rees
b5eebe0cc8 Fixed tests with newer testbrowser. 2017-02-04 16:58:38 +01:00
MrTango
bc2a9ac5d9 remove __of__ calls on views 2017-01-31 17:57:41 +01:00
Daniel Jowett
d2bba1d5ea Fix some easy pep8 issues 2017-01-24 10:59:43 +00:00
Maurits van Rees
802e3ec04c Make comment on private content not publicly available in search results.
This is part of PloneHotfix20161129.

Updated metadata.xml version to 1000.  This leaves more room for
profile version increases in earlier releases.  We apply the rolemap
step again to avoid accidentally missing it.
2017-01-14 17:58:48 +01:00
Gil Forcada
26a21a12d5 Reindex comments when they are modified 2016-09-20 13:05:24 +02:00
Maurits van Rees
358ec89c03 Apply security hotfix 20160830 for redirects. 2016-09-19 17:10:10 +02:00
Maurits van Rees
6952923b1e Reset the required setting of the author_email widget each time.
Otherwise, the email field might get set to required when an anonymous
user visits, and then remain required when an authenticated user
visits, making it impossible for an authenticated user to fill in the
form without validation error.  Or when in the control panel the field
is set as not required anymore, that change would have no effect until
the instance was restarted.
2016-06-10 01:57:04 +02:00
Tom Gross
085567431f Make tests work with lxml safe html cleaner (#97)
* Make tests work with lxml safe html cleaner

* whitespace fix in test assertion
2016-05-31 11:41:34 +02:00