Commit Graph

429 Commits

Author SHA1 Message Date
vangheem 4bd649e021 fix test 2015-05-30 19:28:22 -05:00
Low Kian Seong da84d4d642 Fixing broken test on travis 2015-05-13 20:03:11 +08:00
vangheem 1a04b5b042 fix test failures with csrf protection and locking behavior 2015-05-08 12:06:29 -05:00
Gil Forcada dcb2a5f51b 2 spaces between top level classes 2015-05-03 08:43:22 +02:00
Gil Forcada 8410b7525f Do not redefine comment 2015-05-03 08:42:52 +02:00
Gil Forcada 754e712372 Typo 2015-05-03 08:42:07 +02:00
Gil Forcada ce48a9ed46 2 spaces before inline comment 2015-05-03 08:41:56 +02:00
Gil Forcada fad5a96129 Unused variable 2015-05-03 08:27:21 +02:00
Gil Forcada 411f36e708 One argument per line 2015-05-03 08:27:03 +02:00
Gil Forcada 2baafcbfd8 Typo 2015-05-03 08:25:19 +02:00
Gil Forcada 9066183ea9 2 lines between top level functions/classes 2015-05-03 08:24:08 +02:00
Gil Forcada 4bc77a2831 Sort imports
Remove unused ones as well.
2015-05-03 08:16:41 +02:00
David Glick 8690461ffb create doc1 in the text fixture rather than in setup for each test 2015-03-09 21:51:45 -07:00
Gil Forcada 4ea41aba43 Fix tests 2015-02-16 16:35:43 +01:00
Timo Stollenwerk 5f1a7fb5bc Merge branch 'master' into plip10359-z3cform
Conflicts:
	CHANGES.rst
2015-01-29 21:31:45 +01:00
Timo Stollenwerk c852609111 Merge branch 'master' into delete-own-comments
Conflicts:
	CHANGES.rst
2015-01-29 21:14:05 +01:00
Timo Stollenwerk 785bc7b890 Read mail settings from new (Plone 5) registry. 2014-12-13 16:20:08 +01:00
Vincent Fretin acacc8281a add a test for delete-own-comment view 2014-09-20 16:21:55 +02:00
Vincent Fretin 2a8082cfa7 add delete_own_comment_enabled option in control panel 2014-09-20 16:02:48 +02:00
Vincent Fretin 42d12200a7 Don't use session at all for content rules, set the event in the request to be able to access comment attributes. This fixes 'InvalidObjectReference: A new object is reachable from multiple databases.' if comment contains a RichTextValue which contains a RawValueHolder (persistent object). 2014-09-20 14:54:02 +02:00
Vincent Fretin ee28528f55 Don't use session at all for content rules, set the event in the request to be able to access comment attributes. This fixes 'InvalidObjectReference: A new object is reachable from multiple databases.' if comment contains a RichTextValue which contains a RawValueHolder (persistent object). 2014-09-20 14:14:19 +02:00
Gil Forcada fa127ad85c Whitespaces cleanup 2014-08-23 00:31:28 +02:00
Andrea Cecchi 4f255a355d rebased CHANGES and tests 2014-05-15 17:51:22 +02:00
Andrea Cecchi e453e0050b fixed HISTORY and add delete test to test_comments_viewlet 2014-05-15 17:51:22 +02:00
Andrea Cecchi 9a4e3718fc added Delete comments permission to manage comments deletion 2014-05-15 17:51:05 +02:00
Andrea Cecchi fd16144b9b fixed edit test 2014-05-15 17:51:05 +02:00
Andrea Cecchi 3711d2fb5f rebased branch from master 2014-05-15 17:51:05 +02:00
Guido A.J. Stevens 520b1e83f4 provide "delete own comments" as a configurable option 2014-05-15 17:50:32 +02:00
Guido A.J. Stevens a82352a36c Make comments editable 2014-05-15 17:50:32 +02:00
Timo Stollenwerk 2b18d5a2e4 Revert "Merge pull request #38 from delib/evilbungle-comment-acquisition"
This reverts commit e18598e316, reversing
changes made to fd6ac0788b.

This pull request introduces two test failures. See http://jenkins.plone.org/job/plone-5.0-python-2.7/lastCompletedBuild/testReport/ for details.
2014-05-13 07:07:37 +02:00
Timo Stollenwerk e18598e316 Merge pull request #38 from delib/evilbungle-comment-acquisition
Fixing incorrect behaviour with acquired permissions
2014-05-12 22:53:34 +02:00
Alin Voinea fe91d7801e Add tests for custom events and contentrules events/string substitutions 2014-05-12 20:20:18 +03:00
tisto 22ed06b66d Add second robot test to test adding comments. 2014-05-02 13:42:19 +02:00
tisto f894d47d62 Add basic robot test setup and a first test. 2014-05-02 13:22:08 +02:00
Jens W. Klein 6609ab6af5 make flake8 happy 2014-03-25 18:38:12 +01:00
Jens W. Klein a145413ac2 make flake8 happy 2014-03-25 18:37:06 +01:00
Jens W. Klein 67213b70eb make flake8 happy 2014-03-25 18:36:14 +01:00
tisto 9c9c2e2aaa Merge branch 'master' of git://github.com/huubbouma/plone.app.discussion into huubbouma-master
Conflicts:
	CHANGES.rst
2014-03-23 18:54:44 +01:00
maartenkling 0ea9a7131f merge upstream and fix numbering 2014-03-04 09:16:36 +01:00
Philip Bauer d788d07a87 fix test. the richtext-field in plone.app.contenttypes uses a behavior 2014-02-14 09:40:55 +01:00
maartenkling 8ccd648928 user member.getId as author_username, so membrane users and plone users have portraits and author urls 2014-02-02 14:55:37 +01:00
Timo Stollenwerk a8dc5dd3f0 Remove test_suite functions since they are only needed for zope.testing < 3.8.0. 2013-12-19 09:54:03 +01:00
tisto a2ae2a888f Remov qunit and jstestdriver test setup. 2013-12-15 12:56:51 +01:00
tisto f0a9d9ad6b Pep8 2013-12-15 12:02:32 +01:00
Alan Hoey e6ec6ebe16 Add tests to confirm that some methods of a conversation incorrectly use an unwrapped comment to determine whether anonymous users can view. 2013-11-25 12:52:31 +00:00
Alan Hoey 4804868ab2 Refactor acquisition tests to define the expected behaviour when dealing with wrapped and unwrapped comments. 2013-11-25 12:06:05 +00:00
vmaksymiv 8e56b99638 added test acquisition chain for unwrapped object
Conflicts:
	plone/app/discussion/tests/test_acquisition.py
2013-11-21 17:23:36 +00:00
Kees Hink 5fb6968fca Add a test for Acquisition in comments. 2013-11-21 17:22:12 +00:00
David Glick 7cfbd20d72 don't fail test if portal_atct is missing 2013-11-15 00:11:13 -08:00
Timo Stollenwerk 654869a30d Remove old topic test. New collections are tested in p.a.contenttypes anyways. 2013-11-14 11:01:14 +01:00
Benoît Suttor c3ce01edd0 Use defaultUser.png instead of defaultUser.gif
Indeed, defaultUser.gif is in a deprecated skins folder (Products/CMFPlone/
skins/plone_deprecated/defaultUser.gif) and not defaultUser.png
(Products/CMFPlone/skins/plone_images/defaultUser.png).
Test is also updated.
2013-11-13 15:53:12 +01:00
maartenkling c45650261e Rename @@discussion-settings to @@discussion-controlpanel 2013-11-12 10:45:59 +01:00
JeanMichel FRANCOIS 410b8c998a Fix ownership of comments. 2013-11-05 10:23:15 +01:00
tisto e7cae8430a Replace deprecated test assert statements. 2013-10-10 16:29:15 +02:00
tisto fbc78e2951 Remove portal_discussion tool. 2013-10-10 15:36:18 +02:00
Huub Bouma fd85de9c30 Fix comments Title if utf-8 characters in author_name 2013-09-20 16:28:05 +02:00
Timo Stollenwerk 9049368cba Refactor tests to use the PLONE_APP_CONTENTTYPES_FIXTURE instead of the PLONE_FIXTURE. This fixes all test p.a.discussion test failures. 2013-08-29 22:20:47 +02:00
Andreas Zeidler b027789391 prevent the viewlet from raising an error for objects that are not annotatable 2013-08-15 00:01:22 +02:00
Paul J Stevens 52c6372664 fix deprecation warning 2013-06-04 13:23:22 +00:00
Kees Hink fd9d0a0eba Revert "Add a test for permission Acquisition on comments."
This reverts commit 66d355544f.
2013-05-10 13:39:02 +02:00
Kees Hink 6d5c193d8c Revert "Move application of custom workflow to test_acquisition.py..."
This reverts commit 6e9b32254e.
2013-05-10 13:38:46 +02:00
Kees Hink 6e9b32254e Move application of custom workflow to test_acquisition.py...
...so it doesn't interfere with other test in the layer.
2013-05-10 13:26:30 +02:00
Kees Hink 66d355544f Add a test for permission Acquisition on comments.
We use a different workflow for comments:
The View permission is acquired instead of given explicitly,
as outlined in https://dev.plone.org/ticket/12531.
2013-05-10 13:18:58 +02:00
Timo Stollenwerk e2a43aefb6 Remove testbrowser dump. 2013-04-22 14:55:04 +02:00
Timo Stollenwerk 849299f233 Pep8. 2013-04-18 15:21:00 +02:00
Timo Stollenwerk 20935da608 Pep8. 2013-04-17 19:37:10 +02:00
Timo Stollenwerk 29fe4bbec7 Pep8. 2013-04-17 19:34:17 +02:00
Timo Stollenwerk b4c22e90bf Pep8. 2013-04-17 19:27:30 +02:00
Timo Stollenwerk 943065c15f Pep8. 2013-04-17 19:07:40 +02:00
Timo Stollenwerk dcb2d3e7d4 Pep8 2013-04-17 19:04:45 +02:00
Timo Stollenwerk 628f72ea0b Pep8. 2013-04-17 14:24:39 +02:00
Patrick Gerken 05f0e7e4d8 Many updates to handle non public comments properly 2013-03-28 14:28:22 +01:00
bdbaddog 6f675b6f80 Merge pull request #23 from bdbaddog/fix_comment_user_migration
fix migration of author_name and author_username
2013-02-11 10:20:41 -08:00
Timo Stollenwerk a6afdf265c Pep8 2013-01-10 18:40:04 +01:00
Timo Stollenwerk 69b628c386 Pep8. 2013-01-10 18:33:46 +01:00
William Deegan 372b573cb1 move creation of test user to test setup, rather than just in the new test_migrate_comment_with_creator() method 2012-12-15 16:45:56 -08:00
William Deegan ff1f65a75e simplify some of the logic and get some tests in place to cover them. TDB: test against actual site to ensure the changes to the logic don't break a real environment, but still work with the tests.. 2012-12-13 21:14:40 -08:00
Kees Hink e57d3a2ad4 Convert test for invalid comment id in url to integration test. 2012-11-16 10:29:50 +01:00
Kees Hink 6bd31ad490 Make conversation view not break when comment-id cannot be converted to long, fixes #13327 2012-11-14 13:25:10 +01:00
Timo Stollenwerk 41a53fc8ff Fix failing test. 2012-11-04 17:18:46 +01:00
Gaudenz Steinlin 56b08b2247 Fix catalog updates for IObjectMovedEvent
If comments were moved because an object on a higher level than the
commented object was moved, these comments were wrongly reindexed.
The commented object also got a wrong __parent__ pointer.

This fixes https://dev.plone.org/ticket/13172.
2012-09-17 16:52:05 +02:00
David Glick 58b4205f38 Revert "Attempt to fix test_format_time()."
This reverts commit c231794940.
2012-08-02 22:21:26 -07:00
David Glick 7fe9f062e8 Revert "Update master"
This reverts commit 53ec8e52ea.
2012-08-02 22:21:19 -07:00
Karl Johan Kleist 53ec8e52ea Update master 2012-07-18 06:58:17 +03:00
Karl Johan Kleist c231794940 Attempt to fix test_format_time(). 2012-07-18 06:56:14 +03:00
Timo Stollenwerk 528e1a1434 Run ConversationTest for dexterity types only if dexterity is installed. 2012-07-12 18:56:10 +02:00
Timo Stollenwerk 103c7323e7 Fix test that fails due to the creator/author_name changes. 2012-07-12 17:29:05 +02:00
Timo Stollenwerk a6a48a58dd Fix test that fails due to the css id changes due to comment text field. 2012-07-12 17:28:12 +02:00
Timo Stollenwerk c47689af42 Fix handling of comments with invalid transforms. Write an error msg to the log and just return the untransformed text. 2012-07-12 16:03:02 +02:00
Timo Stollenwerk 702f7e1f1d Make 'text/plain' the default mime type for comments and make sure the default type is set properly when creating a new comment. 2012-07-12 16:01:07 +02:00
Timo Stollenwerk f45373b311 Test for mime type transformation from html to html added. 2012-07-12 15:54:38 +02:00
Timo Stollenwerk 0535e659ff Refactor the comment creator/author_name to comply with the Plone core convention to store the username on the creator attribute and not the fullname. 2012-07-12 15:39:27 +02:00
Timo Stollenwerk f45a2e8bba Replace deprecated unit test methods. 2012-07-12 15:08:22 +02:00
Karl Johan Kleist 636e77e3b2 Reverting, as per Timo's comment in 49734cd39b (commitcomment-1559057).
So Jenkins is running the tests using the en-US locale?
2012-07-10 10:56:56 +03:00
Karl Johan Kleist 49734cd39b Fallback for localized time is now ISO style.
https://jenkins.plone.org/job/plone-4.3-tests/89/testReport/junit/plone.app.discussion.tests.test_comments_viewlet/TestCommentsViewlet/test_format_time/
2012-07-07 11:58:46 +03:00
Timo Stollenwerk 0e587a7d85 Support for Dexterity added. 2012-06-30 10:59:49 +02:00
Paul J Stevens 53428fe5f6 total_comments only counts published comments
Also migrate workflow state during migration.
2012-06-13 11:17:22 +00:00
Paul J Stevens e31f90c440 Prune duplicated test code 2012-06-12 14:44:42 +00:00
Timo Stollenwerk f66d6e1c05 Make topic/collection tests pass when plone.app.collection is installed. 2012-04-02 22:00:27 +02:00
Timo Stollenwerk 4d330f2daa Make comment collection tests work with plone.app.collection. 2012-03-31 18:40:58 +02:00