Commit Graph

1346 Commits

Author SHA1 Message Date
Maurits van Rees
d39b2fcbbe
Merge pull request #166 from plone/moderation-extended
Extended Moderation of comments
2020-03-16 23:18:14 +01:00
tschorr
bf41101c86 fix test for Plone > 5; deprecate Plone < 5 2020-02-11 18:49:57 +01:00
Katja Suess
61545c6ef6 Moderation on commented page also with ajax like on moderation view 2020-01-21 12:02:09 +01:00
Katja Suess
f7ae6e49a5 unique css ids
and bug fix test: editing comment: button label "save" instead of "edit comment"
2020-01-16 15:32:46 +01:00
Katja Suess
6794d95f85 Translation: label for save button on edit form 2020-01-14 16:26:32 +01:00
Katja Suess
9b1eb6834b Upgrade step added
Upgrade applies workflow changes to existing instances
2020-01-14 15:59:05 +01:00
Katja Suess
64093660ac Style: Filter by review state: more space between options 2020-01-14 14:05:36 +01:00
Katja Suess
812b28d846 clean up 2020-01-13 11:23:58 +01:00
Katja Suess
336808bfa9 Update metadata.xml 2020-01-13 11:23:48 +01:00
Katja Suess
dde8640fc5 Update test_comments_viewlet.py 2020-01-11 11:43:35 +01:00
Katja Suess
c1ec431769 extended existing review workflow by stati 'rejected' and 'spam'
removed addional third workflow
2020-01-08 12:42:03 +01:00
Katja Suess
f777315da3 moderation view: get last transition entry faster
get it from @@contenthistorypopup instead from @@historyview
2020-01-08 12:41:06 +01:00
Katja Suess
96e0fb83c0 last transition entry as is from history 2020-01-08 12:41:06 +01:00
Katja Suess
54de9b32e1 Update test_moderation.robot 2020-01-08 12:41:06 +01:00
Katja Suess
dfc21d1d5d comment "approved" renamed to "published" 2020-01-08 12:41:06 +01:00
Katja Suess
30490412ab batch navigation: reload on filtering by review_state 2020-01-08 12:39:58 +01:00
Katja Suess
bf20752b69 bulk moderation of comments
extended for comment_multiple_state_review_workflow, refactoring and tests
2020-01-08 12:39:57 +01:00
Katja Suess
d93525ff27 Moderation view: filter on state only for comment_multiple_state_review_workflow 2020-01-08 12:37:34 +01:00
Katja Suess
7a680675be disable portlet slots 2020-01-08 12:37:34 +01:00
Katja Suess
64d50fbd00 fix docstring 2020-01-08 12:37:34 +01:00
Katja Suess
084d2893e7 Additional (optional) workflow: "Comment Multiple State Review Workflow"
Moderator is not forced to delete a comment or to let it pending:
Workflow has two more states "rejected" and "spam" to existing review workflow.
Moderation view extended showing all states. Filter by state.
2020-01-08 12:36:28 +01:00
Katja Suess
f7b8335d27 additional workflow with rejected state
moderation view and approved comments view: buttons for reject and approve
2020-01-08 12:22:09 +01:00
Katja Suess
875409daff Moderation view tabbed
two tabs for comments to moderate and comments approved
2020-01-08 12:22:09 +01:00
Katja Suess
ee6b107a31 publish only pending comment, else show status message 2020-01-08 12:22:09 +01:00
Katja Suess
7b43d80486 test_notifications moderator 2019-12-02 09:09:49 +01:00
Katja Suess
296d591856 Update moderation.py
unused IDisableCSRFProtection removed
2019-12-01 19:53:11 +01:00
Katja Suess
3d3c638565 Notification moderator: email of commentator added. Link as is but request to log in for moderating comment added.
New moderator notification with email and link to commented page and request to login.
No links to approve and delete: due to CSRF direct links to modification of Plone objects result in request to confirm. So page with comments is presented to moderator.
If already logged in, moderator is on comment to moderate.
If not logged in, moderator is on login page with came_from.
2019-12-01 19:47:08 +01:00
Katja Suess
1e5951101f prevent infinite request for confirmation (plone.protect) 2019-11-29 16:23:43 +01:00
Katja Suess
8bd1992a7f IDisableCSRFProtection on @@moderate-publish-comment removed 2019-11-29 16:23:43 +01:00
Katja Suess
22a7152e92 publish only pending comment, else show status message 2019-11-29 16:23:43 +01:00
Jens W. Klein
06c55bec14
Merge pull request #156 from plone/roto-window-resize-huge
Default to a 4K x 4K browser window in Robot tests
2019-10-30 11:12:07 +01:00
Maurits van Rees
d09794d7e8
Load zcml of plone.resource.
This is for our use of the `plone:static` directive.
See https://github.com/plone/Products.CMFPlone/issues/2952
2019-09-28 13:01:11 +02:00
Katja Suess
1b7d9fcb16 Additional view for approved comments
linked in "moderate comments" view
2019-09-07 11:31:53 +02:00
Philip Bauer
c229e51690 add upgrade-step to re-enable comments.js 2019-06-27 19:59:20 +02:00
Philip Bauer
4966d8388e add plone.resource dependency and change to plone:static 2019-06-27 19:43:27 +02:00
Philip Bauer
f39a7551f6 Registrr old js in legacy bundle (same as in p.a.event) 2019-06-24 08:43:27 +02:00
Joni Orponen
c1518d87d1 Re-enable two disabled Robot tests. 2019-05-14 10:40:09 +02:00
Joni Orponen
45fd2c51ce Use the shared test setup and test teardown keywords in Robot tests. 2019-05-14 10:37:15 +02:00
Jens W. Klein
df09fc2d59 fix import with deprecation warning 2019-04-12 11:40:56 +02:00
Gil Forcada
f217a42932
index/reindex/unindex the object itself
Do not defer to p.a.discussion own tool.

That's needed so that collective.indexing can patch comments,
so in turn can be indexed by Solr.
2019-03-21 08:57:08 +01:00
Jens W. Klein
afa48be877 Do not depend on the meta_type metadata in the catalog 2019-02-04 16:04:54 +01:00
nzambello
4973670ea1 [a11y] Added role attribute for portalMessage 2018-12-24 13:24:56 +01:00
Filippo Campi
0336d0f7c9 [doc][fix] updated CHANGES + changed the method to wait for page to load 2018-10-25 23:34:21 +02:00
Filippo Campi
c61da98dac Merge branch 'master' into filippo_moderation_js 2018-10-25 00:32:28 +02:00
Filippo Campi
7bd62fa1cb Changes NotifyOnDelete to CommentDeletedEvent and NotifyOnPublish to CommentPublishedEvent for respect naming of event and interface 2018-10-24 16:49:22 +02:00
Filippo Campi
65b187ea53 Added comment to try/except on import of IConfigurationChangedEvent 2018-10-24 16:46:50 +02:00
Filippo Campi
671f0cc796 Removed change from .load to .ready, I'll create another PR 2018-10-24 16:43:38 +02:00
Filippo Campi
6fed2ad760 [dev] added conditional import for some version of Products.CMFPlone 2018-09-28 16:51:52 +02:00
Jens W. Klein
6cf6bf25f2 fix test in py3 2018-09-28 14:22:51 +02:00
Filippo Campi
36f0e03805 [dev] added event for comment delete, comment publication + notify for events 2018-09-27 11:26:41 +02:00
Filippo Campi
3648c3345f merge master in filippo_moderation_js 2018-09-25 16:31:09 +02:00
Philip Bauer
9e7448a049 fix test 2018-09-21 13:38:09 +02:00
Philip Bauer
08b6db8b67 fix test in py3 2018-09-20 18:31:23 +02:00
hvelarde
c6d1f832da Fix old-division 2018-09-18 15:13:38 +02:00
Philip Bauer
95861b28d5 fix tests with py3 2018-09-18 15:13:38 +02:00
Philip Bauer
a8f2db58ff fix commenting in py3 2018-09-18 15:13:38 +02:00
Jens W. Klein
76f4f50160 get rid of plone.app.controlpanel dependencies 2018-08-08 13:46:16 +02:00
Jens W. Klein
fa7ee67be4 Revert "get rid of plone.app.controlpanel dependencies"
This reverts commit 64529715ee.
2018-08-08 12:36:01 +02:00
Jens W. Klein
64529715ee get rid of plone.app.controlpanel dependencies 2018-08-08 12:34:22 +02:00
Markus Hilbert
3c36af8ebc Fixed tests when IRichText behavior is used. 2018-07-11 12:35:46 +02:00
Filippo Campi
dfc6d0620b [fix] fix load of js in moderation.js 2018-06-27 15:31:07 +02:00
Jens W. Klein
58711579c4 isort 2018-06-15 10:22:11 +02:00
Jens W. Klein
bf0fa909b9 fix tests for plone.login merge 2018-06-15 10:14:51 +02:00
Philip Bauer
723ec8375b fix relative imports for py3 2018-03-21 21:43:58 +01:00
Philip Bauer
71dcbf8465 some py3 fixes 2018-03-18 17:01:27 +01:00
Philip Bauer
e4f798d9d3 make doctest syntax py3 compatible 2018-01-26 11:11:50 +01:00
Philip Bauer
93a227c80d Add Python 2 / 3 compatibility 2018-01-25 13:04:11 +01:00
David Glick
252b85e796 fix test layer ordering 2017-09-18 12:13:28 +02:00
Katja Süss
b08852baa0 some code-analysis reclamations fixed.
code-analysis OK up to: T100, S100, S101, C815, C812
2017-07-29 11:35:15 +02:00
Katja Süss
100690ccdf html nearer to conventions 2017-07-29 11:33:53 +02:00
Katja Süss
78abff152d Test 2017-07-28 19:12:49 +00:00
Katja Süss
fb7c68d5e5 Make moderation view changes less invasive. 2017-07-28 19:12:47 +00:00
Katja Süss
71205b552f Replaced tabs with soft tabs 2017-07-28 19:12:40 +00:00
Katja Süss
01473db9b9 added missing new line at the end of the file 2017-07-28 19:12:15 +00:00
Katja Süss
8e344cbf2b Show email in moderation view 2017-07-28 19:12:01 +00:00
Katja Süss
15cf0e6336 Removed dependency on plone.api. Following style guidelines: one import per line 2017-06-21 12:15:32 +02:00
Katja Süss
0fd9b02c80 Email validation 2017-06-20 15:16:19 +02:00
KUMAR AKSHAY
964dcea523 kakshay unittest (#121)
remove unittest2 dependency
2017-05-08 09:24:38 +02:00
KUMAR AKSHAY
fba905e465 removed "change portal events" permission
https://github.com/plone/Products.CMFPlone/issues/1975
2017-04-11 14:45:36 +05:30
Maurits van Rees
b5eebe0cc8 Fixed tests with newer testbrowser. 2017-02-04 16:58:38 +01:00
MrTango
bc2a9ac5d9 remove __of__ calls on views 2017-01-31 17:57:41 +01:00
Daniel Jowett
d2bba1d5ea Fix some easy pep8 issues 2017-01-24 10:59:43 +00:00
Daniel Jowett
6547486fd8 Improve English on a couple of field descriptions 2017-01-24 10:41:15 +00:00
Maurits van Rees
802e3ec04c Make comment on private content not publicly available in search results.
This is part of PloneHotfix20161129.

Updated metadata.xml version to 1000.  This leaves more room for
profile version increases in earlier releases.  We apply the rolemap
step again to avoid accidentally missing it.
2017-01-14 17:58:48 +01:00
Maurits van Rees
97477163be Moved all upgrade steps to upgrades.zcml.
Until now some were in configure.zcml and some in upgrades.zcml.
2017-01-10 18:18:52 +01:00
Gil Forcada
26a21a12d5 Reindex comments when they are modified 2016-09-20 13:05:24 +02:00
Maurits van Rees
358ec89c03 Apply security hotfix 20160830 for redirects. 2016-09-19 17:10:10 +02:00
TsungWei Hu
466ca149d3 Update Traditional Chinese Translation. 2016-09-10 07:30:47 +00:00
Gil Forcada
d5e7afcd23 Use zope.interface decorator
This not only makes code more pleasent to read,
but also makes the code python 3 compatible
(while maintaining python 2 compatibility).
2016-07-08 23:17:03 +02:00
Jens W. Klein
69ded592c3 Merge pull request #104 from plone/maurits-remove-migration
Removed `comment-migration` view.
2016-06-13 09:48:39 +02:00
Maurits van Rees
1e9909ab6f Split too complex _enabled_for_archetypes. 2016-06-12 06:51:41 +02:00
Maurits van Rees
d496dfdddc Split too complex handleComment. 2016-06-12 06:51:41 +02:00
Maurits van Rees
814af8d837 Various flake8 fixes.
- Removed tabs.
- Fixed E731 do not assign a lambda expression, use a def.
- avoid hasattr
2016-06-12 06:51:35 +02:00
Maurits van Rees
bfeb66ee60 Removed comment-migration view.
This did not work anymore on Plone 5.  If you still need to migrate
from old-style comments, so from Plone 4.0 or earlier, please upgrade
to Plone 4.3 first.
2016-06-11 15:56:31 +02:00
Maurits van Rees
6952923b1e Reset the required setting of the author_email widget each time.
Otherwise, the email field might get set to required when an anonymous
user visits, and then remain required when an authenticated user
visits, making it impossible for an authenticated user to fill in the
form without validation error.  Or when in the control panel the field
is set as not required anymore, that change would have no effect until
the instance was restarted.
2016-06-10 01:57:04 +02:00
Maurits van Rees
e1dbaef82a Fixed possible cross site scripting (XSS) attack on moderate comments page. 2016-06-03 00:43:21 +02:00
Tom Gross
085567431f Make tests work with lxml safe html cleaner (#97)
* Make tests work with lxml safe html cleaner

* whitespace fix in test assertion
2016-05-31 11:41:34 +02:00
Maurits van Rees
89d542e8d2 Apply hotfix 20160419 (#94)
Removed docstrings from some methods to avoid publishing them.
2016-05-04 10:40:36 +02:00
Gil Forcada Codinachs
eee8e3c1b6 Mark edit link for translation (#91)
Mark edit link for translation.
2016-04-07 18:36:19 +02:00
Johannes Raggam
ec7fe25b6c Use `getSite()` instead of portal url
For the discussion controlpanel, change base URLs from portal URL to what getSite returns, but don't change the controlpanels context binding.
This allows for more flexibility when configuring it to be allowed on a sub site with a local registry.
2016-03-11 14:16:22 +01:00