ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,891 Commits 1 Branch 0 Tags 5 MiB
ac1ac4ae4a
Commit Graph

38 Commits

Author SHA1 Message Date
Philip Bauer
71dcbf8465 some py3 fixes 2018-03-18 17:01:27 +01:00
Katja Süss
b08852baa0 some code-analysis reclamations fixed. 
code-analysis OK up to: T100, S100, S101, C815, C812
 2017-07-29 11:35:15 +02:00
Katja Süss
78abff152d Test 2017-07-28 19:12:49 +00:00
Gil Forcada
cb1bf28c16 Cleanup 
Follow https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst
to clean up the code.
 2016-02-05 09:43:42 +01:00
Gil Forcada
4bc77a2831 Sort imports 
Remove unused ones as well.
 2015-05-03 08:16:41 +02:00
Gil Forcada
d5b5b1c2cd Fix total_comments indexer 
"@property removes Acquisition wrappers from 'self'.
I don't remember why exactly (some implementation detail of Acquisition),
but it's a fact of life."

Quote from @davisagli on
https://github.com/plone/plone.app.discussion/pull/58

In short: removing the @property from total_comments fix the problem.
 2015-02-16 11:31:47 +01:00
Patrick Gerken
05f0e7e4d8 Many updates to handle non public comments properly 2013-03-28 14:28:22 +01:00
tisto
aa36c0bc9b Pep8 2012-01-14 07:41:50 +01:00
Timo Stollenwerk
f98b82b2d8 Make sure the catalog index for creator always stores encoded stings and not unicode since all strings in the catalog have to be utf-8 encoded strings. 
svn path=/plone.app.discussion/trunk/; revision=51435
 2011-07-25 08:12:04 +00:00
Timo Stollenwerk
1a6b1fdb91 Use Plone's safe_encode method instead of encode() to make sure unicode encoded strings can be indexed too. 
svn path=/plone.app.discussion/trunk/; revision=51432
 2011-07-25 06:47:45 +00:00
Timo Stollenwerk
b84211ddf0 Remove ImportError exceptions for Plone < 4.1 code and plone.z3cform < 0.6.0. 
svn path=/plone.app.discussion/trunk/; revision=49033
 2011-04-22 14:59:59 +00:00
Ross Patterson
cad670d6af Fax Missing.Value for Creator in the catalog. Fixes #11634. 
svn path=/plone.app.discussion/trunk/; revision=48838
 2011-04-14 19:59:05 +00:00
David Glick
636bca745c merge r47140, r47290, r47579 from davisagli-features: fix timezone handling when migrating legacy comments and when indexing 
svn path=/plone.app.discussion/trunk/; revision=48358
 2011-04-02 21:26:36 +00:00
David Glick
eb004aab44 merge r46437 and r46946 from davisagli-features: respect the per-comment mime_type setting, and use the old cooked text/html from legacy comments when migrating 
svn path=/plone.app.discussion/trunk/; revision=48356
 2011-04-02 19:51:37 +00:00
David Glick
0cb75778ba make sure comments don't get indexed with their parents' UID in Plone 3. only declare dependency on plone.app.uuid in Python 2.6, since we only use it in Plone 4 currently. 
svn path=/plone.app.discussion/trunk/; revision=46353
 2010-12-15 20:39:55 +00:00
Timo Stollenwerk
f0cecaf274 Always set the effective date of a comment to the same value as the creation date. 
svn path=/plone.app.discussion/trunk/; revision=46019
 2010-11-29 17:36:52 +00:00
Yiorgis Gozadinos
ab00fa3d99 Make the creator indexer return utf-8 to the catalog. 
svn path=/plone.app.discussion/trunk/; revision=45735
 2010-11-10 10:06:20 +00:00
Timo Stollenwerk
f67c7cde6d Remove title field from the comment form and replace it with an auto-generated title ("John Doe on Welcome to Plone"). 
This also fixes http://dev.plone.org/plone/ticket/11098

svn path=/plone.app.discussion/trunk/; revision=40431
 2010-09-29 07:56:36 +00:00
Timo Stollenwerk
aeabd6fc11 Ignore certain lines for code coverage. 
svn path=/plone.app.discussion/trunk/; revision=40081
 2010-09-20 10:02:07 +00:00
Timo Stollenwerk
946ff36190 "W0622 total_comments: Redefining built-in 'object'" added to pylint msg ignores. 
svn path=/plone.app.discussion/trunk/; revision=39323
 2010-08-28 19:48:40 +00:00
Patrick Gerken
94e73b43a7 Catch TypeError in indexers if content can not be adapted 
Currently plone.app.discussion provides indexers
for IContentish. In these it tries to adapt
the content object to IDiscussion. But an IDiscussion Factory is only
provided for IAnnotatable.
The Criteria are IContentish but not IAnnotatable.
Indexing them fails

svn path=/plone.app.discussion/trunk/; revision=38182
 2010-07-21 23:36:16 +00:00
Timo Stollenwerk
1ea36d7d82 Conversation indexers won't work on old discussion items. Fix tests. 
svn path=/plone.app.discussion/trunk/; revision=30658
 2009-10-17 08:28:50 +00:00
Timo Stollenwerk
e5f1a70de6 Make unit tests pass with Plone 3.3 again. Migration tests still failing. 
svn path=/plone.app.discussion/trunk/; revision=30633
 2009-10-16 12:11:58 +00:00
Hanno Schlichting
71ed707794 Get this running again for the most part under Plone 4.0 - the main trick was probably to use the new CMFCatalogAware class. Removed collective.testcaselayer dependency, as that broke totally. There's some test failures left, but indexing works in general. Maybe the custom indexing event handlers aren't all required anymore. The title_or_id test failure looks like there's an infinite loop in the __parent__ pointers never reaching the actual content object. This change breaks Plone 3.x compatibility for the moment. 
svn path=/plone.app.discussion/trunk/; revision=30629
 2009-10-16 00:42:08 +00:00
Timo Stollenwerk
a946fb54fa indexes for IComment added to override the IConversation indexes. 
svn path=/plone.app.discussion/trunk/; revision=27838
 2009-07-06 16:56:09 +00:00
Timo Stollenwerk
072f903c3a in_response_to metadata added. 
svn path=/plone.app.discussion/trunk/; revision=27789
 2009-07-03 08:03:09 +00:00
Timo Stollenwerk
47fd22f02e don't convert commentators to a set before converting it to a tuple, since the values are unique. 
svn path=/plone.app.discussion/trunk/; revision=27785
 2009-07-03 05:45:47 +00:00
Timo Stollenwerk
41010fb32a fix for "TypeError: can't pickle OIBTreeItems objects". 
svn path=/plone.app.discussion/trunk/; revision=27778
 2009-07-02 17:50:20 +00:00
Timo Stollenwerk
6647439971 indexers for commentators, number of comments, and latest comment added. 
svn path=/plone.app.discussion/trunk/; revision=27766
 2009-07-01 20:57:55 +00:00
Timo Stollenwerk
9e94afc072 fix description index for short comments. 
svn path=/plone.app.discussion/trunk/; revision=27764
 2009-07-01 10:01:37 +00:00
Timo Stollenwerk
a6a64bd3d6 rename all indexes from comment_XXX to XXX. clean up indexes test. 
svn path=/plone.app.discussion/trunk/; revision=27259
 2009-06-01 23:45:49 +00:00
Timo Stollenwerk
dc948da00b creator index added. 
svn path=/plone.app.discussion/trunk/; revision=27258
 2009-06-01 23:29:09 +00:00
Timo Stollenwerk
04bed35357 Indexes for created and modified added. 
svn path=/plone.app.discussion/trunk/; revision=27257
 2009-06-01 23:17:13 +00:00
Timo Stollenwerk
69334f6000 The comment_description index now returns the first 25 words of a comment. 
svn path=/plone.app.discussion/trunk/; revision=27252
 2009-06-01 09:59:07 +00:00
Timo Stollenwerk
d3ba4f58db Description index added. 
svn path=/plone.app.discussion/trunk/; revision=27251
 2009-05-31 19:07:35 +00:00
Timo Stollenwerk
ca7752714b remove comment_text index. 
svn path=/plone.app.discussion/trunk/; revision=27249
 2009-05-31 18:14:42 +00:00
Timo Stollenwerk
5f8acfd805 comment_title, comment_text, and comment_searchable_text indexes added. 
svn path=/plone.app.discussion/trunk/; revision=27247
 2009-05-31 17:55:46 +00:00
Martin Aspeli
6381b14763 check in some skeletal code + notes, nothing concrete or working yet 
svn path=/plone.app.discussion/trunk/; revision=26892
 2009-05-11 16:52:16 +00:00