ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
445 Commits 1 Branch 0 Tags 5 MiB
9b29be8473
Commit Graph

401 Commits

Author SHA1 Message Date
Timo Stollenwerk
94adf62566 do not show moderation message when user has manage rights. 
svn path=/plone.app.discussion/trunk/; revision=30997
 2009-10-31 16:42:04 +00:00
Timo Stollenwerk
7550e95d5c fix redirection after a comment has been added. 
svn path=/plone.app.discussion/trunk/; revision=30986
 2009-10-31 12:33:59 +00:00
Timo Stollenwerk
58f8f4bf22 Do not show "publish" bulk action in moderation view when moderation is disabled. Fix story 1105355 
.

svn path=/plone.app.discussion/trunk/; revision=30678
 2009-10-18 13:12:52 +00:00
Timo Stollenwerk
3e75eedca8 KNOWN_ISSUES.txt removed. 
svn path=/plone.app.discussion/trunk/; revision=30671
 2009-10-17 16:34:58 +00:00
Timo Stollenwerk
c9a5070681 Adding Persistent to subclasses of comment - this fixes five.intid choking on Comments in the catalog on reinstall. evilbungle branch merge. 
svn path=/plone.app.discussion/trunk/; revision=30670
 2009-10-17 16:29:45 +00:00
Timo Stollenwerk
8db9c8c175 Removing hard coded publish action. evilbungle branch merge. 
svn path=/plone.app.discussion/trunk/; revision=30669
 2009-10-17 16:14:44 +00:00
Timo Stollenwerk
7ef2672e5c Making captcha validator only adapt for the appropriate browser layer. This fixes the captcha error issue when p.a.d is in a deployment but not installed yet. evilbungle branch merge. 
svn path=/plone.app.discussion/trunk/; revision=30667
 2009-10-17 14:13:27 +00:00
Timo Stollenwerk
7cd9ef2491 Changing browser:view registrations to browser:page since view doesn't actually do anything with the permissions. This fixes the anyone can delete comments problem. evilbungle branch merge. 
svn path=/plone.app.discussion/trunk/; revision=30665
 2009-10-17 13:50:55 +00:00
Timo Stollenwerk
78d547daa6 Replacing infinite-recursion happy traverse_parent_folders method with one based on aq_chain; evilbungle branch merge. 
svn path=/plone.app.discussion/trunk/; revision=30660
 2009-10-17 09:33:58 +00:00
Timo Stollenwerk
60b6196736 Show info message after adding a comment when moderation is enabled. 
svn path=/plone.app.discussion/trunk/; revision=30659
 2009-10-17 09:17:13 +00:00
Timo Stollenwerk
1ea36d7d82 Conversation indexers won't work on old discussion items. Fix tests. 
svn path=/plone.app.discussion/trunk/; revision=30658
 2009-10-17 08:28:50 +00:00
Timo Stollenwerk
e5f1a70de6 Make unit tests pass with Plone 3.3 again. Migration tests still failing. 
svn path=/plone.app.discussion/trunk/; revision=30633
 2009-10-16 12:11:58 +00:00
Hanno Schlichting
6e8f812eee Duh, I wanted the new CatalogAware without the OpaqueItemManager base, not the old CMFCatalogAware 
svn path=/plone.app.discussion/trunk/; revision=30630
 2009-10-16 00:51:58 +00:00
Hanno Schlichting
71ed707794 Get this running again for the most part under Plone 4.0 - the main trick was probably to use the new CMFCatalogAware class. Removed collective.testcaselayer dependency, as that broke totally. There's some test failures left, but indexing works in general. Maybe the custom indexing event handlers aren't all required anymore. The title_or_id test failure looks like there's an infinite loop in the __parent__ pointers never reaching the actual content object. This change breaks Plone 3.x compatibility for the moment. 
svn path=/plone.app.discussion/trunk/; revision=30629
 2009-10-16 00:42:08 +00:00
Timo Stollenwerk
c19feeab6e remove clear-and-rebuild catalog from known issues and todo. 
svn path=/plone.app.discussion/trunk/; revision=30612
 2009-10-15 10:45:35 +00:00
Timo Stollenwerk
f4a4b6e370 fix catalog clear-and-rebuild. this finally fixes story 847941. 
svn path=/plone.app.discussion/trunk/; revision=30610
 2009-10-15 10:11:12 +00:00
Timo Stollenwerk
9befc4c651 Monkey patch for clear-and-rebuild catalog added. This fixes story 847941. Nested comments are not reindexed yet. 
svn path=/plone.app.discussion/trunk/; revision=30574
 2009-10-14 14:58:08 +00:00
Timo Stollenwerk
83b631413a revert r30055, since p.a.d. will not become part of Plone 4. 
svn path=/plone.app.discussion/trunk/; revision=30462
 2009-10-12 18:46:03 +00:00
Timo Stollenwerk
b09d42e505 fix has_replies function when get_replies returns None. 
svn path=/plone.app.discussion/trunk/; revision=30256
 2009-10-07 20:50:01 +00:00
Timo Stollenwerk
f0cbc787ab has_replies function added to get only published comments for anon users. elro review fix. refs #9288 
svn path=/plone.app.discussion/trunk/; revision=30252
 2009-10-07 20:07:55 +00:00
Timo Stollenwerk
6daa8824fb Hide the editable-object border in moderation view. elro review fix. refs #9288 
svn path=/plone.app.discussion/trunk/; revision=30244
 2009-10-07 11:52:44 +00:00
Timo Stollenwerk
f9115d6f87 "comment objects are not indexed with Plone 4" added to known issues. 
svn path=/plone.app.discussion/trunk/; revision=30087
 2009-09-30 21:10:36 +00:00
Timo Stollenwerk
9adff9e869 comment out monkey patch of plone.app.vocabularies for now. 
svn path=/plone.app.discussion/trunk/; revision=30055
 2009-09-30 11:21:15 +00:00
Timo Stollenwerk
aae633cb26 update TODO.txt. 
svn path=/plone.app.discussion/trunk/; revision=29626
 2009-09-09 15:17:47 +00:00
Timo Stollenwerk
5a8e1eed93 Fix "insufficient privileges" bug reported by elro. 
svn path=/plone.app.discussion/trunk/; revision=29624
 2009-09-09 14:48:19 +00:00
Timo Stollenwerk
a6cc6c6fcb fix story 1109910. Tabs in moderation view have a margin. 
svn path=/plone.app.discussion/trunk/; revision=29461
 2009-08-29 16:23:54 +00:00
Timo Stollenwerk
9aaf24e247 Fix story 1140047. Comment text wraps around commenter image. 
svn path=/plone.app.discussion/trunk/; revision=29457
 2009-08-28 21:21:54 +00:00
Timo Stollenwerk
a69f2baf01 remove unnecessary discussion-check utility code. 
svn path=/plone.app.discussion/trunk/; revision=29436
 2009-08-28 13:34:45 +00:00
Timo Stollenwerk
96e2899955 hide the email field for now. we keep the field for integrators or later use. 
svn path=/plone.app.discussion/trunk/; revision=29435
 2009-08-28 13:12:14 +00:00
Timo Stollenwerk
48ab88a8b4 code cleanup; 
reply to comment button and handler removed; 
reply-to-comment is now handled by the comment handler as well;
this also solves story 1173673;

svn path=/plone.app.discussion/trunk/; revision=29434
 2009-08-28 13:03:16 +00:00
Timo Stollenwerk
1747a3655b fix recaptcha reply-to-comment form bug. 
svn path=/plone.app.discussion/trunk/; revision=29433
 2009-08-28 12:03:34 +00:00
Timo Stollenwerk
f7f10a5572 fix that conversation.enabled wasn't called. evilbungle fix. 
svn path=/plone.app.discussion/trunk/; revision=29432
 2009-08-28 11:39:02 +00:00
Timo Stollenwerk
1c3aa5e9b5 call WrongReCaptchaCode validator for recaptcha. 
svn path=/plone.app.discussion/trunk/; revision=29428
 2009-08-28 08:32:20 +00:00
Timo Stollenwerk
5cf3510dd9 import (re)captcha message factory for (re)captcha validation error. this fixes the strange type error. 
svn path=/plone.app.discussion/trunk/; revision=29427
 2009-08-28 08:28:58 +00:00
Timo Stollenwerk
72ac358c4c fix reply-to-comment form buttons. 
svn path=/plone.app.discussion/trunk/; revision=29405
 2009-08-26 22:31:23 +00:00
Timo Stollenwerk
8e406ccf2d remove "display: inline" CSS from reply-button; show reply-button only when JS is enabled. 
svn path=/plone.app.discussion/trunk/; revision=29404
 2009-08-26 21:55:27 +00:00
Timo Stollenwerk
defb4b91c4 hide reply and cancel button with css when JS is disabled. 
svn path=/plone.app.discussion/trunk/; revision=29403
 2009-08-26 21:53:34 +00:00
Timo Stollenwerk
d2ceb44a0c fixed IE errors. merge r29394 from evilbungle-safe-html branch. 
svn path=/plone.app.discussion/trunk/; revision=29398
 2009-08-26 15:05:58 +00:00
Timo Stollenwerk
9d5453b1da Modifying permissions so reviewers can moderate/remove comments. evilbungle branch r29364. 
svn path=/plone.app.discussion/trunk/; revision=29384
 2009-08-26 08:59:50 +00:00
Timo Stollenwerk
8b9a3e63c9 replace data.has_key() with "key in data". 
svn path=/plone.app.discussion/trunk/; revision=29342
 2009-08-24 18:09:32 +00:00
Timo Stollenwerk
c83d826c46 Making captcha validator only adapt for the appropriate browser layer. This fixes the captcha error issue when p.a.d is in a deployment but not installed yet. 
Merge from r29239 from evilbungle-safe-html branch.

svn path=/plone.app.discussion/trunk/; revision=29248
 2009-08-21 21:15:13 +00:00
Timo Stollenwerk
9c3bdb3a72 Stopping comments being rendered as structure; 
Merge r29173 from evilbungle-safe-html branch.

svn path=/plone.app.discussion/trunk/; revision=29246
 2009-08-21 20:52:12 +00:00
Timo Stollenwerk
8c9a8b9f93 remove limit on zcatalog query for comments. 
svn path=/plone.app.discussion/trunk/; revision=29244
 2009-08-21 19:53:04 +00:00
Carsten Senger
241c17df72 move the access of reply/Creator into a nested tag. tal:defines are 
evaluated before tal:condition so we may have no permission to access
Creator.

svn path=/plone.app.discussion/trunk/; revision=29207
 2009-08-20 02:21:23 +00:00
Carsten Senger
c145378f34 Allways use an accessor method on the comment, never access the 
attribute directly as the attribute is not acquisition wrapped 
and a permission check for the required permission will fail

svn path=/plone.app.discussion/trunk/; revision=29205
 2009-08-20 02:17:02 +00:00
Carsten Senger
984a1fed7d Zope 2.12 compatibility: ViewPageTemplate's id property is read only 
svn path=/plone.app.discussion/trunk/; revision=29203
 2009-08-20 02:11:57 +00:00
Carsten Senger
06b332a801 Compatibility with Zope 2.12: don't wrap the ViewPageTemplate into an acquisition wrapper. 
svn path=/plone.app.discussion/trunk/; revision=29201
 2009-08-20 02:09:53 +00:00
Carsten Senger
e946ef7979 Add an accessor method for title. As title is part of the interface 
IComment for which we <require> zope2.View a permission check will raise
Unauthorized cause we can not assure that the user's userfolder is in 
the acqusition chain of the object (the attribute is a bare unicode object).
It works for methods. im_self is used to get the acquisition wrapped
object.

svn path=/plone.app.discussion/trunk/; revision=29199
 2009-08-20 02:06:15 +00:00
Carsten Senger
4da4ab3599 import Event interfaces from where they are defined (also works in Zope 2.12) 
svn path=/plone.app.discussion/trunk/; revision=29187
 2009-08-19 22:16:06 +00:00
Timo Stollenwerk
775fc1572a Plone CSS classes added to buttons. 
svn path=/plone.app.discussion/trunk/; revision=29108
 2009-08-17 21:46:44 +00:00
Timo Stollenwerk
962e4dd0d3 autoresize css class added to comment-textarea. 
svn path=/plone.app.discussion/trunk/; revision=29104
 2009-08-17 20:31:37 +00:00
Timo Stollenwerk
ed4c6c411c Simplify comment form labels as suggested by jon. 
svn path=/plone.app.discussion/trunk/; revision=28979
 2009-08-16 08:38:42 +00:00
Timo Stollenwerk
09a88ff9fb todo update. 
svn path=/plone.app.discussion/trunk/; revision=28947
 2009-08-15 20:10:17 +00:00
Timo Stollenwerk
d889f2ed9a documentation update. 
svn path=/plone.app.discussion/trunk/; revision=28946
 2009-08-15 20:09:27 +00:00
Timo Stollenwerk
4a78ce44e0 fix captcha import; unit tests pass without p.f.captcha installed. 
svn path=/plone.app.discussion/trunk/; revision=28942
 2009-08-15 19:44:39 +00:00
Timo Stollenwerk
50de2b4031 fix discussion control panel description. 
svn path=/plone.app.discussion/trunk/; revision=28939
 2009-08-15 17:49:50 +00:00
Timo Stollenwerk
987805c927 fix inline validation for reply-to-comment form. 
svn path=/plone.app.discussion/trunk/; revision=28923
 2009-08-15 16:36:49 +00:00
Timo Stollenwerk
dbff6b4f67 add captcha check for reply-to-comment form. 
svn path=/plone.app.discussion/trunk/; revision=28922
 2009-08-15 16:36:35 +00:00
Timo Stollenwerk
bbf7cb5685 show captcha validation only for anonymous users. 
svn path=/plone.app.discussion/trunk/; revision=28902
 2009-08-15 11:35:54 +00:00
Timo Stollenwerk
2567483281 CaptchaValidator for captcha/recaptcha/no captcha added. This is necessary because the zcml registration of the CaptchaValidator has to work with all three options. 
svn path=/plone.app.discussion/trunk/; revision=28894
 2009-08-15 10:21:26 +00:00
Timo Stollenwerk
ead8813188 simplify (re)captcha test. 
svn path=/plone.app.discussion/trunk/; revision=28893
 2009-08-15 10:18:10 +00:00
Timo Stollenwerk
4ef604f43f make captcha field not required. otherwise recaptcha is not working. 
svn path=/plone.app.discussion/trunk/; revision=28892
 2009-08-15 10:17:34 +00:00
Timo Stollenwerk
cdfbdb3d7d remove debug line. 
svn path=/plone.app.discussion/trunk/; revision=28819
 2009-08-14 09:02:42 +00:00
Timo Stollenwerk
dff06b8c8c show post-comment form when user is logged in or user is not logged in and anonymous comments are allowed. 
svn path=/plone.app.discussion/trunk/; revision=28817
 2009-08-14 09:02:00 +00:00
Timo Stollenwerk
2a1ae7dc62 do not make a captcha check when captcha is disabled; this fixes the non-captcha comment form. 
svn path=/plone.app.discussion/trunk/; revision=28790
 2009-08-13 19:21:52 +00:00
Timo Stollenwerk
ce30a1b594 remove SimpleFieldValidator import fallback, because it breaks the CaptchaValidator. 
svn path=/plone.app.discussion/trunk/; revision=28789
 2009-08-13 18:53:27 +00:00
Timo Stollenwerk
c3a0631813 add hint for enabling comment moderation workflow. 
svn path=/plone.app.discussion/trunk/; revision=28760
 2009-08-13 13:52:50 +00:00
Timo Stollenwerk
f4f0e29e96 fix errors that are thrown when plone.formwidget.captcha is not installed. 
svn path=/plone.app.discussion/trunk/; revision=28755
 2009-08-13 10:01:40 +00:00
Timo Stollenwerk
e1b068dbbc captcha validator added. 
svn path=/plone.app.discussion/trunk/; revision=28746
 2009-08-12 20:45:47 +00:00
Timo Stollenwerk
0ba3bda065 unnecessary AttributeAnnotations removed. 
imports for captcha/recaptcha added.

svn path=/plone.app.discussion/trunk/; revision=28745
 2009-08-12 19:20:18 +00:00
Timo Stollenwerk
7f7c4b1345 captcha registry entry and vocabulary added. 
svn path=/plone.app.discussion/trunk/; revision=28679
 2009-08-11 09:45:34 +00:00
Timo Stollenwerk
5500c8d42e remove old files. 
svn path=/plone.app.discussion/trunk/; revision=28677
 2009-08-11 09:39:17 +00:00
Timo Stollenwerk
ffcd7d7a31 adapt CaptchaExtender to CommentForm only. 
svn path=/plone.app.discussion/trunk/; revision=28642
 2009-08-10 16:38:41 +00:00
Timo Stollenwerk
ef8e34adbb Add dead-simple captcha to show the z3c-form-extender works. 
svn path=/plone.app.discussion/trunk/; revision=28371
 2009-08-05 09:01:58 +00:00
Timo Stollenwerk
8e9c75a6fc Set fields as class attribute to make captcha formextender work again. This is kind of ugly, the fields should be enirely omitted and not only hidden. 
svn path=/plone.app.discussion/trunk/; revision=28370
 2009-08-05 09:01:14 +00:00
Timo Stollenwerk
eadbb55a87 fix commenting for anonymous users. 
svn path=/plone.app.discussion/trunk/; revision=28363
 2009-08-04 20:47:25 +00:00
Timo Stollenwerk
355f50388c reorder comment form fields. 
svn path=/plone.app.discussion/trunk/; revision=28362
 2009-08-04 20:47:06 +00:00
Timo Stollenwerk
2e2528aa76 clean up the imports. 
svn path=/plone.app.discussion/trunk/; revision=28360
 2009-08-04 19:36:33 +00:00
Timo Stollenwerk
ae0b9486b7 remove unnecessary wrap_form. 
svn path=/plone.app.discussion/trunk/; revision=28358
 2009-08-04 19:30:12 +00:00
Timo Stollenwerk
c0d7f326b2 remove "implements(IViewlet)" since the base class takes care of it. 
svn path=/plone.app.discussion/trunk/; revision=28357
 2009-08-04 19:25:40 +00:00
Timo Stollenwerk
01f44e3147 add cancel button. 
make strings translatable.

svn path=/plone.app.discussion/trunk/; revision=28356
 2009-08-04 19:24:47 +00:00
Timo Stollenwerk
6014a65daa replace CommentFactory() with createObject(). 
svn path=/plone.app.discussion/trunk/; revision=28355
 2009-08-04 18:42:17 +00:00
Timo Stollenwerk
a63f518bcb fix the cancel button for the comment reply form. 
svn path=/plone.app.discussion/trunk/; revision=28354
 2009-08-04 18:39:10 +00:00
Timo Stollenwerk
12ee7d6a5a show/hide the comment/reply button inside the comment/reply-to-comment forms. 
svn path=/plone.app.discussion/trunk/; revision=28352
 2009-08-04 15:19:20 +00:00
Timo Stollenwerk
c516d6ba55 hide the in_reply_to field inside the comment form. 
svn path=/plone.app.discussion/trunk/; revision=28351
 2009-08-04 15:12:15 +00:00
Timo Stollenwerk
ddd8596dbd move reply to comment view to z3cform. 
svn path=/plone.app.discussion/trunk/; revision=28349
 2009-08-04 14:51:34 +00:00
Timo Stollenwerk
a5c8fe33ed redirect after adding a comment. 
remove unnecessary Comment class.

svn path=/plone.app.discussion/trunk/; revision=28348
 2009-08-04 12:55:46 +00:00
Timo Stollenwerk
4876a5fb59 move addComment view to z3cform. 
svn path=/plone.app.discussion/trunk/; revision=28346
 2009-08-04 11:56:52 +00:00
Timo Stollenwerk
878f45029b fix attribute error when submitting the comment form. 
omit form fields for comment form the right way.

svn path=/plone.app.discussion/trunk/; revision=28345
 2009-08-04 11:35:05 +00:00
Timo Stollenwerk
2e2f6fc690 set form fields manually. 
svn path=/plone.app.discussion/trunk/; revision=28325
 2009-08-02 17:32:41 +00:00
Timo Stollenwerk
424d1c79ed z3c.form form added to commentsviewlet (not fully functional yet). 
svn path=/plone.app.discussion/trunk/; revision=28300
 2009-08-01 21:47:50 +00:00
Timo Stollenwerk
98204dc84a fix the recursive migrate_replies function, so that it returns True only after all comments on a certain level have been migrated. 
svn path=/plone.app.discussion/trunk/; revision=28054
 2009-07-13 22:14:30 +00:00
Timo Stollenwerk
377f9ddbfd fix depth in migrated comments and add more complex threaded test case. 
svn path=/plone.app.discussion/trunk/; revision=28053
 2009-07-13 21:01:38 +00:00
Timo Stollenwerk
8bc0b068ae delete old replies and talkbacks during the migration. 
svn path=/plone.app.discussion/trunk/; revision=28052
 2009-07-13 20:22:37 +00:00
Timo Stollenwerk
dcb3665d36 plone.registry 1.0a2 changed methods to mixedCase (register_interface to registerInterface). 
svn path=/plone.app.discussion/trunk/; revision=28041
 2009-07-13 10:22:45 +00:00
Timo Stollenwerk
b106262e31 plone.registry 1.0a2 changed methods to mixedCase (for_interface to forInterface). 
svn path=/plone.app.discussion/trunk/; revision=28024
 2009-07-12 19:13:42 +00:00
Timo Stollenwerk
39e0faffc9 remove allow_discussion test, since it is unnecessary. 
svn path=/plone.app.discussion/trunk/; revision=28023
 2009-07-12 18:19:29 +00:00
Timo Stollenwerk
356db660b0 migrate creation_date and modification_date too. 
svn path=/plone.app.discussion/trunk/; revision=28019
 2009-07-12 17:55:54 +00:00
Timo Stollenwerk
18ee5159bd function to recursively migrate comments added. 
svn path=/plone.app.discussion/trunk/; revision=28016
 2009-07-12 16:09:34 +00:00
Timo Stollenwerk
d7eaab75c8 add migration test for comment Creator and nested comments. 
svn path=/plone.app.discussion/trunk/; revision=27960
 2009-07-12 07:09:07 +00:00