Commit Graph

810 Commits

Author SHA1 Message Date
Maurits van Rees
d90c436f8a Removed the conditional loading of event subscribers:
- zope.app.container is available in both Plone 3 and Plone 4, so the 'not-installed zope.app.container' condition was always false
- zope.lifecycleevent.interfaces does not have an IObjectAddedEvent or IObjectRemovedEvent so even if the condition would have been true, the loading would have failed.

svn path=/plone.app.discussion/trunk/; revision=46367
2010-12-16 02:12:13 +00:00
Maurits van Rees
a2a17085a3 Nuke trailing white space
svn path=/plone.app.discussion/trunk/; revision=46366
2010-12-15 23:52:56 +00:00
Maurits van Rees
aff8a3709c Avoid sending multiple notification emails to the same person when
he has commented multiple times.

svn path=/plone.app.discussion/trunk/; revision=46365
2010-12-15 23:41:57 +00:00
Maurits van Rees
9eb172023a No tabs in zcml please
svn path=/plone.app.discussion/trunk/; revision=46364
2010-12-15 22:59:24 +00:00
Maurits van Rees
87d767651b Do not fail on startup with Plone 3 when plone.uuid is not there:
make implementing the plone.uuid.interfaces.IAttributeUUID interface conditional for Plone 4 only.

svn path=/plone.app.discussion/trunk/; revision=46363
2010-12-15 22:45:19 +00:00
David Glick
0cb75778ba make sure comments don't get indexed with their parents' UID in Plone 3. only declare dependency on plone.app.uuid in Python 2.6, since we only use it in Plone 4 currently.
svn path=/plone.app.discussion/trunk/; revision=46353
2010-12-15 20:39:55 +00:00
Timo Stollenwerk
b9d929bca3 Fix failing test.
svn path=/plone.app.discussion/trunk/; revision=46344
2010-12-14 21:30:40 +00:00
Timo Stollenwerk
a8bfd7fc6e Disable discussion by default.
svn path=/plone.app.discussion/trunk/; revision=46337
2010-12-14 17:58:46 +00:00
Timo Stollenwerk
d702c666f0 Tests for moderation_enabled setting added.
svn path=/plone.app.discussion/trunk/; revision=46266
2010-12-12 13:56:06 +00:00
Timo Stollenwerk
ea2038b122 Remove XXX line from conversation.py. Martin and I agree that this is probably not relevant anymore. Refs #9288
svn path=/plone.app.discussion/trunk/; revision=46265
2010-12-12 12:51:41 +00:00
Timo Stollenwerk
a9ef0503f2 Move discussion action item from actionicons.xml to actions.xml to avoid deprecation warning.
svn path=/plone.app.discussion/trunk/; revision=46264
2010-12-12 12:40:19 +00:00
Timo Stollenwerk
4c4cd9e44d Replace XXX with todo.
svn path=/plone.app.discussion/trunk/; revision=46263
2010-12-12 08:14:48 +00:00
Timo Stollenwerk
0485398de0 whitespace, make jslint happy.
svn path=/plone.app.discussion/trunk/; revision=46262
2010-12-12 08:13:03 +00:00
Timo Stollenwerk
be78fbe300 There is no need to enable the "enable moderation" checkbox dynamically, except when commenting is disabled/enabled globally.
svn path=/plone.app.discussion/trunk/; revision=46261
2010-12-12 07:35:43 +00:00
Timo Stollenwerk
08857df7a9 Fix cancel button on edit view when using Dexterity types. This fixes http://dev.plone.org/plone/ticket/11338. Refs #11338
svn path=/plone.app.discussion/trunk/; revision=46254
2010-12-11 21:33:43 +00:00
Timo Stollenwerk
f2f97c5b38 Change the comment workflow setting in the discussion control panel if the setting is changed in the types control panel; show warning message and disable the setting if a custom comment workflow is enabled.
svn path=/plone.app.discussion/trunk/; revision=46253
2010-12-11 21:30:18 +00:00
Timo Stollenwerk
0475376ed0 "Enable comment moderation" setting added to the discussion control panel. Just a proof of concept so far. Not fully implemented yet. No tests.
svn path=/plone.app.discussion/trunk/; revision=46249
2010-12-11 17:18:14 +00:00
Timo Stollenwerk
09a804aa88 Remove unnecessary and failing test.
svn path=/plone.app.discussion/trunk/; revision=46235
2010-12-10 09:16:36 +00:00
Timo Stollenwerk
54af7d3fa1 Assigning the 'Reply to item' permission to the 'Authenticated' role. The old commenting system allowed 'Authenticated' users to post comments. Also, OpenID users do not possess the 'Authenticated' role. Refs #9288
svn path=/plone.app.discussion/trunk/; revision=46230
2010-12-10 08:57:35 +00:00
Timo Stollenwerk
45140c66db Functional test for posting a comment as user without the 'Reply to item' permission added.
svn path=/plone.app.discussion/trunk/; revision=46215
2010-12-09 10:58:32 +00:00
Timo Stollenwerk
7e279d3ad3 Make sure the handleComment method checks for the 'Reply to item' permission when adding a comment.
svn path=/plone.app.discussion/trunk/; revision=46212
2010-12-09 08:11:41 +00:00
Timo Stollenwerk
c8e78449a2 Make the mail-setting warning message show up in the discussion control panel.
svn path=/plone.app.discussion/trunk/; revision=46211
2010-12-09 08:07:15 +00:00
Timo Stollenwerk
797ed40852 Link directly to the "Discussion Item" types control panel in the moderation view.
svn path=/plone.app.discussion/trunk/; revision=46207
2010-12-08 17:45:58 +00:00
Timo Stollenwerk
583b25530e Show "moderate comments" link in the admin panel only if a moderation workflow is enabled for comments.
svn path=/plone.app.discussion/trunk/; revision=46206
2010-12-08 17:45:11 +00:00
Timo Stollenwerk
6e354718f4 Revert r46143.
svn path=/plone.app.discussion/trunk/; revision=46144
2010-12-05 14:56:13 +00:00
Timo Stollenwerk
22425b06ac Disable commenting by default if pad is shipped with Plone. If shipped as add-on product, commenting should be enabled by default.
svn path=/plone.app.discussion/trunk/; revision=46143
2010-12-05 14:50:25 +00:00
Timo Stollenwerk
04a0669731 Remove the grey background from disabled settings.
svn path=/plone.app.discussion/trunk/; revision=46142
2010-12-05 14:10:21 +00:00
Timo Stollenwerk
bbd44b7b95 workflow setting added to control panel config string.
svn path=/plone.app.discussion/trunk/; revision=46091
2010-12-02 23:20:10 +00:00
Timo Stollenwerk
ffde4b423d Do not allow to change the mail settings in the discussion control panel, if there is no valid mail setup. Refactor js code to use class settings of #content.
svn path=/plone.app.discussion/trunk/; revision=46090
2010-12-02 23:02:00 +00:00
Timo Stollenwerk
fbd7eb2bbc Do not allow to change the mail settings in the discussion control panel, if there is no valid mail setup.
svn path=/plone.app.discussion/trunk/; revision=46089
2010-12-02 21:07:58 +00:00
Timo Stollenwerk
1b36f99a7a make jslint happy; disable settings onload;
svn path=/plone.app.discussion/trunk/; revision=46088
2010-12-02 19:49:49 +00:00
Timo Stollenwerk
2a7a65293e disable form fields when disabling the fields.
svn path=/plone.app.discussion/trunk/; revision=46087
2010-12-02 19:09:16 +00:00
Timo Stollenwerk
f97c17e62a Factor out enable/disable settings function.
svn path=/plone.app.discussion/trunk/; revision=46086
2010-12-02 18:50:21 +00:00
Timo Stollenwerk
ffcc29a401 Override the default plone.app.registry controlpanel template; JS file for the controlpanel added. Disable all commenting options in the discussion control panel when comments are disabled globally.
svn path=/plone.app.discussion/trunk/; revision=46085
2010-12-02 18:15:47 +00:00
Timo Stollenwerk
c311a4f88d Check for the 'review comments' permission instead of 'manage' to decide if the user should see a 'this comment is pending' message.
svn path=/plone.app.discussion/trunk/; revision=46050
2010-12-01 06:34:05 +00:00
Timo Stollenwerk
19f0666b39 Move "moderate comments" site action above the logout action.
svn path=/plone.app.discussion/trunk/; revision=46047
2010-11-30 18:17:02 +00:00
Timo Stollenwerk
d94767576b Do not use plone.app.uuid to generate unique UIDs for Plone 3. plone.app.uuid causes the IObjectAddedEvent to be fired twice on Plone 3. This causes the email notifications to be send twice. This means that https://dev.plone.org/plone/ticket/10652 is fixed only for Plone 4.
svn path=/plone.app.discussion/trunk/; revision=46043
2010-11-30 09:50:12 +00:00
Timo Stollenwerk
2b3a84e9d1 Moderator notification description updated.
svn path=/plone.app.discussion/trunk/; revision=46042
2010-11-30 09:13:30 +00:00
Timo Stollenwerk
13772c6e5b Redirect back to the discussion control panel when the discussion control panel form is submitted.
svn path=/plone.app.discussion/trunk/; revision=46040
2010-11-30 09:06:46 +00:00
Timo Stollenwerk
824ed1e94a Fix document_byline bottom margin if commenter images are disabled.
svn path=/plone.app.discussion/trunk/; revision=46037
2010-11-30 07:33:22 +00:00
Timo Stollenwerk
0c94707743 Dynamically show the comment formatting message dependent on the text transform setting.
svn path=/plone.app.discussion/trunk/; revision=46035
2010-11-29 22:42:20 +00:00
Timo Stollenwerk
ea2ff81b43 Description for text transform added to the discussion control panel.
svn path=/plone.app.discussion/trunk/; revision=46027
2010-11-29 18:54:29 +00:00
Timo Stollenwerk
9dd33c47d0 Move the discussion control panel to the core Plone configuration.
svn path=/plone.app.discussion/trunk/; revision=46020
2010-11-29 17:40:37 +00:00
Timo Stollenwerk
f0cecaf274 Always set the effective date of a comment to the same value as the creation date.
svn path=/plone.app.discussion/trunk/; revision=46019
2010-11-29 17:36:52 +00:00
Timo Stollenwerk
b26d5a5a62 Fix SMTP exception when an email is send to the moderator.
svn path=/plone.app.discussion/trunk/; revision=46013
2010-11-29 08:27:09 +00:00
Timo Stollenwerk
3b31ac1602 Always import ObjectCreatedEvent from zope.lifecycleevent.
svn path=/plone.app.discussion/trunk/; revision=46006
2010-11-28 12:01:27 +00:00
Timo Stollenwerk
ac4a64f55d Make sure comment UIDs in the catalog are always unique. This fixes
http://dev.plone.org/plone/ticket/10652. We depend on plone.uuid and plone.app.uuid now. Refs #10652.

svn path=/plone.app.discussion/trunk/; revision=46005
2010-11-28 11:39:19 +00:00
Timo Stollenwerk
b08d7ddbeb revert r46002.
svn path=/plone.app.discussion/trunk/; revision=46003
2010-11-28 10:00:31 +00:00
Timo Stollenwerk
7e39197114 hudson buildout added.
svn path=/plone.app.discussion/trunk/; revision=46002
2010-11-28 09:51:35 +00:00
David Glick
4c31afeac2 fix comparison of string to integer which broke 'check all'
svn path=/plone.app.discussion/trunk/; revision=45926
2010-11-23 18:53:38 +00:00
Timo Stollenwerk
7dbcc9e2be Use safe_unicode to decode the title of the content. encode("utf-9") caused Dexterity based content types to raise a unicode decode error. This fixes http://dev.plone.org/plone/ticket/11292. Refs #11292
svn path=/plone.app.discussion/trunk/; revision=45915
2010-11-23 14:03:47 +00:00
Israel Saeta Pérez
6f698551ce Update Spanish localization.
svn path=/plone.app.discussion/trunk/; revision=45880
2010-11-19 11:01:05 +00:00
Victor Fernandez de Alba
289f876244 Corrected typo in catalan translation
svn path=/plone.app.discussion/trunk/; revision=45852
2010-11-17 14:50:43 +00:00
Victor Fernandez de Alba
48d225e97e Catalan translations
svn path=/plone.app.discussion/trunk/; revision=45851
2010-11-17 14:26:15 +00:00
Luca Fabbri
7083607d63 update italian translation
svn path=/plone.app.discussion/trunk/; revision=45811
2010-11-15 16:02:11 +00:00
Yiorgis Gozadinos
ab00fa3d99 Make the creator indexer return utf-8 to the catalog.
svn path=/plone.app.discussion/trunk/; revision=45735
2010-11-10 10:06:20 +00:00
Timo Stollenwerk
d358a31c74 Comments viewlet test for posting anonymous comments added.
svn path=/plone.app.discussion/trunk/; revision=45663
2010-11-08 17:10:19 +00:00
Timo Stollenwerk
5b788d1156 Merge 'Convert anonymous-supplied name to unicode as done for authenticated members.' from jarn-unicode branch.
svn path=/plone.app.discussion/trunk/; revision=45662
2010-11-08 17:09:26 +00:00
Anton Stonor
91a488931d staring Danish translation
svn path=/plone.app.discussion/trunk/; revision=45615
2010-11-07 22:02:08 +00:00
Radim Novotny
469da01f11 typo in Czech translation
svn path=/plone.app.discussion/trunk/; revision=45607
2010-11-07 18:52:12 +00:00
Timo Stollenwerk
cbd2edf932 Catch SMTP exceptions when sending email notifications.
svn path=/plone.app.discussion/trunk/; revision=45199
2010-11-04 15:56:12 +00:00
Timo Stollenwerk
501cee78e2 ".comment" and ".replyTreeLevel0" are both CSS classes of the comment div. Fix for Plone 3 only.
svn path=/plone.app.discussion/trunk/; revision=45189
2010-11-04 14:50:30 +00:00
Timo Stollenwerk
823ada7491 Remove AJAX comment deletion binding. This function relies on the nextUntil() selector introduced by jQuery 1.4 and therefore breaks in Plone 3 (that currently uses jQuery 1.3.2).
svn path=/plone.app.discussion/trunk/; revision=45188
2010-11-04 14:42:32 +00:00
Timo Stollenwerk
b68da9925b Use parseInt with second param to make jslint happy.
svn path=/plone.app.discussion/trunk/; revision=45187
2010-11-04 14:37:18 +00:00
Radim Novotny
b3ec7d61f5 Updated Czech translation :)
svn path=/plone.app.discussion/trunk/; revision=45126
2010-11-03 13:52:16 +00:00
Timo Stollenwerk
3d2f01b440 Translations updated.
svn path=/plone.app.discussion/trunk/; revision=45125
2010-11-03 13:45:00 +00:00
Timo Stollenwerk
25a82538b4 Fix Czech language code and name.
svn path=/plone.app.discussion/trunk/; revision=45124
2010-11-03 13:42:20 +00:00
Timo Stollenwerk
7f98b94031 Fix Dutch language code and name.
svn path=/plone.app.discussion/trunk/; revision=45123
2010-11-03 13:40:48 +00:00
Timo Stollenwerk
b95707ac52 Re-add the CommentsViewlet can_manage method. This method has been removed in version 1.0b9 and added again in 1.0b11 because we don't want to change the API in beta releases.
svn path=/plone.app.discussion/trunk/; revision=45110
2010-11-03 11:26:18 +00:00
Timo Stollenwerk
8e8e78c2d9 Fix language code and name in the Basque .po file.
svn path=/plone.app.discussion/trunk/; revision=45082
2010-11-02 11:34:52 +00:00
Israel Saeta Pérez
1b02b799c6 Add and update es and eu l10ns.
svn path=/plone.app.discussion/trunk/; revision=45063
2010-11-02 09:05:22 +00:00
Timo Stollenwerk
a39ac82858 There is no need to set the comment title in the tests, since comments do not have title fields anymore.
svn path=/plone.app.discussion/trunk/; revision=44738
2010-10-31 11:09:32 +00:00
Timo Stollenwerk
feec103b56 Fix user email notification test for Plone 3.
svn path=/plone.app.discussion/trunk/; revision=44737
2010-10-31 10:48:45 +00:00
Timo Stollenwerk
fa6e380eaf Use secureSend for user email notification on Plone 3
svn path=/plone.app.discussion/trunk/; revision=44736
2010-10-31 10:34:58 +00:00
Timo Stollenwerk
c8cd370fc9 Use len(tuple()) instead of tuple() to make tests pass again.
svn path=/plone.app.discussion/trunk/; revision=44706
2010-10-30 19:26:51 +00:00
Timo Stollenwerk
093eaa393a Use tuple() to test for generators. Thanks to otacon!
svn path=/plone.app.discussion/trunk/; revision=42096
2010-10-30 18:58:20 +00:00
Timo Stollenwerk
cc96acb50a Ajaxify comment deletion and approval. thanks thomasdesvenain!
svn path=/plone.app.discussion/trunk/; revision=40984
2010-10-30 17:32:31 +00:00
Timo Stollenwerk
82afd3ef15 New feature: As a logged-in user, I can enable/disable email notification of additional comments on this content object.
svn path=/plone.app.discussion/trunk/; revision=40949
2010-10-30 15:02:05 +00:00
Timo Stollenwerk
5fe339215b Use the jstestdriver coverage plugin.
svn path=/plone.app.discussion/trunk/; revision=40909
2010-10-30 11:24:03 +00:00
Timo Stollenwerk
380b81bd3e Disable the moderation qunit tests for now because they are currently failing.
svn path=/plone.app.discussion/trunk/; revision=40907
2010-10-30 11:12:04 +00:00
Timo Stollenwerk
0820d3771f Basic js-test-driver configuration added.
svn path=/plone.app.discussion/trunk/; revision=40892
2010-10-30 10:22:21 +00:00
Timo Stollenwerk
81dcdeaea3 Disable the plone.app.registry check on schema elements, so no error is raised on upgrades. This fixes https://dev.plone.org/plone/ticket/11195. Refs #11195
svn path=/plone.app.discussion/trunk/; revision=40868
2010-10-29 10:43:46 +00:00
Timo Stollenwerk
f6b7ef1bcb Remove the too generic id attribute of the comment form.
svn path=/plone.app.discussion/trunk/; revision=40858
2010-10-28 10:30:10 +00:00
Timo Stollenwerk
777e687169 Rename the id of the comment form from "form" to "comment-form".
svn path=/plone.app.discussion/trunk/; revision=40857
2010-10-28 09:45:34 +00:00
Timo Stollenwerk
22e4189c37 Revert revisions r40851 to r40853, they should have gone into the ajax-ui branch.
svn path=/plone.app.discussion/trunk/; revision=40856
2010-10-28 09:39:00 +00:00
Timo Stollenwerk
14e2600a79 Make ajax call for delete comment button work for comment replies.
svn path=/plone.app.discussion/trunk/; revision=40853
2010-10-27 16:10:04 +00:00
Timo Stollenwerk
926e4f6b8e Integrate Denys ajax ui code.
svn path=/plone.app.discussion/trunk/; revision=40852
2010-10-27 14:44:52 +00:00
Timo Stollenwerk
79f4481722 Use "#comment-form" as id for the comment form instead of "#form" which is too generic.
svn path=/plone.app.discussion/trunk/; revision=40851
2010-10-27 14:44:06 +00:00
Hanno Schlichting
aa8a1ea934 Fixed handling of non-ascii member data, like fullname and email.
svn path=/plone.app.discussion/trunk/; revision=40789
2010-10-22 10:14:07 +00:00
Hanno Schlichting
54bbb08c62 Whitespace removal
svn path=/plone.app.discussion/trunk/; revision=40788
2010-10-22 09:57:55 +00:00
Andreas Jung
8fc3dda8e6 wrong language-code
svn path=/plone.app.discussion/trunk/; revision=40586
2010-10-11 09:37:28 +00:00
Radim Novotny
18e92f7a85 - Fixed "global name 'WrongCaptchaCode' is not defined" if norobots captcha,
but no other validation package is installed.

svn path=/plone.app.discussion/trunk/; revision=40574
2010-10-09 11:13:28 +00:00
Timo Stollenwerk
f7ed357a83 Use 'comment_review_workflow' instead of 'simple_publication_workflow' for testing.
svn path=/plone.app.discussion/trunk/; revision=40571
2010-10-08 11:03:14 +00:00
Timo Stollenwerk
324d2274bd Check for a 'pending' state in the current comment workflow instead of checking for the 'comment_review' workflow. Refs #11184. Merge last three submits in CHANGES.txt.
svn path=/plone.app.discussion/trunk/; revision=40570
2010-10-08 10:37:10 +00:00
Timo Stollenwerk
6e9bb4a9cd Check the review_state to decide if moderation is enabled. If the current comment workflow implements a 'pending' state, moderation is enabled. Refs #11184.
svn path=/plone.app.discussion/trunk/; revision=40569
2010-10-08 10:22:40 +00:00
Timo Stollenwerk
2790e6d4eb Check the review_state instead of the workflow after a comment has been posted to decide if a message is shown to the user. This allows integrators to use custom review workflows. Refs #11184
svn path=/plone.app.discussion/trunk/; revision=40566
2010-10-08 09:53:00 +00:00
Timo Stollenwerk
43d3222086 Run functional tests only with Plone 4 (and plone.testing).
svn path=/plone.app.discussion/trunk/; revision=40537
2010-10-06 15:12:11 +00:00
Timo Stollenwerk
94584429fd Do not use has_key.
svn path=/plone.app.discussion/trunk/; revision=40536
2010-10-06 14:12:30 +00:00
Timo Stollenwerk
4bbfe677e4 Replace the can_manage method with a can_review method that checks the 'Review comments' permission. This fixes http://dev.plone.org/plone/ticket/11145.
svn path=/plone.app.discussion/trunk/; revision=40534
2010-10-06 13:55:57 +00:00
Timo Stollenwerk
3e73903a8d Remove (old) functional test.
svn path=/plone.app.discussion/trunk/; revision=40533
2010-10-06 13:53:07 +00:00