49504c1ddd
Redirect to the comment itself when notifying a user about a new comment.
...
svn path=/plone.app.discussion/trunk/; revision=49030
2011-04-22 08:54:35 +00:00
80a7b90a30
Move all tests from testing layer to plone.app.testing.
...
svn path=/plone.app.discussion/trunk/; revision=48916
2011-04-17 08:51:58 +00:00
f3d97b2f20
Use plone.app.testing in test_moderation_view.
...
svn path=/plone.app.discussion/trunk/; revision=48915
2011-04-17 08:50:34 +00:00
d66328a26a
Use plone.app.testing in test_migration.
...
svn path=/plone.app.discussion/trunk/; revision=48906
2011-04-16 09:51:28 +00:00
216e95aa27
Use plone.app.testing in test_indexers.
...
svn path=/plone.app.discussion/trunk/; revision=48905
2011-04-16 09:35:34 +00:00
85126e9109
Use plone.app.testing in test_notifications.
...
svn path=/plone.app.discussion/trunk/; revision=48904
2011-04-16 09:31:03 +00:00
1682c89745
Use plone.app.testing in test_tool.
...
svn path=/plone.app.discussion/trunk/; revision=48903
2011-04-16 09:30:11 +00:00
fc59094cb2
Use plone.app.testing in test_workflow.
...
svn path=/plone.app.discussion/trunk/; revision=48902
2011-04-16 09:29:15 +00:00
41f5afa8b9
Use plone.app.testing in test_conversation.
...
svn path=/plone.app.discussion/trunk/; revision=48901
2011-04-16 09:27:15 +00:00
c4e69627b3
Use plone.app.testing in test_controlpanel.
...
svn path=/plone.app.discussion/trunk/; revision=48900
2011-04-16 09:26:20 +00:00
f8019b0c10
Use plone.app.testing in test_comments_viewlet.
...
svn path=/plone.app.discussion/trunk/; revision=48899
2011-04-16 09:25:16 +00:00
38b70a28e5
Use plone.app.testing in test_comment.
...
svn path=/plone.app.discussion/trunk/; revision=48898
2011-04-16 09:16:18 +00:00
e5d45dbd78
Use plone.app.testing in test_catalog.
...
svn path=/plone.app.discussion/trunk/; revision=48897
2011-04-16 09:13:39 +00:00
9db8909ea7
Avoid using deprecated test assertions, see http://docs.python.org/dev/library/unittest.html#deprecated-aliases for the full list
...
svn path=/plone.app.discussion/trunk/; revision=48881
2011-04-15 16:23:38 +00:00
811d4a0429
Avoid deprecation warnings and always specify a catalog query as a dict
...
svn path=/plone.app.discussion/trunk/; revision=48880
2011-04-15 16:17:02 +00:00
3708429a37
Move some policy out of the conversation storage adapter into a view,
...
specifically "enabled()". Prevents having to replace/migrate
persistent objects to change policy which really only concerns the
context and possibly the request, not the conversation storage. Fixes
#11372 .
svn path=/plone.app.discussion/trunk/; revision=48849
2011-04-15 04:29:46 +00:00
7354ca4298
Fix unindexing of comments when deleting content resulting from
...
iterating over a BTree while modifying it. Fixes #11402 .
svn path=/plone.app.discussion/trunk/; revision=48845
2011-04-14 21:30:32 +00:00
5786bfa6b6
pep8
...
svn path=/plone.app.discussion/trunk/; revision=48840
2011-04-14 20:17:10 +00:00
cad670d6af
Fax Missing.Value for Creator in the catalog. Fixes #11634 .
...
svn path=/plone.app.discussion/trunk/; revision=48838
2011-04-14 19:59:05 +00:00
187aa60452
These testbrowser tests certainly no longer raise 404s for me
...
svn path=/plone.app.discussion/trunk/; revision=48837
2011-04-14 19:06:55 +00:00
d8f864596e
The functional tests haven't been running due to an unused import
...
svn path=/plone.app.discussion/trunk/; revision=48835
2011-04-14 19:05:31 +00:00
d5a999b429
Clarify a doctest
...
svn path=/plone.app.discussion/trunk/; revision=48831
2011-04-14 16:41:11 +00:00
586cd1fdb7
Don't add the annotation unless a comment is actually being added.
...
Fixes #11370 .
svn path=/plone.app.discussion/trunk/; revision=48829
2011-04-14 16:17:29 +00:00
6d11fa6d5e
merge c48523 from 1.x branch
...
svn path=/plone.app.discussion/trunk/; revision=48527
2011-04-07 21:31:56 +00:00
636bca745c
merge r47140, r47290, r47579 from davisagli-features: fix timezone handling when migrating legacy comments and when indexing
...
svn path=/plone.app.discussion/trunk/; revision=48358
2011-04-02 21:26:36 +00:00
9d83b4f0e6
merge -r46947 from davisagli-features: preserve legacy titles on migrated comments
...
svn path=/plone.app.discussion/trunk/; revision=48357
2011-04-02 21:16:24 +00:00
eb004aab44
merge r46437 and r46946 from davisagli-features: respect the per-comment mime_type setting, and use the old cooked text/html from legacy comments when migrating
...
svn path=/plone.app.discussion/trunk/; revision=48356
2011-04-02 19:51:37 +00:00
bf5946367a
merge r46436 from davisagli-features: make it possible to specify a callback filter for the migration
...
svn path=/plone.app.discussion/trunk/; revision=48354
2011-04-02 19:33:10 +00:00
774ed36746
Ups, there is a nother unicode problem
...
svn path=/plone.app.discussion/trunk/; revision=47990
2011-03-08 20:15:37 +00:00
b6d406d298
Trigger failure for objects with unicode titles in string
...
svn path=/plone.app.discussion/trunk/; revision=47989
2011-03-08 20:15:21 +00:00
478273aa80
minor code cleanup
...
svn path=/plone.app.discussion/trunk/; revision=47599
2011-02-15 16:23:12 +00:00
81d74cfe6b
Fixed test failure for the default user portrait, which changed from
...
defaultUser.gif to defaultUser.png in Products.PlonePAS 4.0.5.
svn path=/plone.app.discussion/trunk/; revision=47597
2011-02-15 16:19:13 +00:00
bf96d0082f
Remove "Plone 3 only" code; Do not monkey patch the BAD_TYPES vocabulary or plone.app.vocabularies anymore.
...
svn path=/plone.app.discussion/trunk/; revision=47311
2011-02-08 09:28:51 +00:00
0a0e69d47d
Do not check for a comment review workflow when sending out a moderator email notification. This fixes http://dev.plone.org/plone/ticket/11444 . Refs #11444
...
svn path=/plone.app.discussion/trunk/; revision=47292
2011-02-07 11:48:24 +00:00
c438743a3b
Show a 'Comments are moderated.' message next to the comment form if comments are moderated.
...
svn path=/plone.app.discussion/trunk/; revision=46782
2011-01-07 10:20:24 +00:00
a2a17085a3
Nuke trailing white space
...
svn path=/plone.app.discussion/trunk/; revision=46366
2010-12-15 23:52:56 +00:00
aff8a3709c
Avoid sending multiple notification emails to the same person when
...
he has commented multiple times.
svn path=/plone.app.discussion/trunk/; revision=46365
2010-12-15 23:41:57 +00:00
0cb75778ba
make sure comments don't get indexed with their parents' UID in Plone 3. only declare dependency on plone.app.uuid in Python 2.6, since we only use it in Plone 4 currently.
...
svn path=/plone.app.discussion/trunk/; revision=46353
2010-12-15 20:39:55 +00:00
b9d929bca3
Fix failing test.
...
svn path=/plone.app.discussion/trunk/; revision=46344
2010-12-14 21:30:40 +00:00
a8bfd7fc6e
Disable discussion by default.
...
svn path=/plone.app.discussion/trunk/; revision=46337
2010-12-14 17:58:46 +00:00
d702c666f0
Tests for moderation_enabled setting added.
...
svn path=/plone.app.discussion/trunk/; revision=46266
2010-12-12 13:56:06 +00:00
0475376ed0
"Enable comment moderation" setting added to the discussion control panel. Just a proof of concept so far. Not fully implemented yet. No tests.
...
svn path=/plone.app.discussion/trunk/; revision=46249
2010-12-11 17:18:14 +00:00
09a804aa88
Remove unnecessary and failing test.
...
svn path=/plone.app.discussion/trunk/; revision=46235
2010-12-10 09:16:36 +00:00
54af7d3fa1
Assigning the 'Reply to item' permission to the 'Authenticated' role. The old commenting system allowed 'Authenticated' users to post comments. Also, OpenID users do not possess the 'Authenticated' role. Refs #9288
...
svn path=/plone.app.discussion/trunk/; revision=46230
2010-12-10 08:57:35 +00:00
45140c66db
Functional test for posting a comment as user without the 'Reply to item' permission added.
...
svn path=/plone.app.discussion/trunk/; revision=46215
2010-12-09 10:58:32 +00:00
7e279d3ad3
Make sure the handleComment method checks for the 'Reply to item' permission when adding a comment.
...
svn path=/plone.app.discussion/trunk/; revision=46212
2010-12-09 08:11:41 +00:00
0c94707743
Dynamically show the comment formatting message dependent on the text transform setting.
...
svn path=/plone.app.discussion/trunk/; revision=46035
2010-11-29 22:42:20 +00:00
f0cecaf274
Always set the effective date of a comment to the same value as the creation date.
...
svn path=/plone.app.discussion/trunk/; revision=46019
2010-11-29 17:36:52 +00:00
ac4a64f55d
Make sure comment UIDs in the catalog are always unique. This fixes
...
http://dev.plone.org/plone/ticket/10652 . We depend on plone.uuid and plone.app.uuid now. Refs #10652 .
svn path=/plone.app.discussion/trunk/; revision=46005
2010-11-28 11:39:19 +00:00
b08d7ddbeb
revert r46002.
...
svn path=/plone.app.discussion/trunk/; revision=46003
2010-11-28 10:00:31 +00:00
7e39197114
hudson buildout added.
...
svn path=/plone.app.discussion/trunk/; revision=46002
2010-11-28 09:51:35 +00:00
d358a31c74
Comments viewlet test for posting anonymous comments added.
...
svn path=/plone.app.discussion/trunk/; revision=45663
2010-11-08 17:10:19 +00:00
b95707ac52
Re-add the CommentsViewlet can_manage method. This method has been removed in version 1.0b9 and added again in 1.0b11 because we don't want to change the API in beta releases.
...
svn path=/plone.app.discussion/trunk/; revision=45110
2010-11-03 11:26:18 +00:00
a39ac82858
There is no need to set the comment title in the tests, since comments do not have title fields anymore.
...
svn path=/plone.app.discussion/trunk/; revision=44738
2010-10-31 11:09:32 +00:00
feec103b56
Fix user email notification test for Plone 3.
...
svn path=/plone.app.discussion/trunk/; revision=44737
2010-10-31 10:48:45 +00:00
c8cd370fc9
Use len(tuple()) instead of tuple() to make tests pass again.
...
svn path=/plone.app.discussion/trunk/; revision=44706
2010-10-30 19:26:51 +00:00
093eaa393a
Use tuple() to test for generators. Thanks to otacon!
...
svn path=/plone.app.discussion/trunk/; revision=42096
2010-10-30 18:58:20 +00:00
82afd3ef15
New feature: As a logged-in user, I can enable/disable email notification of additional comments on this content object.
...
svn path=/plone.app.discussion/trunk/; revision=40949
2010-10-30 15:02:05 +00:00
5fe339215b
Use the jstestdriver coverage plugin.
...
svn path=/plone.app.discussion/trunk/; revision=40909
2010-10-30 11:24:03 +00:00
380b81bd3e
Disable the moderation qunit tests for now because they are currently failing.
...
svn path=/plone.app.discussion/trunk/; revision=40907
2010-10-30 11:12:04 +00:00
0820d3771f
Basic js-test-driver configuration added.
...
svn path=/plone.app.discussion/trunk/; revision=40892
2010-10-30 10:22:21 +00:00
aa8a1ea934
Fixed handling of non-ascii member data, like fullname and email.
...
svn path=/plone.app.discussion/trunk/; revision=40789
2010-10-22 10:14:07 +00:00
54bbb08c62
Whitespace removal
...
svn path=/plone.app.discussion/trunk/; revision=40788
2010-10-22 09:57:55 +00:00
f7ed357a83
Use 'comment_review_workflow' instead of 'simple_publication_workflow' for testing.
...
svn path=/plone.app.discussion/trunk/; revision=40571
2010-10-08 11:03:14 +00:00
324d2274bd
Check for a 'pending' state in the current comment workflow instead of checking for the 'comment_review' workflow. Refs #11184 . Merge last three submits in CHANGES.txt.
...
svn path=/plone.app.discussion/trunk/; revision=40570
2010-10-08 10:37:10 +00:00
6e9bb4a9cd
Check the review_state to decide if moderation is enabled. If the current comment workflow implements a 'pending' state, moderation is enabled. Refs #11184 .
...
svn path=/plone.app.discussion/trunk/; revision=40569
2010-10-08 10:22:40 +00:00
43d3222086
Run functional tests only with Plone 4 (and plone.testing).
...
svn path=/plone.app.discussion/trunk/; revision=40537
2010-10-06 15:12:11 +00:00
4bbfe677e4
Replace the can_manage method with a can_review method that checks the 'Review comments' permission. This fixes http://dev.plone.org/plone/ticket/11145 .
...
svn path=/plone.app.discussion/trunk/; revision=40534
2010-10-06 13:55:57 +00:00
3e73903a8d
Remove (old) functional test.
...
svn path=/plone.app.discussion/trunk/; revision=40533
2010-10-06 13:53:07 +00:00
1230e67a01
Functional test for comment_review_workflow added; existing fonctional test renamed to functional_test_comments.txt;
...
svn path=/plone.app.discussion/trunk/; revision=40532
2010-10-06 13:52:11 +00:00
f9ca4497bd
Obey the 80 chars limit.
...
svn path=/plone.app.discussion/trunk/; revision=40526
2010-10-06 08:47:24 +00:00
94b0c58511
Fix pylint disable-msg statements.
...
svn path=/plone.app.discussion/trunk/; revision=40521
2010-10-05 15:54:49 +00:00
fbb042c012
Remove unused import.
...
svn path=/plone.app.discussion/trunk/; revision=40520
2010-10-05 15:52:19 +00:00
773345c40f
Make pylint happy.
...
svn path=/plone.app.discussion/trunk/; revision=40519
2010-10-05 15:47:02 +00:00
0ee649fb6c
Functional test for special characters added. Remove unnecessary decode statement from creator.
...
svn path=/plone.app.discussion/trunk/; revision=40502
2010-10-04 13:48:27 +00:00
6d92d1383c
Remove comment title from comments viewlet tests.
...
svn path=/plone.app.discussion/trunk/; revision=40496
2010-10-03 19:41:02 +00:00
ede295e649
Functional test for posting a comment with comment review workflow enabled.
...
svn path=/plone.app.discussion/trunk/; revision=40495
2010-10-03 19:07:30 +00:00
f5cf756e31
Functional test for replying to an existing comment added.
...
svn path=/plone.app.discussion/trunk/; revision=40493
2010-10-03 16:50:47 +00:00
e0055d0ba7
Make sure comment titles work with special characters as well.
...
svn path=/plone.app.discussion/trunk/; revision=40486
2010-10-02 18:16:49 +00:00
51d6c60412
Use the right event subscriber to make sure all comments are removed from the catalog, if their content object is deleted.
...
svn path=/plone.app.discussion/trunk/; revision=40485
2010-10-02 14:50:17 +00:00
0e27b8b7b6
Move regression test for #11157 into the main functional test.
...
svn path=/plone.app.discussion/trunk/; revision=40458
2010-09-30 17:45:26 +00:00
22db0b1c78
Fix comment title for anonymous commentators that do not provide a name.
...
svn path=/plone.app.discussion/trunk/; revision=40435
2010-09-29 10:52:11 +00:00
2cce7e0d0f
"Post comment as logged-in users" test added.
...
svn path=/plone.app.discussion/trunk/; revision=40434
2010-09-29 10:17:25 +00:00
f67c7cde6d
Remove title field from the comment form and replace it with an auto-generated title ("John Doe on Welcome to Plone").
...
This also fixes http://dev.plone.org/plone/ticket/11098
svn path=/plone.app.discussion/trunk/; revision=40431
2010-09-29 07:56:36 +00:00
7df932204c
Functional plone.testing doctest added.
...
svn path=/plone.app.discussion/trunk/; revision=40393
2010-09-28 16:35:45 +00:00
a55ff5b883
Fix pickle regression test.
...
svn path=/plone.app.discussion/trunk/; revision=40373
2010-09-28 10:18:16 +00:00
77e44f96ad
Added test (currently failing) to trigger "can't pickle objects in acquisition wrapper". Refs #11157
...
svn path=/plone.app.discussion/trunk/; revision=40357
2010-09-27 19:03:43 +00:00
58868c55e7
whitespace.
...
svn path=/plone.app.discussion/trunk/; revision=40232
2010-09-24 19:45:57 +00:00
e95ae26a11
Fix moderation test headline.
...
svn path=/plone.app.discussion/trunk/; revision=40229
2010-09-24 19:04:35 +00:00
cf11a5134a
Javascript tests for the bulk moderation view added (currently failing).
...
svn path=/plone.app.discussion/trunk/; revision=40228
2010-09-24 19:04:03 +00:00
399bba5eca
Use "(function($) { /* some code that uses $ */ })(jQuery)" instead of "$(document).ready(function(){ /* some code that uses $ */ });" to invoke jQuery code.
...
svn path=/plone.app.discussion/trunk/; revision=40214
2010-09-24 14:21:26 +00:00
57758d2cf8
More workflow tests.
...
svn path=/plone.app.discussion/trunk/; revision=40203
2010-09-24 13:33:21 +00:00
d77ca9d583
Commenting form explanation added.
...
svn path=/plone.app.discussion/trunk/; revision=40167
2010-09-23 14:46:24 +00:00
c364630a8c
js test for comments updated.
...
svn path=/plone.app.discussion/trunk/; revision=40166
2010-09-23 14:42:18 +00:00
9d0fa61c4d
Remove unnecessary XXX since we already use layers.
...
svn path=/plone.app.discussion/trunk/; revision=40165
2010-09-23 12:56:17 +00:00
4b3473f74b
Always provide that path param for bulk action view tests.
...
svn path=/plone.app.discussion/trunk/; revision=40004
2010-09-18 17:02:37 +00:00
14c0a3a4d1
Remove wrong_bulkaction test.
...
svn path=/plone.app.discussion/trunk/; revision=39946
2010-09-16 15:44:07 +00:00
e8a4caa5db
Some more tests for moderation bulk actions.
...
svn path=/plone.app.discussion/trunk/; revision=39945
2010-09-16 15:42:27 +00:00
742412a7d8
Test publish bulk actions as well.
...
svn path=/plone.app.discussion/trunk/; revision=39943
2010-09-16 15:12:59 +00:00
8d866a0ff6
Tests for moderate comments bulk actions added.
...
svn path=/plone.app.discussion/trunk/; revision=39942
2010-09-16 14:58:11 +00:00
Timo Stollenwerk
Hanno Schlichting
Ross Patterson
David Glick
Patrick Gerken
Maurits van Rees