Commit Graph

240 Commits

Author SHA1 Message Date
Timo Stollenwerk
4bbfe677e4 Replace the can_manage method with a can_review method that checks the 'Review comments' permission. This fixes http://dev.plone.org/plone/ticket/11145.
svn path=/plone.app.discussion/trunk/; revision=40534
2010-10-06 13:55:57 +00:00
Timo Stollenwerk
3e73903a8d Remove (old) functional test.
svn path=/plone.app.discussion/trunk/; revision=40533
2010-10-06 13:53:07 +00:00
Timo Stollenwerk
1230e67a01 Functional test for comment_review_workflow added; existing fonctional test renamed to functional_test_comments.txt;
svn path=/plone.app.discussion/trunk/; revision=40532
2010-10-06 13:52:11 +00:00
Timo Stollenwerk
f9ca4497bd Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=40526
2010-10-06 08:47:24 +00:00
Timo Stollenwerk
94b0c58511 Fix pylint disable-msg statements.
svn path=/plone.app.discussion/trunk/; revision=40521
2010-10-05 15:54:49 +00:00
Timo Stollenwerk
fbb042c012 Remove unused import.
svn path=/plone.app.discussion/trunk/; revision=40520
2010-10-05 15:52:19 +00:00
Timo Stollenwerk
773345c40f Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=40519
2010-10-05 15:47:02 +00:00
Timo Stollenwerk
0ee649fb6c Functional test for special characters added. Remove unnecessary decode statement from creator.
svn path=/plone.app.discussion/trunk/; revision=40502
2010-10-04 13:48:27 +00:00
Timo Stollenwerk
6d92d1383c Remove comment title from comments viewlet tests.
svn path=/plone.app.discussion/trunk/; revision=40496
2010-10-03 19:41:02 +00:00
Timo Stollenwerk
ede295e649 Functional test for posting a comment with comment review workflow enabled.
svn path=/plone.app.discussion/trunk/; revision=40495
2010-10-03 19:07:30 +00:00
Timo Stollenwerk
f5cf756e31 Functional test for replying to an existing comment added.
svn path=/plone.app.discussion/trunk/; revision=40493
2010-10-03 16:50:47 +00:00
Timo Stollenwerk
e0055d0ba7 Make sure comment titles work with special characters as well.
svn path=/plone.app.discussion/trunk/; revision=40486
2010-10-02 18:16:49 +00:00
Timo Stollenwerk
51d6c60412 Use the right event subscriber to make sure all comments are removed from the catalog, if their content object is deleted.
svn path=/plone.app.discussion/trunk/; revision=40485
2010-10-02 14:50:17 +00:00
Timo Stollenwerk
0e27b8b7b6 Move regression test for #11157 into the main functional test.
svn path=/plone.app.discussion/trunk/; revision=40458
2010-09-30 17:45:26 +00:00
Timo Stollenwerk
22db0b1c78 Fix comment title for anonymous commentators that do not provide a name.
svn path=/plone.app.discussion/trunk/; revision=40435
2010-09-29 10:52:11 +00:00
Timo Stollenwerk
2cce7e0d0f "Post comment as logged-in users" test added.
svn path=/plone.app.discussion/trunk/; revision=40434
2010-09-29 10:17:25 +00:00
Timo Stollenwerk
f67c7cde6d Remove title field from the comment form and replace it with an auto-generated title ("John Doe on Welcome to Plone").
This also fixes http://dev.plone.org/plone/ticket/11098

svn path=/plone.app.discussion/trunk/; revision=40431
2010-09-29 07:56:36 +00:00
Timo Stollenwerk
7df932204c Functional plone.testing doctest added.
svn path=/plone.app.discussion/trunk/; revision=40393
2010-09-28 16:35:45 +00:00
Timo Stollenwerk
a55ff5b883 Fix pickle regression test.
svn path=/plone.app.discussion/trunk/; revision=40373
2010-09-28 10:18:16 +00:00
Timo Stollenwerk
77e44f96ad Added test (currently failing) to trigger "can't pickle objects in acquisition wrapper". Refs #11157
svn path=/plone.app.discussion/trunk/; revision=40357
2010-09-27 19:03:43 +00:00
Timo Stollenwerk
58868c55e7 whitespace.
svn path=/plone.app.discussion/trunk/; revision=40232
2010-09-24 19:45:57 +00:00
Timo Stollenwerk
e95ae26a11 Fix moderation test headline.
svn path=/plone.app.discussion/trunk/; revision=40229
2010-09-24 19:04:35 +00:00
Timo Stollenwerk
cf11a5134a Javascript tests for the bulk moderation view added (currently failing).
svn path=/plone.app.discussion/trunk/; revision=40228
2010-09-24 19:04:03 +00:00
Timo Stollenwerk
399bba5eca Use "(function($) { /* some code that uses $ */ })(jQuery)" instead of "$(document).ready(function(){ /* some code that uses $ */ });" to invoke jQuery code.
svn path=/plone.app.discussion/trunk/; revision=40214
2010-09-24 14:21:26 +00:00
Timo Stollenwerk
57758d2cf8 More workflow tests.
svn path=/plone.app.discussion/trunk/; revision=40203
2010-09-24 13:33:21 +00:00
Timo Stollenwerk
d77ca9d583 Commenting form explanation added.
svn path=/plone.app.discussion/trunk/; revision=40167
2010-09-23 14:46:24 +00:00
Timo Stollenwerk
c364630a8c js test for comments updated.
svn path=/plone.app.discussion/trunk/; revision=40166
2010-09-23 14:42:18 +00:00
Timo Stollenwerk
9d0fa61c4d Remove unnecessary XXX since we already use layers.
svn path=/plone.app.discussion/trunk/; revision=40165
2010-09-23 12:56:17 +00:00
Timo Stollenwerk
4b3473f74b Always provide that path param for bulk action view tests.
svn path=/plone.app.discussion/trunk/; revision=40004
2010-09-18 17:02:37 +00:00
Timo Stollenwerk
14c0a3a4d1 Remove wrong_bulkaction test.
svn path=/plone.app.discussion/trunk/; revision=39946
2010-09-16 15:44:07 +00:00
Timo Stollenwerk
e8a4caa5db Some more tests for moderation bulk actions.
svn path=/plone.app.discussion/trunk/; revision=39945
2010-09-16 15:42:27 +00:00
Timo Stollenwerk
742412a7d8 Test publish bulk actions as well.
svn path=/plone.app.discussion/trunk/; revision=39943
2010-09-16 15:12:59 +00:00
Timo Stollenwerk
8d866a0ff6 Tests for moderate comments bulk actions added.
svn path=/plone.app.discussion/trunk/; revision=39942
2010-09-16 14:58:11 +00:00
Timo Stollenwerk
087efab54a Trying to fix the comments viewlet functional tests on Plone 3.x.
svn path=/plone.app.discussion/trunk/; revision=39932
2010-09-16 12:41:01 +00:00
Patrick Gerken
697d9af803 Test that correct local time gets displayed.
Since we now store the utc time in comments, we display
code must not only format the date correctly, but show the correct
local time.

svn path=/plone.app.discussion/trunk/; revision=39727
2010-09-07 12:03:18 +00:00
Patrick Gerken
a7b1eb7c10 Change all datetime creations from now to utcnow
svn path=/plone.app.discussion/trunk/; revision=39726
2010-09-07 12:03:07 +00:00
Patrick Gerken
4e43cfed2e Adding a test to assert that dates get stored utc
and not in local time

svn path=/plone.app.discussion/trunk/; revision=39725
2010-09-07 12:02:55 +00:00
Timo Stollenwerk
68a264c9d9 Use unicode strings for test requests in test_comments_viewlet to make the Plone 3 tests happy.
svn path=/plone.app.discussion/trunk/; revision=39680
2010-09-06 10:40:06 +00:00
Timo Stollenwerk
288732d276 Removed unused imports from test_comments_viewlet tests.
svn path=/plone.app.discussion/trunk/; revision=39632
2010-09-03 21:57:36 +00:00
Timo Stollenwerk
a4011ce414 Fix the comment view test.
svn path=/plone.app.discussion/trunk/; revision=39629
2010-09-03 21:23:44 +00:00
Timo Stollenwerk
ea13020498 Raise an unauthorized error when authenticated users try to post a comment on a content object that has discussion disabled. Thanks to vincentfrentin for reporting this!
svn path=/plone.app.discussion/trunk/; revision=39627
2010-09-03 20:40:27 +00:00
Timo Stollenwerk
a410c72333 Complete comments form integration test.
svn path=/plone.app.discussion/trunk/; revision=39610
2010-09-02 20:52:33 +00:00
Timo Stollenwerk
81cba38a74 Comment form test added.
svn path=/plone.app.discussion/trunk/; revision=39608
2010-09-02 20:00:43 +00:00
Timo Stollenwerk
8d915b6327 Obey the 80 chars limit.
svn path=/plone.app.discussion/trunk/; revision=39567
2010-08-31 17:28:07 +00:00
Timo Stollenwerk
23122ded8b Test if registry has been registered.
svn path=/plone.app.discussion/trunk/; revision=39356
2010-08-28 22:58:23 +00:00
Timo Stollenwerk
435040e0b2 Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39287
2010-08-28 17:06:53 +00:00
Timo Stollenwerk
ba8e7ac5cd Move the functions out of the ready function. this makes the JS tests pass.
svn path=/plone.app.discussion/trunk/; revision=39151
2010-08-27 21:26:37 +00:00
Timo Stollenwerk
f4435a563b Remove unnecessary init test. remove namespaces from method calls.
svn path=/plone.app.discussion/trunk/; revision=39145
2010-08-27 20:51:19 +00:00
Timo Stollenwerk
9e405b47a1 qunit files added.
svn path=/plone.app.discussion/trunk/; revision=39143
2010-08-27 20:50:18 +00:00
Timo Stollenwerk
d713409aa1 Use a discussion JS namespace for comments.js; JS tests for clearForm and createReplyForm functions added.
svn path=/plone.app.discussion/trunk/; revision=39104
2010-08-27 17:11:25 +00:00
Timo Stollenwerk
2c5d387cfc Rename js directory to javascripts.
svn path=/plone.app.discussion/trunk/; revision=39066
2010-08-27 12:07:04 +00:00
Timo Stollenwerk
e310c1d021 Basic JS tests added.
svn path=/plone.app.discussion/trunk/; revision=39064
2010-08-27 11:41:39 +00:00
Timo Stollenwerk
a2c89ed5e8 Plain text and intelligent text options for comment text added to preserve basic text structure and to make links clickable.
svn path=/plone.app.discussion/trunk/; revision=38931
2010-08-25 14:03:29 +00:00
Timo Stollenwerk
35d7743b7a Plain text to HTML transformation added for comment text
svn path=/plone.app.discussion/trunk/; revision=38898
2010-08-25 09:19:28 +00:00
Vincent Fretin
352a517a0a Fixed the case where a folder has allow_discussion=False and
conversation.enabled() on a document in this folder returned False
instead of True because of allow_discussion acquisition.

svn path=/plone.app.discussion/trunk/; revision=38835
2010-08-20 11:52:05 +00:00
Timo Stollenwerk
a54a15a90f Remove unnecessary imports and variables from test code.
svn path=/plone.app.discussion/trunk/; revision=37768
2010-07-13 10:45:53 +00:00
Timo Stollenwerk
27d8ced62d revert r37751.
svn path=/plone.app.discussion/trunk/; revision=37753
2010-07-12 13:49:57 +00:00
Timo Stollenwerk
cac0bae7a5 revert r37751.
svn path=/plone.app.discussion/trunk/; revision=37752
2010-07-12 13:47:53 +00:00
Timo Stollenwerk
eabf3bc890 Always use zope.component getUtility instead of queryUtility.
svn path=/plone.app.discussion/trunk/; revision=37751
2010-07-12 13:34:02 +00:00
Florian Friesdorf
5beebe42fa hardcoded fti_title, don't query typestool for Type()
all tests succeed

svn path=/plone.app.discussion/trunk/; revision=35290
2010-03-18 14:42:52 +00:00
Florian Friesdorf
8150617081 fixed #662654: As an administrator, I can configure a Collection to show
recent comments.

Type now correctly returns FTI type title. A catalog rebuild is
necessary.

svn path=/plone.app.discussion/trunk/; revision=35266
2010-03-18 13:22:16 +00:00
Florian Friesdorf
5e6c7f6fdb fixed catalog test to fail for current broken Type()
svn path=/plone.app.discussion/trunk/; revision=35265
2010-03-18 13:22:06 +00:00
Timo Stollenwerk
f5a171a6e0 add missing DiscussionLayer to TestCommentOperations test.
svn path=/plone.app.discussion/trunk/; revision=35129
2010-03-17 15:09:23 +00:00
Timo Stollenwerk
b70774343f collection test added.
svn path=/plone.app.discussion/trunk/; revision=35126
2010-03-17 15:00:19 +00:00
Timo Stollenwerk
52ebbe2e71 Fix #2494228: Remove comments as well when a content object is deleted.
svn path=/plone.app.discussion/trunk/; revision=34965
2010-03-16 15:06:43 +00:00
Timo Stollenwerk
6e226be248 failing test for Pivotal Tracker issue #2494228 added (comment out test for now).
svn path=/plone.app.discussion/trunk/; revision=34915
2010-03-16 11:09:40 +00:00
Timo Stollenwerk
ebc4c408e3 fix tests for conversation.getThreads generator.
svn path=/plone.app.discussion/trunk/; revision=34911
2010-03-16 10:52:25 +00:00
Timo Stollenwerk
4ed9d08119 fix the moderator notification for Plone 3.x.
svn path=/plone.app.discussion/trunk/; revision=34698
2010-03-11 19:23:53 +00:00
Timo Stollenwerk
ce7e47f07b remove the user notification feature for now, since it requires the current z3c.form trunk and does not work with the latest release on PyPi.
svn path=/plone.app.discussion/trunk/; revision=34697
2010-03-11 19:23:26 +00:00
Timo Stollenwerk
1d39b53c4b Merge notification branch into trunk:
New feature: As a moderator, I am notified when new comments require my attention;
New feature: As a commenter, I can enable/disable email notification of additional comments on this object;
Make p.a.d. work with the recent version of plone.z3cform (0.5.10);

svn path=/plone.app.discussion/trunk/; revision=34602
2010-03-06 10:04:34 +00:00
Timo Stollenwerk
d81b95f7c1 more catalog tests added.
svn path=/plone.app.discussion/branches/notification/; revision=34476
2010-03-03 19:20:02 +00:00
Timo Stollenwerk
90c44a7c67 test do not notify user when no sender is available.
svn path=/plone.app.discussion/branches/notification/; revision=33964
2010-02-13 21:44:26 +00:00
Timo Stollenwerk
be3d347471 user email notification added.
svn path=/plone.app.discussion/branches/notification/; revision=33963
2010-02-13 21:31:17 +00:00
Timo Stollenwerk
38fd65f46d remove whitespace to make coverage-test happy.
svn path=/plone.app.discussion/branches/notification/; revision=33929
2010-02-12 10:21:39 +00:00
Timo Stollenwerk
6e46ce7581 test moderator notification enabled setting.
svn path=/plone.app.discussion/branches/notification/; revision=33928
2010-02-12 10:11:01 +00:00
Timo Stollenwerk
f0fb6514c7 Moderator email notification added: As a moderator, I am notified when new comments require my attention.
svn path=/plone.app.discussion/branches/notification/; revision=33921
2010-02-11 21:05:28 +00:00
Timo Stollenwerk
67b5ff566e fix singlecheckboxwidget for comment form.
svn path=/plone.app.discussion/branches/notification/; revision=33873
2010-02-08 18:28:03 +00:00
Timo Stollenwerk
23eeb041aa comment out CommentForm test.
svn path=/plone.app.discussion/trunk/; revision=33845
2010-02-07 11:37:34 +00:00
Timo Stollenwerk
2ffbe75611 collection test added (failing).
svn path=/plone.app.discussion/trunk/; revision=33780
2010-02-05 22:40:38 +00:00
Hanno Schlichting
c27d1b5cc1 De-tabbify
svn path=/plone.app.discussion/trunk/; revision=33491
2010-01-27 14:54:07 +00:00
Timo Stollenwerk
3c22930ba2 test discussion control panel view.
svn path=/plone.app.discussion/trunk/; revision=33314
2010-01-23 09:02:09 +00:00
Timo Stollenwerk
6ca20c7514 Make test coverage happy. 1 second seems to be not enough to create a comment when running the test coverage.
svn path=/plone.app.discussion/trunk/; revision=33309
2010-01-23 07:26:19 +00:00
Timo Stollenwerk
1e58aa63b1 fix CommentViewlet has_replies method.
svn path=/plone.app.discussion/trunk/; revision=33282
2010-01-22 19:02:41 +00:00
Timo Stollenwerk
0b530a0a75 Ugly hack that works around a "ContentProviderLookupError: plone.htmlhead" error caused by Zope 2 permissions. See https://bugs.launchpad.net/zope2/+bug/176566 for further details. This error occured on Plone 3.3.x only.
svn path=/plone.app.discussion/trunk/; revision=33275
2010-01-22 16:28:00 +00:00
Timo Stollenwerk
1a1c903086 Integration test for comments viewlet added.
Empty test class for comment form added.

svn path=/plone.app.discussion/trunk/; revision=33271
2010-01-22 12:29:26 +00:00
Timo Stollenwerk
365684f137 test stop iteration for get_replies method.
svn path=/plone.app.discussion/trunk/; revision=33218
2010-01-18 12:20:45 +00:00
Timo Stollenwerk
1bfff5255a more tests for comments viewlet.
svn path=/plone.app.discussion/trunk/; revision=33217
2010-01-18 11:38:57 +00:00
Timo Stollenwerk
ca0aecd170 user portal membership tool for is_anonyous method; tests for comments viewlet added.
svn path=/plone.app.discussion/trunk/; revision=33216
2010-01-18 11:04:08 +00:00
Timo Stollenwerk
77eaee146e tests for comments viewlet added (some are still empty).
svn path=/plone.app.discussion/trunk/; revision=33215
2010-01-18 09:55:44 +00:00
Timo Stollenwerk
dc2e5232f7 fix migration tests. do not use transactions during unit testing.
svn path=/plone.app.discussion/trunk/; revision=32805
2010-01-03 17:36:01 +00:00
Timo Stollenwerk
adb0390227 use object_provides instead of portal_type to query the catalog for comments. this fixes bug #2010085;
svn path=/plone.app.discussion/trunk/; revision=32538
2009-12-19 15:03:12 +00:00
Timo Stollenwerk
47cba8797f filter tabs removed from moderation view;
svn path=/plone.app.discussion/trunk/; revision=32355
2009-12-08 11:19:26 +00:00
Timo Stollenwerk
58f8f4bf22 Do not show "publish" bulk action in moderation view when moderation is disabled. Fix story 1105355
.

svn path=/plone.app.discussion/trunk/; revision=30678
2009-10-18 13:12:52 +00:00
Timo Stollenwerk
8db9c8c175 Removing hard coded publish action. evilbungle branch merge.
svn path=/plone.app.discussion/trunk/; revision=30669
2009-10-17 16:14:44 +00:00
Timo Stollenwerk
7cd9ef2491 Changing browser:view registrations to browser:page since view doesn't actually do anything with the permissions. This fixes the anyone can delete comments problem. evilbungle branch merge.
svn path=/plone.app.discussion/trunk/; revision=30665
2009-10-17 13:50:55 +00:00
Timo Stollenwerk
1ea36d7d82 Conversation indexers won't work on old discussion items. Fix tests.
svn path=/plone.app.discussion/trunk/; revision=30658
2009-10-17 08:28:50 +00:00
Timo Stollenwerk
e5f1a70de6 Make unit tests pass with Plone 3.3 again. Migration tests still failing.
svn path=/plone.app.discussion/trunk/; revision=30633
2009-10-16 12:11:58 +00:00
Hanno Schlichting
71ed707794 Get this running again for the most part under Plone 4.0 - the main trick was probably to use the new CMFCatalogAware class. Removed collective.testcaselayer dependency, as that broke totally. There's some test failures left, but indexing works in general. Maybe the custom indexing event handlers aren't all required anymore. The title_or_id test failure looks like there's an infinite loop in the __parent__ pointers never reaching the actual content object. This change breaks Plone 3.x compatibility for the moment.
svn path=/plone.app.discussion/trunk/; revision=30629
2009-10-16 00:42:08 +00:00
Timo Stollenwerk
f4a4b6e370 fix catalog clear-and-rebuild. this finally fixes story 847941.
svn path=/plone.app.discussion/trunk/; revision=30610
2009-10-15 10:11:12 +00:00
Timo Stollenwerk
9befc4c651 Monkey patch for clear-and-rebuild catalog added. This fixes story 847941. Nested comments are not reindexed yet.
svn path=/plone.app.discussion/trunk/; revision=30574
2009-10-14 14:58:08 +00:00