ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,612 Commits 1 Branch 0 Tags 5 MiB
4a83166d95
Commit Graph

356 Commits

Author SHA1 Message Date
Timo Stollenwerk
a6afdf265c Pep8 2013-01-10 18:40:04 +01:00
Timo Stollenwerk
69b628c386 Pep8. 2013-01-10 18:33:46 +01:00
William Deegan
372b573cb1 move creation of test user to test setup, rather than just in the new test_migrate_comment_with_creator() method 2012-12-15 16:45:56 -08:00
William Deegan
ff1f65a75e simplify some of the logic and get some tests in place to cover them. TDB: test against actual site to ensure the changes to the logic don't break a real environment, but still work with the tests.. 2012-12-13 21:14:40 -08:00
Kees Hink
e57d3a2ad4 Convert test for invalid comment id in url to integration test. 2012-11-16 10:29:50 +01:00
Kees Hink
6bd31ad490 Make conversation view not break when comment-id cannot be converted to long, fixes #13327 2012-11-14 13:25:10 +01:00
Timo Stollenwerk
41a53fc8ff Fix failing test. 2012-11-04 17:18:46 +01:00
Gaudenz Steinlin
56b08b2247 Fix catalog updates for IObjectMovedEvent 
If comments were moved because an object on a higher level than the
commented object was moved, these comments were wrongly reindexed.
The commented object also got a wrong __parent__ pointer.

This fixes https://dev.plone.org/ticket/13172.
 2012-09-17 16:52:05 +02:00
David Glick
58b4205f38 Revert "Attempt to fix test_format_time()." 
This reverts commit c231794940.
 2012-08-02 22:21:26 -07:00
David Glick
7fe9f062e8 Revert "Update master" 
This reverts commit 53ec8e52ea.
 2012-08-02 22:21:19 -07:00
Karl Johan Kleist
53ec8e52ea Update master 2012-07-18 06:58:17 +03:00
Karl Johan Kleist
c231794940 Attempt to fix test_format_time(). 2012-07-18 06:56:14 +03:00
Timo Stollenwerk
528e1a1434 Run ConversationTest for dexterity types only if dexterity is installed. 2012-07-12 18:56:10 +02:00
Timo Stollenwerk
103c7323e7 Fix test that fails due to the creator/author_name changes. 2012-07-12 17:29:05 +02:00
Timo Stollenwerk
a6a48a58dd Fix test that fails due to the css id changes due to comment text field. 2012-07-12 17:28:12 +02:00
Timo Stollenwerk
c47689af42 Fix handling of comments with invalid transforms. Write an error msg to the log and just return the untransformed text. 2012-07-12 16:03:02 +02:00
Timo Stollenwerk
702f7e1f1d Make 'text/plain' the default mime type for comments and make sure the default type is set properly when creating a new comment. 2012-07-12 16:01:07 +02:00
Timo Stollenwerk
f45373b311 Test for mime type transformation from html to html added. 2012-07-12 15:54:38 +02:00
Timo Stollenwerk
0535e659ff Refactor the comment creator/author_name to comply with the Plone core convention to store the username on the creator attribute and not the fullname. 2012-07-12 15:39:27 +02:00
Timo Stollenwerk
f45a2e8bba Replace deprecated unit test methods. 2012-07-12 15:08:22 +02:00
Karl Johan Kleist
636e77e3b2 Reverting, as per Timo's comment in 49734cd39b (commitcomment-1559057). 
So Jenkins is running the tests using the en-US locale?
 2012-07-10 10:56:56 +03:00
Karl Johan Kleist
49734cd39b Fallback for localized time is now ISO style. 
https://jenkins.plone.org/job/plone-4.3-tests/89/testReport/junit/plone.app.discussion.tests.test_comments_viewlet/TestCommentsViewlet/test_format_time/
 2012-07-07 11:58:46 +03:00
Timo Stollenwerk
0e587a7d85 Support for Dexterity added. 2012-06-30 10:59:49 +02:00
Paul J Stevens
53428fe5f6 total_comments only counts published comments 
Also migrate workflow state during migration.
 2012-06-13 11:17:22 +00:00
Paul J Stevens
e31f90c440 Prune duplicated test code 2012-06-12 14:44:42 +00:00
Timo Stollenwerk
f66d6e1c05 Make topic/collection tests pass when plone.app.collection is installed. 2012-04-02 22:00:27 +02:00
Timo Stollenwerk
4d330f2daa Make comment collection tests work with plone.app.collection. 2012-03-31 18:40:58 +02:00
Elizabeth Leddy
877f2d3e84 fix url redirect for content types that must have /view in url to view contents 2012-03-14 15:01:17 -07:00
tisto
81fd515455 Pep8 2012-01-14 07:53:03 +01:00
tisto
11e101f7d7 Pep8 2012-01-14 07:47:07 +01:00
tisto
aa36c0bc9b Pep8 2012-01-14 07:41:50 +01:00
tisto
2dc5393ff2 Pep8 2012-01-14 07:35:59 +01:00
tisto
0558a9b739 Pep8 2012-01-14 07:26:01 +01:00
tisto
a3883d7e7b Pep8 2012-01-14 07:13:39 +01:00
tisto
f520482eb3 Pep8 2012-01-14 07:03:29 +01:00
Timo Stollenwerk
e17cfa68a1 Fix whitespace/Pep8/Pyflakes in tests. 2012-01-09 16:43:54 +01:00
Timo Stollenwerk
3b1d1b8967 Changelog entry and test to fix #12437 added. 2011-12-21 19:37:40 +01:00
Timo Stollenwerk
f68c2caf9f Remove unused PloneTestCase import. 2011-10-30 08:19:30 +01:00
Timo Stollenwerk
b0a177f4d2 Fix various text typos. 2011-10-30 08:11:06 +01:00
Timo Stollenwerk
cdf2beda40 Make sure only comments to the content object are removed from the catalog when the content object is moved. 
svn path=/plone.app.discussion/trunk/; revision=51527
 2011-08-04 15:53:21 +00:00
Timo Stollenwerk
0e47299c75 Make sure the comment brains are updated properly when the content object is renamed. Thanks hannosch for the code review. 
svn path=/plone.app.discussion/trunk/; revision=51526
 2011-08-04 14:13:01 +00:00
Timo Stollenwerk
9cd4058bca Move move_comments test to the right position. 
svn path=/plone.app.discussion/trunk/; revision=50947
 2011-07-04 07:27:16 +00:00
Timo Stollenwerk
b7dad192d5 Update comment brains in zcatalog when moving a content object with comments. This fixes http://dev.plone.org/plone/ticket/11331. Refs #11331 
svn path=/plone.app.discussion/trunk/; revision=50937
 2011-07-03 18:36:02 +00:00
Erico Andrei
1a751b495f Unless Discussion Item has an workflow, moderation is not enabled 
svn path=/plone.app.discussion/trunk/; revision=49135
 2011-04-27 17:41:07 +00:00
Timo Stollenwerk
e75685d5c0 Add links to delete/approve a comment in the moderator notification email. 
Remove the unnecessary workflow_action parameter from the PublishComments request.

svn path=/plone.app.discussion/trunk/; revision=49045
 2011-04-22 17:09:09 +00:00
Timo Stollenwerk
521ea78ce3 Whitespace. 
svn path=/plone.app.discussion/trunk/; revision=49043
 2011-04-22 17:04:35 +00:00
Timo Stollenwerk
b84211ddf0 Remove ImportError exceptions for Plone < 4.1 code and plone.z3cform < 0.6.0. 
svn path=/plone.app.discussion/trunk/; revision=49033
 2011-04-22 14:59:59 +00:00
Timo Stollenwerk
31ecf38129 Provide the comment body text in the email notification. 
svn path=/plone.app.discussion/trunk/; revision=49032
 2011-04-22 13:34:50 +00:00
Timo Stollenwerk
f8c39c1b87 Fix comment link in email notification. This fixes http://dev.plone.org/plone/ticket/11413 
svn path=/plone.app.discussion/trunk/; revision=49031
 2011-04-22 12:47:29 +00:00
Timo Stollenwerk
49504c1ddd Redirect to the comment itself when notifying a user about a new comment. 
svn path=/plone.app.discussion/trunk/; revision=49030
 2011-04-22 08:54:35 +00:00
Timo Stollenwerk
80a7b90a30 Move all tests from testing layer to plone.app.testing. 
svn path=/plone.app.discussion/trunk/; revision=48916
 2011-04-17 08:51:58 +00:00
Timo Stollenwerk
f3d97b2f20 Use plone.app.testing in test_moderation_view. 
svn path=/plone.app.discussion/trunk/; revision=48915
 2011-04-17 08:50:34 +00:00
Timo Stollenwerk
d66328a26a Use plone.app.testing in test_migration. 
svn path=/plone.app.discussion/trunk/; revision=48906
 2011-04-16 09:51:28 +00:00
Timo Stollenwerk
216e95aa27 Use plone.app.testing in test_indexers. 
svn path=/plone.app.discussion/trunk/; revision=48905
 2011-04-16 09:35:34 +00:00
Timo Stollenwerk
85126e9109 Use plone.app.testing in test_notifications. 
svn path=/plone.app.discussion/trunk/; revision=48904
 2011-04-16 09:31:03 +00:00
Timo Stollenwerk
1682c89745 Use plone.app.testing in test_tool. 
svn path=/plone.app.discussion/trunk/; revision=48903
 2011-04-16 09:30:11 +00:00
Timo Stollenwerk
fc59094cb2 Use plone.app.testing in test_workflow. 
svn path=/plone.app.discussion/trunk/; revision=48902
 2011-04-16 09:29:15 +00:00
Timo Stollenwerk
41f5afa8b9 Use plone.app.testing in test_conversation. 
svn path=/plone.app.discussion/trunk/; revision=48901
 2011-04-16 09:27:15 +00:00
Timo Stollenwerk
c4e69627b3 Use plone.app.testing in test_controlpanel. 
svn path=/plone.app.discussion/trunk/; revision=48900
 2011-04-16 09:26:20 +00:00
Timo Stollenwerk
f8019b0c10 Use plone.app.testing in test_comments_viewlet. 
svn path=/plone.app.discussion/trunk/; revision=48899
 2011-04-16 09:25:16 +00:00
Timo Stollenwerk
38b70a28e5 Use plone.app.testing in test_comment. 
svn path=/plone.app.discussion/trunk/; revision=48898
 2011-04-16 09:16:18 +00:00
Timo Stollenwerk
e5d45dbd78 Use plone.app.testing in test_catalog. 
svn path=/plone.app.discussion/trunk/; revision=48897
 2011-04-16 09:13:39 +00:00
Hanno Schlichting
9db8909ea7 Avoid using deprecated test assertions, see http://docs.python.org/dev/library/unittest.html#deprecated-aliases for the full list 
svn path=/plone.app.discussion/trunk/; revision=48881
 2011-04-15 16:23:38 +00:00
Hanno Schlichting
811d4a0429 Avoid deprecation warnings and always specify a catalog query as a dict 
svn path=/plone.app.discussion/trunk/; revision=48880
 2011-04-15 16:17:02 +00:00
Ross Patterson
3708429a37 Move some policy out of the conversation storage adapter into a view, 
specifically "enabled()".  Prevents having to replace/migrate
persistent objects to change policy which really only concerns the
context and possibly the request, not the conversation storage. Fixes
#11372.

svn path=/plone.app.discussion/trunk/; revision=48849
 2011-04-15 04:29:46 +00:00
Ross Patterson
7354ca4298 Fix unindexing of comments when deleting content resulting from 
iterating over a BTree while modifying it. Fixes #11402.

svn path=/plone.app.discussion/trunk/; revision=48845
 2011-04-14 21:30:32 +00:00
Ross Patterson
5786bfa6b6 pep8 
svn path=/plone.app.discussion/trunk/; revision=48840
 2011-04-14 20:17:10 +00:00
Ross Patterson
cad670d6af Fax Missing.Value for Creator in the catalog. Fixes #11634. 
svn path=/plone.app.discussion/trunk/; revision=48838
 2011-04-14 19:59:05 +00:00
Ross Patterson
187aa60452 These testbrowser tests certainly no longer raise 404s for me 
svn path=/plone.app.discussion/trunk/; revision=48837
 2011-04-14 19:06:55 +00:00
Ross Patterson
d8f864596e The functional tests haven't been running due to an unused import 
svn path=/plone.app.discussion/trunk/; revision=48835
 2011-04-14 19:05:31 +00:00
Ross Patterson
d5a999b429 Clarify a doctest 
svn path=/plone.app.discussion/trunk/; revision=48831
 2011-04-14 16:41:11 +00:00
Ross Patterson
586cd1fdb7 Don't add the annotation unless a comment is actually being added. 
Fixes #11370.

svn path=/plone.app.discussion/trunk/; revision=48829
 2011-04-14 16:17:29 +00:00
David Glick
6d11fa6d5e merge c48523 from 1.x branch 
svn path=/plone.app.discussion/trunk/; revision=48527
 2011-04-07 21:31:56 +00:00
David Glick
636bca745c merge r47140, r47290, r47579 from davisagli-features: fix timezone handling when migrating legacy comments and when indexing 
svn path=/plone.app.discussion/trunk/; revision=48358
 2011-04-02 21:26:36 +00:00
David Glick
9d83b4f0e6 merge -r46947 from davisagli-features: preserve legacy titles on migrated comments 
svn path=/plone.app.discussion/trunk/; revision=48357
 2011-04-02 21:16:24 +00:00
David Glick
eb004aab44 merge r46437 and r46946 from davisagli-features: respect the per-comment mime_type setting, and use the old cooked text/html from legacy comments when migrating 
svn path=/plone.app.discussion/trunk/; revision=48356
 2011-04-02 19:51:37 +00:00
David Glick
bf5946367a merge r46436 from davisagli-features: make it possible to specify a callback filter for the migration 
svn path=/plone.app.discussion/trunk/; revision=48354
 2011-04-02 19:33:10 +00:00
Patrick Gerken
774ed36746 Ups, there is a nother unicode problem 
svn path=/plone.app.discussion/trunk/; revision=47990
 2011-03-08 20:15:37 +00:00
Patrick Gerken
b6d406d298 Trigger failure for objects with unicode titles in string 
svn path=/plone.app.discussion/trunk/; revision=47989
 2011-03-08 20:15:21 +00:00
Maurits van Rees
478273aa80 minor code cleanup 
svn path=/plone.app.discussion/trunk/; revision=47599
 2011-02-15 16:23:12 +00:00
Maurits van Rees
81d74cfe6b Fixed test failure for the default user portrait, which changed from 
defaultUser.gif to defaultUser.png in Products.PlonePAS 4.0.5.

svn path=/plone.app.discussion/trunk/; revision=47597
 2011-02-15 16:19:13 +00:00
Timo Stollenwerk
bf96d0082f Remove "Plone 3 only" code; Do not monkey patch the BAD_TYPES vocabulary or plone.app.vocabularies anymore. 
svn path=/plone.app.discussion/trunk/; revision=47311
 2011-02-08 09:28:51 +00:00
Timo Stollenwerk
0a0e69d47d Do not check for a comment review workflow when sending out a moderator email notification. This fixes http://dev.plone.org/plone/ticket/11444. Refs #11444 
svn path=/plone.app.discussion/trunk/; revision=47292
 2011-02-07 11:48:24 +00:00
Timo Stollenwerk
c438743a3b Show a 'Comments are moderated.' message next to the comment form if comments are moderated. 
svn path=/plone.app.discussion/trunk/; revision=46782
 2011-01-07 10:20:24 +00:00
Maurits van Rees
a2a17085a3 Nuke trailing white space 
svn path=/plone.app.discussion/trunk/; revision=46366
 2010-12-15 23:52:56 +00:00
Maurits van Rees
aff8a3709c Avoid sending multiple notification emails to the same person when 
he has commented multiple times.

svn path=/plone.app.discussion/trunk/; revision=46365
 2010-12-15 23:41:57 +00:00
David Glick
0cb75778ba make sure comments don't get indexed with their parents' UID in Plone 3. only declare dependency on plone.app.uuid in Python 2.6, since we only use it in Plone 4 currently. 
svn path=/plone.app.discussion/trunk/; revision=46353
 2010-12-15 20:39:55 +00:00
Timo Stollenwerk
b9d929bca3 Fix failing test. 
svn path=/plone.app.discussion/trunk/; revision=46344
 2010-12-14 21:30:40 +00:00
Timo Stollenwerk
a8bfd7fc6e Disable discussion by default. 
svn path=/plone.app.discussion/trunk/; revision=46337
 2010-12-14 17:58:46 +00:00
Timo Stollenwerk
d702c666f0 Tests for moderation_enabled setting added. 
svn path=/plone.app.discussion/trunk/; revision=46266
 2010-12-12 13:56:06 +00:00
Timo Stollenwerk
0475376ed0 "Enable comment moderation" setting added to the discussion control panel. Just a proof of concept so far. Not fully implemented yet. No tests. 
svn path=/plone.app.discussion/trunk/; revision=46249
 2010-12-11 17:18:14 +00:00
Timo Stollenwerk
09a804aa88 Remove unnecessary and failing test. 
svn path=/plone.app.discussion/trunk/; revision=46235
 2010-12-10 09:16:36 +00:00
Timo Stollenwerk
54af7d3fa1 Assigning the 'Reply to item' permission to the 'Authenticated' role. The old commenting system allowed 'Authenticated' users to post comments. Also, OpenID users do not possess the 'Authenticated' role. Refs #9288 
svn path=/plone.app.discussion/trunk/; revision=46230
 2010-12-10 08:57:35 +00:00
Timo Stollenwerk
45140c66db Functional test for posting a comment as user without the 'Reply to item' permission added. 
svn path=/plone.app.discussion/trunk/; revision=46215
 2010-12-09 10:58:32 +00:00
Timo Stollenwerk
7e279d3ad3 Make sure the handleComment method checks for the 'Reply to item' permission when adding a comment. 
svn path=/plone.app.discussion/trunk/; revision=46212
 2010-12-09 08:11:41 +00:00
Timo Stollenwerk
0c94707743 Dynamically show the comment formatting message dependent on the text transform setting. 
svn path=/plone.app.discussion/trunk/; revision=46035
 2010-11-29 22:42:20 +00:00
Timo Stollenwerk
f0cecaf274 Always set the effective date of a comment to the same value as the creation date. 
svn path=/plone.app.discussion/trunk/; revision=46019
 2010-11-29 17:36:52 +00:00
Timo Stollenwerk
ac4a64f55d Make sure comment UIDs in the catalog are always unique. This fixes 
http://dev.plone.org/plone/ticket/10652. We depend on plone.uuid and plone.app.uuid now. Refs #10652.

svn path=/plone.app.discussion/trunk/; revision=46005
 2010-11-28 11:39:19 +00:00
Timo Stollenwerk
b08d7ddbeb revert r46002. 
svn path=/plone.app.discussion/trunk/; revision=46003
 2010-11-28 10:00:31 +00:00
Timo Stollenwerk
7e39197114 hudson buildout added. 
svn path=/plone.app.discussion/trunk/; revision=46002
 2010-11-28 09:51:35 +00:00