ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,019 Commits 1 Branch 0 Tags 5 MiB
1a45b0a374
Commit Graph

598 Commits

Author SHA1 Message Date
Maurits van Rees
802e3ec04c Make comment on private content not publicly available in search results. 
This is part of PloneHotfix20161129.

Updated metadata.xml version to 1000.  This leaves more room for
profile version increases in earlier releases.  We apply the rolemap
step again to avoid accidentally missing it.
 2017-01-14 17:58:48 +01:00
Gil Forcada
26a21a12d5 Reindex comments when they are modified 2016-09-20 13:05:24 +02:00
Maurits van Rees
358ec89c03 Apply security hotfix 20160830 for redirects. 2016-09-19 17:10:10 +02:00
Gil Forcada
d5e7afcd23 Use zope.interface decorator 
This not only makes code more pleasent to read,
but also makes the code python 3 compatible
(while maintaining python 2 compatibility).
 2016-07-08 23:17:03 +02:00
Jens W. Klein
69ded592c3 Merge pull request #104 from plone/maurits-remove-migration 
Removed `comment-migration` view.
 2016-06-13 09:48:39 +02:00
Maurits van Rees
1e9909ab6f Split too complex _enabled_for_archetypes. 2016-06-12 06:51:41 +02:00
Maurits van Rees
d496dfdddc Split too complex handleComment. 2016-06-12 06:51:41 +02:00
Maurits van Rees
814af8d837 Various flake8 fixes. 
- Removed tabs.
- Fixed E731 do not assign a lambda expression, use a def.
- avoid hasattr
 2016-06-12 06:51:35 +02:00
Maurits van Rees
bfeb66ee60 Removed comment-migration view. 
This did not work anymore on Plone 5.  If you still need to migrate
from old-style comments, so from Plone 4.0 or earlier, please upgrade
to Plone 4.3 first.
 2016-06-11 15:56:31 +02:00
Maurits van Rees
6952923b1e Reset the required setting of the author_email widget each time. 
Otherwise, the email field might get set to required when an anonymous
user visits, and then remain required when an authenticated user
visits, making it impossible for an authenticated user to fill in the
form without validation error.  Or when in the control panel the field
is set as not required anymore, that change would have no effect until
the instance was restarted.
 2016-06-10 01:57:04 +02:00
Maurits van Rees
e1dbaef82a Fixed possible cross site scripting (XSS) attack on moderate comments page. 2016-06-03 00:43:21 +02:00
Gil Forcada Codinachs
eee8e3c1b6 Mark edit link for translation (#91) 
Mark edit link for translation.
 2016-04-07 18:36:19 +02:00
Johannes Raggam
ec7fe25b6c Use `getSite()` instead of portal url 
For the discussion controlpanel, change base URLs from portal URL to what getSite returns, but don't change the controlpanels context binding.
This allows for more flexibility when configuring it to be allowed on a sub site with a local registry.
 2016-03-11 14:16:22 +01:00
Johannes Raggam
4df90c2ade remove duplicate 2016-02-10 17:16:35 +01:00
Gil Forcada
cb1bf28c16 Cleanup 
Follow https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst
to clean up the code.
 2016-02-05 09:43:42 +01:00
Davi Lima
3f07781675 Update Site Setup link in all control panels (fixes plone/Products.CMFPlone#1255) 2015-11-23 09:13:00 -03:00
Gil Forcada
0713bcd8bc Use plone i18n domain 
plone.app.discussion is an official Plone core package,
thus their translations belong to plone.app.locales.

This commit removes the plone.app.discussion domain and changes it for
plone.

This fixes:
https://github.com/plone/plone.app.discussion/issues/66
 2015-11-05 00:30:42 +01:00
esteele
98f1f3d6a4 Move portal_properties settings to configuration registry 
commit b13db31e3c55fd5ed9320e9d0c93aea48366c883
Author: esteele <eric@esteele.net>
Date:   Fri Sep 18 10:14:56 2015 +0200

    Remove pdb.

commit 6b3e591583146ca661556ef50cafd02f62c79d46
Author: esteele <eric@esteele.net>
Date:   Fri Sep 18 09:50:06 2015 +0200

    Fix registry id

commit 9dfce9a739496b6023f93376535dccc9a9310517
Author: esteele <eric@esteele.net>
Date:   Thu Sep 17 18:34:42 2015 +0200

    Use registry lookup for types_use_view_action_in_listings
 2015-09-20 17:31:55 +02:00
Philip Bauer
e2bd22e74b fix comment-moderation 2015-09-19 14:58:53 +02:00
Philip Bauer
35e6ab2677 remove discussion.css 2015-09-16 14:58:42 +02:00
ichim-david
99ef943328 Refs #764; added context class to edit link: 
- This styles the link as a button which aligns with the other
  actions that have button styles from bootstrap and
  plonetheme.barcelonata
 2015-09-15 23:38:23 +03:00
ichim-david
6e85735b5b Fix reply button visibility toggle by javascript 2015-09-15 22:43:34 +03:00
ichim-david
cb83fc2042 Refs #764 style tweaks needed for plonetheme.barcelonata coexistance 2015-09-15 00:14:05 +03:00
Philip Bauer
b7f81fc3fe Move anonymous_email_enabled after anonymous_comments in controlpanel 2015-09-13 15:38:46 +02:00
Victor Fernandez de Alba
35862dd6dc Updated links for the renamed 'Types' control panel 2015-07-16 12:17:59 +02:00
vangheem
e2192e5973 use modal pattern for comment edit 2015-05-30 15:20:32 -05:00
vangheem
68665b6f2b Only use edit overlay if available for editing comments. We will need a plone 5 alternative 2015-05-30 11:45:02 -05:00
Low Kian Seong
da84d4d642 Fixing broken test on travis 2015-05-13 20:03:11 +08:00
Gil Forcada
7c8a1371ee 'X not in Y' 2015-05-03 08:56:58 +02:00
Gil Forcada
8b883451ca 80 chars 2015-05-03 08:41:24 +02:00
Gil Forcada
4bc77a2831 Sort imports 
Remove unused ones as well.
 2015-05-03 08:16:41 +02:00
vangheem
bd0637e0b2 fix window load event to use 2015-02-11 16:30:03 -06:00
vangheem
c49c9707ec more js improvements 2015-02-10 16:41:00 -06:00
vangheem
ad3953f794 use requirejs if available 2015-02-10 16:21:17 -06:00
Timo Stollenwerk
5f1a7fb5bc Merge branch 'master' into plip10359-z3cform 
Conflicts:
	CHANGES.rst
 2015-01-29 21:31:45 +01:00
Timo Stollenwerk
c852609111 Merge branch 'master' into delete-own-comments 
Conflicts:
	CHANGES.rst
 2015-01-29 21:14:05 +01:00
Timo Stollenwerk
785bc7b890 Read mail settings from new (Plone 5) registry. 2014-12-13 16:20:08 +01:00
Victor Fernandez de Alba
30c88842c0 Reapplied on correct branch. 
Revert "Revert "Update tag for id=content element to article instead of a simple div.""

This reverts commit 45f58edd06.
 2014-10-09 13:30:53 +02:00
Vincent Fretin
06b20b8f81 merge fix from master (Don't execute createReplyForm js if there is no in_reply_to button) 2014-10-09 11:44:31 +02:00
Vincent Fretin
838f229726 Don't execute createReplyForm js if there is no in_reply_to button. 2014-10-09 11:41:00 +02:00
Vincent Fretin
2a8082cfa7 add delete_own_comment_enabled option in control panel 2014-09-20 16:02:48 +02:00
Thomas Desvenain
a94b3249a9 fixed can_delete called from parent 2014-09-05 11:11:54 +02:00
Gil Forcada
fa127ad85c Whitespaces cleanup 2014-08-23 00:31:28 +02:00
Jens W. Klein
2ba35bb0d4 merge fixed 2014-08-17 04:54:12 +02:00
Jens W. Klein
62b2990b7c merged master 2014-08-17 04:48:44 +02:00
Victor Fernandez de Alba
45f58edd06 Revert "Update tag for id=content element to article instead of a simple div." 
This reverts commit 0165f1b73c.
 2014-08-11 14:11:18 +02:00
Victor Fernandez de Alba
0165f1b73c Update tag for id=content element to article instead of a simple div. 2014-08-11 14:09:48 +02:00
Ammy2
002c81427e Id for textarea of reply form made unique 2014-06-25 02:32:48 +05:30
Andrea Cecchi
9a4e3718fc added Delete comments permission to manage comments deletion 2014-05-15 17:51:05 +02:00
Guido A.J. Stevens
520b1e83f4 provide "delete own comments" as a configurable option 2014-05-15 17:50:32 +02:00
Guido A.J. Stevens
a82352a36c Make comments editable 2014-05-15 17:50:32 +02:00
Timo Stollenwerk
fd6ac0788b Merge pull request #43 from plone/remove-dt-dl-dd 
Remove DL's from portal message in templates.
 2014-05-12 20:52:49 +02:00
Gaudenz Steinlin
fa17c51a7b Replace $.live with $.on 
This is needed for jQuery >= 1.9 compatibility and is compatible with
JQuery >= 1.7 (Plone 4.3 onwards).
 2014-04-28 18:06:41 +02:00
Jens W. Klein
2729f5a7e9 required showed up, but validation needs it on field too. huh. this is not what i expected, but, well, its z3cforms 2014-03-26 11:27:12 +01:00
Jens W. Klein
6bfa19411d bugfix 1: according to IDiscussionSettings.anonymous_email_enabled (cite): 
If selected, anonymous user will have to give their email. - But field
was not required. Now it is.

bugfix 2: anonymous email field was never saved.
 2014-03-25 21:30:50 +01:00
tisto
01641b4957 Merge branch 'fix_reindex_on_publish' of git://github.com/RedTurtle/plone.app.discussion into RedTurtle-fix_reindex_on_publish 2014-03-24 20:49:32 +01:00
maartenkling
0ea9a7131f merge upstream and fix numbering 2014-03-04 09:16:36 +01:00
Kees Hink
6ae623c39d Remove DL's from portal message in templates. 2014-02-11 09:42:42 +01:00
Kees Hink
cc02ed01ad Remove DL's from portal message in templates. 2014-02-11 09:38:54 +01:00
Ovidiu Miron
6bc5db4276 Fixed typo error 2014-02-04 11:46:29 +02:00
Ovidiu Miron
a9d0cb574b Execute the property workflow 2014-02-04 11:15:31 +02:00
maartenkling
8ccd648928 user member.getId as author_username, so membrane users and plone users have portraits and author urls 2014-02-02 14:55:37 +01:00
Benoît Suttor
c3ce01edd0 Use defaultUser.png instead of defaultUser.gif 
Indeed, defaultUser.gif is in a deprecated skins folder (Products/CMFPlone/
skins/plone_deprecated/defaultUser.gif) and not defaultUser.png
(Products/CMFPlone/skins/plone_images/defaultUser.png).
Test is also updated.
 2013-11-13 15:53:12 +01:00
maartenkling
c45650261e Rename @@discussion-settings to @@discussion-controlpanel 2013-11-12 10:45:59 +01:00
JeanMichel FRANCOIS
410b8c998a Fix ownership of comments. 2013-11-05 10:23:15 +01:00
JeanMichel FRANCOIS
34bbd39829 fix: add form serialized data to the delete comment ajax form submit 
Even if in fresh Plone there is no data, I'm in a case where I'm adding
'ajax' marker in the form to not render all the page (which is the case
here) and the render is not used at all except if the action do not
happens in ajax.
 2013-08-21 11:07:48 +02:00
Andrea Cecchi
bde1a1a44a fix reindexObject for comment container object 2013-08-20 15:37:56 +02:00
Andreas Zeidler
b027789391 prevent the viewlet from raising an error for objects that are not annotatable 2013-08-15 00:01:22 +02:00
Timo Stollenwerk
b151244138 Pep8. 2013-04-18 15:51:57 +02:00
Timo Stollenwerk
0a8cd01922 Pep8 2013-04-18 15:46:28 +02:00
Timo Stollenwerk
37faab444a Pep8. 2013-04-18 15:38:17 +02:00
Timo Stollenwerk
0b8112fda1 Pep8. 2013-04-18 15:31:40 +02:00
Timo Stollenwerk
65ade424d8 Pep8. 2013-04-17 14:55:50 +02:00
Asko Soukka
4165a74180 Fix migration to not fail when member has been deleted 2013-04-10 10:28:46 +03:00
Felipe Duardo
7f16b55493 return to last commit... 2013-04-09 13:55:21 -03:00
Felipe Duardo
79a96a8c1e Added a prefix to the id attr of the comment field 
The W3C validator does not accept the attributes id or class started with numbers.
 2013-04-09 12:21:14 -03:00
Patrick Gerken
05f0e7e4d8 Many updates to handle non public comments properly 2013-03-28 14:28:22 +01:00
Timo Stollenwerk
0c6b873bef Do not raise an error when no workflow is assigned to the comment type. 2013-03-27 17:06:14 +01:00
bdbaddog
6f675b6f80 Merge pull request #23 from bdbaddog/fix_comment_user_migration 
fix migration of author_name and author_username
 2013-02-11 10:20:41 -08:00
ichim-david
e2d8543020 Cherry-picked 7a48d5 and 10f031 from 2.1.x branch to master 2013-02-03 22:07:51 +02:00
JeanMichel FRANCOIS
a16958c1c7 add anonymous_email_enabled settings to really let integrator activate it. add the migration script which add the option to the registry and do not change the behavior: the email will not be displayed by default 2013-01-04 19:00:24 +01:00
William Deegan
68d195375e use member.getProperty('fullname') if member.fullname is an empty string. Not sure in what case this would happen, but it did happen in my site migration 2012-12-15 16:47:01 -08:00
William Deegan
ff1f65a75e simplify some of the logic and get some tests in place to cover them. TDB: test against actual site to ensure the changes to the logic don't break a real environment, but still work with the tests.. 2012-12-13 21:14:40 -08:00
William Deegan
485571325f fix migration of author_name and author_username 2012-11-27 21:32:07 -08:00
maartenkling
c6af5ee670 Merge remote-tracking branch 'upstream/master' 2012-11-13 09:37:14 +01:00
Timo Stollenwerk
e008bcf54d Whitespace. 2012-11-04 17:25:25 +01:00
maartenkling
f1aaa0d752 The border attribute is obsolete. Consider specifying img { border: 0; } in CSS instead. 2012-11-01 08:31:02 +01:00
Johannes Raggam
882236cb15 For migrations of comments without a valid old_status, apply the 'published' 
state.
 2012-10-31 22:46:10 +01:00
maartenkling
62b0b47b56 remove the submitting completly, the form is submitted fine without and this fixes both #13037 and #12357 2012-10-26 11:12:44 +02:00
maartenkling
cb14c4f89e change how to submit the form to stop ff to hang, this fixes #13037 2012-10-25 21:46:57 +02:00
maartenkling
96d72e7e29 fix #11324, add fallback border color for ie8 and browser that not support boxshadows 2012-10-22 10:04:35 +02:00
maartenkling
66898bb87a remove inline styles, this also fixes #12399 2012-10-22 09:58:40 +02:00
Thijs Jonkman
1fb71d5f17 Unified the site setup html structure 
Change to unify the site setup html structure
=============================================
- Check for structure:

  #portal-column-content
    #content
      .setup-link
      .documentFirstHeading
      .documentDescription
      #content-core

- Check for body template- class

Related changes
---------------
Templates have also changed in:
  plone.app.contentrules
  plone.app.controlpanel
  plone.app.discussion
  plone.app.registry
  plone.app.users
  Products.CMFPlone

Styles have been updated in plonetheme.sunburst
 2012-10-14 17:00:13 +02:00
rnd0101
cdea1ce59d Update plone/app/discussion/browser/comments.pt 
i18n for the Anonymous
 2012-09-19 12:55:55 +03:00
Izak Burger
cde250bf4c remove unused local variable. 2012-09-17 23:57:13 +02:00
Izak Burger
4d1e7b5806 don't ignore user_notification checkbox. 2012-09-17 23:51:15 +02:00
Patrick Gerken
9146aa8025 Don't use reindexObject from catalog, but from the object 
collective.indexing assumes that reindexObject from catalog is not
an official api method, therefor it does not patch it.
This results in missing updates if plone.app.discussion is used
together with solr, which uses collective.indexing
 2012-08-22 18:00:27 +02:00
Timo Stollenwerk
702f7e1f1d Make 'text/plain' the default mime type for comments and make sure the default type is set properly when creating a new comment. 2012-07-12 16:01:07 +02:00
Timo Stollenwerk
ac9d4f9584 Rename the id of the text widgets because there can be css-id clashes with 
the text field of documents when using TinyMCE in overlays or multiple
instances of TinyMCE on a single page.
 2012-07-12 15:49:19 +02:00
Timo Stollenwerk
0535e659ff Refactor the comment creator/author_name to comply with the Plone core convention to store the username on the creator attribute and not the fullname. 2012-07-12 15:39:27 +02:00