Commit Graph

1350 Commits

Author SHA1 Message Date
Jon Pentland 0d643964a2 Don't convert time when adding timezone in getter. Refactor time comparison in tests to correct direction (avoid comparing against negative deltas) 2022-10-23 10:24:59 +02:00
Jon Pentland 2df8ff4ea7 Try reindexing comment and increasing delta (in case of slow test causing failure) 2022-10-22 13:13:20 +02:00
Jon Pentland 35b11a0120 Prevent test failures when converting to timezone 2022-10-22 12:16:14 +02:00
Jon Pentland 194f2d9f76 Use configured portal timezone in tests 2022-10-22 11:48:10 +02:00
Jon Pentland b28d6d1f91 Don't set the server timezone, seems to break other tests 2022-10-21 18:12:08 +02:00
Jon Pentland 9944796627 Fix timezone tests 2022-10-21 17:11:19 +02:00
Jon Pentland f0cd076fd7 Update test_indexers to account for local timezones. Test across daylight savings bounds. 2022-10-21 15:20:32 +02:00
Jon Pentland c70abe2b63 Create a test for the custom getter to ensure timezones are being added 2022-10-21 15:19:27 +02:00
Jon Pentland 2506286c43 Create custom __getattribute__ method to return timezone aware dates from older Comment objects 2022-10-21 15:18:09 +02:00
Jon Pentland 103bd894d9 Use correct timezone when indexing comments 2022-10-21 15:17:34 +02:00
Jon Pentland fd1cfa8cad Use local timezone when setting dates 2022-10-21 15:16:58 +02:00
Jon Pentland 45ef9a51c4 Fix syntax errors 2022-10-18 16:56:05 +02:00
Jon Pentland d6bbff89c7 update conversation tests 2022-10-18 16:40:30 +02:00
Jon Pentland f1b753d088 Update tests 2022-10-18 16:33:08 +02:00
Jon Pentland 42e5238622 Update tests 2022-10-18 16:17:17 +02:00
Jon Pentland 16123e268b Set timezone for creation and modification dates of comments 2022-10-18 16:06:24 +02:00
David Glick 3f8f647e03
Fix password used in tests 2022-10-05 20:49:42 +02:00
David Glick cf68b9ece0
missed file 2022-09-18 20:46:04 -07:00
David Glick 8a64e85435
Use longer passwords for tests 2022-09-18 19:30:04 -07:00
Maurits van Rees 266d87b3b9
Test-only fix: normalize white space when comparing output of comment.getText().
Needed to not fail with newer `plone.outputfilters` from this PR: https://github.com/plone/plone.outputfilters/pull/49
Comments go through the outputfilters, and the new branch calls `soup.prettify()` from `Beautifulsoup`, leading to more white space.
Sample test failures on Jenkins, see https://jenkins.plone.org/job/plip-plip-image-srcsets-3.8/5/#showFailuresLink

```
'<p>\n Go to http://www.plone.org\n</p>' != '<p>Go to http://www.plone.org</p>'
- <p>
-  Go to http://www.plone.org
? ^                          ^
+ <p>Go to http://www.plone.org</p>? ^^^                          ^^^^
- </p>

  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
    yield
  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 676, in run
    self._callTestMethod(testMethod)
  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
    method()
  File "/home/jenkins/.buildout/eggs/cp38/plone.app.discussion-4.0.0a7-py3.8.egg/plone/app/discussion/tests/test_comment.py", line 180, in test_getText_doesnt_link
    self.assertEqual(
  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 912, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 1292, in assertMultiLineEqual
    self.fail(self._formatMessage(msg, standardMsg))
  File "/srv/python3.8/lib/python3.8/unittest/case.py", line 753, in fail
    raise self.failureException(msg)
```
2022-06-10 13:50:16 +02:00
Maurits van Rees 1ea81e4a90
Increase metadata version to 2000.
We need to leave some room for another upgrade step in Plone 5.2.
2022-05-10 21:36:50 +02:00
Maurits van Rees 245a2d9be3
Grant Site Administrators the same workflow permissions as Managers.
They were missing permissions on pending comments.
Fixes https://github.com/plone/plone.app.discussion/issues/199
2022-05-10 21:32:46 +02:00
Jens W. Klein fe10c7448f
Merge pull request #195 from plone/plone-base-overhaul
Plone base overhaul
2022-05-03 15:10:38 +02:00
Maurits van Rees ef6b558c28
Make compatible with robotframework 3-5. 2022-05-02 23:03:24 +02:00
Maurits van Rees e81e26c02b
Removed a few more unicode literals. 2022-05-02 17:12:04 +02:00
Jens W. Klein bcb9315772 add newsfile 2022-05-02 00:43:21 +02:00
Jens W. Klein f443deacbd use plone.base and remove dependencies to CMFPlone 2022-05-02 00:39:34 +02:00
Jens W. Klein 19571f45ed remove six plus some bbb cleanup 2022-05-01 23:28:00 +02:00
Jens W. Klein 75c6a5dcc1 find -name "*.py" -exec pyupgrade --py3-only --py37-plus {} + 2022-05-01 23:14:41 +02:00
Jens W. Klein 34b758f2bd black 2022-05-01 23:14:09 +02:00
Jens W. Klein e72d86b985 isort 2022-05-01 23:14:00 +02:00
Maurits van Rees 336642ddc3
Replaced use of plone.api.
That should not be done in Plone core.
2022-04-14 18:29:09 +02:00
Philip Bauer b9d794489c no longer register old resources 2022-03-23 21:09:23 +01:00
MrTango a79670d3a1 Moved JS to Mockup control panel patterns (ES6) 2022-03-23 21:09:23 +01:00
Godefroid Chapelle 8bc3d824e6 Fix test
after PortalTransforms uses lxml html method to serialize
(instead of xml method)
2022-03-15 12:12:39 +01:00
Miu Razvan 733efe3287 Changed import_step to rolemap 2022-03-01 13:09:03 +02:00
Miu Razvan 5beb673321 Add upgrade step 2022-03-01 13:07:27 +02:00
Miu Razvan d6bfa9eebd #180 Added 'View comments' permission 2022-02-17 16:37:38 +02:00
Mikel Larreategi 62e0eb8059 add missing i18n:translate tags 2021-10-14 07:57:12 +02:00
Érico Andrei 6f3fa11f10 Implement events for Comment (ICommentModifiedEvent) and Reply(IReplyModifiedEvent) modification 2021-09-08 16:18:39 +02:00
Stefan Antonelli c4c2bb8095 fix tests 2021-02-17 19:36:26 +01:00
Stefan Antonelli 82ca44ee68 add i18n message id 2021-02-17 16:02:26 +01:00
Stefan Antonelli 6bbd1aa91a move warning messages to code 2021-02-17 15:46:11 +01:00
agitator 8e614828e5
Merge pull request #176 from plone/issue_169_bootstrap_5
Update Markup
2021-02-16 10:31:42 +01:00
Stefan Antonelli 7212f49b3b update markup, fix js for controlpanel 2021-02-15 17:06:49 +01:00
Peter Mathis 3d53ab09cc add upgradestep and update classifiers 2021-02-15 15:34:19 +01:00
André Gonçalves 5d0d97a432
Update markup of templates to Bootstrap 5 (#173)
* Update markup of all buttons, forms and input elements to Bootstrap 4

* Add documentByLine in the card-header. Add commentBody in the card-body

* Update CHANGES.txt

* Update @@manage-comments.pt moderation interface with Bootstrap 4

* bs5 form updates

* add bootstrap icon from resolver

* update bindings for button

* update markup for bootstrap 5

* turn configlet portlets into menu

* turn configlet portlets into menu (2)

* bootstrap b1 changes

* major version bump

Co-authored-by: Peter Holzer <peter.holzer@agitator.com>
Co-authored-by: Jens W. Klein <jk@kleinundpartner.at>
Co-authored-by: Peter Mathis <peter.mathis@kombinat.at>
2021-02-13 09:56:21 +01:00
Maurits van Rees 4d36d0b342
Fix tests with Products.MailHost 4.11.
Fixes https://github.com/plone/plone.app.discussion/issues/174
2021-01-22 16:37:12 +01:00
Maurits van Rees c9d9cfca04
Message test: we never get a Message object, but always bytes/string/unicode.
Which type we get back, depends on the Python version and the Products.MailHost version.
2020-09-23 15:35:32 +02:00
Maurits van Rees e4bcf2f53c
Fix tests with Products.MailHost 4.10. 2020-09-23 15:26:30 +02:00