58711579c4
isort
2018-06-15 10:22:11 +02:00
71dcbf8465
some py3 fixes
2018-03-18 17:01:27 +01:00
93a227c80d
Add Python 2 / 3 compatibility
2018-01-25 13:04:11 +01:00
d496dfdddc
Split too complex handleComment.
2016-06-12 06:51:41 +02:00
6952923b1e
Reset the required setting of the author_email widget each time.
...
Otherwise, the email field might get set to required when an anonymous
user visits, and then remain required when an authenticated user
visits, making it impossible for an authenticated user to fill in the
form without validation error. Or when in the control panel the field
is set as not required anymore, that change would have no effect until
the instance was restarted.
2016-06-10 01:57:04 +02:00
cb1bf28c16
Cleanup
...
Follow https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst
to clean up the code.
2016-02-05 09:43:42 +01:00
0713bcd8bc
Use plone i18n domain
...
plone.app.discussion is an official Plone core package,
thus their translations belong to plone.app.locales.
This commit removes the plone.app.discussion domain and changes it for
plone.
This fixes:
https://github.com/plone/plone.app.discussion/issues/66
2015-11-05 00:30:42 +01:00
7c8a1371ee
'X not in Y'
2015-05-03 08:56:58 +02:00
4bc77a2831
Sort imports
...
Remove unused ones as well.
2015-05-03 08:16:41 +02:00
2a8082cfa7
add delete_own_comment_enabled option in control panel
2014-09-20 16:02:48 +02:00
62b2990b7c
merged master
2014-08-17 04:48:44 +02:00
9a4e3718fc
added Delete comments permission to manage comments deletion
2014-05-15 17:51:05 +02:00
520b1e83f4
provide "delete own comments" as a configurable option
2014-05-15 17:50:32 +02:00
a82352a36c
Make comments editable
2014-05-15 17:50:32 +02:00
2729f5a7e9
required showed up, but validation needs it on field too. huh. this is not what i expected, but, well, its z3cforms
2014-03-26 11:27:12 +01:00
6bfa19411d
bugfix 1: according to IDiscussionSettings.anonymous_email_enabled (cite):
...
If selected, anonymous user will have to give their email. - But field
was not required. Now it is.
bugfix 2: anonymous email field was never saved.
2014-03-25 21:30:50 +01:00
8ccd648928
user member.getId as author_username, so membrane users and plone users have portraits and author urls
2014-02-02 14:55:37 +01:00
c3ce01edd0
Use defaultUser.png instead of defaultUser.gif
...
Indeed, defaultUser.gif is in a deprecated skins folder (Products/CMFPlone/
skins/plone_deprecated/defaultUser.gif) and not defaultUser.png
(Products/CMFPlone/skins/plone_images/defaultUser.png).
Test is also updated.
2013-11-13 15:53:12 +01:00
410b8c998a
Fix ownership of comments.
2013-11-05 10:23:15 +01:00
b027789391
prevent the viewlet from raising an error for objects that are not annotatable
2013-08-15 00:01:22 +02:00
0a8cd01922
Pep8
2013-04-18 15:46:28 +02:00
0c6b873bef
Do not raise an error when no workflow is assigned to the comment type.
2013-03-27 17:06:14 +01:00
a16958c1c7
add anonymous_email_enabled settings to really let integrator activate it. add the migration script which add the option to the registry and do not change the behavior: the email will not be displayed by default
2013-01-04 19:00:24 +01:00
cde250bf4c
remove unused local variable.
2012-09-17 23:57:13 +02:00
4d1e7b5806
don't ignore user_notification checkbox.
2012-09-17 23:51:15 +02:00
702f7e1f1d
Make 'text/plain' the default mime type for comments and make sure the default type is set properly when creating a new comment.
2012-07-12 16:01:07 +02:00
ac9d4f9584
Rename the id of the text widgets because there can be css-id clashes with
...
the text field of documents when using TinyMCE in overlays or multiple
instances of TinyMCE on a single page.
2012-07-12 15:49:19 +02:00
0535e659ff
Refactor the comment creator/author_name to comply with the Plone core convention to store the username on the creator attribute and not the fullname.
2012-07-12 15:39:27 +02:00
53428fe5f6
total_comments only counts published comments
...
Also migrate workflow state during migration.
2012-06-13 11:17:22 +00:00
a7b3c818f2
Delete own comments
...
Add permission to allow comment authors to delete their own comments if
there are no replies yet.
2012-05-29 13:33:46 +02:00
ebb39b4994
No need to define portal_membership tool twice.
2012-03-19 16:32:33 +01:00
910f75aa7e
Make comments and controlpanel views more robust, so they don't break if no workflow is assigned to the 'Discussion Item' content type.
2012-03-15 13:06:00 +01:00
0558a9b739
Pep8
2012-01-14 07:26:01 +01:00
87700f3810
Markdown syntax added to possible comment text transforms.
...
svn path=/plone.app.discussion/trunk/; revision=51530
2011-08-05 10:08:39 +00:00
98bcc19d5c
Do not render/update the comment form in CommentViewlets if commenting is disabled, since this slows down the page rendering. This fixes http://dev.plone.org/plone/ticket/11930 #11930
...
svn path=/plone.app.discussion/trunk/; revision=50489
2011-06-16 10:59:25 +00:00
a7f61eb4d3
Refactor/clean up the handleComment method.
...
svn path=/plone.app.discussion/trunk/; revision=50069
2011-05-27 13:47:15 +00:00
1ea5f0cdb4
Make handleComment method store comment attributes from form extenders. This allows us to extend the comment form with external add-ons.
...
svn path=/plone.app.discussion/trunk/; revision=50059
2011-05-26 21:37:37 +00:00
b84211ddf0
Remove ImportError exceptions for Plone < 4.1 code and plone.z3cform < 0.6.0.
...
svn path=/plone.app.discussion/trunk/; revision=49033
2011-04-22 14:59:59 +00:00
f2e47227f9
Fix old-style exception raising
...
svn path=/plone.app.discussion/trunk/; revision=48884
2011-04-15 16:44:16 +00:00
3708429a37
Move some policy out of the conversation storage adapter into a view,
...
specifically "enabled()". Prevents having to replace/migrate
persistent objects to change policy which really only concerns the
context and possibly the request, not the conversation storage. Fixes
#11372 .
svn path=/plone.app.discussion/trunk/; revision=48849
2011-04-15 04:29:46 +00:00
eb004aab44
merge r46437 and r46946 from davisagli-features: respect the per-comment mime_type setting, and use the old cooked text/html from legacy comments when migrating
...
svn path=/plone.app.discussion/trunk/; revision=48356
2011-04-02 19:51:37 +00:00
feb1759958
fix incorrect parenthesization
...
svn path=/plone.app.discussion/trunk/; revision=48240
2011-03-26 05:04:22 +00:00
7c2a815fdb
Fixed internationalization issues.
...
svn path=/plone.app.discussion/trunk/; revision=48110
2011-03-17 16:15:40 +00:00
0c435dc9ca
Check if the current user has configured an e-mail address for the email notification option. Refs #11428
...
svn path=/plone.app.discussion/trunk/; revision=47069
2011-01-26 08:15:14 +00:00
c438743a3b
Show a 'Comments are moderated.' message next to the comment form if comments are moderated.
...
svn path=/plone.app.discussion/trunk/; revision=46782
2011-01-07 10:20:24 +00:00
a2a17085a3
Nuke trailing white space
...
svn path=/plone.app.discussion/trunk/; revision=46366
2010-12-15 23:52:56 +00:00
4c4cd9e44d
Replace XXX with todo.
...
svn path=/plone.app.discussion/trunk/; revision=46263
2010-12-12 08:14:48 +00:00
7e279d3ad3
Make sure the handleComment method checks for the 'Reply to item' permission when adding a comment.
...
svn path=/plone.app.discussion/trunk/; revision=46212
2010-12-09 08:11:41 +00:00
c311a4f88d
Check for the 'review comments' permission instead of 'manage' to decide if the user should see a 'this comment is pending' message.
...
svn path=/plone.app.discussion/trunk/; revision=46050
2010-12-01 06:34:05 +00:00
0c94707743
Dynamically show the comment formatting message dependent on the text transform setting.
...
svn path=/plone.app.discussion/trunk/; revision=46035
2010-11-29 22:42:20 +00:00
Jens W. Klein
Philip Bauer
Maurits van Rees
Gil Forcada
Vincent Fretin
Andrea Cecchi
Guido A.J. Stevens
Jens W. Klein
maartenkling
Benoît Suttor
JeanMichel FRANCOIS
Andreas Zeidler
Timo Stollenwerk
Izak Burger
Paul J Stevens
Gaudenz Steinlin
Timo Stollenwerk
Hanno Schlichting
Ross Patterson
David Glick
Thomas Desvenain