Commit Graph

58 Commits

Author SHA1 Message Date
Maurits van Rees
802e3ec04c Make comment on private content not publicly available in search results.
This is part of PloneHotfix20161129.

Updated metadata.xml version to 1000.  This leaves more room for
profile version increases in earlier releases.  We apply the rolemap
step again to avoid accidentally missing it.
2017-01-14 17:58:48 +01:00
Gil Forcada
26a21a12d5 Reindex comments when they are modified 2016-09-20 13:05:24 +02:00
Gil Forcada
cb1bf28c16 Cleanup
Follow https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst
to clean up the code.
2016-02-05 09:43:42 +01:00
Gil Forcada
ce48a9ed46 2 spaces before inline comment 2015-05-03 08:41:56 +02:00
Gil Forcada
4bc77a2831 Sort imports
Remove unused ones as well.
2015-05-03 08:16:41 +02:00
David Glick
8690461ffb create doc1 in the text fixture rather than in setup for each test 2015-03-09 21:51:45 -07:00
Jens W. Klein
67213b70eb make flake8 happy 2014-03-25 18:36:14 +01:00
Timo Stollenwerk
a8dc5dd3f0 Remove test_suite functions since they are only needed for zope.testing < 3.8.0. 2013-12-19 09:54:03 +01:00
tisto
f0a9d9ad6b Pep8 2013-12-15 12:02:32 +01:00
David Glick
7cfbd20d72 don't fail test if portal_atct is missing 2013-11-15 00:11:13 -08:00
Timo Stollenwerk
654869a30d Remove old topic test. New collections are tested in p.a.contenttypes anyways. 2013-11-14 11:01:14 +01:00
tisto
fbc78e2951 Remove portal_discussion tool. 2013-10-10 15:36:18 +02:00
Paul J Stevens
52c6372664 fix deprecation warning 2013-06-04 13:23:22 +00:00
Timo Stollenwerk
849299f233 Pep8. 2013-04-18 15:21:00 +02:00
Timo Stollenwerk
20935da608 Pep8. 2013-04-17 19:37:10 +02:00
Patrick Gerken
05f0e7e4d8 Many updates to handle non public comments properly 2013-03-28 14:28:22 +01:00
Gaudenz Steinlin
56b08b2247 Fix catalog updates for IObjectMovedEvent
If comments were moved because an object on a higher level than the
commented object was moved, these comments were wrongly reindexed.
The commented object also got a wrong __parent__ pointer.

This fixes https://dev.plone.org/ticket/13172.
2012-09-17 16:52:05 +02:00
Timo Stollenwerk
103c7323e7 Fix test that fails due to the creator/author_name changes. 2012-07-12 17:29:05 +02:00
Timo Stollenwerk
0535e659ff Refactor the comment creator/author_name to comply with the Plone core convention to store the username on the creator attribute and not the fullname. 2012-07-12 15:39:27 +02:00
Timo Stollenwerk
f45a2e8bba Replace deprecated unit test methods. 2012-07-12 15:08:22 +02:00
Timo Stollenwerk
4d330f2daa Make comment collection tests work with plone.app.collection. 2012-03-31 18:40:58 +02:00
tisto
0558a9b739 Pep8 2012-01-14 07:26:01 +01:00
tisto
a3883d7e7b Pep8 2012-01-14 07:13:39 +01:00
Timo Stollenwerk
e17cfa68a1 Fix whitespace/Pep8/Pyflakes in tests. 2012-01-09 16:43:54 +01:00
Timo Stollenwerk
3b1d1b8967 Changelog entry and test to fix #12437 added. 2011-12-21 19:37:40 +01:00
Timo Stollenwerk
cdf2beda40 Make sure only comments to the content object are removed from the catalog when the content object is moved.
svn path=/plone.app.discussion/trunk/; revision=51527
2011-08-04 15:53:21 +00:00
Timo Stollenwerk
0e47299c75 Make sure the comment brains are updated properly when the content object is renamed. Thanks hannosch for the code review.
svn path=/plone.app.discussion/trunk/; revision=51526
2011-08-04 14:13:01 +00:00
Timo Stollenwerk
9cd4058bca Move move_comments test to the right position.
svn path=/plone.app.discussion/trunk/; revision=50947
2011-07-04 07:27:16 +00:00
Timo Stollenwerk
b7dad192d5 Update comment brains in zcatalog when moving a content object with comments. This fixes http://dev.plone.org/plone/ticket/11331. Refs #11331
svn path=/plone.app.discussion/trunk/; revision=50937
2011-07-03 18:36:02 +00:00
Timo Stollenwerk
e5d45dbd78 Use plone.app.testing in test_catalog.
svn path=/plone.app.discussion/trunk/; revision=48897
2011-04-16 09:13:39 +00:00
Hanno Schlichting
9db8909ea7 Avoid using deprecated test assertions, see http://docs.python.org/dev/library/unittest.html#deprecated-aliases for the full list
svn path=/plone.app.discussion/trunk/; revision=48881
2011-04-15 16:23:38 +00:00
Hanno Schlichting
811d4a0429 Avoid deprecation warnings and always specify a catalog query as a dict
svn path=/plone.app.discussion/trunk/; revision=48880
2011-04-15 16:17:02 +00:00
Ross Patterson
5786bfa6b6 pep8
svn path=/plone.app.discussion/trunk/; revision=48840
2011-04-14 20:17:10 +00:00
Ross Patterson
586cd1fdb7 Don't add the annotation unless a comment is actually being added.
Fixes #11370.

svn path=/plone.app.discussion/trunk/; revision=48829
2011-04-14 16:17:29 +00:00
Maurits van Rees
a2a17085a3 Nuke trailing white space
svn path=/plone.app.discussion/trunk/; revision=46366
2010-12-15 23:52:56 +00:00
Timo Stollenwerk
51d6c60412 Use the right event subscriber to make sure all comments are removed from the catalog, if their content object is deleted.
svn path=/plone.app.discussion/trunk/; revision=40485
2010-10-02 14:50:17 +00:00
Timo Stollenwerk
22db0b1c78 Fix comment title for anonymous commentators that do not provide a name.
svn path=/plone.app.discussion/trunk/; revision=40435
2010-09-29 10:52:11 +00:00
Timo Stollenwerk
f67c7cde6d Remove title field from the comment form and replace it with an auto-generated title ("John Doe on Welcome to Plone").
This also fixes http://dev.plone.org/plone/ticket/11098

svn path=/plone.app.discussion/trunk/; revision=40431
2010-09-29 07:56:36 +00:00
Timo Stollenwerk
435040e0b2 Make pylint happy.
svn path=/plone.app.discussion/trunk/; revision=39287
2010-08-28 17:06:53 +00:00
Timo Stollenwerk
a54a15a90f Remove unnecessary imports and variables from test code.
svn path=/plone.app.discussion/trunk/; revision=37768
2010-07-13 10:45:53 +00:00
Florian Friesdorf
8150617081 fixed #662654: As an administrator, I can configure a Collection to show
recent comments.

Type now correctly returns FTI type title. A catalog rebuild is
necessary.

svn path=/plone.app.discussion/trunk/; revision=35266
2010-03-18 13:22:16 +00:00
Florian Friesdorf
5e6c7f6fdb fixed catalog test to fail for current broken Type()
svn path=/plone.app.discussion/trunk/; revision=35265
2010-03-18 13:22:06 +00:00
Timo Stollenwerk
b70774343f collection test added.
svn path=/plone.app.discussion/trunk/; revision=35126
2010-03-17 15:00:19 +00:00
Timo Stollenwerk
d81b95f7c1 more catalog tests added.
svn path=/plone.app.discussion/branches/notification/; revision=34476
2010-03-03 19:20:02 +00:00
Timo Stollenwerk
2ffbe75611 collection test added (failing).
svn path=/plone.app.discussion/trunk/; revision=33780
2010-02-05 22:40:38 +00:00
Hanno Schlichting
c27d1b5cc1 De-tabbify
svn path=/plone.app.discussion/trunk/; revision=33491
2010-01-27 14:54:07 +00:00
Timo Stollenwerk
1ea36d7d82 Conversation indexers won't work on old discussion items. Fix tests.
svn path=/plone.app.discussion/trunk/; revision=30658
2009-10-17 08:28:50 +00:00
Timo Stollenwerk
f4a4b6e370 fix catalog clear-and-rebuild. this finally fixes story 847941.
svn path=/plone.app.discussion/trunk/; revision=30610
2009-10-15 10:11:12 +00:00
Timo Stollenwerk
9befc4c651 Monkey patch for clear-and-rebuild catalog added. This fixes story 847941. Nested comments are not reindexed yet.
svn path=/plone.app.discussion/trunk/; revision=30574
2009-10-14 14:58:08 +00:00
Timo Stollenwerk
a946fb54fa indexes for IComment added to override the IConversation indexes.
svn path=/plone.app.discussion/trunk/; revision=27838
2009-07-06 16:56:09 +00:00