Fix comments Title if utf-8 characters in author_name
This commit is contained in:
		
							parent
							
								
									0463b20f78
								
							
						
					
					
						commit
						fd85de9c30
					
				@ -10,6 +10,9 @@ Changelog
 | 
				
			|||||||
- Fix ajax form submit for delete comment action: add 'data' to the request.
 | 
					- Fix ajax form submit for delete comment action: add 'data' to the request.
 | 
				
			||||||
  [toutpt]
 | 
					  [toutpt]
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					- Fix comments Title if utf-8 characters in author_name
 | 
				
			||||||
 | 
					  [huub_bouma]
 | 
				
			||||||
 | 
					
 | 
				
			||||||
2.2.8 (2013-08-20)
 | 
					2.2.8 (2013-08-20)
 | 
				
			||||||
------------------
 | 
					------------------
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
				
			|||||||
@ -186,7 +186,7 @@ class Comment(CatalogAware, WorkflowAware, DynamicType, Traversable,
 | 
				
			|||||||
        content = aq_base(self.__parent__.__parent__)
 | 
					        content = aq_base(self.__parent__.__parent__)
 | 
				
			||||||
        title = translate(
 | 
					        title = translate(
 | 
				
			||||||
            Message(COMMENT_TITLE,
 | 
					            Message(COMMENT_TITLE,
 | 
				
			||||||
                    mapping={'author_name': author_name,
 | 
					                    mapping={'author_name': safe_unicode(author_name),
 | 
				
			||||||
                             'content': safe_unicode(content.Title())}))
 | 
					                             'content': safe_unicode(content.Title())}))
 | 
				
			||||||
        return title
 | 
					        return title
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
				
			|||||||
@ -125,6 +125,18 @@ class CommentTest(unittest.TestCase):
 | 
				
			|||||||
        conversation.addComment(comment1)
 | 
					        conversation.addComment(comment1)
 | 
				
			||||||
        self.assertEqual(u"Tarek Ziadé on Document äüö", comment1.Title())
 | 
					        self.assertEqual(u"Tarek Ziadé on Document äüö", comment1.Title())
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    def test_title_special_characters_utf8(self):
 | 
				
			||||||
 | 
					        self.portal.invokeFactory(
 | 
				
			||||||
 | 
					            id='doc_sp_chars_utf8',
 | 
				
			||||||
 | 
					            title='Document ëïû',
 | 
				
			||||||
 | 
					            type_name='Document'
 | 
				
			||||||
 | 
					        )
 | 
				
			||||||
 | 
					        conversation = IConversation(self.portal.doc_sp_chars_utf8)
 | 
				
			||||||
 | 
					        comment1 = createObject('plone.Comment')
 | 
				
			||||||
 | 
					        comment1.author_name = "Hüüb Bôûmä"
 | 
				
			||||||
 | 
					        conversation.addComment(comment1)
 | 
				
			||||||
 | 
					        self.assertEqual(u"Hüüb Bôûmä on Document ëïû", comment1.Title())
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    def test_creator(self):
 | 
					    def test_creator(self):
 | 
				
			||||||
        comment1 = createObject('plone.Comment')
 | 
					        comment1 = createObject('plone.Comment')
 | 
				
			||||||
        comment1.creator = "jim"
 | 
					        comment1.creator = "jim"
 | 
				
			||||||
 | 
				
			|||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user