ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace $.live with $.on

Browse Source 
This is needed for jQuery >= 1.9 compatibility and is compatible with
JQuery >= 1.7 (Plone 4.3 onwards).
This commit is contained in:
Gaudenz Steinlin 2014-03-14 16:51:57 +01:00 committed by Gaudenz Steinlin
parent f58e900e25
commit fa17c51a7b
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGES.rst
View File

@ -10,6 +10,10 @@ Changelog
- Trigger custom events on comment add/remove/reply - Trigger custom events on comment add/remove/reply
[avoinea] [avoinea]
- Replace $.live with $.on for jQuery >= 1.9 compatibility. This works on
jQuery >= 1.7 (Plone 4.3 onwards).
[gaudenz]
2.3.2 (2014-04-05) 2.3.2 (2014-04-05)
------------------ ------------------

4
plone/app/discussion/browser/javascripts/comments.js
View File

@ -143,7 +143,7 @@
/********************************************************************** /**********************************************************************
* Publish a single comment. * Publish a single comment.
**********************************************************************/ **********************************************************************/
$("input[name='form.button.PublishComment']").live('click', function () { $("input[name='form.button.PublishComment']").on('click', function () {
var trigger = this; var trigger = this;
var form = $(this).parents("form"); var form = $(this).parents("form");
var data = $(form).serialize(); var data = $(form).serialize();
@ -169,7 +169,7 @@
/********************************************************************** /**********************************************************************
* Delete a comment and its answers. * Delete a comment and its answers.
**********************************************************************/ **********************************************************************/
$("input[name='form.button.DeleteComment']").live('click', function () { $("input[name='form.button.DeleteComment']").on('click', function () {
var trigger = this; var trigger = this;
var form = $(this).parents("form"); var form = $(this).parents("form");
var data = $(form).serialize(); var data = $(form).serialize();

2
plone/app/discussion/browser/javascripts/controlpanel.js
View File

@ -100,7 +100,7 @@
$.updateSettings(); $.updateSettings();
// Set #content class and update settings afterwards // Set #content class and update settings afterwards
$("input,select").live("change", function (e) { $("input,select").on("change", function (e) {
var id = $(this).attr("id"); var id = $(this).attr("id");
if (id === "form-widgets-globally_enabled-0") { if (id === "form-widgets-globally_enabled-0") {
if ($(this).attr("checked")) { if ($(this).attr("checked")) {