Fix handling of comments with invalid transforms. Write an error msg to the log and just return the untransformed text.

This commit is contained in:
Timo Stollenwerk
2012-07-12 16:03:02 +02:00
parent 08f11534ea
commit c47689af42
3 changed files with 30 additions and 4 deletions
+16 -4
View File
@@ -142,10 +142,22 @@ class Comment(CatalogAware, WorkflowAware, DynamicType, Traversable,
return ''
if isinstance(text, unicode):
text = text.encode('utf8')
return transforms.convertTo(targetMimetype,
text,
context=self,
mimetype=sourceMimetype).getData()
transform = transforms.convertTo(
targetMimetype,
text,
context=self,
mimetype=sourceMimetype)
if transform:
return transform.getData()
else:
logger = logging.getLogger("plone.app.discussion")
logger.error(
_(u"Transform '%s' => '%s' not available. Failed to transform comment '%s'." % (
sourceMimetype,
targetMimetype,
self.absolute_url(),
)))
return text
def Title(self):
"""The title of the comment.