ajung/plone.app.discussion
ajung/plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

The comment_description index now returns the first 25 words of a comment.

Browse Source 
svn path=/plone.app.discussion/trunk/; revision=27252
This commit is contained in:
Timo Stollenwerk 2009-06-01 09:59:07 +00:00
parent d3ba4f58db
commit 69334f6000
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plone/app/discussion/catalog.py
View File

@ -4,18 +4,22 @@ indexes with values based on the IComment interface.
Also provide event handlers to actually catalog the comments. Also provide event handlers to actually catalog the comments.
""" """
from string import split, join
from plone.indexer import indexer from plone.indexer import indexer
from plone.app.discussion.interfaces import IComment from plone.app.discussion.interfaces import IComment
MAX_DESCRIPTION=25
@indexer(IComment) @indexer(IComment)
def comment_title(object): def comment_title(object):
return object.title return object.title
@indexer(IComment) @indexer(IComment)
def comment_description(object): def comment_description(object):
# Todo: this is wrong!!! # Return the first 25 words of the comment text and append '...'
return object.title return '%s...' % join(object.text.split()[:MAX_DESCRIPTION])
@indexer(IComment) @indexer(IComment)
def comment_searchable_text(object): def comment_searchable_text(object):

6
plone/app/discussion/tests/test_indexers.py
View File

@ -47,6 +47,8 @@ class IndexersTest(PloneTestCase):
self.assert_(isinstance(comment_title, DelegatingIndexerFactory)) self.assert_(isinstance(comment_title, DelegatingIndexerFactory))
def test_comment_description(self): def test_comment_description(self):
# Create a 50 word comment and make sure the description returns
# only the first 25 words
# Create a conversation. In this case we doesn't assign it to an # Create a conversation. In this case we doesn't assign it to an
# object, as we just want to check the Conversation object API. # object, as we just want to check the Conversation object API.
@ -60,11 +62,11 @@ class IndexersTest(PloneTestCase):
comment = createObject('plone.Comment') comment = createObject('plone.Comment')
comment.title = 'Comment 1' comment.title = 'Comment 1'
comment.text = 'Comment text' comment.text = 'Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.'
new_id = conversation.addComment(comment) new_id = conversation.addComment(comment)
self.assertEquals(comment_description(comment)(), 'Comment 1') self.assertEquals(comment_description(comment)(), 'Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At...')
self.assert_(isinstance(comment_description, DelegatingIndexerFactory)) self.assert_(isinstance(comment_description, DelegatingIndexerFactory))
def test_dates(self): def test_dates(self):