ajung/plone.app.discussion
ajung
/
plone.app.discussion
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #200 from plone/maurits-site-administrators-master 

Grant Site Administrators same workflow permissions as Managers [master]
This commit is contained in:
Jens W. Klein 2022-05-11 01:51:34 +02:00 committed by GitHub
parent 37dc258051 1ea81e4a90
commit 0439e9ea24
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 21 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
news/199.bugfix Normal file
View File

@ -0,0 +1,3 @@
Grant Site Administrators the same workflow permissions as Managers.
They were missing permissions on pending comments.
[maurits]

2
plone/app/discussion/profiles/default/metadata.xml
View File

@ -1,5 +1,5 @@
<metadata> <metadata>
<version>1004</version> <version>2000</version>
<dependencies> <dependencies>
<dependency>profile-plone.resource:default</dependency> <dependency>profile-plone.resource:default</dependency>
<dependency>profile-plone.app.registry:default</dependency> <dependency>profile-plone.app.registry:default</dependency>

4
plone/app/discussion/profiles/default/workflows/comment_review_workflow/definition.xml
View File

@ -20,11 +20,13 @@
<permission-role>Manager</permission-role> <permission-role>Manager</permission-role>
<permission-role>Owner</permission-role> <permission-role>Owner</permission-role>
<permission-role>Reviewer</permission-role> <permission-role>Reviewer</permission-role>
<permission-role>Site Administrator</permission-role>
</permission-map> </permission-map>
<permission-map name="Modify portal content" acquired="False"> <permission-map name="Modify portal content" acquired="False">
<permission-role>Manager</permission-role> <permission-role>Manager</permission-role>
<permission-role>Owner</permission-role> <permission-role>Owner</permission-role>
<permission-role>Reviewer</permission-role> <permission-role>Reviewer</permission-role>
<permission-role>Site Administrator</permission-role>
</permission-map> </permission-map>
<permission-map name="Reply to item" acquired="False"> <permission-map name="Reply to item" acquired="False">
</permission-map> </permission-map>
@ -32,6 +34,7 @@
<permission-role>Manager</permission-role> <permission-role>Manager</permission-role>
<permission-role>Owner</permission-role> <permission-role>Owner</permission-role>
<permission-role>Reviewer</permission-role> <permission-role>Reviewer</permission-role>
<permission-role>Site Administrator</permission-role>
</permission-map> </permission-map>
</state> </state>
<state state_id="published" title="Published"> <state state_id="published" title="Published">
@ -43,6 +46,7 @@
</permission-map> </permission-map>
<permission-map name="Modify portal content" acquired="False"> <permission-map name="Modify portal content" acquired="False">
<permission-role>Manager</permission-role> <permission-role>Manager</permission-role>
<permission-role>Site Administrator</permission-role>
</permission-map> </permission-map>
<permission-map name="Reply to item" acquired="True"> <permission-map name="Reply to item" acquired="True">
</permission-map> </permission-map>

27
plone/app/discussion/upgrades.zcml
View File

@ -73,20 +73,19 @@
/> />
</genericsetup:upgradeSteps> </genericsetup:upgradeSteps>
<genericsetup:upgradeDepends <genericsetup:upgradeSteps
source="1002" source="1999"
destination="1003" destination="2000"
profile="plone.app.discussion:default" profile="plone.app.discussion:default">
title="Update controlpanel icon"
import_steps="controlpanel" />
<genericsetup:upgradeDepends <genericsetup:upgradeDepends
source="1003" title="Update controlpanel icon"
destination="1004" import_steps="controlpanel" />
profile="plone.app.discussion:default" <genericsetup:upgradeDepends
title="Add 'View comments' permission" title="Add 'View comments' permission"
import_steps="rolemap" /> import_steps="rolemap" />
<genericsetup:upgradeStep
title="Grant Site Administrator permissions on pending comments"
handler=".upgrades.upgrade_comment_workflows" />
</genericsetup:upgradeSteps>
</configure> </configure>