akramer/digital-credentials-public-validator
akramer/digital-credentials-public-validator
0
0
Fork 0
Code Issues Pull Requests Activity

add credential subject probe

Browse Source
This commit is contained in:
Markus Gylling 2022-08-31 22:44:22 +02:00
parent ccdcd6b0a5
commit e1d4f76046
2 changed files with 46 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
inspector-vc/src/main/java/org/oneedtech/inspect/vc/OB30Inspector.java
View File

@ -31,6 +31,7 @@ import org.oneedtech.inspect.util.resource.UriResource;
import org.oneedtech.inspect.util.resource.context.ResourceContext; import org.oneedtech.inspect.util.resource.context.ResourceContext;
import org.oneedtech.inspect.util.spec.Specification; import org.oneedtech.inspect.util.spec.Specification;
import org.oneedtech.inspect.vc.Credential.Type; import org.oneedtech.inspect.vc.Credential.Type;
import org.oneedtech.inspect.vc.probe.CredentialSubjectProbe;
import org.oneedtech.inspect.vc.probe.ContextPropertyProbe; import org.oneedtech.inspect.vc.probe.ContextPropertyProbe;
import org.oneedtech.inspect.vc.probe.CredentialParseProbe; import org.oneedtech.inspect.vc.probe.CredentialParseProbe;
import org.oneedtech.inspect.vc.probe.ExpirationVerifierProbe; import org.oneedtech.inspect.vc.probe.ExpirationVerifierProbe;
@ -92,8 +93,6 @@ public class OB30Inspector extends VCInspector {
//we expect the above to place a generated object in the context //we expect the above to place a generated object in the context
Credential crd = ctx.getGeneratedObject(Credential.ID); Credential crd = ctx.getGeneratedObject(Credential.ID);
//TODO new check: that subject @id or IdentityObject is available (at least one is the req)
//context and type properties //context and type properties
Credential.Type type = Type.OpenBadgeCredential; Credential.Type type = Type.OpenBadgeCredential;
for(Probe<JsonNode> probe : List.of(new ContextPropertyProbe(type), new TypePropertyProbe(type))) { for(Probe<JsonNode> probe : List.of(new ContextPropertyProbe(type), new TypePropertyProbe(type))) {
@ -110,6 +109,8 @@ public class OB30Inspector extends VCInspector {
if(broken(accumulator)) return abort(ctx, accumulator, probeCount); if(broken(accumulator)) return abort(ctx, accumulator, probeCount);
} }
accumulator.add(new CredentialSubjectProbe().run(crd.getJson(), ctx));
//signatures, proofs //signatures, proofs
probeCount++; probeCount++;
if(crd.getJwt().isPresent()){ if(crd.getJwt().isPresent()){

42
inspector-vc/src/main/java/org/oneedtech/inspect/vc/probe/CredentialSubjectProbe.java Normal file
View File

@ -0,0 +1,42 @@
package org.oneedtech.inspect.vc.probe;
import org.oneedtech.inspect.core.probe.Probe;
import org.oneedtech.inspect.core.probe.RunContext;
import org.oneedtech.inspect.core.report.ReportItems;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.node.ArrayNode;
/**
* A Probe that checks credential subject specifics not capturable by schemata.
*
* @author mgylling
*/
public class CredentialSubjectProbe extends Probe<JsonNode> {
public CredentialSubjectProbe() {
super(ID);
}
@Override
public ReportItems run(JsonNode root, RunContext ctx) throws Exception {
JsonNode subject = root.get("credentialSubject");
if(subject == null) return notRun("no credentialSubject node found", ctx); //error reported by schema
/*
* Check that we have either .id or .identifier populated
*/
JsonNode id = root.get("id");
if (id != null && id.textValue().strip().length() > 0) return success(ctx);
JsonNode identifier = root.get("identifier");
if(identifier != null && identifier instanceof ArrayNode
&& ((ArrayNode)identifier).size() > 0) return success(ctx);
return error("no id in credentialSubject", ctx);
}
public static final String ID = CredentialSubjectProbe.class.getSimpleName();
}