Merge branch 'master' of gitea.iwm-tuebingen.de:IWMBrowser/iwmlib

# Conflicts:
#	lib/scatter.js
This commit is contained in:
2019-07-30 17:02:58 +02:00
2 changed files with 26 additions and 9 deletions
+15 -5
View File
@@ -3325,15 +3325,22 @@
} }
close() { close() {
this._callCloseCallbacks();
this._removeSelfFromScatterContainer();
}
_callCloseCallbacks() {
if (this.onClose) { if (this.onClose) {
this.onClose.forEach(callback => callback(this)); this.onClose.forEach(callback => callback(this));
}
}
/** _removeSelfFromScatterContainer() {
/**
Removes self from container when it's closed. Removes self from container when it's closed.
*/ */
if (this.container) { if (this.container) {
this.container.remove(this); this.container.remove(this);
}
} }
} }
@@ -3930,7 +3937,10 @@
* @memberof DOMScatterContainer * @memberof DOMScatterContainer
*/ */
remove(scatter) { remove(scatter) {
this.scatter.delete(scatter.element); const element = scatter.element;
if (!this.scatter.has(element)) console.warn(`Try removing element that is not in the scatter.`, element);
this.scatter.delete(element);
} }
/** /**
+11 -4
View File
@@ -6771,15 +6771,22 @@
} }
close() { close() {
this._callCloseCallbacks();
this._removeSelfFromScatterContainer();
}
_callCloseCallbacks() {
if (this.onClose) { if (this.onClose) {
this.onClose.forEach(callback => callback(this)); this.onClose.forEach(callback => callback(this));
}
}
/** _removeSelfFromScatterContainer() {
/**
Removes self from container when it's closed. Removes self from container when it's closed.
*/ */
if (this.container) { if (this.container) {
this.container.remove(this); this.container.remove(this);
}
} }
} }