From ffde4b423dc7525e0b91f64cd96f2d7f3612a9f1 Mon Sep 17 00:00:00 2001 From: Timo Stollenwerk Date: Thu, 2 Dec 2010 23:02:00 +0000 Subject: [PATCH] Do not allow to change the mail settings in the discussion control panel, if there is no valid mail setup. Refactor js code to use class settings of #content. svn path=/plone.app.discussion/trunk/; revision=46090 --- CHANGES.txt | 6 +- plone/app/discussion/browser/controlpanel.pt | 2 +- plone/app/discussion/browser/controlpanel.py | 26 ++-- .../browser/javascripts/controlpanel.js | 120 +++++++++--------- 4 files changed, 83 insertions(+), 71 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index b9371db..d78b8f4 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -4,7 +4,11 @@ Changelog 1.0RC1 (unreleased) ------------------- -- Disable all commenting options in the discussion control panel when comments +- Do not allow to change the mail settings in the discussion control panel, if + there is no valid mail setup. + [timo] + +- Disable all commenting options in the discussion control panel if comments are disabled globally. - Check for the 'review comments' permission instead of 'manage' to decide diff --git a/plone/app/discussion/browser/controlpanel.pt b/plone/app/discussion/browser/controlpanel.pt index 25af7f6..31c3bd3 100644 --- a/plone/app/discussion/browser/controlpanel.pt +++ b/plone/app/discussion/browser/controlpanel.pt @@ -18,7 +18,7 @@