From 4c31afeac287484b8373a0cef9d607ee55e33ad8 Mon Sep 17 00:00:00 2001 From: David Glick Date: Tue, 23 Nov 2010 18:53:38 +0000 Subject: [PATCH] fix comparison of string to integer which broke 'check all' svn path=/plone.app.discussion/trunk/; revision=45926 --- CHANGES.txt | 3 +++ plone/app/discussion/browser/javascripts/moderation.js | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGES.txt b/CHANGES.txt index 2ba3bf8..3d64c0c 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -4,6 +4,9 @@ Changelog 1.0RC1 (unreleased) ------------------- +- Fix 'check all' on batch moderation page. + [davisagli] + - Use safe_unicode to decode the title of the content. encode("utf-9") caused Dexterity based content types to raise a unicode decode error. This fixes http://dev.plone.org/plone/ticket/11292 diff --git a/plone/app/discussion/browser/javascripts/moderation.js b/plone/app/discussion/browser/javascripts/moderation.js index d3eb2de..b33524a 100644 --- a/plone/app/discussion/browser/javascripts/moderation.js +++ b/plone/app/discussion/browser/javascripts/moderation.js @@ -108,7 +108,7 @@ * Check or uncheck all checkboxes from the batch moderation page. **********************************************************************/ $("input[name='check_all']").click(function () { - if ($(this).val() === 0) { + if ($(this).val() === '0') { $(this).parents("table") .find("input:checkbox") .attr("checked", "checked");