From 45fd2c51ce601a5ae259ab0a6c9e347c9421976f Mon Sep 17 00:00:00 2001 From: Joni Orponen Date: Tue, 14 May 2019 10:37:15 +0200 Subject: [PATCH 1/2] Use the shared test setup and test teardown keywords in Robot tests. --- news/155.bugfix | 3 +++ plone/app/discussion/tests/robot/test_discussion.robot | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 news/155.bugfix diff --git a/news/155.bugfix b/news/155.bugfix new file mode 100644 index 0000000..2278b62 --- /dev/null +++ b/news/155.bugfix @@ -0,0 +1,3 @@ +- Use the shared 'Plone test setup' and 'Plone test teardown' keywords in Robot + tests. + [Rotonen] diff --git a/plone/app/discussion/tests/robot/test_discussion.robot b/plone/app/discussion/tests/robot/test_discussion.robot index a4e56e1..32e1e88 100644 --- a/plone/app/discussion/tests/robot/test_discussion.robot +++ b/plone/app/discussion/tests/robot/test_discussion.robot @@ -9,12 +9,13 @@ *** Settings *** +Resource plone/app/robotframework/saucelabs.robot Resource plone/app/robotframework/selenium.robot Library Remote ${PLONE_URL}/RobotRemote -Test Setup Open test browser -Test Teardown Close all browsers +Test Setup Run Keywords Plone test setup +Test Teardown Run keywords Plone test teardown *** Test Cases *** From c1518d87d1f492b79bece80d7a1c13cf5c7383b1 Mon Sep 17 00:00:00 2001 From: Joni Orponen Date: Tue, 14 May 2019 10:40:09 +0200 Subject: [PATCH 2/2] Re-enable two disabled Robot tests. --- .../app/discussion/tests/robot/test_discussion.robot | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/plone/app/discussion/tests/robot/test_discussion.robot b/plone/app/discussion/tests/robot/test_discussion.robot index 32e1e88..dc1caa2 100644 --- a/plone/app/discussion/tests/robot/test_discussion.robot +++ b/plone/app/discussion/tests/robot/test_discussion.robot @@ -32,13 +32,13 @@ Add Comment to a Document When I add a comment Then I can see the comment below the document -#Reply to a comment on a Document -# Given a logged-in Site Administrator -# and a document with discussion enabled +Reply to a comment on a Document + Given a logged-in Site Administrator + and a document with discussion enabled -#Delete Comment from a Document -# Given a logged-in Site Administrator -# and a document with discussion enabled +Delete Comment from a Document + Given a logged-in Site Administrator + and a document with discussion enabled *** Keywords ***