From 56799f10ca002407bd670ab4f12c369d9b76a94f Mon Sep 17 00:00:00 2001 From: Uwe Oestermeier Date: Fri, 16 Oct 2026 12:53:37 +0200 Subject: [PATCH] Use loader signals for progress and fix error handler arguments. PIXI.Loader#on is a no-op since pixi.js 5.3, so the progress callback in PIXIApp.loadTextures was never called. Also PIXI.Loader#onError passes (error, loader, resource), so log the failed url and error. Co-Authored-By: Claude Opus 5.5 --- lib/pixi/app.js | 2 +- lib/pixi/deepzoom/loader.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/pixi/app.js b/lib/pixi/app.js index 74dd74b..debef86 100644 --- a/lib/pixi/app.js +++ b/lib/pixi/app.js @@ -528,7 +528,7 @@ export default class PIXIApp extends PIXI.Application { } if (progress) { - loader.on('progress', e => { + loader.onProgress.add(e => { this.progress(e.progress) }) } diff --git a/lib/pixi/deepzoom/loader.js b/lib/pixi/deepzoom/loader.js index a07d488..f5443fc 100644 --- a/lib/pixi/deepzoom/loader.js +++ b/lib/pixi/deepzoom/loader.js @@ -143,8 +143,8 @@ export class PIXITileLoader extends TileLoader { } } - _onError(loader, error) { - console.warn('Cannot load', error) + _onError(error, loader, resource) { + console.warn('Cannot load', resource ? resource.url : '', error) } /** Private method. Called by the PIXI loader after each successfull